Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
10306
Off-topic / Post count fever
« on September 12th, 2010, 04:18 PM »
Congrats on reaching 500 posts, Pete!
Next stop: 500 more posts... in a day :P
I'm sure you can do it when we go public :lol:
Next stop: 500 more posts... in a day :P
I'm sure you can do it when we go public :lol:
10307
Features / Re: New revs
« on September 12th, 2010, 04:17 PM »
I'm not very confident that we can actually keep both the internal Wysiwyg editor AND add support for others without too much hacking, but I'll let you play with it if you want ;) I wouldn't mind only supporting external editors, myself.
BTW, what tool do you use to do your site-wide searches, and search & replace events?
Personally, I'm with very old tools (outdated?): Super Text Search for searches (supports regex so I kept it so far), and BK ReplaceEm for search & replace.
Also, in PersonalMessage.php:
Code: [Select] Is it wanted? $_REQUEST then $_GET? Not logical to me...
On to the boring stuff... (Haven't tested user menus yet. Excited about 'em.)
rev 93
- Removed support for Konqueror. (Load.php, Subs.php, Admin.template.php, Packages.template.php)
- Removed support for some browser version numbers: Opera 9/10, Firefox 1/2/3, as they're not known to have specific issues. Added user agent in $context['browser']['ua'] for modders to get a clean way to search for specific version numbers. (Load.php)
* After looking through Who.php, I realized I'm also an isset-nazi. Starting work on merging isset() && isset() calls together. (Subs-Editor.php, Subs-List.php, Subs-Menu.php, Subs-MessageIndex.php, ViewQuery.php, Who.php, Post.template.php, Wireless.template.php)
+ Added a msnbot (Bing) check in possibly_robot, but it should be useless anyway. Maybe just in case they decide to add "Mozilla" in their user agent string... (Load.php)
rev 94
! I don't know what a profie is... Is it a profitable profile? (Display.php, index.english.php)
- Deleted im_switch.gif. Goodbye, and please don't call, we won't miss you. (im_switch.gif, Help.template.php)
* Spacing nazi (index.css, Display.template.php, topic.js)
BTW, what tool do you use to do your site-wide searches, and search & replace events?
Personally, I'm with very old tools (outdated?): Super Text Search for searches (supports regex so I kept it so far), and BK ReplaceEm for search & replace.
Also, in PersonalMessage.php:
// Changing view?
if (isset($_REQUEST['view']))
{
$_GET['view'] = (int) $_GET['view'];On to the boring stuff... (Haven't tested user menus yet. Excited about 'em.)
rev 93
- Removed support for Konqueror. (Load.php, Subs.php, Admin.template.php, Packages.template.php)
- Removed support for some browser version numbers: Opera 9/10, Firefox 1/2/3, as they're not known to have specific issues. Added user agent in $context['browser']['ua'] for modders to get a clean way to search for specific version numbers. (Load.php)
* After looking through Who.php, I realized I'm also an isset-nazi. Starting work on merging isset() && isset() calls together. (Subs-Editor.php, Subs-List.php, Subs-Menu.php, Subs-MessageIndex.php, ViewQuery.php, Who.php, Post.template.php, Wireless.template.php)
+ Added a msnbot (Bing) check in possibly_robot, but it should be useless anyway. Maybe just in case they decide to add "Mozilla" in their user agent string... (Load.php)
rev 94
! I don't know what a profie is... Is it a profitable profile? (Display.php, index.english.php)
- Deleted im_switch.gif. Goodbye, and please don't call, we won't miss you. (im_switch.gif, Help.template.php)
* Spacing nazi (index.css, Display.template.php, topic.js)
10308
Features / Re: New revs
« on September 12th, 2010, 01:36 AM »When it comes to having it in a random file that seems disjointed, or at least tied to the behaviour in which it is most directly used, I'd rather have it attached to where it is used.Quote I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()?
Look at Aeva-Media.php... It has the media object in it. See the extList function? I put it outside the object because I was getting errors when running in strict mode (dunno why.) Still, I think it's better in that place because basically it was mainly unrelated to the media object and made no use of it. The function is still in the better file, but doesn't have to be in the object itself.
There is no use within SMF/Wedge where preparsecode is used where the content hasn't come from the editor. Sure... it could come from a feed or a mod, but in that case it's still coming from an arbitrary place. As far as I'm concerned, we talking about the function being just in a file, versus being with the code that hands content to it.
I'd like to think we can make a useful changelog for people much like the AeMe one, in a way that's fun as well.
10309
Features / Re: New revs
« on September 12th, 2010, 01:03 AM »* Nao/Gilles is in a trance listening to the Atari ST Chambers of Shaolin soundtrack...
There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.
I liked how you did the AeMe changelog though I'll admit I never read it in detail.
I don't believe anyone ever admitted to me having read the changelog at all. It's okay with me. It's THERE to be read if you need to. If you don't, then that's okay. But it's just like buying a new car and thinking, "okay it's cool, I can drive a car already, I don't need to read the manual..." And then of course you realize some things are done differently, then you read the changelog, and discover in the meantime a feature you never knew had been added, so you figure you'll read the entire changelog to spot other hidden features, and all you end up finding is easter eggs... :P
Oh my... Chambers... of... Shaolin... It's so great, I can't focus on this post... Too bad the Amiga version sounds so dull...
Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.
I'll have a look tomorrow...
10310
Features / Re: New revs
« on September 11th, 2010, 04:18 PM »Oops, I broke it :P
I must say, I'm not too excited about having to type wedgeEditor::preparsecode instead of just preparsecode(), but I'm sure there's a good reason behind it, I trust you on that one. (If there isn't, then I'll kill you dead for it :P)
Are we going to update changelog.txt?
So, having a 800KB changelog is totally useless in that respect. What people need is the kind of changelog I do for AeMe on big version updates: I categorize changes by interest. The biggest changes are put first, then the "cool" changes, then at the end I have a list of geeky, uninteresting changes, and finally the mandatory line "Plenty of bug fixes as usual", which is totally right.
I generate my changelogs at release time (or close to), by getting them from Tortoise and reordering them.
We could try having a changelog generated automatically from the svn (I'm sure there's a tool for that), and then we can go through it and delete anything that's not of interest to the reader.
Also, one of the things that piss me off in SMF's changelog, is that they document fixes for *unreleased revs*. Yay... Like it's going to be of any interest to non-testers! Even them don't read changelogs -- at best, they go through (most of) the bug tracker.
Also, did you see my proposed changes for the PM UI? (http://tracker.wedge.org/?sa=ticket;ticket=18.msg253#msg253)
I was trying to send meself a PM to see if you had committed the change already (I wasn't sure.)
Anyway, yeah, do try and commit it. ANYTHING is better than what's up right now...! :) We'll fix it later if it needs anything.
Really, really -- let's all have fun with Wedge. It's been over 2 weeks now, and it's been a lot of fun already. I can't stop working on it, it's so thrilling to finally be able to get rid of legacy code and add features that have been waiting for so long. And I haven't even got started on converting Noisen features!! ;)
At some point, we'll have to consider posting a working copy of Wedge in private, for our users here. I'm sure they'll appreciate being able to browse through the changes instead of just discussing them. Since we're working on local copies, it won't be updated as often, but it could.
10311
Features / Re: New revs
« on September 11th, 2010, 02:59 PM »
rev 87
! Sending PM and moving topics were broken due to wedgeEditor not being correctly loaded. (MoveTopic.php, Subs-Post.php)
* Renamed install/upgrade_2-0_mysql.sql to install/upgrade_2-0.sql, to match the 1.1 branch files. (install.php, upgrade.php, *.sql)
! Sending PM and moving topics were broken due to wedgeEditor not being correctly loaded. (MoveTopic.php, Subs-Post.php)
* Renamed install/upgrade_2-0_mysql.sql to install/upgrade_2-0.sql, to match the 1.1 branch files. (install.php, upgrade.php, *.sql)
10312
Features / Re: New revs
« on September 11th, 2010, 09:05 AM »
rev 86
* Updating to SMF rev 10101. Parenthenazi kills SD.
! fetch_web_data didn't properly parse ports (Subs-Package.php)
! constructPageIndex didn't respect flexible start for compact pagination (Subs.php)
(Yikes, I felt dirty committing this, even though the fixes were made by the reporters, not the committers... They're giving commit access to SlammedDime, after what he did to the team's rep?! Woohoo... And vbgamer45 made his first commit in something like *4 months*, to backport that fetch_web_data fix which isn't even perfect but... :P)
! Minor optimisation for participation icons (Recent.php) <--------- Hey, that was my find :P Thief! :lol:
* Updating to SMF rev 10101. Parenthenazi kills SD.
! fetch_web_data didn't properly parse ports (Subs-Package.php)
! constructPageIndex didn't respect flexible start for compact pagination (Subs.php)
(Yikes, I felt dirty committing this, even though the fixes were made by the reporters, not the committers... They're giving commit access to SlammedDime, after what he did to the team's rep?! Woohoo... And vbgamer45 made his first commit in something like *4 months*, to backport that fetch_web_data fix which isn't even perfect but... :P)
! Minor optimisation for participation icons (Recent.php) <--------- Hey, that was my find :P Thief! :lol:
10313
Features / Re: New revs
« on September 11th, 2010, 01:26 AM »
rev 82
* If modder forgets to put empty quotes at the beginning of a smf_db_query call, let's fix it for them. Dunno if it could be useful. Just felt like it. (Subs-Database.php)
* Cleanup for script.js
- Removed all of the optional parameters in queries, as they were only used by PGSQL and SQlite. (All other files -- please don't make me list them!)
--> Don't bother testing the param stuff Pete, there are about 75 occurrences and I checked them all, one by one. (Automatic search & replace so it was unlikely to fail anyway.)
* If modder forgets to put empty quotes at the beginning of a smf_db_query call, let's fix it for them. Dunno if it could be useful. Just felt like it. (Subs-Database.php)
* Cleanup for script.js
- Removed all of the optional parameters in queries, as they were only used by PGSQL and SQlite. (All other files -- please don't make me list them!)
--> Don't bother testing the param stuff Pete, there are about 75 occurrences and I checked them all, one by one. (Automatic search & replace so it was unlikely to fail anyway.)
10314
Features / Re: New revs
« on September 11th, 2010, 12:26 AM »
rev 81
* Uninteresting code cleanup and optimizations. (Class-Editor.php, Load.php, index.css, script.js)
! replaceText() could fail on Opera if run on a message without any carriage return. (script.js)
! Post editor smileys and bbcode buttons would fail on Opera < 10.5 and IE 6-8 because setting innerHTML or outerHTML on an object with dynamic events will reset the event list in these browsers. (script.js)
* Uninteresting code cleanup and optimizations. (Class-Editor.php, Load.php, index.css, script.js)
! replaceText() could fail on Opera if run on a message without any carriage return. (script.js)
! Post editor smileys and bbcode buttons would fail on Opera < 10.5 and IE 6-8 because setting innerHTML or outerHTML on an object with dynamic events will reset the event list in these browsers. (script.js)
10315
Features / Re: New revs
« on September 10th, 2010, 09:35 PM »
Yeah, I have a SVN and a SVN_2 folder to make my diff patches for SMF, and a SVN and SVN_all folder for Wedge, although it's a bit different (SVN is a shortcut to trunk, so I can't diff patch between the two, I have to specify SVN_all/trunk and it's boring... :P)
If I could find a way to automate the entire process, that'd be swell... Retrieve rev number in SVN folder, update SVN2 to that rev, then update SVN to latest rev. If different, generate a patch, with name "dev-CURRENT_REV.diff". Make coffee, too.
If I could find a way to automate the entire process, that'd be swell... Retrieve rev number in SVN folder, update SVN2 to that rev, then update SVN to latest rev. If different, generate a patch, with name "dev-CURRENT_REV.diff". Make coffee, too.
10316
Features / Re: New revs
« on September 10th, 2010, 09:27 PM »
Yeah... ;) I actually considered changing the text to say some other thing, but then I decided against it, as I like chocobos, too :P Had it been a Pokémon reference, I would have changed it haha.
Good to see you're reading every fucking borin' line of my stuff!
How do you do it? I mean, I do it too, but sometimes when there are too many changes, I have to take a few minutes to build a diff patch out so I can read more comfortably instead of checking out the log and having to watch the changes file by file...
Good to see you're reading every fucking borin' line of my stuff!
How do you do it? I mean, I do it too, but sometimes when there are too many changes, I have to take a few minutes to build a diff patch out so I can read more comfortably instead of checking out the log and having to watch the changes file by file...
10317
Features / Re: New revs
« on September 10th, 2010, 01:50 PM »
rev 79
! grabJumpToContent() is called through onmousemover if document.implementation isn't defined... It should be done for all, or nothing. (script.js)
* set/getInnerHTML are deprecated, but weren't actually removed from the SMF codebase. (install.php, ssi_examples.php, repair_settings.php, smfinfo.php, unittest.js, upgrade.php, latest-news.js, latest-support.js, admin.js, editor.js, fader.js, PersonalMessage.js, script.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, Templates: Admin, ManageMaintenance ManageSearch, ManageSmileys, MessageIndex, Packages, PersonalMessage, Post, Profile, SplitTopics, Themes)
rev 80
+ Added a placeholder for parse_bbc_inline(). Should be rewritten to use regex later. (Subs.php)
! grabJumpToContent() is called through onmousemover if document.implementation isn't defined... It should be done for all, or nothing. (script.js)
* set/getInnerHTML are deprecated, but weren't actually removed from the SMF codebase. (install.php, ssi_examples.php, repair_settings.php, smfinfo.php, unittest.js, upgrade.php, latest-news.js, latest-support.js, admin.js, editor.js, fader.js, PersonalMessage.js, script.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, Templates: Admin, ManageMaintenance ManageSearch, ManageSmileys, MessageIndex, Packages, PersonalMessage, Post, Profile, SplitTopics, Themes)
Posted: September 10th, 2010, 10:46 AM
rev 80
+ Added a placeholder for parse_bbc_inline(). Should be rewritten to use regex later. (Subs.php)
10318
Features / Re: New revs
« on September 10th, 2010, 12:39 AM »
What happened with your fix, was that selecting "Select font size" would add [size=0pt][/size] to the message box... :)
So I simply did it the way other boxes were done. Now it works, it simply returns "" (insteaf of "0") and thus doesn't show anything.
BTW, wrong place to discuss but I'm a bit lazy...
$breaker = '<span style="margin: 0 -0.5ex 0 0;"> </span>';
This is in the code to fix long words. Uh... How about we use the proper tool -- ­?
rev 75
- Removed setRequestHeader test for Opera... That issue was only in the 5yo Opera 8.00 (note the specific minor version number), so... what the heck?! (Post.template.php, topic.js)
(Looks like Wedge is on a diet, today... ;))
rev 76
- Market share for IE 5.x was 0.08% in 2009... We're in 2010. IE5 support is out. (Load.php, Subs.php, Display.template.php, editor.js, script.js, topic.js)
rev 77
! Oops again. (Load.php) <-- crash
rev 78
! is_opera105up wasn't properly filled in. (script.js)
! document.body isn't always initialized. Replaced with a createElement. (script.js)
+ Re-introduced ActiveX hack, as IE6 also made use of it. Limiting to the newer namespace, though. (script.js)
* If browser supports querySelectorAll(), use that in the rounded corner emulator. Probably only Opera 9.x through 10.10 can make use of that. (script.js)
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
I don't even have access to the console, for a reason unknown. :(
Quote from Nao/Gilles on September 10th, 2010, 12:03 AM Grmpf... Did the update, and it works in O 9.5. Dunno if it was broken in O9 because I had some wrong configuration. Anyway... O9.5+ is 90% of the Opera userbase or so. Fine with it.
So I simply did it the way other boxes were done. Now it works, it simply returns "" (insteaf of "0") and thus doesn't show anything.
BTW, wrong place to discuss but I'm a bit lazy...
$breaker = '<span style="margin: 0 -0.5ex 0 0;"> </span>';
This is in the code to fix long words. Uh... How about we use the proper tool -- ­?
Posted: September 9th, 2010, 03:06 PM
rev 75
- Removed setRequestHeader test for Opera... That issue was only in the 5yo Opera 8.00 (note the specific minor version number), so... what the heck?! (Post.template.php, topic.js)
(Looks like Wedge is on a diet, today... ;))
Posted: September 9th, 2010, 03:09 PM
rev 76
- Market share for IE 5.x was 0.08% in 2009... We're in 2010. IE5 support is out. (Load.php, Subs.php, Display.template.php, editor.js, script.js, topic.js)
rev 77
! Oops again. (Load.php) <-- crash
rev 78
! is_opera105up wasn't properly filled in. (script.js)
! document.body isn't always initialized. Replaced with a createElement. (script.js)
+ Re-introduced ActiveX hack, as IE6 also made use of it. Limiting to the newer namespace, though. (script.js)
* If browser supports querySelectorAll(), use that in the rounded corner emulator. Probably only Opera 9.x through 10.10 can make use of that. (script.js)
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
I don't even have access to the console, for a reason unknown. :(
Posted: September 10th, 2010, 12:03 AM
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
10319
Features / Re: New revs
« on September 9th, 2010, 02:45 PM »
Sometimes... I really feel like a small-time hacker with my minor revs :P
rev 68
- Removed needs_size_fix hack, as it was only used in Babylon themes. (Load.php)
- Removed nopadding from Admin template -- looked ugly for no reason. (Admin.template.php, admin.css)
* Pete... I'm afraid I'm a parenthesis nazi. (Load.php, Display.template.php)
! Fixed Register and SplitTopics templates to apply rounded corners to divs instead of lists and forms. This allows for faster parsing when in compatibility mode. (Register.template.php, SplitTopics.template.php)
Okay, this one's a bit better actually :eheheh:
I'm not too sure about the is_opera105up though... And I'd be tempted to delete WAY MORE is_* variables at this point. (Discuss in related topic, thanks.)
rev 69
+ Added code to automatically detect browser support for border-radius and box-shadow. (script.js)
* Moved rounded corner emulation code to script.js, as it's likely to be more stable now. (index.template.php, script.js)
* Started conversion of roundframe divs to delete non-semantic code. (index.css, BoardIndex.template.php)
* Rewrote browser detection code to be more efficient. Dropped versions is_ie4, is_opera5/6/7/8 are now forced to false, is_safari is only set if not in a smartphone environment, dropped is_opera96 entirely (was it used at all?), added is_opera105up (not is_opera105 though... I don't want to overdo it), is_ff is really only set for the actual Firefox and assimilated, and added is_ie9 and is_ie9up. (script.js)
* Updated this.bRichTextPossible initialization code accordingly. (editor.js)
! Deleted more IE4 compatibility code and fixed typos. (script.js)
! Fixed admin sub-menus to avoid showing a scrollbar. (index.css)
rev 70
* Plenty of cleaning up. @todo: what's with the random registration code hardcoded into this..?! (Help.template.php)
* Some cleaning up. (Memberlist.template.php)
- Removed legacy class innerframe. (Help.template.php, BoardIndex.template.php, Profile.template.php)
* Finished converting roundframe divs to the new system. Yay! (Templates: Admin, Calendar, Display, Help, Login, Memberlist, Notify, PersonalMessage, Poll, Post, Profile, Register, Reminder, Search)
rev 71
- Removing securityPackages folder, as it's SMF-specific and being well behaved, we don't play with others' toys.
! Fixed undefined error 'submit_label'. (Display.php)
rev 72
! Fixed incorrect regex in browser detection. (script.js)
(Sorry, forgot to commit the second one at the same time...)
rev 73
! Clean fix for the font size dropdown in Opera (see here), and added support for 6pt font size. (Class-Editor.php, editor.js)
* Another coup from the Parenthenazi. (Wireless.template.php)
rev 68
- Removed needs_size_fix hack, as it was only used in Babylon themes. (Load.php)
- Removed nopadding from Admin template -- looked ugly for no reason. (Admin.template.php, admin.css)
* Pete... I'm afraid I'm a parenthesis nazi. (Load.php, Display.template.php)
! Fixed Register and SplitTopics templates to apply rounded corners to divs instead of lists and forms. This allows for faster parsing when in compatibility mode. (Register.template.php, SplitTopics.template.php)
Posted: September 9th, 2010, 11:25 AM
Okay, this one's a bit better actually :eheheh:
I'm not too sure about the is_opera105up though... And I'd be tempted to delete WAY MORE is_* variables at this point. (Discuss in related topic, thanks.)
rev 69
+ Added code to automatically detect browser support for border-radius and box-shadow. (script.js)
* Moved rounded corner emulation code to script.js, as it's likely to be more stable now. (index.template.php, script.js)
* Started conversion of roundframe divs to delete non-semantic code. (index.css, BoardIndex.template.php)
* Rewrote browser detection code to be more efficient. Dropped versions is_ie4, is_opera5/6/7/8 are now forced to false, is_safari is only set if not in a smartphone environment, dropped is_opera96 entirely (was it used at all?), added is_opera105up (not is_opera105 though... I don't want to overdo it), is_ff is really only set for the actual Firefox and assimilated, and added is_ie9 and is_ie9up. (script.js)
* Updated this.bRichTextPossible initialization code accordingly. (editor.js)
! Deleted more IE4 compatibility code and fixed typos. (script.js)
! Fixed admin sub-menus to avoid showing a scrollbar. (index.css)
Posted: September 9th, 2010, 11:37 AM
rev 70
* Plenty of cleaning up. @todo: what's with the random registration code hardcoded into this..?! (Help.template.php)
* Some cleaning up. (Memberlist.template.php)
- Removed legacy class innerframe. (Help.template.php, BoardIndex.template.php, Profile.template.php)
* Finished converting roundframe divs to the new system. Yay! (Templates: Admin, Calendar, Display, Help, Login, Memberlist, Notify, PersonalMessage, Poll, Post, Profile, Register, Reminder, Search)
Posted: September 9th, 2010, 12:13 PM
rev 71
- Removing securityPackages folder, as it's SMF-specific and being well behaved, we don't play with others' toys.
! Fixed undefined error 'submit_label'. (Display.php)
rev 72
! Fixed incorrect regex in browser detection. (script.js)
(Sorry, forgot to commit the second one at the same time...)
Posted: September 9th, 2010, 01:29 PM
rev 73
! Clean fix for the font size dropdown in Opera (see here), and added support for 6pt font size. (Class-Editor.php, editor.js)
* Another coup from the Parenthenazi. (Wireless.template.php)
10320
Features / Re: New revs
« on September 8th, 2010, 02:36 PM »
rev 64
* Updated to SVN rev 10098 (hmm, just a line to change. Cleaned up the function, too, as the comment was a bit contradictory.)
! Add attachments cleaning for IE as well, though it allows manually deleting the file input box (script.js)
* Updated to SVN rev 10098 (hmm, just a line to change. Cleaned up the function, too, as the comment was a bit contradictory.)
! Add attachments cleaning for IE as well, though it allows manually deleting the file input box (script.js)