Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
Features / Re: New revs
« on September 5th, 2010, 09:27 PM »
Nice! Although that adds a lot of lines, but they'll run fast enough so that's okay :)
BTW --> I compressed the two isset()->unset() into a single unset() with both variables listed in it. isset() isn't needed, as PHP5 won't generate an error if you try unsetting a non-existent variable (it won't even do it if you try to unset an array entry in a non-existent array). So, might as well unset both in one go. :)

My first big one is here... (Mostly Norv's doing.)

rev 44
Code: [Select]
- More PHP4 stuff removal. (index.php, SSI.php)
* Updated to SMF rev 10093:
  ! Fixed calculating steps/substeps for log_actions changes (upgrade script) [Bug 4427]
  ! Added the optional (in 1.1 spec) assoc_type to OpenID parameters (Subs-OpenID.php) [Bug 4420]
  ! Small improvement to be more mod-friendly, a useless variable usage could have caused issues with mods (Load.php) [Bug 4445]
  ! Avatars loaded from remote locations may have failed resizing in some cases (script.js) [Bug 3842]
  ! Re-added a couple of flock() calls, as fclose() does not unlock the file on PHP 5.3.2+ (Load.php, ManageMaintenance.php) [Bug 4330]
  ! Improved 'who's online' behavior for a user who toggles WYSIWYG view (index.php) [Bug 4415]
  ! MySQL needs the autoincrement column defined as primary key (DbPackages-mysql.php) [Bug 4422]
  ! A variable was overwritten for font-size style tag, but needed later for <a> tag preservation (Subs-Editor.php -> Class-Editor.php) [Bug 4447]
Features / Re: New revs
« on September 5th, 2010, 06:02 PM »
Quote from Arantor on September 5th, 2010, 04:55 PM
Just for reference, yes, try/catch (I keep typing cache instead, haha)
Thta's not a porblem, we're not hree to witre a thises. We're hree to wrok on Webge Wegde[/s] Wgede.
would be a syntax error in PHP 4, so yes it would crash PHP in that respect.
Yeah, that's what I feared...
Oh well, as I said, it's okay because convert.php is unlikely to be used if the installer refused to work in the first place.
Features / Re: New revs
« on September 5th, 2010, 04:52 PM »
Quote from Arantor on September 5th, 2010, 04:43 PM
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
It'll be a fatal error since try/catch is a language construct not in PHP 4. Since we don't support PHP 4 at all, it's not worth worrying about unless we reinstate the original branch too (since the eval will just return false in PHP 4 and do absolutely nothing otherwise)
I think I need to explain myself better, sorry. What I mean is, when you put a syntax error into a function, even a function that never gets called, PHP will directly crash on running the file. Would the try+catch and com_exception be considered as syntax errors? Because in that case, it would crash convert.php even before getting to the error message about the need to upgrade php.
However, it doesn't really matter, because you need to install your forum before you can convert to it, and if it won't install, there's no need to run the file anyway. So I'm good.
All I did was remove the code that defines session_regenerate_id() if it doesn't exist, it's not done with a PHP_VERSION check but a function_exists(), so it's possible you wouldn't find it otherwise.
I was actually planning to do a site-wide search on function_exists() as well, don't worry :) I only thought about it at the last moment though, so you're right, I could just as well have forgotten about it.
Sure, can assign stuff, it's been a while since I worked in a team!
We're a bit rusty :blush:

@Lorenzo> If you share that piece of code, even under a nickname, we'll KNOW it was your doing!

@Pete> He was kidding, re-read my previous PM with the code quote ;)
Features / Re: New revs
« on September 5th, 2010, 04:38 PM »
@Lorenzo> An exclusive for you! Here's a short sample from some of our custom code!

Code: [Select]
if (!empty(

Sorry, can't show more. Hope it keeps you excited  :eheh:
Quote from Arantor on September 5th, 2010, 03:45 PM
If you're referring to the eval that's executed with a check on PHP 5 (line 2436 or so), just dropping it back out of being an eval and removing the other branch would be fine. The point is that try/catch is a language construct in PHP 5 and would choke in PHP 4.
Yeah, but I don't know if it could crash a PHP4 just by having some instructions it doesn't understand -- maybe com_exception, things like that.
Trouble is, it's all based on the logic in SimpleDesk.php, particularly shd_helpdesk_listing() IIRC - haven't touched that code in months, but it's the main part of SimpleDesk.php, which handles querying for data and processing it... it's not pretty, because it does have the ability to paginate on each block independently, and preserve pagination as you go, so if you hit page 2 of one block, and page 3 of another, both are preserved.
That's nice... But I'm sure it can be rewritten, still ;)
! Do not add extraneous Core rows in themes table on install (install_2-0_mysql.sql)
! Set it to return to post after posting by default (install_2-0_mysql.sql)
Yeah, I have yet to look into the mysql install files. I'm really removing things as things go, like, this morning I was simply looking for php_version and tried getting rid of all of the unneeded stuff. Still a lot remains to be done. Nothing biggie though.
Revision: 42
Author: arantor
Ahhhh!! You, filthy thief!![1] You stole my rev! I was looking forward to committing it myself! :P

'kay, just kidding, I already had rev 10.000 on SMF, and no one will take that one away from me... Despite Norv's efforts to revert part of that commit :niark:
Next stop: rev 69. Who will be getting it? :ph34r:

We just finished eating and I'm quite a bit wasted, again. What a weekend... And what with that 26'' monitor my hosts are using?! Why do they need that much space?
Anyway, I'll deal with all of these commits tonight (I have at least 3 on my waiting list, as I try to separate different fixes/additions into different commits).
! Remove legacy PHP 4.3.2 and lower compatibility function (Subs-Auth.php)
Can't look into the svn right now (see above), so... Are you doing stuff in my stead? Maybe we should determine how to deal with commit conflicts. Usually we work on different parts at the same time so it's okay, but for instance, if you're going to tackle a task in the bug tracker, could you assign it to yourself first? That way I would have a way to make sure we're not working on fixing the same issue at the same time. Which at best is a waste of time for one of us, and at worst, brings commit confusion. (I'm talking about big fixes and features, of course. If it's just a few lines of code, who cares if we're wasting time.)
 1. I like the sound of that.
Features / Re: New revs
« on September 5th, 2010, 12:05 PM »
rev 39
- Removed php_412_bugfix leftovers. (Load.php, smf_api.php, install.php)
- Some of the files were not requiring PHP 5. (index.php, webinstall.php, install.php, upgrade.php, Subs-Compat.php)
@ Is the eval() necessary in convert.php? Will it run on PHP4 without them? (Considering PHP4 isn't supported, it's not important but...)

--> The eval() stuff should be unneeded, but I'm just not sure whether PHP4 won't choke on some stuff in it. I don't think so, but I kinda have a hangover, AND I'm about to go to that stupid party in a minute.
Anyway, I'm not yet finished with the PHP5 requirements (I only did the files that should be a "barrier" to installing Wegde on PHP4). There are many more lines to remove, I'll do them later today when I get back, so we're finished with it.

I've also upgraded to the latest SMF rev (10093), and I'm nearly finished with the botslice/topslice stuff, hopefully, tonight, or tomorrow morning everything will be committed.
Features / Re: New revs
« on September 5th, 2010, 09:20 AM »
Thanks for the auto-topic fix, I really don't have time to work on anything this weekend... (I hate it.)
BTW, the "Mark Resolved" feature in SD doesn't seem to work when clicked from within a ticket. It does work when using the icon in the ticket list.
I really should rewrite the template for the homepage, btw, just so it shows tickets a bit more like Mantis & PT do... Right now it's a bit confusing to me, because of this whole "waiting for user/admin feedback" thing that really isn't necessary here.
The reason for this one is to make it much easier to build on and/or replace in the event of using something like CKEditor; now whatever we do in terms of altering the code, we just have to update wedgeEditor rather than liberally hitting up the code throughout Wedge.
Oh... Right! Then it's fantastic.
I love it that you baptized our project :) Very logically, too, since this is something that is unlikely of reaching SMF at all. (And if it does, they'd better keep the name :P)
Features / Re: New revs
« on September 5th, 2010, 01:39 AM »
Wow, I totally need to read this backlog... I haven't looked into the "Bigger changes" topic yet (it's opened in a tab -- only, I have about 50 tabs open just for!! Have to read them all!), neither have I looked into your code refactoring tickets (shame on me. Same reason.)

So, you're not much into social events either, eh? :P
[off-topic real life crap]Tonight I was at my brother in law's birthday party... Very noisy bar, very hot in there, and boring people (next time I see someone demonstrating their new iPhone, I'll be using my fists.)
I like my BIL (he lives in London and I don't get to see him a lot), but he was overcrowded today so I didn't even get to tell him a word, lol. The guy I talked for the longest (about... 10 minutes) was a geek co-worker of his who was in Paris for the first time. We discussed TV shows, the hate of commuting to London (guess why) and other things. The only 10 interesting minutes -- and it reminded me just how AWFUL my accent is. And there's no Backspace key in a muscle-powered vocal controller. God bless the Backspace key. I can fix all (most) of my English mistakes as soon as they take shape, and nobody needs to know! I'm looking forward to meeting you in the future and making a fool out of myself :D

Tomorrow I'm set to see BIL again... With family, this time. Argh. Someone, please free me from non-geeks! I bore them to death, and they return the favour with pleasure![/off-topic real life crap]
Features / Re: New revs
« on September 4th, 2010, 02:58 PM »
Not a problem... When I said "forgotten", I really meant Norv didn't fix it the same way as he fixed Subs.php...
And as I wrote in my earlier rant... As unimportant a fix is, what matters is commitment. We both have it, let's keep it that way :)
Features / Re: New revs
« on September 4th, 2010, 02:12 PM »
rev 36
* Applied Pete's rockin' fix from Subs.php to convert.php as well. (convert.php)

(This one tends to get forgotten in the process... Maybe because now over at the tools folder is in an external repository, I don't know. "Ommit externals" is disabled in my Tortoise copy.)
Features / Re: New revs
« on September 4th, 2010, 12:18 PM »
I didn't do anything special with it, your Honour! Honest to God!
Features / Re: New revs
« on September 4th, 2010, 09:53 AM »
rev 33
! Putting a windowbg block inside a windowbg2? Eh? (Help.template.php)
* Starting the wrc conversion process. Only one for now... More will follow :P (Recent.template.php)

What's the issue? Aren't you able to view the svn log?

As for rev 34 -- very interesting! I'll have a look.
Features / Re: New revs
« on September 3rd, 2010, 06:05 PM »
rev 28
! Fixed a potential error in $board_info['moderators'][id]['link'] ($txt is not supposed to be loaded at this point). Besides, this entry is never used as far as I know, so it might as well be removed entirely... (Load.php)

rev 29
! Incorrect indenting (Display.template.php)
! Minor spacing fixes. (Subs-Editor.php, QueryString.php, Profile-Modify.php, ManagePaid.php, ManageNews.php, upgrade.php, smf_api.php, repair.php)

rev 30
* Updated to SMF rev 10075 + minor spacing fixes. (changelog.txt, convert.php, Subs.php)
@ This needs being looked into. convert.php and Subs.php have apparently been converted to full UTF8. Is this as desired?

rev 31
* Updated to SMF rev 10083. (changelog.txt, repair_settings.php, Subs-Calendar.php)
@ This mostly moves old themes and the tools folder to their own repository. As a direct result, the tools folder is still here, and the old themes are gone, but since we'd already removed them anyway, it's all just fine.
Features / Re: New revs
« on September 2nd, 2010, 08:27 PM »
rev 25
! Fixed remaining CR-LF files. (changelog.txt, install.php, ssi_examples.php, mailQueueCron.php, repair_settings.php, upgrade.php, Admin.php)
Features / New revs
« on September 2nd, 2010, 02:57 PM »
Note to the Wedge audience!

What is this topic about?

It's our official changelog. Every time we commit something to the central SVN server (which retains the master copy of Wedge), we document our changes, and then we post them here.
Pete uses the SVN format to post his changelogs here, while I've been using a slightly different format (eventually adding extra line breaks to improve readability of the whole damn thing.)

As you can see below, this topic started at revision 23, so it's missing about a week's worth of changes, maybe we'll report them later.

There's already a feature list. What's the point of this topic?

The point is that we're being open about what we're currently working on. Not many people do that. They tend to keep you updated once in a blue moon. Our goal has always been to make this topic public, at least after the first alpha release. We're just making that happen a bit earlier.
We're also being honest about our blunders. Perhaps because there aren't a lot of them, eh eh. And honest about the time it sometimes takes us to implement something. Writing a new feature is not as easy as "one two three done". Sometimes you'll just give up on it for some time, come back to it, etc. I think it's an interesting way of going through our numerous changes to the original SMF codebase.
And of course, the feature list is a good thing, and pretty complete as it is, but it doesn't get updated too often.

Another point is that SMF users can finally get to know about SMF quirks we've been fixing. The feature list has an obscure entry about 'SMF bugs' being fixed. I didn't want to reveal what they were. After some consideration, I decided that they 'might as well be told'. So, if anyone has the courage to dig through the complete changelog and compile a list of SMF bugs we fixed (I always try to indicate 'smf bug' or a similar mention in the changelog when I fix one), feel free to transmit it to SMF. We personally don't give a damn about them.

So, do I need to read it?

No. Only if you're a hardcore fan. In which case you probably already had access to it before. I'd recommend you read through the changelog after rev ~750 though. That is, when I compiled the feature list. Anything done after is not in the feature list. I'll update it of course, eventually.

The topic is locked, how do I comment it?

It is locked to help with readability. We don't want to bury the changelogs in the middle of pages and pages of off-topic discussions.
There's already a private comment topic, but it's private and WILL remain so.
The official comment topic is here:
But you can create new topics or whatever you'd like.

Back to the original post!

Hmm, I don't know if it'll work, but I'll try to make a specific thread where we can post our latest rev logs, and maybe discuss them. We're already doing that in the To-do topic, but there's a long post I have to answer over there, and I don't want to forget it :P
Anyway, this is to give more visibility for our cheerleaders, who currently have no way to test the code themselves (or see it in action anywhere.)

rev 23
* Updating to SMF rev 10072 (fixes to strlen and board/topic optimizations) (changelog.txt, ManageSettings.php, News.php, Post.php, Search.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php, Subs-Auth.php, Subs.php)
! Small @ hack in ManageSmileys to avoid errors when the smiley list is empty (wrong folder, etc.) (ManageSmileys.php)

--> Yeah, I ended up committing that one... Sorry, it was too tempting :lol: