Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
1
Features / Re: Language revs
« on March 24th, 12:44 PM »
[Commit revision 1ac5400]
Author: Nao
Date: Fri, 24 Mar 2017 12:41:55 +0100
Stats: 1 file changed; +3 (insertions), -3 (deletions)

  • OMG typos!!!!!!! Not from me I think! I hope! Can anyone check? (ManagePermissions.french.php)
2
Bug reports / Re: Couple things to look into...
« on March 20th, 10:25 PM »
Well, I wouldn't have committed otherwise... ;)
But it's still in the air. I mean the problem with post manipulation inside topics is that there are so many niche situations... Like people showing topics in reverse order, etc... I'm just hoping nothing was broken.
3
Features / Re: New revs
« on March 20th, 04:28 PM »
[Commit revision 7fdc0bd]
Author: Nao
Date: Mon, 20 Mar 2017 16:28:03 +0100
Stats: 2 files changed; +6 (insertions), -6 (deletions)

  • This is a follow-up to rev c92eb3fb73b94a545029e73a830540e5779dfd5c from October 2013. I'd changed the Mark Topic as Unread system to better accomodate for infinite scrolling, but it also broke 'regular' use of the feature by resetting the read post counter to the beginning of the page, instead of the last unread post. I've tweaked the files to always reset to the last unread post, unless (1) you're on a read page (in which case it will mark the LAST post in THAT page as unread), (2) you're in infinite scrolling mode and you just viewed a new page (here it'll simply mark the penultimate read page's last post as unread.) This sounds complicated, but it works better for me. Until, of course, someone tells me it's broken... (Display.php, Subs-Boards.php)
4
Features / Re: New revs
« on March 20th, 03:40 PM »
[Commit revision d9f6873]
Author: Nao
Date: Mon, 20 Mar 2017 15:40:19 +0100
Stats: 1 file changed; +12 (insertions), -19 (deletions)

  • Simplified 'test' strings in the BBCode list. Looks like when the strings were originally moved to the database, extra useless backslashes were added to them. (Subs-BBC.php)
5
Features / Re: New revs
« on March 20th, 03:33 PM »
Test

Hello
6
Thanks, your last bug report was addressed. ;)
7
Features / Re: New revs
« on March 20th, 12:28 AM »
[Commit revision e5868b1]
Author: Nao
Date: Mon, 20 Mar 2017 00:28:38 +0100
Stats: 1 file changed; +77 (insertions), -77 (deletions)

  • Fixed lightness value being treated is a 0-1 float instead of a 0-100% value. (Class-CSS.php)
  • Changed all array()'s to [] while I was at it. Looks so cool. But, yeah, dream on, I won't do it across the entire project. Maybe just the commonly loaded files. This has no influence on performance, so it's just to a developer's benefit. (Class-CSS.php)
8
Quote from Freñiçh on March 19th, 12:37 PM
Quote from Nao
Any reason you'd want to have an exclusive https connection?
Well a secure connection between internet browsers and websites is not a luxury it's a must, allowing to transmit details,passwords or any personal information.
But what personal information would you want to transmit over https here that isn't already encrypted..?
It should be enough that Wedge now fully supports https. ;) (It wasn't the case before.)
The only problem is with avatars, which sometimes use http links so you have to be smart about them.
Quote
So when an users on my Website which is secured with a SSL Certificate chooses to click on a link (on our credit page) it seems logical to me that this must be a secure connection.
Not really, no..?
9
Development blog / Re: The obligatory Christmas update.
« on March 19th, 12:40 PM »
I just realized this was my last post on the blog... :^^;:
Oh, and that comment system looks so cool.

I'm guessing I need to make a strong statement about Wedge still being alive.
Thanks to CerealGuy for never giving up and pestering me into coming back :)
Also thanks to Lestrades.com for giving me a good reason to get back to work!
10
Well, IIRC I only added https support to wedge.org for testing. I'm only making use of it on lestrades.com, where sensitive (or more precisely, 'valuable') data can be shared. I keep asking my host to enable http/2 on nginx[1] but she won't budge. I had my websites hosted by someone else so I wouldn't have to deal with keeping a list of installed modules to update, but apparently I'm not the only one not willing to do that ahah.

Any reason you'd want to have an exclusive https connection? Because AFAIK it's a bit slower (5% at least?), and there is no sensitive data here-- everything is open source and passwords are encrypted before they're transmitted anyway.
 1. This would give me a good reason to move everything to https, by making everything load noticeably faster.
11
Features / Re: New revs
« on March 19th, 11:48 AM »
[Commit revision 0d9d3e4]
Author: Nao
Date: Sun, 19 Mar 2017 11:47:30 +0100
Stats: 1 file changed; +9 (insertions), -29 (deletions)

  • Spacinazi. (Subs-BBC.php)
  • Removed duplicate array declarations, and simplified one of them. (Subs-BBC.php)
12
Bug reports / Re: Couple things to look into...
« on March 19th, 11:41 AM »
Quote from Nao on March 19th, 12:29 AM
Also, looks like your subs-bbc commit is broken... At the very least, 'list' or 'cli' tags aren't working properly (see New Revs topic). Dunno if it's a problem during the rewrite for 'list', or a problem with external custom bbcode not loading at all.
Actually that's because the cli tag didn't have a plugin ID and you're only loading those.
This might be a problem if someone built a mod (rather than a plugin) that still added stuff to the database, but it's unlikely of course.

(This still isn't working yet, ahah.)

:edit: Was due to the fact that the list tag didn't have 'cli' in its allowed children.
13
Bug reports / Re: Couple things to look into...
« on March 19th, 12:29 AM »
Quote from CerealGuy on March 18th, 08:20 PM
Will definetly look into the login thing, unread topics also but less priority.
Thanks!

Also, looks like your subs-bbc commit is broken... At the very least, 'list' or 'cli' tags aren't working properly (see New Revs topic). Dunno if it's a problem during the rewrite for 'list', or a problem with external custom bbcode not loading at all.
Quote
There are some things which bug me about login (besides sha256):
- no js counter for failed logins, i find myself quite often on the "you have to wait before you can try to login again" error page.
I don't know, TBH with LT I only use Steam Connect (i.e. OpenID) to handle users, so no one has to enter passwords on the site. So I don't really have a reason to look into this ahah.
Quote
- after x failed logins this error page should first show up, for me it shows up after the first try
Ah, really?
Quote
- no redirect of $_POST content, i often loose posts because my session timed out. Don't know if this should get solved on login or in editor. Have to think about that.
I thought $_POST got kept, actually...?
Quote
- notification on x failed logins for the user would be cool, maybe plugin stuff.
Yeah, more likely.
14
The Pub / Re: PHP 5.4?
« on March 19th, 12:26 AM »
Implemented.
Go crazy with [ ] now ;)
Also removed all magic quote shit. It felt good!
15
Features / Re: New revs
« on March 19th, 12:22 AM »
[Commit revision f2ba207]
Author: Nao
Date: Sun, 19 Mar 2017 00:22:20 +0100
Stats: 13 files changed; +18 (insertions), -90 (deletions)

  • Removed support for PHP 5.3.x, which hasn't been patched in years. Going for 5.4 now, may even go higher if I ever find a reason to do so. Please, upgrade to PHP 7 if you're still on one of these slow 5.x versions. Faster PHP means happier visitors. (README.md, SSI.php, Class-DB.php, Class-SFTP.php, Errors.php, Memberlist.php, OriginalFiles.php, QueryString.php, Subs-Plugins.php, getid3.php, index.php, install.php, readme_install.html)
  • Note: magic quote functions were removed in PHP 5.4, so Wedge no longer has to deal with these. :-D (Plenty of occurrences removed.)
  • Note: there was also a typo in Memberlist.php (which, for once, was my own fault), causing an 'escape route' to be bypassed instead of executed on PHP 5.4+.