New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #75, on September 9th, 2010, 02:49 PM »
Re r73... so, then, where the select is later set to value = 0 to reset it, what happens? The idea is that in WYSIWYG mode it should retain its value until deselected, or in non WYSIWYG mode it should deselect.

Chrome didn't care, FF didn't like it either (before). Will have to test whether it works now.
Re: New revs
« Reply #76, on September 9th, 2010, 03:06 PM »
Revision: 74
Author: arantor
Date: 14:05:08, 09 September 2010
Message:
! Removal of easter eggs:
 the clock (Calendar.php, Calendar.template.php, index.php)
 the Books of Unknown (Karma.php, index.php)
 i am the administrator. (Post.php)
 iamanoompaloompa (Subs-Menu.php)
 chocolate cake (Subs-Members.php)
 fake integrate_egg_nog (ViewQuery.php)
 OH NOES (ManageMaintenance.php)
----
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Karma.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/index.php


As per http://wedge.org/up/6160/easter-eggs/
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #77, on September 10th, 2010, 12:39 AM »
What happened with your fix, was that selecting "Select font size" would add [size=0pt][/size] to the message box... :)
So I simply did it the way other boxes were done. Now it works, it simply returns "" (insteaf of "0") and thus doesn't show anything.

BTW, wrong place to discuss but I'm a bit lazy...

   $breaker = '<span style="margin: 0 -0.5ex 0 0;"> </span>';

This is in the code to fix long words. Uh... How about we use the proper tool -- &shy;?
Posted: September 9th, 2010, 03:06 PM

rev 75
- Removed setRequestHeader test for Opera... That issue was only in the 5yo Opera 8.00 (note the specific minor version number), so... what the heck?! (Post.template.php, topic.js)

(Looks like Wedge is on a diet, today... ;))
Posted: September 9th, 2010, 03:09 PM

rev 76
- Market share for IE 5.x was 0.08% in 2009... We're in 2010. IE5 support is out. (Load.php, Subs.php, Display.template.php, editor.js, script.js, topic.js)

rev 77
! Oops again. (Load.php) <-- crash

rev 78
! is_opera105up wasn't properly filled in. (script.js)
! document.body isn't always initialized. Replaced with a createElement. (script.js)
+ Re-introduced ActiveX hack, as IE6 also made use of it. Limiting to the newer namespace, though. (script.js)
* If browser supports querySelectorAll(), use that in the rounded corner emulator. Probably only Opera 9.x through 10.10 can make use of that. (script.js)

Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
I don't even have access to the console, for a reason unknown. :(
Posted: September 10th, 2010, 12:03 AM
Quote from Nao/Gilles on September 10th, 2010, 12:03 AM
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
Grmpf... Did the update, and it works in O 9.5. Dunno if it was broken in O9 because I had some wrong configuration. Anyway... O9.5+ is 90% of the Opera userbase or so. Fine with it.
Re: New revs
« Reply #78, on September 10th, 2010, 01:50 PM »
rev 79
! grabJumpToContent() is called through onmousemover if document.implementation isn't defined... It should be done for all, or nothing. (script.js)
* set/getInnerHTML are deprecated, but weren't actually removed from the SMF codebase. (install.php, ssi_examples.php, repair_settings.php, smfinfo.php, unittest.js, upgrade.php, latest-news.js, latest-support.js, admin.js, editor.js, fader.js, PersonalMessage.js, script.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, Templates: Admin, ManageMaintenance ManageSearch, ManageSmileys, MessageIndex, Packages, PersonalMessage, Post, Profile, SplitTopics, Themes)
Posted: September 10th, 2010, 10:46 AM

rev 80
+ Added a placeholder for parse_bbc_inline(). Should be rewritten to use regex later. (Subs.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #79, on September 10th, 2010, 09:07 PM »
You know you fixed up an easter egg in r79, right? :P ssi-examples.php, line 52...

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #80, on September 10th, 2010, 09:27 PM »
Yeah... ;) I actually considered changing the text to say some other thing, but then I decided against it, as I like chocobos, too :P Had it been a Pokémon reference, I would have changed it haha.

Good to see you're reading every fucking borin' line of my stuff!
How do you do it? I mean, I do it too, but sometimes when there are too many changes, I have to take a few minutes to build a diff patch out so I can read more comfortably instead of checking out the log and having to watch the changes file by file...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #81, on September 10th, 2010, 09:30 PM »
The slow way; I look through the log, rev by rev, and then file by file. Though depending on the level and nature of changes I have been known to run two revs together, such as when we were fixing CRLFs, when I'd run two revs together to see the total changes between them.

Basically whatever looks like it'll give me the best clue as to what's changed in the code.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #82, on September 10th, 2010, 09:35 PM »
Yeah, I have a SVN and a SVN_2 folder to make my diff patches for SMF, and a SVN and SVN_all folder for Wedge, although it's a bit different (SVN is a shortcut to trunk, so I can't diff patch between the two, I have to specify SVN_all/trunk and it's boring... :P)
If I could find a way to automate the entire process, that'd be swell... Retrieve rev number in SVN folder, update SVN2 to that rev, then update SVN to latest rev. If different, generate a patch, with name "dev-CURRENT_REV.diff". Make coffee, too.
Re: New revs
« Reply #83, on September 11th, 2010, 12:26 AM »
rev 81
* Uninteresting code cleanup and optimizations. (Class-Editor.php, Load.php, index.css, script.js)
! replaceText() could fail on Opera if run on a message without any carriage return. (script.js)
! Post editor smileys and bbcode buttons would fail on Opera < 10.5 and IE 6-8 because setting innerHTML or outerHTML on an object with dynamic events will reset the event list in these browsers. (script.js)
Re: New revs
« Reply #84, on September 11th, 2010, 01:26 AM »
rev 82
* If modder forgets to put empty quotes at the beginning of a smf_db_query call, let's fix it for them. Dunno if it could be useful. Just felt like it. (Subs-Database.php)
* Cleanup for script.js
- Removed all of the optional parameters in queries, as they were only used by PGSQL and SQlite. (All other files -- please don't make me list them!)

--> Don't bother testing the param stuff Pete, there are about 75 occurrences and I checked them all, one by one. (Automatic search & replace so it was unlikely to fail anyway.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #85, on September 11th, 2010, 03:56 AM »
There was me checking one by one since I tried to commit myself in the interim...

Revision: 83
Author: arantor
Date: 00:35:43, 11 September 2010
Message:
! Remove support for the no longer maintained Turck MMcache (it doesn't even support PHP 5.x properly not having been updated in 7 years) (smfinfo.php, Admin.php, Load.php, ManageServer.php, Subs-Admin.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/tools/smfinfo.php
Posted: September 11th, 2010, 01:36 AM

Revision: 84
Author: arantor
Date: 01:02:19, 11 September 2010
Message:
! Minor optimisation for participation icons (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Posted: September 11th, 2010, 02:02 AM

Revision: 85
Author: arantor
Date: 02:55:32, 11 September 2010
Message:
! Fix bug with the top selector in Who's Online not working (Who.php)
----
Modified : /trunk/Sources/Who.php


As reported by http://www.simplemachines.org/community/index.php?topic=399617.0

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #86, on September 11th, 2010, 09:05 AM »Last edited on September 11th, 2010, 09:33 AM by Nao/Gilles
rev 86
* Updating to SMF rev 10101. Parenthenazi kills SD.
 ! fetch_web_data didn't properly parse ports (Subs-Package.php)
 ! constructPageIndex didn't respect flexible start for compact pagination (Subs.php)

(Yikes, I felt dirty committing this, even though the fixes were made by the reporters, not the committers... They're giving commit access to SlammedDime, after what he did to the team's rep?! Woohoo... And vbgamer45 made his first commit in something like *4 months*, to backport that fetch_web_data fix which isn't even perfect but... :P)

! Minor optimisation for participation icons (Recent.php) <--------- Hey, that was my find :P Thief! :lol:

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #87, on September 11th, 2010, 01:53 PM »
SlammedDime has had commit access for years, just he never uses it.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #88, on September 11th, 2010, 02:59 PM »
rev 87
! Sending PM and moving topics were broken due to wedgeEditor not being correctly loaded. (MoveTopic.php, Subs-Post.php)
* Renamed install/upgrade_2-0_mysql.sql to install/upgrade_2-0.sql, to match the 1.1 branch files. (install.php, upgrade.php, *.sql)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278