Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
991
Features / Re: New revs
« on March 30th, 2014, 12:52 AM »
[Commit revision da7e415]
Author: Nao
Date: Sun, 30 Mar 2014 00:43:09 +0100
Stats: 1 file changed; +3 (insertions), -7 (deletions)

  • Class-ZipExtract was already loaded by ManagePlugins. (Subs-Plugins.php)

[Commit revision 5ed43d4]
Author: Nao
Date: Sun, 30 Mar 2014 00:43:57 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Unneeded parameter. (Display.php)
992
Features / Re: New revs
« on March 30th, 2014, 12:41 AM »
[Commit revision da98ab2]
Author: Nao
Date: Sat, 29 Mar 2014 15:21:29 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Eliminating a logged error from stupid bots. This is mainly Wedge.org-oriented, but it's pretty much free. (Load.php)

[Commit revision 7c36c80]
Author: Nao
Date: Sat, 29 Mar 2014 19:37:02 +0100
Stats: 1 file changed; +0 (insertion), -1 (deletion)

  • An old unused variable. (ManagePermissions.php)

[Commit revision b7aa32d]
Author: Nao
Date: Sat, 29 Mar 2014 20:23:34 +0100
Stats: 1 file changed; +19 (insertions), -45 (deletions)

  • Removed some pre-2004 updateSettingsFile code (I'm sure the "server oddities" mentioned were fixed in the meantime!), and replaced it with file_put_contents and a rename. This is cleaner, shorter, and should work better against low disk space. (Subs-Admin.php)
  • Note: updateSettingsFile now returns false if an error occurred. Instead of nothing special.

[Commit revision 57328c4]
Author: Nao
Date: Sat, 29 Mar 2014 20:24:56 +0100
Stats: 2 files changed; +20 (insertions), -17 (deletions)

  • This one's messed up... It looks like doing updateSettingsFile and subsequently redirecting to the same page will not always load the correct settings file. Perhaps it's due to my Windows setup, I don't know. But I'd rather do an ugly, visible refresh than give the user a finger and force them to reload the page manually. (Subs.php, Upgrade.php)

[Commit revision b0db1d0]
Author: Nao
Date: Sat, 29 Mar 2014 20:31:41 +0100
Stats: 1 file changed; +4 (insertions), -12 (deletions)

  • Maintenance. (ManageMaintenance.php) (Had to be.)
993
Features / [Poll] Re: Board status icons: what's the point?
« on March 30th, 2014, 12:27 AM »
Quote from Maxx on March 29th, 2014, 09:07 PM
Not to mention  you can see who posted last on the board index.
Yes, and as such, you already have a "last updated" date... :^^;:
Quote from Maxx on March 29th, 2014, 09:07 PM
Or just place a text "!" in there. and for child boards maybe a small green dot like would work?
I'm not there yet.
994
Support / Re: No rank stars
« on March 30th, 2014, 12:25 AM »
Can you confirm it as fixed with the new update..?
995
Importing into Wedge / Re: Importer tool
« on March 30th, 2014, 12:24 AM »
[Commit revision ebc715a]
Author: Nao (Signed-off)
Date: Sun, 30 Mar 2014 00:24:23 +0100
Stats: 3 files changed; +15 (insertions), -0 (deletion)

  • Attempting to fix the missing star images on membergroup ranks. (smf11_to_wedge.xml, smf2_to_wedge.xml, smf2RC_to_wedge.xml)
  • Also fixing online colors for SMF 1.1. (smf11_to_wedge.xml)
996
Features / [Poll] Re: Board status icons: what's the point?
« on March 29th, 2014, 08:46 PM »
Okay, I've been working on this since yesterday, reviewing the whole stuff for commit, and then it occurred to me...

What would you prefer, now that the "unread posts in this board" thing is removed?

Would you prefer the board status icon to tell you:
1- "This board's latest post is 1 day/1 week/1 month/1 year/+ old" (current solution)
2- "This board's latest post was made after your last visit" (it'll stay turned on until you log out or just leave the forum for 15+ minutes)
3- "This board's latest post was made after your last post" (it'll stay turned on until you post anywhere again)
4- Give a user option to choose between these..?? (Overkill, probably!)

(1) has the advantage of being already written, ah ah. It also encourages you to post in old forums. The main drawback is that the various visual "levels" can be confusing. Which can, of course, be "fixed" by reducing to a couple of levels (new posts today, no new posts today.)

(2) has the advantage of using last_login data, which is free. Or id_msg_last_visit, also free, dunno which would be best for now. Although, if I don't use this, it means I can remove the id_msg_last_visit column from the members table, because I can't think of a good reason to keep it. (It was used in SMF to determine unread posts "for this session", but Pete removed that, although he never removed that item from the table.)

(3) would require recording your message ID to the members table everytime you post something. That's an extra query per post action, although maybe it's already done, but I don't know where.

Please discuss!
997
Features / Re: Plugin revs
« on March 29th, 2014, 03:48 PM »
[Commit revision 097c83b]
Author: Nao (Signed-off)
Date: Sat, 29 Mar 2014 15:47:52 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)

  • Outdated hooks. (calendar/ManageCalendar.php, wedgedesk/src/Subs-WedgeDeskAdmin.php)

[Commit revision 18702a2]
Author: Nao (Signed-off)
Date: Sat, 29 Mar 2014 15:48:09 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Removing seen! (recent_items/Recent-Main.php)
998
Plugins / [Plugin] Re: HideMod
« on March 29th, 2014, 03:28 PM »
Oh... Bugger.
999
Archived fixes / Re: wuthering theme "new" error
« on March 29th, 2014, 03:26 PM »
Sorry, had uploaded an outdated version of a file.

I'm not finished with the 'new' stuff rewrite, but the commit should be coming today.
1000
Features / [Poll] Re: Board status icons: what's the point?
« on March 29th, 2014, 08:42 AM »
What second option? The one in the poll, or my last question?
1001
Support / Re: Mobile Wedge
« on March 29th, 2014, 08:23 AM »
What phone are you using, BTW...? Apparently it's neither an Android nor an iOS device. Windows Phone?
1002
Features / [Poll] Re: Board status icons: what's the point?
« on March 28th, 2014, 11:15 PM »
Just wanted to point out...
Code is close to finished locally; I've taken the liberty to upload the files here, so you can see the board index in action.

So, basically:

.boardstate_day mixes .inline-block

.boardstate_week extends .boardstate_day
   opacity: .9

.boardstate_month extends .boardstate_day
   opacity: .75

.boardstate_year extends .boardstate_day
   opacity: .6

.boardstate_old extends .boardstate_day
   opacity: .4

.boardstate_redirect extends .boardstate_day
   opacity: .2

So, anything posted within the last day has an opacity of 1, anything posted between 1 month and 1 year ago has an opacity of .75, and anything posted before you were born has an opacity of .4.
From what I can see, it's a fair representation. It's not perfect though, and I'm willing to change this if anyone has something better to suggest. I can also remove one class or more, if it's too 'specific' or not enough.

Also, removing this whole system will save you one SQL query per topic read (one per board; if reading multiple topics within the same board, that's still just one query.)

Removing log_boards felt good, too..! I'll need to update the upgrader to remove it automatically, will be cool.

A classic SMF question that I'll adapt to Wedge, though...: should the main boards (those with an icon) display their age according to their own content, or based on their content + any of their children's contents..? Right now, I'm doing it based on their own content, although it costs me an extra timeformat() per board processed.

Bed time.

PS: I *do* have GIMP 2.8 installed on my PC, I just never launch it because it takes 20 seconds to initialize. PSP7 takes less than a second... And yes, I have a SSD drive and a Core i7 processor...
1003
Features / Re: New revs
« on March 28th, 2014, 11:06 PM »
[Commit revision 7d8f681]
Author: Nao
Date: Fri, 28 Mar 2014 18:27:55 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Doing a quick test to see if a percentage width gives better results on mobile PM pages. This is the best I can do apart from converting the PM template to use the Msg skeleton, and quite honestly I have other priorities for now. :-/

[Commit revision 3673754]
Author: Nao
Date: Fri, 28 Mar 2014 21:20:42 +0100
Stats: 11 files changed; +26 (insertions), -118 (deletions)

  • After reducing 'topicseen' URLs to 'seen', they're now reduced to '', which is definitely better... Seriously, I've removed this old ability (pre-1.0!) that SMF had of showing unread status on boards in the board index. The first reason was that it was buggy, and apparently not due to Wedge. The second reason was that after a quick poll, I realized others were just like me, completely ignoring these icons, and simply reading new posts through other methods like Unread Topics, Unread Replies, Recent Posts, etc. Board icons are better used as a way of showing activity in a board. (SSI.php, Announce.php, Display.php, MessageIndex.php, QuickMod.php, Subs-BoardIndex.php, Subs-Boards.php, Subs-Post.php, Unread.php, UnreadReplies.php, Search.template.php)
  • Left to do: remove the log_boards table.
1004
Importing into Wedge / Re: Importer tool
« on March 28th, 2014, 09:34 PM »
[Commit revision 8c2ced7]
Author: Nao (Signed-off)
Date: Fri, 28 Mar 2014 21:33:58 +0100
Stats: 8 files changed; +2 (insertions), -40 (deletions)

  • Removed log_boards import. (*_to_wedge.xml)
1005
Features / [Poll] Re: Board status icons: what's the point?
« on March 28th, 2014, 11:14 AM »
Apparently, getting rid of topicseen and boardseen would also allow me to get rid of the log_boards table... Hmm.

It's interesting how all of these log_* tables are unclear in what they're supposed for help us with. (log_boards, log_topics and log_mark_read, most notably.)