Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
976
Features / Re: New revs
« on April 1st, 2014, 08:04 PM »
[Commit revision b24e313]
Author: Nao
Date: Mon, 31 Mar 2014 22:57:52 +0200
Stats: 1 file changed; +31 (insertions), -22 (deletions)

  • Sped up the BadBehavior process by replacing stripos with strhas, and strtolowering the user agent once and for all at the beginning. (Security.php)
  • MJ's bot is up to version 1.4.4, I dunno why BadBehavior only takes 1.0.8 into account but it's still hammering my server with stupid requests, and I don't like bots that pretend to be for "SEO purposes" anyway. We don't need you. (Security.php)

[Commit revision 8989d5a]
Author: Nao
Date: Tue, 01 Apr 2014 15:46:00 +0200
Stats: 1 file changed; +5 (insertions), -5 (deletions)

  • Fixed fake Baidu blocking. Long time no see, Pete bugs! This one was actually a double negative that resulted in blocking only some valid Baidu requests. I have to say, though, apparently Baidu has way more IP blocks than indicated here, and I doubt it'll be very helpful in the end. (Security.php)

[Commit revision eda89f6]
Author: Nao
Date: Tue, 01 Apr 2014 15:57:23 +0200
Stats: 1 file changed; +12 (insertions), -12 (deletions)

  • As far as I know, search bots like Google will never log into your forum, ah ah... So we might as well block Google/Bing/Yahoo/Baidu if they're trying to use an account. (Security.php)
  • And, on the other hand, we could just as well let Opera/Safari/Konqueror/Lynx requests go if they don't have an Accept header BUT they're logged in. Because it may be caused by firewall software, or things like that. Also leaving IE alone if it's logged in. (Security.php)
  • Although being whitelisted as a member won't help if you're not logged in yet (duh), feedback told me that Accept header problems were caused by media requests. In this case, it should be helpful: user logs in, and no longer gets empty avatars. Yayz. (Security.php)

[Commit revision ca579ed]
Author: Nao
Date: Tue, 01 Apr 2014 18:48:38 +0200
Stats: 1 file changed; +7 (insertions), -3 (deletions)

  • Some fixes for SSI examples. (install/ssi_examples.php)

[Commit revision bceb12e]
Author: Nao
Date: Tue, 01 Apr 2014 19:47:13 +0200
Stats: 16 files changed; +82 (insertions), -257 (deletions)

  • Removed log_boards table. (index.php, SSI.php, Class-DBHelper.php, MoveTopic.php, Post2.php, Profile-Modify.php, RemoveTopic.php, RepairBoards.php, Subs-BoardIndex.php, Subs-Boards.php, Subs-Members.php, Upgrade.php, install.sql)
  • Note: this effectively removes 'New' icons from ssi_topBoards(). Not that this function's ever been any useful, but hey...

Posted: April 1st, 2014, 07:48 PM

[Commit revision 8cb1a75]
Author: Nao
Date: Tue, 01 Apr 2014 20:03:52 +0200
Stats: 1 file changed; +0 (insertion), -4 (deletions)

  • log_boards language cleanup.
977
Features / Re: Language revs
« on April 1st, 2014, 08:04 PM »
[Commit revision f837061]
Author: Nao (Signed-off)
Date: Tue, 01 Apr 2014 20:03:41 +0200
Stats: 3 files changed; +0 (insertion), -12 (deletions)

  • log_boards language cleanup.
978
Features / Re: New revs
« on March 31st, 2014, 10:24 PM »
[Commit revision 993d2f0]
Author: Nao
Date: Mon, 31 Mar 2014 22:08:26 +0200
Stats: 2 files changed; +10 (insertions), -19 (deletions)

  • Added an {empty} type for empty strings in query replacements. (Class-System.php)
  • Rewrote a bit of the database variable replacement code. (Class-DB.php)
  • - Renamed the function to just wesql::replace_value,
  • - Removed the 'identifier' type (never used, not even in SMF?!),
  • - Removed 'text' (an alias of 'string' that was never used...
  • - Removed all break instructions, because they were never executed anyway,
  • - And hopefully made the error message for replacement errors more helpful.
  • And if I were to rename string to text across all files, I'd rather rename it to 'str', which I won't do anyway.

[Commit revision 6b1a53d]
Author: Nao
Date: Mon, 31 Mar 2014 22:23:57 +0200
Stats: 2 files changed; +27 (insertions), -25 (deletions)

  • Removed query_see_topic test from loadBoard, as it was actually overkill (this isn't the place to test whether the topic is actually viewable...), and was the thing that broke topic privacy for moderators. (Load.php)
  • And thus, I can revert my revert, and push back query_see_topic creation to we::permissions. Phew... (Class-System.php)
979
Features / Re: New revs
« on March 31st, 2014, 04:26 PM »
[Commit revision 187bcbc]
Author: Nao
Date: Mon, 31 Mar 2014 15:58:34 +0200
Stats: 2 files changed; +47 (insertions), -31 (deletions)

  • Fixed topic privacy. Hopefully. (Class-System.php, Load.php)
  • Fixed bypass_edit_disable permission. This one's 100% confirmed. (Class-System.php, Load.php)
  • This was due to permissions being tested against before they were loaded at all. We are not amused.

Posted: March 31st, 2014, 03:58 PM

[Commit revision 200556a]
Author: Nao
Date: Mon, 31 Mar 2014 16:26:09 +0200
Stats: 1 file changed; +24 (insertions), -28 (deletions)

  • A partial revert of the topic privacy fix. The fix was all about the fact that non-admins with permission to approve posts wouldn't be able to see see unapproved posts. Which is pretty bad, so I'll need to rewrite a query in loadBoard because it's caught in a logic loop with loadPermission. In the meantime, because my fix was breaking inside uncached boards, I'll just leave the code where it used to be -- it'll work fine for everyone else. (Class-System.php)
980
Plugins / [Plugin] Re: HideMod
« on March 31st, 2014, 04:10 PM »
This one's fixed... I broke the rest of Wedge by fixing it, though... :lol:
Well, technically I was trying to fix topic privacy, and it backfired because of a logic loop. I'm trying to find a solution for that. I'll get back to you guys when I find it... If I do!
981
Archived fixes / Re: Disable user selectable language support error
« on March 31st, 2014, 03:31 PM »
Oh... Good to know. :)
982
Support / Re: No rank stars
« on March 30th, 2014, 11:34 PM »
Not that I know of. You'd have to ask @TE if he can add support for importing badges & rank images, I suppose.
Other than that... Just copy the files manually, eh! ;)
983
Features / [Poll] Re: Board status icons: what's the point?
« on March 30th, 2014, 11:32 PM »
Well, there are many ways to remove it, of course. Not harm done either way.

I'm surprised no one's trying to discuss the various alternatives I gave...?
984
Features / Re: New revs
« on March 30th, 2014, 11:24 PM »
[Commit revision bf04bdc]
Author: Nao
Date: Sun, 30 Mar 2014 23:24:11 +0200
Stats: 3 files changed; +19 (insertions), -20 (deletions)

  • Move Topic page wasn't working on mobile devices. (sections.css)
  • Spacinazi. (Unread.php, UnreadReplies.php)
  • Details. (sections.css)
985
Features / [Poll] Re: Board status icons: what's the point?
« on March 30th, 2014, 05:04 PM »
Well. Apologies if I was mistaken. But still, I'd rather talk about ways to replace that crappy SMF feature.
So you have this one post to comment on.
http://wedge.org/pub/feats/8550/poll-board-status-icons-what-s-the-point/msg295244/#msg295244
986
Support / Re: No rank stars
« on March 30th, 2014, 04:04 PM »
Icons fixed then?

As for the error. It's in the smiley code. Any problems with the assets/smileys folder permissions..?

Also I dunno why it gives you an error when there is an error suppressor in that line of code.
987
Features / Re: Language revs
« on March 30th, 2014, 12:47 PM »
[Commit revision 3553c5f]
Author: Pandos (Signed-off)
Date: Fri, 28 Mar 2014 10:21:35 +0100
Stats: 2 files changed; +3 (insertions), -1 (deletion)

  • German translation for bypass_edit_disable permission strings. (Help, ManagePermissions).

[Commit revision 9ed1872]
Author: Nao
Date: Sun, 30 Mar 2014 12:47:07 +0200
Stats: 2 files changed; +3 (insertions), -1 (deletion)

  • Merge pull request #16 from Pandos/dev
  • German translation for bypass_edit_disable permission strings. (Help, Ma...
988
Features / [Poll] Re: Board status icons: what's the point?
« on March 30th, 2014, 12:22 PM »
Well, that's the idea... ;)
989
Features / [Poll] Re: Board status icons: what's the point?
« on March 30th, 2014, 10:59 AM »
Quote from Johnny54 on March 29th, 2014, 10:19 PM
With the removal of the "unread posts in this board" you destroyed the useabillity of the software.
Hmm... If i had, I'm sure poll voters would have said so.
You chose to vote for the option I didn't vote for and that was in the minority. As such, you should have made a strong case for your choice. You didn't.
Quote from Johnny54 on March 29th, 2014, 10:19 PM
Using the "unread posts" is extra work and you jump in a unlogical manner through the topics and posts.
You're free to use the Unread Posts links next to the board names. The only difference between now and before is that the board ICON will no longer give you a BUGGY unread status for you. It will tell you whether there have been new posts recently. If you're following a few boards only, then it'll be just the same to you. Or just use the general unread posts link and make sure to add specific boards to your ignore list. Dunno what the problem is.
Quote from Johnny54 on March 29th, 2014, 10:19 PM
Wedge just lost a big part of his value. At least for me.
Judging from your lack of participation after Pete left, I'd say you've been thinking that since that day.

Again, Wedge is my vision of great forum software. I'm making decisions to improve usability. You may not agree with them, but if you don't then if you feel concerned, you should participate in discussions instead of contesting my decisions after I made a democratic poll about them.
You could even ask for a Plugin to restore this. Or even a per user setting. Just because I removed that crappy SMF code doesn't mean I can't put a better replacement in.

But no... You have to be aggressive about it. That's not the way to get what you want. Nuff said.

@everyone else, I'm listening to suggestions on the few alternatives I made yesterday. ;)
990
Bug reports / Re: Posting pictures on posts generates 8 errors
« on March 30th, 2014, 10:47 AM »
I'm not asking about these. I'm asking about the strtr error. Please re read my previous post ^^