Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
3571
Features / Re: New revs
« on February 25th, 2013, 12:29 PM »
rev 1952 -- wanted to have a cooler update, but.. had to pull it at the last minute. Still -- enough content for a commit.
(14 files, 5kb)

! Fixed menu tabs in Android. (GenericMenu.template.php)

* More strings to literals. (Class-Editor.php, ManageBoards.php, ManageMembergroups.php, ManagePermissions.php, ManageSearch.php, Aeva-Gallery2.php, ManageMedia2.php)

* Commenazi. (ManageBans.php, ManageMail.php, ManageMemberOptions.php, ManagePaid.php, ManageSearch.php, ManageSettings.php)

* More partial French translation... Honestly, I think I'm lost in this ocean of translation work. I'll give it another try, and then... We'll see. (Help.french.php)
3572
The Pub / Re: This describes me somewhat
« on February 24th, 2013, 09:42 PM »
Wedge is European. We don't have problems with language :P
3573
Off-topic / Re: Crashing PHP in one easy lesson (aka WTF?)
« on February 24th, 2013, 05:50 PM »
I thought it could be due to gzip because it happened to me years ago, and once I disabled mod_gzip (or was it the equivalent setting in PHP...), it started working again...

Oh, now I remember, it didn't crash PHP, it just 500'ed my Apache. Don't bother.

It's really odd...
3574
Off-topic / Re: Crashing PHP in one easy lesson (aka WTF?)
« on February 24th, 2013, 05:28 PM »
Have you tried turning it off and on again?™

Have you tried turning off gzipping?

Is this the default php.ini in WampServer? (The one in the Apache bin folder.)
3575
Features / Re: Micro feature: escliteral type
« on February 24th, 2013, 04:10 PM »
Okay, so... Get ready for the big stupid suggestion.

Why not just call ob_sessrewrite($string) directly..? :^^;:
I'm sure we can accomodate for direct calls very easily.

Also, before I leave to take a break --
1/ I've managed to implement my flexbox test. It has the advantage of not breaking anything for old browsers. I'll commit it next. I'll be glad to get your opinion on it. It's a very, very minor thing... But one that has been 'in your face' ever since the early days of SMF 2.0. And because it's something in the Msg template... Well, it's even more 'in your face', but I think most people never noticed the difference ;)

2/ I was considering something else... A bit bigger. I know there's a "policy" for function naming in SMF (and thus Wedge), and you've explained it several times at sm.org and here, and it has something to do with functions for internal use, functions for plugin/theme/mod use, etc... I know all that. But when I go through Subs.php, and all of these pretty similar functions (semantically at least), I just can't a hold of it. Why is this camel-cased, while that one isn't..?
And then it came to me. We're Wedge. We can afford to rename functions.
So... Wouldn't it make sense to settle for one style, and only one..?
Obviously, dropping camel-case would make the most sense to me. Having everything rendered through underscores and lowercase chars would at least save people the hassle of trying to remember how a function name was to be written.

Or, just forget it ;)
3576
Features / Re: Micro feature: escliteral type
« on February 24th, 2013, 03:33 PM »
Quote from Arantor on February 24th, 2013, 03:09 PM
I remember Orstio publicly saying "Is this meant to be some kind of joke?"
Actually, come to think of it... It might very well have been.
After all, some of the devs did the transition quite... reluctantly.
Quote
Bed is this way --->
<--- unless it's this way.
It's this way. <----
Unless you're looking from inside my monitor, of course. (Now get off my monitor!)
Quote
I'm really not that worried. I never really planned to go on a blitz through the source, I figured I'd just update them as I encountered them, much how <URL> is being applied.
Yeah, but $scripturl is a special one... Many of its uses aren't easily portable to <URL>. So we're trying to do it carefully. There are still over 1500 uses of it throughout the source... Oh my, I never realized.

Oh, makes me think... I think somewhere else you asked about making ob_sessrewrite callable from a non-buffer context so that we could apply pretty URLs and <URL> transforms to any string, without having to bother with resetting the buffer output. Is it still in the news..? I know I wanted to do that 'back in the day', but I can't remember why I stepped back, though.
3577
Plugins / Re: Plugin server
« on February 24th, 2013, 02:57 PM »
Now that's a silly name... :niark:
3578
Features / Re: Micro feature: escliteral type
« on February 24th, 2013, 02:56 PM »
Quote from Arantor on February 24th, 2013, 02:43 PM
Numbers don't need escaping.
I know, I was just pulling your leg :P Twice even :^^;:

Oh, right, you probably weren't there at the time SMF underwent the {change}. That was in late 2007 or early 2008... Charter members and beta testers with access to the files were disgusted at how the team had implemented the security change -- while it was a GOOD thing, it was done in such an automated way, we'd find many useless escaped strings and it really, really made the codebase look so ugly... Over the months, though, the devs ensured that the initial mess was mostly cleaned up, but they still left a lot of {int:zero} things here and there...
Of course, there's one case where it's all right to use this system for constants. Which is explaining an integer value of an option list. For instance, SELECT something WHERE value IN ({int:nobody}, {int:everyone}) -> array('nobody' => 0, 'everyone' => 1).
In this case, yes, it's better to stick with the escaped constant.

Anyway: sorry if my sarcasm wasn't too obvious. Maybe it's the lack of sleep... Only had less than 3 hours today.

But posting this thing in the changelog sort of made me consider removing the 'obvious' ones.
Well, I guess I'll do that... When I see them!
I already spent half an hour turning strings to literal this morning, so I guess I'll leave it for another time.
Do you want to do the rest by yourself, BTW..? I think I did at least half of them.
3579
Plugins / Re: Plugin server
« on February 24th, 2013, 02:38 PM »
Post-review is the way to go... Always has been.
With a badge system for plugins. Always has been.

'Official plugin' for team plugins
'Outstanding plugin' for non-team plugins the team loves
'Reviewed plugin' for non-team plugins the team has tested and can attest will work, but do not particularly recommend over anything else.

Of course we don't care about the badge names, it's just that we need to differentiate them...
3580
Features / Re: Pages: [1] 2 3 styling
« on February 24th, 2013, 02:03 PM »
Again, you should PM me or bump multiple times when you want to catch my attention. As I said before, there are too many topics and I try to focus on development rather than development discussion (since I haven't found the magic formula that allows me to do both and also deal with real life...), anyway.

I'm afraid I don't like these alternatives. The second one is better but overall its font is only supposed to remind you of 'new' posts, so a number in that style would represent a post number, not a page number... I know, it's only very technical, but I certainly don't get why the 'next' and 'go down' links should be using the same font, too...

I'd suggest doing the same styling, but only for the numbers area. Do you want me to make a mockup or something...?

@godboko> Fat fingers should use Chrome for Android. It actually detects fat fingers and does a 'pop-up zoom' of the area you clicked, so that you can do a proper choice... I love how intuitive that one is. And, of course, iOS and Android Stock Browser don't have it... -_-
Posted: February 24th, 2013, 07:58 AM

It could be argued that Likes also use the same styling for numbers, so I'll try to think of it that way.

I've done various tests, and found one that I like enough.
It's done on the basis that only the numbers are styles. But the 'trick', is that you get the current page to be shown either on a green, or red background. The difference..? Green = it's all done. Red = there's new stuff to be found on this page.
I think it works well, but then another problem occurs to me: is it worth keeping the 'new' indicator next to later pages..? Just a simple example: let's say you've read all 3 pages of a topic... Then you go back to page 1, but in the meantime, someone posted in page 3. In the current Wedge, you'll see a New indicator in the page list. In the proposed change, you'll just see a green page number, and that's all.
3581
Is there an admin option to delete the language cache..? Just curious. I can imagine I'd be tired of manually emptying the cache folder everytime I'm uploading a new language update...

(Oh, and probably time to use CACHEDIR or something... ;))
3582
Features / Re: Micro feature: escliteral type
« on February 24th, 2013, 07:48 AM »
And as you can see, I immediately adopted it... ;D

I think the best way to ensure it's used everywhere, is to do it the hard way, i.e. search for {string: and verify what it's matched to... Also, as I asked in the changelog: should we do {literal:0} things, too..?
3583
Features / Re: New revs
« on February 24th, 2013, 07:12 AM »
rev 1951
(17 files, 9kb)

! Fixed -prefix replacements in Wess. Seriously, I'm ashamed of this one... Probably a last-minute change. (Class-CSS.php)

! Fixed @if not supporting member/guest flags in Wess. I really thought they were already accounted for... (Class-CSS.php)

* More literal love... Literally. Okay, that one's done... Okay, should we also use literal for constant numbers..? (upgrade.php, Subs-Media.php, Merge.php, ModerationCenter.php, Profile-Actions.php, Profile-Modify.php, RemoveTopic.php, Reports.php, Stats.php, Subs-Admin.php, Subs-Charset.php, Subs-Members.php, Subs-Post.php, Themes.php)

* Minor layout fix. Yes, with a language string change... Don't bother. (ManageBans.french.php)

* Another scripturl bites the dust. (Subs-Media.php)

! setlocale fix and harmonizing. (Subs-Media.php, Subs.php)

@ Not that I'm teaching anyone anything, but my regex to find potential literals is '([^']+)' => '\1' -- although it's (ahem) unlikely to find things like {string:icon} associated with 'icon' => 'xx', for instance...
3584
Features / Re: New revs
« on February 24th, 2013, 05:46 AM »
rev 1950 -- I'm hungry... Can't sleep... Browsing on my S3... Fixing stuff for it.
(2 files, 2kb)

! Fixed scrollbar no longer being reactive in Android. This was mostly due to the fact that I forgot the window object has a scrollTo method already. Costs an additional 2 bytes to fix. (sbox.js)

+ Implemented my own super-short Android compatibility hack into menus. It only does the basics, but you don't need more because AFAIK, all parent menus have an equivalent link in their children. And it's only 21 more bytes, eh eh. Likely in reaction to Ant's comment at Elk about how Superfish got bloated to add mobile support... ;) (script.js)
3585
The Pub / Re: When can I download Wedge? / Where can I download Wedge?
« on February 23rd, 2013, 11:49 PM »
Well, it does make it obvious that our recent decision to release a new private alpha didn't come to fruition...
As always, as soon as a 'big' feature is being worked on, we can't release an alpha to show it off until it's ready.

Hey, first post since I've recovered from my fever. I started work on implementing flexbox in a critical area, but it's harder than expected... Ah well, not exactly a nice comeback... :lol: