Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
3271
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on April 4th, 2013, 11:08 AM »
Well, looks like it's working now, without changes... Something like @NaoSecond line.
Ah, your git repo... I don't tend to visit github often... :whistle:
Right now, I'm fighting with my caret position hack for your mentions popup. It's... quite interesting. I dunno why, this morning I decided I wanted to have it pixel perfect, and still überfast. I managed to do it, but then I realized my pixel-perfect code issues were mostly down to errors on my side, hmm...
Ah, your git repo... I don't tend to visit github often... :whistle:
Right now, I'm fighting with my caret position hack for your mentions popup. It's... quite interesting. I dunno why, this morning I decided I wanted to have it pixel perfect, and still überfast. I managed to do it, but then I realized my pixel-perfect code issues were mostly down to errors on my side, hmm...
3272
Archived fixes / Re: Wedge.org today
« on April 4th, 2013, 11:04 AM »
Firefox 20 is supposed to support the flexbox mode by default (i.e. no flags to enable). Isn't it the case in Linux..?
Oh my, I don't know why I've been having so many flex problems since precisely yesterday... Why oh why? Is something up there trying to make me give up on flex...?!
Oh my, I don't know why I've been having so many flex problems since precisely yesterday... Why oh why? Is something up there trying to make me give up on flex...?!
3273
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on April 4th, 2013, 11:00 AM »
Didn't you notice earlier...? It's been installed for a couple of weeks at least...
Also, now there's this strange bug where I actually get a proper reference when doing @NaoSecond..?! Shouldn't it be ignored..?
Yes, I plan to have it work on quick reply, too, but I won't make any promises. The problem is mostly with loading extra files on topic load, which is always annoying. (I'm considering loading these scripts only when first clicking Quick Reply, though...)
Only the display name is taken into account. That's how Dragooon programmed it, and I don't have plans to change it.
The only place where you can see a user name (login) anyway is in the profile page...
Also, now there's this strange bug where I actually get a proper reference when doing @NaoSecond..?! Shouldn't it be ignored..?
Yes, I plan to have it work on quick reply, too, but I won't make any promises. The problem is mostly with loading extra files on topic load, which is always annoying. (I'm considering loading these scripts only when first clicking Quick Reply, though...)
Only the display name is taken into account. That's how Dragooon programmed it, and I don't have plans to change it.
The only place where you can see a user name (login) anyway is in the profile page...
3274
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on April 4th, 2013, 09:14 AM »
Thought I should mention... (Ah, ah.)
(Where do I post my updated files anyway..?)
Yesterday I fixed the silly bug where doing @Nao on a single line without any other punctuation would fail to 'detect' it.
For the record: it was due to the strip_tags call. It can be called, but it should add an exception parameter of '<br>'. Otherwise, multiple lines are put together without any separator, and you know what that means... Something like @NaoSecond line.
(Where do I post my updated files anyway..?)
Yesterday I fixed the silly bug where doing @Nao on a single line without any other punctuation would fail to 'detect' it.
For the record: it was due to the strip_tags call. It can be called, but it should add an exception parameter of '<br>'. Otherwise, multiple lines are put together without any separator, and you know what that means... Something like @NaoSecond line.
3275
The Pub / Re: Don't update log_online for certain actions
« on April 4th, 2013, 08:42 AM »
I don't want to create a precedent... I just want to be done with this crap!
It's either this, or in QueryString I modify the query on the fly to read like action=feed;sa=media... And still redirect to Aeva-Foxy.php's feed handling somehow.
Oh well... I should probably simply do includes in the feed code. I'll look into doing that.
It's either this, or in QueryString I modify the query on the fly to read like action=feed;sa=media... And still redirect to Aeva-Foxy.php's feed handling somehow.
Oh well... I should probably simply do includes in the feed code. I'll look into doing that.
3276
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 11:51 PM »
Pete..? This is the 'best' I could come up with... -_-
index.php:236 (after $context['subaction'] is declared)
Code: [Select]
Very ugly. But, well... At least, it works. And it shouldn't have much impact on influence. (The only impact I'm afraid of would be the extra bytes to load for each index.php file if it's not being kept in memory, I'm afraid...)
I tried doing it the hard way -- moving Aeva-Foxy's feed code to Feed.php... First of all, it adds 10KB to the 25KB in Feed.php (meaning parsing the file is a bit longer when it's a fairly often accessed file...), then the Foxy code in itself is too tightly integrated with AeMe to 'make sense' in Feed.php, in my opinion... I may be wrong, but... I felt bad doing this, so I cancelled my changes.
Today sucked.
index.php:236 (after $context['subaction'] is declared)
if ($action === 'media' && $context['subaction'] === 'feed')
{
global $action_no_log;
$action_no_log[] = 'media';
}Very ugly. But, well... At least, it works. And it shouldn't have much impact on influence. (The only impact I'm afraid of would be the extra bytes to load for each index.php file if it's not being kept in memory, I'm afraid...)
I tried doing it the hard way -- moving Aeva-Foxy's feed code to Feed.php... First of all, it adds 10KB to the 25KB in Feed.php (meaning parsing the file is a bit longer when it's a fairly often accessed file...), then the Foxy code in itself is too tightly integrated with AeMe to 'make sense' in Feed.php, in my opinion... I may be wrong, but... I felt bad doing this, so I cancelled my changes.
Today sucked.
3277
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 07:53 PM »
That's the problem.... I feel that everything should be 'natural'.
And in this particular situation, there is no way for that to happen, so I'm asking you what your preferred solution(s) are...
(Would also appreciate some feedback on Chrome + flexbox model from other users...)
And in this particular situation, there is no way for that to happen, so I'm asking you what your preferred solution(s) are...
(Would also appreciate some feedback on Chrome + flexbox model from other users...)
3278
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 07:36 PM »
No. pretty and non pretty URLs are interoperable...
3279
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 07:12 PM »
Hmm... I guess it's a lose-lose situation, then...
I can't change the URL. That's because older installs will still need them to be valid. Or I'll have to add a redirection like I'm doing for old feeds... But that's not 'clean', either.
... :-/
I can't change the URL. That's because older installs will still need them to be valid. Or I'll have to add a redirection like I'm doing for old feeds... But that's not 'clean', either.
... :-/
3280
Features / Re: New revs
« on April 3rd, 2013, 06:50 PM »
rev 2044
(7 files, 3kb)
+ Added new Wess constant, 'can_animate', which aliases the long and complicated list of browsers that support CSS3 animations. Of course, you don't have to use it -- you only need it if you're planning to provide a, err... fallback. (Class-CSS.php, common.css)
! Fixed that annoying glitch in the error log, where filters would show with double-encoded entities. Note to self and anyone: westr::safe() rocks, use it more! (ManageErrors.php)
! Settings.language.php is a special file; creating an empty version of it will generate an error when someone switches skins while using said language. (Settings.english-uk.php)
* Finished British version of a file. If I ain't a good European citizen! (Who.english-uk.php)
- Removed 'gallery feed' action from Who's Online list. Just like regular Atom feeds, there's little reason to waste time logging these, as they're not real page loads. (Who.language.php)
- Old Opera and old Safari don't need to view CSS3 animations, as they don't support them at all. (Class-CSS.php)
(7 files, 3kb)
+ Added new Wess constant, 'can_animate', which aliases the long and complicated list of browsers that support CSS3 animations. Of course, you don't have to use it -- you only need it if you're planning to provide a, err... fallback. (Class-CSS.php, common.css)
! Fixed that annoying glitch in the error log, where filters would show with double-encoded entities. Note to self and anyone: westr::safe() rocks, use it more! (ManageErrors.php)
! Settings.language.php is a special file; creating an empty version of it will generate an error when someone switches skins while using said language. (Settings.english-uk.php)
* Finished British version of a file. If I ain't a good European citizen! (Who.english-uk.php)
- Removed 'gallery feed' action from Who's Online list. Just like regular Atom feeds, there's little reason to waste time logging these, as they're not real page loads. (Who.language.php)
- Old Opera and old Safari don't need to view CSS3 animations, as they don't support them at all. (Class-CSS.php)
3281
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 06:34 PM »No it isn't, seeing that there can already be three parameters (plugin added actions will add function, file, plugin id) which means it would become 3 or 4 parameters depending on plugin.
I explained all this when I wrote it into the plugin manager.
Anyway, talk about clean code: if I want to prevent media feeds from being logged, instead of doing a define(), I now have to global $action_no_log, and add 'media' to it from within the feed function... :-/
I can do that if you think it's the preferred method, but I don't think it's 'clean' at all.
(Of course, adding a param to $action_list isn't gonna help in this situation, either; but I was thinking of WEDGE_NO_LOG in this case.)
Not observed in Chrome 26. I still have issues with the horizontal scrollbars though.
I fixed it by opening the dev tools, and disabling flex for the post area. Which totally doesn't make sense...
So, it looks like only Sleipnir (Chrome 24) seems to deal with flexbox correctly... :-/ And I don't know how to fix that.
To tell the truth, I'm very tempted to just give up on flex, even though I spent something like a week on that feature, and instead use macros to use, ahem, pure table tags by default in posts... (Which, of course, brings old problems to the table -- responsiveness and all.)
Fun, eh..?
(Oh, and yes, my font is Open Sans... The joys of custom.m1.css 8-))
PS: also, the bottom margin is bodies is eaten up in Chrome 28.
Posted: April 3rd, 2013, 06:30 PM
I'm starting to wonder if this isn't a graphic driver problem... I mean, I never had this problem with flex until today, and now I'm seeing it everywhere (in Chrome), although with different results depending on the version...
Oh, really funny: I'm in quick reply mode, and the text from my previous post is overwriting the textarea.
Let me see.... (Oh, and yes, my font is Open Sans... The joys of custom.m1.css 8-))
I was only re-typing what was showing up at that exact position, ah ah. Well, gotta go, can't read what I'm typing anymore...
3282
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 04:04 PM »
Bugger... I'm currently trying out Maxthon 4 (Chrome 22 engine), and the little guy is not liking Wedge... -_-
Basically, from what I could gather: if a div is using the flex model, its children will ignore margin collapsing. i.e., my recent fix for quote margins is fucked up by Maxthon. Great...
Since my main browser is currently Sleipnir (Chrome 24), and it behaves correctly, I'd love to know if anyone noticed that issue... (It's pretty simple, post text is 'stuck' to the gray line that separates it from the post header, "Posted at ... by ...", you know.)Quote from Arantor on April 3rd, 2013, 03:06 PM Yeah... And we can't really hide these links from bots, ah ah...Quote I see...Quote Yes, it's using the media action. I'll look into it.
Oh, a suggestion for $action_no_log... Why not, instead, make this an optional third parameter in the $action_list array..?
$action_list = array(
'action' => array('Function', 'File.php', $no_log)
);
Isn't that... 'cleaner'?
It seems technically doable, and IIRC $action_list can be altered by plugins anyway, can't it..?
The only issue is with extra_actions... It's no longer the same 'format'. But I don't see the point of this one either... Why not, simply add to $action_list..? Isn't this a global already? Yes it is...Quote I thought you'd be using wingrep or equivalent, with a set of common used words.. No?
Basically, from what I could gather: if a div is using the flex model, its children will ignore margin collapsing. i.e., my recent fix for quote margins is fucked up by Maxthon. Great...
Since my main browser is currently Sleipnir (Chrome 24), and it behaves correctly, I'd love to know if anyone noticed that issue... (It's pretty simple, post text is 'stuck' to the gray line that separates it from the post header, "Posted at ... by ...", you know.)
Given how many places it's linked, not really a surprise.
As for whether it is meaningful, I would say it is. Given how often feeds get requested, not running additional (and not entirely cheap) queries is quite a nice thing.
The deal is that anything hitting action=feed will not be logged. If the media feed is handled through the feed handler it will also not be logged. If it's handled through the media area it will be logged.
Oh, a suggestion for $action_no_log... Why not, instead, make this an optional third parameter in the $action_list array..?
$action_list = array(
'action' => array('Function', 'File.php', $no_log)
);
Isn't that... 'cleaner'?
It seems technically doable, and IIRC $action_list can be altered by plugins anyway, can't it..?
The only issue is with extra_actions... It's no longer the same 'format'. But I don't see the point of this one either... Why not, simply add to $action_list..? Isn't this a global already? Yes it is...
Yeah, I didn't check that one as heavily as I should. It's really, really, really boring to go through English US to look for differences especially when you see the alternative spellings so often.
3283
The Pub / Re: Don't update log_online for certain actions
« on April 3rd, 2013, 11:52 AM »
Yes, I suppose not logging these would make more sense...
A few notes that might warrant comments, though.
- I only checked your latest rev out just now (and am about to cancel a few modifications I made on my local install and was planning to commit later today or this week :^^;:), so please bear with me.
- Before checking out this topic, which I kinda remembered was floating around (and I guess it was a good idea to check it out before committing anything :P), I made some changes to fix sudden bugs in the Who's Online page that were mentioned elsewhere. The reason was actually due to the fact that when updating wedge.org to the latest rev, I forgot to update index.php as well (it's not very frequently updated, and while I usually keep an eye on its latest modification date, it looks like I forgot to do it the one time it was needed.)
- So that's the reason why there were more 'unknown action' entries... These were from both 'notifications' and 'feeds'. It's interesting to know that there are so many feed requests, BTW...!
- But call me crazy, I STILL have to ask the question: what difference does it make that a bot is downloading a feed or a page...? It's still checking out whether I have updates in some particular area (overall, board, topic, etc.) The only point in logging online data for bots is that we know what they're indexing... If they're indexing one of my feeds, I'm interested in knowing it. What do you think? Does it make sense..?
- Also, there was still a media_wo_feed entry, which should (logically) not be recorded either, if main feeds aren't...?
- I've noticed that Who.english-uk.php has a use of 'license' in one string and 'licence' in another. I've changed it to 'licence', I suppose that was the intention...?
- Also changed an 'analyzer' to 'analyser'. Is that correct? Finally, removed plenty of language strings that were actually identical to Who.english.php's...
- My guess is that you (@Arantor) started working on it, and became busy on something else, and forgot to check when you got back. It's harder to check one's code when you're committing new code rather than code updates -- I've myself often fallen in some traps because of that.
A few notes that might warrant comments, though.
- I only checked your latest rev out just now (and am about to cancel a few modifications I made on my local install and was planning to commit later today or this week :^^;:), so please bear with me.
- Before checking out this topic, which I kinda remembered was floating around (and I guess it was a good idea to check it out before committing anything :P), I made some changes to fix sudden bugs in the Who's Online page that were mentioned elsewhere. The reason was actually due to the fact that when updating wedge.org to the latest rev, I forgot to update index.php as well (it's not very frequently updated, and while I usually keep an eye on its latest modification date, it looks like I forgot to do it the one time it was needed.)
- So that's the reason why there were more 'unknown action' entries... These were from both 'notifications' and 'feeds'. It's interesting to know that there are so many feed requests, BTW...!
- But call me crazy, I STILL have to ask the question: what difference does it make that a bot is downloading a feed or a page...? It's still checking out whether I have updates in some particular area (overall, board, topic, etc.) The only point in logging online data for bots is that we know what they're indexing... If they're indexing one of my feeds, I'm interested in knowing it. What do you think? Does it make sense..?
- Also, there was still a media_wo_feed entry, which should (logically) not be recorded either, if main feeds aren't...?
- I've noticed that Who.english-uk.php has a use of 'license' in one string and 'licence' in another. I've changed it to 'licence', I suppose that was the intention...?
- Also changed an 'analyzer' to 'analyser'. Is that correct? Finally, removed plenty of language strings that were actually identical to Who.english.php's...
- My guess is that you (@Arantor) started working on it, and became busy on something else, and forgot to check when you got back. It's harder to check one's code when you're committing new code rather than code updates -- I've myself often fallen in some traps because of that.
3284
Archived fixes / Re: Notifications show one avatar
« on April 2nd, 2013, 11:34 PM »
Yes, it is.
Let me fetch my code...
Code: [Select]
Also, I've just uploaded an updated version of script.js which allows you to close the popup by clicking anywhere else. Very, VERY oddly, I had many difficulties to pull it off, because of some peculiarities in the way it's shown in the first place.
Let me fetch my code...
public function getText(Notification $notification)
{
global $txt, $memberContext;
$data = $notification->getData();
if (empty($memberContext[$data['member']['id']]['avatar']))
loadMemberAvatar($data['member']['id'], true);
return sprintf($txt['wementions_notification'], !empty($memberContext[$data['member']['id']]['avatar']) ? $memberContext[$data['member']['id']]['avatar']['image'] : '', $data['member']['name'], $data['subject']);
}Also, I've just uploaded an updated version of script.js which allows you to close the popup by clicking anywhere else. Very, VERY oddly, I had many difficulties to pull it off, because of some peculiarities in the way it's shown in the first place.
3285
Off-topic / Re: Doctor Who
« on April 2nd, 2013, 11:32 PM »
This monster is not very... enticing.
I think it'd be more interesting to point out something else for the 50th Ann. special that is apparently well known (to Englishmen?!), but wasn't said here:
(click to show/hide)
I think it'd be more interesting to point out something else for the 50th Ann. special that is apparently well known (to Englishmen?!), but wasn't said here:
That the 10th Doctor and Rose will appear in it, too!