Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
256
Support / Re: Class-DB changes?
« on September 28th, 2016, 12:39 AM »Took me some time to get things right,but it seems to be oké now,suppose you have not incorporated the final addition of :at: Cereal Guy ?,because i had to add this lines manually into the newest revs of Class-DB.PHP.
https://github.com/Wedge/wedge/commit/9f59d4284378079b4840623185a3c87b763a21c6
257
Features / Re: New revs
« on September 27th, 2016, 02:32 PM »
[Commit revision 9f59d42]
Author: Nao
Date: Tue, 27 Sep 2016 14:30:05 +0200
Stats: 1 file changed; +7 (insertions), -7 (deletions)
[Commit revision 4633689]
Author: Nao
Date: Tue, 27 Sep 2016 14:31:50 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
Date: Tue, 27 Sep 2016 14:30:05 +0200
Stats: 1 file changed; +7 (insertions), -7 (deletions)
- Fixed untested utf8mb4 placeholder code. Note, this still doesn't support 4-byte UTF8... I still don't know exactly what I should do with those. (Class-DB.php)
[Commit revision 4633689]
Date: Tue, 27 Sep 2016 14:31:50 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- Forgot to remove <ob:ignore> pseudo-tags from final HTML if used. (Subs-Template.php)
258
Support / Re: Class-DB changes?
« on September 27th, 2016, 01:32 PM »
Yeah, I should have split the three different changes to that file into three commits (variable renaming, function renaming and adding a placeholder for it)... sorry about that.
I'll commit it.
Btw what's that css edit in your pull request..?
I'll commit it.
Btw what's that css edit in your pull request..?
259
Support / Re: Class-DB changes?
« on September 25th, 2016, 08:02 PM »
All these years wasted trying to debug things when I could have added that command in index.php... ^^
Okay, I may have forgotten to add "self::" in front of all handle_utf8mb4 calls! Can you check?
Okay, I may have forgotten to add "self::" in front of all handle_utf8mb4 calls! Can you check?
260
Features / Re: New revs
« on September 25th, 2016, 03:38 PM »
[Commit revision 18dee46]
Author: Nao
Date: Sun, 25 Sep 2016 15:29:13 +0200
Stats: 3 files changed; +15 (insertions), -1 (deletion)
[Commit revision ad3a277]
Author: Nao
Date: Sun, 25 Sep 2016 15:30:57 +0200
Stats: 1 file changed; +18 (insertions), -28 (deletions)
[Commit revision a6ab3dd]
Author: Nao
Date: Sun, 25 Sep 2016 15:32:54 +0200
Stats: 1 file changed; +9 (insertions), -0 (deletion)
[Commit revision e22ec54]
Author: Nao
Date: Sun, 25 Sep 2016 15:36:26 +0200
Stats: 1 file changed; +4 (insertions), -2 (deletions)
[Commit revision d41f147]
Author: Nao
Date: Sun, 25 Sep 2016 15:38:07 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)
Date: Sun, 25 Sep 2016 15:29:13 +0200
Stats: 3 files changed; +15 (insertions), -1 (deletion)
- Added a small task to the 'Find and fix errors' maintenance task, where boards with pretty URLs will make sure they have correctly cached their URL length. This is mainly to help you get up to speed faster if you ever move forums and need to update your URLs. (RepairBoards.php, ManageMaintenance.english.php)
- Outdated comment. (ManageMaintenance.php)
[Commit revision ad3a277]
Date: Sun, 25 Sep 2016 15:30:57 +0200
Stats: 1 file changed; +18 (insertions), -28 (deletions)
- A single wesql::get('SELECT RAND()') now replaces 7 lines of code. I told you that helper function was nice. (Subs-Members.php)
[Commit revision a6ab3dd]
Date: Sun, 25 Sep 2016 15:32:54 +0200
Stats: 1 file changed; +9 (insertions), -0 (deletion)
- Added support for a pseudo-block, <ob:ignore>, within which the output buffer won't be manipulated. For instance, if you need to show a lot of data where you know there's no need to change anything (e.g. plenty of external links), adding this block around your data could shave several seconds off the total processing time. Tried by yours truly. (Subs-Template.php)
[Commit revision e22ec54]
Date: Sun, 25 Sep 2016 15:36:26 +0200
Stats: 1 file changed; +4 (insertions), -2 (deletions)
- Fixed wrong HTML nesting for guests. (index.template.php)
- New HTML validator no longer supports protocol-relative URLs for item properties. Don't get a word of what I said? Well, I just mean I have to add 5 extra bytes per page, and it sucks. (index.template.php)
[Commit revision d41f147]
Date: Sun, 25 Sep 2016 15:38:07 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)
- Some PHP installs prefer, by default, to give you blank pages or Apache errors instead of showing you an unfinished page when errors are met. I never realized that. Putting things back to normal. At least it'll make debugging easier now... (index.php)
261
Support / Re: Class-DB changes?
« on September 24th, 2016, 11:55 PM »
Are you sure you uploaded all of the files in the new revision..? If you missed one, it may have triggered an incompatibility.
262
Support / Re: I want a wedge support 5.2 PHP IS it Possible
« on September 23rd, 2016, 11:15 AM »
Nice link/theory!
263
Support / Re: Class-DB changes?
« on September 23rd, 2016, 11:10 AM »
I only changed $db_string to $query because I wanted to make the source code more readable. Really no big deal. And I don't think any mod would change anything in that file anyway, so it was a moot point to me...
As for get(), the function was added VERY late in the development process, like, a month before I left full-time development, and I never got around to replacing more DB calls with it. So I figured it was also pretty much a safe change. I don't know of any plugins that use query_get(), either. At least nowhere in the official plugin repo...
As for get(), the function was added VERY late in the development process, like, a month before I left full-time development, and I never got around to replacing more DB calls with it. So I figured it was also pretty much a safe change. I don't know of any plugins that use query_get(), either. At least nowhere in the official plugin repo...
264
Support / Re: Class-DB changes?
« on September 22nd, 2016, 03:10 PM »
I don't see what your problem is, really.
It's all working fine on my site...
It's all working fine on my site...
265
Support / Re: I want a wedge support 5.2 PHP IS it Possible
« on September 21st, 2016, 11:01 AM »
Some days, I even wonder if I shouldn't make PHP 7 a requirement, lol...
But that's mostly because the Wedge userbase isn't really huge, so I could actually get away with it...
I just love using "$var ?? 1" instead of "isset($var) ? $var : 1"... Plus, the HHVM performance!
But that's mostly because the Wedge userbase isn't really huge, so I could actually get away with it...
I just love using "$var ?? 1" instead of "isset($var) ? $var : 1"... Plus, the HHVM performance!
266
Support / Re : Class-DB changes?
« on September 21st, 2016, 10:59 AM »
I have no idea why you're reposting a complete file... Apart from taking space in the database, I don't know what its purpose is.
It's important to update all the files at the same time (well, not at the same second lol), since they rely on changed code.
If you have a custom Class-DB file, well... You should use plugins to change code ;) (I personally don't, but that's because I know the files well, and most of the changes I make end up in Wedge itself anyway, but you get the point.)
Class-DB only updates the ::get() method to be more useful, i.e. allow the webmaster to get a single variable from the database without having to go through the query/fetch_assoc/free_result crap.
PS: don't post bug reports in the New Revs topic... It's updated automatically when I push new commits, meaning I don't expect to see someone else posting on it.
It's important to update all the files at the same time (well, not at the same second lol), since they rely on changed code.
If you have a custom Class-DB file, well... You should use plugins to change code ;) (I personally don't, but that's because I know the files well, and most of the changes I make end up in Wedge itself anyway, but you get the point.)
Class-DB only updates the ::get() method to be more useful, i.e. allow the webmaster to get a single variable from the database without having to go through the query/fetch_assoc/free_result crap.
PS: don't post bug reports in the New Revs topic... It's updated automatically when I push new commits, meaning I don't expect to see someone else posting on it.
267
Features / Re: New revs
« on September 16th, 2016, 12:55 PM »
[Commit revision 1e5c171]
Author: Nao
Date: Fri, 16 Sep 2016 12:36:08 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
Date: Fri, 16 Sep 2016 12:36:08 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- W3C validator was broken over HTTPS installs. (Subs-Template.php)
268
Features / Re: New revs
« on September 16th, 2016, 11:30 AM »
[Commit revision 2e507da]
Author: Nao (Signed-off)
Date: Fri, 16 Sep 2016 11:30:00 +0200
Stats: 1 file changed; +2 (insertions), -3 (deletions)
Date: Fri, 16 Sep 2016 11:30:00 +0200
Stats: 1 file changed; +2 (insertions), -3 (deletions)
- #index_common_stats was broken in most (all?) skins. (sections.css)
- Left arrow was broken in blog post comments if commented didn't have an avatar. (sections.css)
270
Features: Theming / Re: Skins
« on September 16th, 2016, 11:19 AM »
Yeah.
I'd recommend overwriting index.css definitions with a new "custom.css" file instead. At least it won't get overwritten by updated files if you download a new version... You can also delete stuff from index.css with the @remove command (just look around and search for these in the skin files, it's pretty self-explained, although writing some documentation would have been nice of me.) (I'm not nice.)
Eh, I forgot I had this weird "bubble-like" comment system on blog types... (as in this topic.) Too bad the bubble tails break when going further down the page... ^^ :edit: Only with avatar-less posts.
I'd recommend overwriting index.css definitions with a new "custom.css" file instead. At least it won't get overwritten by updated files if you download a new version... You can also delete stuff from index.css with the @remove command (just look around and search for these in the skin files, it's pretty self-explained, although writing some documentation would have been nice of me.) (I'm not nice.)
Eh, I forgot I had this weird "bubble-like" comment system on blog types... (as in this topic.) Too bad the bubble tails break when going further down the page... ^^ :edit: Only with avatar-less posts.