Wedge

So... Infinite scrolling. We meet again.

I just wanted to say something about it.

Really, infinite scrolling is for *static content*. All websites that show infinite scrolling will only do it on items that they know are built in a way to 'accept' being nested into other pages and not corrupting them.

Earlier today, I noticed that the More button was broken in infinite-scrolling-loaded pages. I then realized it was broken by a small change in rev 2262 that fixed infinite scrolling on IE 11, or something... But broke many things everywhere else. So, back to the old code...
Unfortunately, it still doesn't execute some things correctly-- e.g. the code BBC hack for Chrome... And, I'm not exactly sure why.
It also tends to duplicate DOM objects that are modified by JavaScript. For instance, the board selector. I tend to fix these manually. Up until now, the quick edit button would be duplicated; it's no longer the case, but...

It's freaking annoying, knowing that in years from now, some people will just break their teeth on their plugin because it does some modifications to individual posts, and it doesn't play along with infinite scrolling.

I gave another try to the iframe-based version, but it's even worse, really... I should have kept a copy of the 'working' version I had before. Maybe it was fixable. I'm not so sure, right now... What I do know, though, is that it's unrealistic to use that right now.

So, I'm asking again... Guys, do you think the infinite scrolling feature is fantastic enough to guarantee that plugin authors will happily comply with its complicated rules..? Or should infinite scrolling simply, well... Redirect to the previous/next page through insistent mouse wheel scrolling? (i.e. if you scroll down for a second, instead of loading the next page via Ajax and showing it below the current page, it'll simply redirect you to the next page.)
That's the 'chicken' solution, but honestly... It also carries zero issues with it, and when I say zero, I do mean zero...

Test.

Testing from my s3...

rev 2264 -- how long am I gonna keep posting bug fixes...? :P
(6 files, 5kb)

* Saved 150 bytes by simplifying the moderation strip code. Really. This JS was just too... Afraid of doing something wrong. (topic.js)

* More Quick Edit fixes/changes...

    ! Entities were being shown in plain view. This was due to the recent changes; used to have bodies injected into a string that was then turned into HTML, but I made it faster by first building the DOM object and then injecting the data into it, which jQuery shows verbatim. I needed to also remove entities at the source. (QuoteFast.php)

    ! If a post was longer than the space available to edit it in to begin with, it should already show scrollbars, not just when we reach the limit while editing. (topic.js)

    ! After sending your edit, the post header (subject and modified) wasn't updated at all. This was an old bug I'd say, not related to the recent changes. (topic.js)

    ! Also, the Modified string was incorrectly formatted, due to a structure change in $txt. Well, that's an old one, too... (JSModify.php)

    * Changed the textarea to keep showing the action bar. The jury's still out on this one. It's obviously better to hide it, because more space and everything, but (1) one might still want to immediately delete their post after first trying to edit it, and having to first cancel the edit is annoying, (2) I don't know, I feel it looks more professional that way, or something... (topic.js)

! Forgot to commit a change related to the UTF encoding tweaks from last rev. This also fixes a debug char bug. Not a debug codeblock. Just a character. Really. (Subs-Template.php)

* Harmonizing an underscore into a dash. Yawn. (Subs-Post.php)

* Commenazi. (Subs.php)

rev 2262 -- finally, the BIG one! I'm happy with it!
(6 files, 19kb)

+ Committing the changes that now allow Firefox, IE 10 and IE 11 to use the flexbox model to show posts in topics. This is way cool, but wait for the next item in this changelog... (sections.css)

+ A very, very thorough rewrite of the Quick Edit code. While most of it is internal stuff geared at making it cross-browser (and it required many subsequent rewrites over the week), here's what you definitely WILL notice when quick-editing a post:

    + The Cancel button shows up right on top of the Quick Edit button, meaning you can click it without moving the mouse if you quick edited by mistake. Mouse path optimization FTW..?! (topic.js, sections.css)

    + The textarea will no longer show scrollbars (unless it gets very long, in which case I added some code to make them reappear); instead, it will grow and shrink depending on the length of your text. (topic.js, sections.css)

    + Additionally, the window will stay focused on the bottom of your posts, moving to the bottom each time you create a new line; this helps you write an entire book without ever having to scroll. Well, maybe not a book... A novella, maybe. Okay, a short story. What, too long? Kids these days... Okay, you can write "LULZ" just like you used to, it's just the same to me. Nobody's reading these changelogs anyway. (topic.js)

    * Moved the quick edit template string to the topic.js file itself; considering moving the quick edit code to post.js entirely (I think it would be the best place for it, needs checking). This is good for bandwidth, as JS files are cached. (Display.template.php)

    * Simplified QuickModify object, now it only holds a tabindex option, and even then-- I think it'd be safe to remove it entirely. Renamed the object to QuickEdit, too, renamed qm_* classes and functions to qe_*, etc. (Display.template.php, topic.js, sections.css, index.member.css)

    * The Quick Edit button is no longer hardcoded in the HTML, but added through JS, which is easy since there was already a can-mod class per message. I don't really mind about people who disable JS on a daily basis, but they won't dictate how I code my software, uh. (Msg.template.php)

    * The edit area is now a layer that shows up independently of the post itself, fixing a lot of minor animation issues. (topic.js, sections.css)

    * The textarea now has a clear 64KB size limit. Well, I put in 65.500 chars, dunno if it's for the best -- but it's still better than 'infinite', if you catch my drift. (topic.js)

    * The error box is relocated to the lower left of the textarea, and is slightly better styled. (topic.js, index.member.css)

    * Size optimizations. Mostly needed by the fact that the rewrite increased the topic.js filesize by 10%... Which, itself, is mainly due to the inclusion of the QuickEdit template into the JS itself. (topic.js)

* Clearly disabling follow_me on touch devices. That's until I get around to adding some proper skin settings to determine whether you want follow_me to be enabled or not. (topic.js)

* follow_me should also be called on a window resize, in case the padding around user boxes is changed. Which, as it happens, is the case in Weaving, my default skin... (topic.js)

! Fixed follow_me in infinite scrolling mode. (topic.js)

* Ensuring that user boxes can be enlarged vertically through CSS. This was needed by the quick edit rewrite. (topic.js)

* Moved IconList init code to topic.js. Okay, it's just one line... (Display.template.php, topic.js)

* Prioretize (prioritize?) DOM layout fixes over script execution in infinite scrolling; in human words, this means you should no longer have broken CSS in newly loaded posts if a script failed to load/run correctly. (topic.js)

* Slightly changed the attachment area's HTML layout, to make it easier to style (one div per thumbnail, and one p tag per description.) Remove a Firefox hack that was, very certainly, a leftover from the Firefox 3.x era. (Msg.template.php, sections.css)

! Attachments weren't being hidden in ignored posts. (Display.template.php)

! The Restore button icon was missing. (sections.css)

@ If you're curious -- yes, I'm planning to backport my quick edit changes into the main post editor.

rev 2260
(1 file, 5kb)

+ IE 11 is now recognized as supporting flexbox by Wedge. I needed proof, you see... I won't test a lot on it, though, so if it breaks... Deal with it. (Class-CSS.php)

+ Added support for IE 10 flexbox model. Meaning you can now simply use @if can_flex and add your Final Flexbox model code, and it'll automatically run in IE 10 as well, even though it's using the 'Tween model internally. Oh, and yes, just like Firefox, IE 10 now uses flexbox for messages. Self high five! (Class-CSS.php)

+ As one would expect, Firefox, IE 10 and IE 11 now correctly support the flexbox path of the msg skeleton, i.e. tables will no longer killed for the making of a topic. Not that I care, but... Apparently, there's an SPCA branch devoted to tables. (Class-CSS.php)

- Removed indirect support for non-final flexbox models to eliminate some confusion, i.e. if you type 'display: box', it won't be renamed to 'display: -webkit-box' in older Safari, for instance. You'll have to provide the generic suffix. Why? Because I want to encourage the use of the final flexbox model, that is. Since Final and Tween models are now supported transparently in Wess, the only browsers that require manual adjustments are old IE (no support at all) and non-latest Safari/iOS. And if you're using these, you can always upgrade if you want flexbox coolness. (Class-CSS.php)

@ Note: flexbox still doesn't work correctly in the aforementioned browsers at this point, but that's because I'm saving the sections.css rewrite for a later commit. I've still got many things to sort through, before it's committable.

Thanks, done then.. ;) (Well, you might have seen it, latest rev :P)