New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2250, on September 16th, 2013, 03:46 PM »
rev 2250
(6 files, 3kb)

* Tweaked Zoomedia. The Close button is now drawn in pure CSS if possible (saving a whopping 2KB off the file and making it HD-friendly), removed the delay as I forgot I'd recently implemented it in the 'main' show_ajax function, saved oldIE from showing the double-click catcher (it just didn't work properly anyway), and fixed bottom padding in Glass mode (hopefully! Needs testing.) (zoomedia.js, zoom.css)

+ Zoomedia can now be shown when previewing posts in the Notifications area. Note that there's a trade-off: I specifically allowed Ajax calls to load Zoomedia, but it also means all Ajax calls need to account for $context['footer_js'] not being shown at all, and must do it manually. I'm already doing it in a few places, but not everywhere, so... These bugs will have to be fixed as they occur, basically, or I need to find a way to safely load footer_js systematically without screwing up the page. I'll get to that, eventually. That's all in a day's job for Ajax man. (Subs-Media.php, Notifications.php)

- Saving a buffer str_replace off English pages-- at least we know these don't use half-width unbreakable, uh... (Subs-Template.php)

! Ajax loader was incorrectly positioned when the parent element had padding. (script.js)

! A small typo of mine in the notification code. (script.js)
Re: New revs
« Reply #2251, on September 16th, 2013, 05:07 PM »
rev 2251
(12 files -1, 278kb, 10 minutes of work.)

* Updated getID3 from v1.9.1 to 1.9.7. Has the new (MPL) license, good! Haven't tested it, though... (media/getID3/*)
Re: New revs
« Reply #2252, on September 16th, 2013, 11:08 PM »
rev 2252
(295 files, 126kb)

* Updated credits, contributors, license, etc... Not only for anything related to Pete's departure from the project, but also cleaning up the credits and adding anything Pete might have forgotten to credit when he compiled the list. 'Wedgeward' is replaced with my full name until I figure out what's best. Also fixed John's last name. More things left to do... Will come, will come. (contributors.txt, license.txt)

* Updated and harmonized all file headers as much as I could; if anything bad's left, I'll fix it later. (295 files)

* Renamed nested-sortable.js to just nested.js, as there's just the one file... (ManageBoards.php, nested.js)

- Removed all @version tags. I'm not, repeat, I am NOT, going to add @version tags to all files every time I'm releasing a new version. I want to be able to upload a package with only the files since the last time. Really. It's easier to upload. Still need to complete the removal of associated features, though. (295 files or so.)

- Removed some code that relies on reading @version tags. Still some left, though. (smfinfo.php) (Yes, that's an odd filename, I know...)
Re: New revs
« Reply #2253, on September 17th, 2013, 12:31 PM »
rev 2253
(2 files, 2kb)

! Finally-- follow_me is pixel-perfect. I took an hour of my time to reconsider the math of it all, and found 3 little bugs in my calculations; Neither the separator height not the fixed userbox top position were taken into account, and ended up doing strange things on very short posts. Also, there was some kind of a margin collapse trick that happened in the user name and made positioning more complicated; replace the margin with a padding, it works just the same. It's all in the past, now. I can finally devote my time to another cool feature. I wish. (topic.js, sections.css)
Re: New revs
« Reply #2254, on September 17th, 2013, 06:26 PM »
rev 2254
(15 files, 6kb)

! A few files were incorrectly set to ISO-8859-1 when they should be UTF-8. These were the files whose copyright lines I modified manually, rather than automatically. Not that it matters much, though: I'll probably change the copyright data again soon, and they'll all be ISO again. Meh. (.htaccess, Settings.php, Settings_bak.php, ssi_examples.shtml, Home.template.php, Class-ZipExtract.php, Wuthering/extra.css, Wireless/extra.css, zoom.css)

! Forgot to credit Karl Benson for the early versions of Aeva in the contributor file. (contributors.txt)

* Renamed 'Consultants' to 'Contributors' in the Credits page (that's been pretty much the same thing so far...), and simplified the code. (Credits.php, Who.template.php, Who.language.php)

* Spacinazi. (Wine/extra.css)
Re: New revs
« Reply #2255, on September 18th, 2013, 04:29 PM »
rev 2255
(5 files, 2kb)

* Licensing tweaks. Most importantly, I decided to try removing the copyright mention from all pages (except for the credits page, of course.) This saves the HTML and my ego from inflating too much, and still keeps my rights the same. If I can't live without my name in there, I'll restore it, but it's unlikely. (Class-ZipExtract.php, index.language.php)

! A final fix for half-width non-breakable spaces not showing up in mobile and oldIE. Basically, I needed more work in minified JavaScript, and in the debug junk, which is shown after doing the original conversion anyway. I'm trying not to be too bothersome with this one, it's just a space... Or a missing one. In French. (Subs-Cache.php, Stats.french.php)
Re: New revs
« Reply #2256, on September 18th, 2013, 11:22 PM »
rev 2256
(2 files, 4kb)

* Solved a problem caused by follow_me, where quick editing a very long post would show a huge empty post and a tiny textarea. The textarea will now match exactly the size of its original post, making it more akin to a live editor. (topic.js)

* Insert a 'merged' div on the first post of a soft-merged series of posts, because users might want to style them all. I'm considering moving the merged class to their containing div (.postheader), but that would make it harder to style for IE6. I know, I know... 'Who cares?' (Subs-Template.php)

! Fixed quick edit of first post in a soft-merged blah blah. It used to request for a quick edit of all posts, at the same time. (topic.js)

! Blog posts can't be soft-merged with a regular comment. That would be silly... On pages 2 and later, obviously. (Subs-Template.php)
Re: New revs
« Reply #2257, on September 20th, 2013, 07:24 PM »
rev 2257
(1 file +2-2, 186kb)

* Updated jQuery from 1.10.2/2.0.3 to 1.11/2.1 beta. They seem to be around the same size, only marginally heavier, no biggie, and supposedly they load faster, and I'm all for that. (Load.php, scripts/jquery-*.min.js)
Re: New revs
« Reply #2258, on September 20th, 2013, 07:36 PM »
rev 2258 -- e-mail rewrite! You didn't think it was needed? Neither did I, until I found the bugs!
(3 files, 9kb)

+ Notification batches can now be sent as HTML, too. Although it's disabled by default, I can confirm that it works just fine. (Notifications.php, Notifications.template.php)

+ Rewrote sendmail() function: updated documentation (needed some work!), allowed for fine-tuning HTML e-mails by specifying the raw text fallback to send (it doesn't have to do that ugly tag stripping), shortened the body building part by not redoing everything twice, simplified the body boundary, added the boundary at the top of the message because it's the way it's done in RFC 2046, sped up mimespecialchars() a bit by not doing a preg_match_all, and fixed a bug where the raw text fallback was actually saying 'UTF-8' instead of the e-mail body itself, added in Arantor's earlier rewrite. Thank you Google for offering to read the 'raw contents' of an e-mail, because not every webmail provider does it, IIRC. (Subs-Post.php)

* Tweaked notification e-mails to look better. (Notifications.template.php)

@ Do we really have to provide TWO raw text fallbacks for HTML e-mails..?! Fighting spam, really? This code is at least 8 years old. Are we sure this isn't a fix for some completely outdated problem..?!
Re: New revs
« Reply #2259, on September 24th, 2013, 04:08 PM »
rev 2259 -- whatever I can commit separately from my huge upcoming rewrite of the quick edit stuff, really...
(8 files, 5kb)

* Updated msg skeleton to add a new layer (and macro), msg_entry, which holds the exact content that should be kept in soft-merging situations, i.e. post header, body and action bar. The HTML counterpart is a new <article> tag, which is also semantically nice, and makes it a bit faster to soft-merge. (Subs-Template.php, Msg.template.php, macros.xml, skeleton.xml)

- Removing some WIP code that I thought I'd already removed before, but... Whatever. (Subs-Cache.php)

- Removing the footer tag from ignored posts; no need for it, in the end... Can't remember why I thought I'd need it, either. (Msg.template.php)

* Moved some credits out of language files, and into Credits.php, to avoid having to update language files every time something gets changed there. (Credits.php, Who.language.php)
Re: New revs
« Reply #2260, on September 26th, 2013, 04:33 PM »
rev 2260
(1 file, 5kb)

+ IE 11 is now recognized as supporting flexbox by Wedge. I needed proof, you see... I won't test a lot on it, though, so if it breaks... Deal with it. (Class-CSS.php)

+ Added support for IE 10 flexbox model. Meaning you can now simply use @if can_flex and add your Final Flexbox model code, and it'll automatically run in IE 10 as well, even though it's using the 'Tween model internally. Oh, and yes, just like Firefox, IE 10 now uses flexbox for messages. Self high five! (Class-CSS.php)

+ As one would expect, Firefox, IE 10 and IE 11 now correctly support the flexbox path of the msg skeleton, i.e. tables will no longer killed for the making of a topic. Not that I care, but... Apparently, there's an SPCA branch devoted to tables. (Class-CSS.php)

- Removed indirect support for non-final flexbox models to eliminate some confusion, i.e. if you type 'display: box', it won't be renamed to 'display: -webkit-box' in older Safari, for instance. You'll have to provide the generic suffix. Why? Because I want to encourage the use of the final flexbox model, that is. Since Final and Tween models are now supported transparently in Wess, the only browsers that require manual adjustments are old IE (no support at all) and non-latest Safari/iOS. And if you're using these, you can always upgrade if you want flexbox coolness. (Class-CSS.php)

@ Note: flexbox still doesn't work correctly in the aforementioned browsers at this point, but that's because I'm saving the sections.css rewrite for a later commit. I've still got many things to sort through, before it's committable.
Re: New revs
« Reply #2261, on September 26th, 2013, 04:43 PM »
rev 2261 -- looked harder -- and found some last files to commit, before the big one.
(7 files, 2kb)

* You can now (plugin, skin, whatever...) add your own credits to the bottom of each page, without having to hack into language files. Beware! If $context['custom_credits'] is abused, I'll add some code to prevent it from getting too large. Push your credits to the credits page, that's where they should be, really. (index.template.php)

* The reqWin animation was a bit too over-the-top when the popup grew in size. Made it a bit more... respectable, say. (index.css)

* On focus, a button should still show some recognizable outline. This week's contribution of mine to accessibility. (index.css)

- Removed a rogue period. Oh, my, now I absolutely need, want to restore it... What's happening to me?! (index.language.php)

- Removed wedge.org-specific code from the index template, at last. (index.template.php)

- Removed a duplicate declaration. Thanks John! (Post.php)

- Removed some hardcoded styles. If these things ever get in the way, well... I'll look into it. There's one remaining in the Display template, but it's scheduled for next commit... (MessageIndex.template.php, Recent.template.php)
Re: New revs
« Reply #2262, on September 27th, 2013, 12:52 AM »
rev 2262 -- finally, the BIG one! I'm happy with it!
(6 files, 19kb)

+ Committing the changes that now allow Firefox, IE 10 and IE 11 to use the flexbox model to show posts in topics. This is way cool, but wait for the next item in this changelog... (sections.css)

+ A very, very thorough rewrite of the Quick Edit code. While most of it is internal stuff geared at making it cross-browser (and it required many subsequent rewrites over the week), here's what you definitely WILL notice when quick-editing a post:

    + The Cancel button shows up right on top of the Quick Edit button, meaning you can click it without moving the mouse if you quick edited by mistake. Mouse path optimization FTW..?! (topic.js, sections.css)

    + The textarea will no longer show scrollbars (unless it gets very long, in which case I added some code to make them reappear); instead, it will grow and shrink depending on the length of your text. (topic.js, sections.css)

    + Additionally, the window will stay focused on the bottom of your posts, moving to the bottom each time you create a new line; this helps you write an entire book without ever having to scroll. Well, maybe not a book... A novella, maybe. Okay, a short story. What, too long? Kids these days... Okay, you can write "LULZ" just like you used to, it's just the same to me. Nobody's reading these changelogs anyway. (topic.js)

    * Moved the quick edit template string to the topic.js file itself; considering moving the quick edit code to post.js entirely (I think it would be the best place for it, needs checking). This is good for bandwidth, as JS files are cached. (Display.template.php)

    * Simplified QuickModify object, now it only holds a tabindex option, and even then-- I think it'd be safe to remove it entirely. Renamed the object to QuickEdit, too, renamed qm_* classes and functions to qe_*, etc. (Display.template.php, topic.js, sections.css, index.member.css)

    * The Quick Edit button is no longer hardcoded in the HTML, but added through JS, which is easy since there was already a can-mod class per message. I don't really mind about people who disable JS on a daily basis, but they won't dictate how I code my software, uh. (Msg.template.php)

    * The edit area is now a layer that shows up independently of the post itself, fixing a lot of minor animation issues. (topic.js, sections.css)

    * The textarea now has a clear 64KB size limit. Well, I put in 65.500 chars, dunno if it's for the best -- but it's still better than 'infinite', if you catch my drift. (topic.js)

    * The error box is relocated to the lower left of the textarea, and is slightly better styled. (topic.js, index.member.css)

    * Size optimizations. Mostly needed by the fact that the rewrite increased the topic.js filesize by 10%... Which, itself, is mainly due to the inclusion of the QuickEdit template into the JS itself. (topic.js)

* Clearly disabling follow_me on touch devices. That's until I get around to adding some proper skin settings to determine whether you want follow_me to be enabled or not. (topic.js)

* follow_me should also be called on a window resize, in case the padding around user boxes is changed. Which, as it happens, is the case in Weaving, my default skin... (topic.js)

! Fixed follow_me in infinite scrolling mode. (topic.js)

* Ensuring that user boxes can be enlarged vertically through CSS. This was needed by the quick edit rewrite. (topic.js)

* Moved IconList init code to topic.js. Okay, it's just one line... (Display.template.php, topic.js)

* Prioretize (prioritize?) DOM layout fixes over script execution in infinite scrolling; in human words, this means you should no longer have broken CSS in newly loaded posts if a script failed to load/run correctly. (topic.js)

* Slightly changed the attachment area's HTML layout, to make it easier to style (one div per thumbnail, and one p tag per description.) Remove a Firefox hack that was, very certainly, a leftover from the Firefox 3.x era. (Msg.template.php, sections.css)

! Attachments weren't being hidden in ignored posts. (Display.template.php)

! The Restore button icon was missing. (sections.css)

@ If you're curious -- yes, I'm planning to backport my quick edit changes into the main post editor.
Re: New revs
« Reply #2263, on September 27th, 2013, 12:52 PM »
rev 2263 -- the leftovers, and some language handling fixes. Oh, and I just found a bug with quick edit (the single quote entities)... Will have to work on that ASAP.
(8 files, 7kb)

! Post-moderation delete button was missing an icon. (index.member.css)

! #new anchors were eaten up by soft-merging. (Msg.template.php)

! Meh. Extra space, not needed, not wanted... (pm.js)

! Okay, I'm adding that silly IE 11 hack I mentioned in passing. Just in case it's also in there in the final release... And it's only a few more bytes, anyway. (topic.js)

! Since jQuery will use entities 'as is' in button values, I had to be more severe and convert named entities to \u strings as well. Works well. (Subs-Cache.php)

* Used the opportunity to convert numeric entities to UTF-8 at language caching time. Again-- it saves bandwidth altogether. (Load.php, Subs-Cache.php)

+ A small addition to loadLanguage, while I'm at it... Ability to force reloading all previously loaded language files, can be useful when doing a language change midway through page load. It's not being used anywhere for now, but it's nice having it around. (Load.php)

* Commenazi. (Class-String.php, Load.php, Subs-Cache.php, ManageLanguages.php)
Re: New revs
« Reply #2264, on September 27th, 2013, 04:46 PM »
rev 2264 -- how long am I gonna keep posting bug fixes...? :P
(6 files, 5kb)

* Saved 150 bytes by simplifying the moderation strip code. Really. This JS was just too... Afraid of doing something wrong. (topic.js)

* More Quick Edit fixes/changes...

    ! Entities were being shown in plain view. This was due to the recent changes; used to have bodies injected into a string that was then turned into HTML, but I made it faster by first building the DOM object and then injecting the data into it, which jQuery shows verbatim. I needed to also remove entities at the source. (QuoteFast.php)

    ! If a post was longer than the space available to edit it in to begin with, it should already show scrollbars, not just when we reach the limit while editing. (topic.js)

    ! After sending your edit, the post header (subject and modified) wasn't updated at all. This was an old bug I'd say, not related to the recent changes. (topic.js)

    ! Also, the Modified string was incorrectly formatted, due to a structure change in $txt. Well, that's an old one, too... (JSModify.php)

    * Changed the textarea to keep showing the action bar. The jury's still out on this one. It's obviously better to hide it, because more space and everything, but (1) one might still want to immediately delete their post after first trying to edit it, and having to first cancel the edit is annoying, (2) I don't know, I feel it looks more professional that way, or something... (topic.js)

! Forgot to commit a change related to the UTF encoding tweaks from last rev. This also fixes a debug char bug. Not a debug codeblock. Just a character. Really. (Subs-Template.php)

* Harmonizing an underscore into a dash. Yawn. (Subs-Post.php)

* Commenazi. (Subs.php)