This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
241
Features / Re: New revs
« on October 9th, 2016, 11:54 PM »
[Commit revision 660aa41]
Author: Nao
Date: Sun, 09 Oct 2016 23:53:23 +0200
Stats: 3 files changed; +8 (insertions), -1 (deletion)
[Commit revision e8cb752]
Author: Nao
Date: Sun, 09 Oct 2016 23:53:42 +0200
Stats: 3 files changed; +12 (insertions), -9 (deletions)
Date: Sun, 09 Oct 2016 23:53:23 +0200
Stats: 3 files changed; +8 (insertions), -1 (deletion)
- It's hack day for me. When logging an error, I'm now adding a small indicator if the error was possibly triggered by a search engine (for instance visiting a page that's not always accessed by humans.) (Errors.php, ManageErrors.php, Errors.template.php)
[Commit revision e8cb752]
Date: Sun, 09 Oct 2016 23:53:42 +0200
Stats: 3 files changed; +12 (insertions), -9 (deletions)
- If a scheduled task function can't be found, try to find it without the 'scheduled_' prefix before giving up. This is mostly to keep in line with the fact that if the function is inside an object (like weobject::random_task), that prefix isn't expected/added at all. (ManageScheduledTasks.php, ScheduledTasks.php)
- Also, if a scheduled task isn't found and Wedge gives up, then at least let the admin know through the error log... (ScheduledTasks.php)
- Minor user box tweaks. (index.css)
242
Support / Re: Class-DB changes?
« on October 8th, 2016, 06:45 PM »
Probably something that can be fixed by fiddling with language settings in the admin area and then resetting them. ^^
Wow, that quick reply focus hack I added works wonders on mobile :)
Wow, that quick reply focus hack I added works wonders on mobile :)
243
Features / Re: New revs
« on October 8th, 2016, 01:56 PM »
[Commit revision 810186f]
Author: Nao
Date: Sat, 08 Oct 2016 13:56:14 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)
Date: Sat, 08 Oct 2016 13:56:14 +0200
Stats: 2 files changed; +2 (insertions), -2 (deletions)
- Added auto-focus on quick reply box when unfolding it. Because usually the next step is typing into that box, isn't it..? (topic.js)
- Some weird placement in the user box CSS. I dunno if this'll break something else. (index.css)
244
Support / Re: Class-DB changes?
« on October 8th, 2016, 01:49 PM »
It doesn't say what error it is..?
And I don't think there should be an error due to missing language strings. Wedge always defaults to English strings in that case.
And I don't think there should be an error due to missing language strings. Wedge always defaults to English strings in that case.
245
Support / Re: Class-DB changes?
« on October 7th, 2016, 08:58 PM »
Yes, unless your file dates weren't modified.
246
Support / Re: Class-DB changes?
« on October 3rd, 2016, 08:25 PM »
Possibly a caching issue then.
Btw Wedge.org is synced to the official repo, for the first time in years... I decided that if I never committed its changes, then maybe they weren't worth it. (I'm keeping them on the side though, just in case...)
Btw Wedge.org is synced to the official repo, for the first time in years... I decided that if I never committed its changes, then maybe they weren't worth it. (I'm keeping them on the side though, just in case...)
247
Features / Re: New revs
« on October 2nd, 2016, 11:26 PM »
[Commit revision 904a392]
Author: Nao
Date: Sun, 02 Oct 2016 15:41:32 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 23cb8a3]
Author: Nao
Date: Sun, 02 Oct 2016 23:25:51 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Sun, 02 Oct 2016 15:41:32 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Avoiding a minor error when browsing the error log and for some reason the URL wasn't recorded. Need to find out why they wouldn't, too... (ManageErrors.php)
[Commit revision 23cb8a3]
Date: Sun, 02 Oct 2016 23:25:51 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Is this a new jQuery 3 bug..? Lazy loading of pages would now show the JavaScript code in plain view (I guess that fadeIn() now applies to all tag types, including script tags, making them get a block display style, which apparently in the latest Chromium is enough to show the code). I added a safety check for that. It works, so I won't bother with the rest. (topic.js)
248
Support / Re: Class-DB changes?
« on October 2nd, 2016, 11:12 PM »
I'd really really like to know on WHAT page/action you're getting the error...
249
Support / Re: Class-DB changes?
« on October 2nd, 2016, 03:53 PM »
Did you enable everything in the admin area, debugging section?
Testing...
Nope, no errors posting for me.
Anywhere else..? I need to know where to reproduce. ;)
I've double-checked the error_backtrace function, and it doesn't seem to be incompatible with ::get_* functions, and I've even forced a fake error (setting an int to empty string before I pass it), and the error shows up in the error log, complete with file & line number... :-/
Posted: October 2nd, 2016, 01:01 PM
Testing...
Nope, no errors posting for me.
Anywhere else..? I need to know where to reproduce. ;)
Posted: October 2nd, 2016, 03:21 PM
I've double-checked the error_backtrace function, and it doesn't seem to be incompatible with ::get_* functions, and I've even forced a fake error (setting an int to empty string before I pass it), and the error shows up in the error log, complete with file & line number... :-/
250
Features / Re: New revs
« on October 2nd, 2016, 02:57 PM »
[Commit revision f3d603f]
Author: Nao
Date: Sun, 02 Oct 2016 14:56:52 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Sun, 02 Oct 2016 14:56:52 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Main menu couldn't be opened anymore if one of its links was opened with a middle click (i.e. in a new tab). (script.js)
251
Support / Re: Class-DB changes?
« on October 1st, 2016, 07:40 PM »
Merged your pr, thanks.
Can you debug that new thing? ;)
I promise I'll get to it next week. This has just bern the shittiest week ever... :(
Can you debug that new thing? ;)
I promise I'll get to it next week. This has just bern the shittiest week ever... :(
252
Features / Re: New revs
« on October 1st, 2016, 07:39 PM »
[Commit revision 3758508]
Author: C3realGuy
Date: Sat, 01 Oct 2016 19:39:44 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)
Date: Sat, 01 Oct 2016 19:39:44 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)
- Fixed escape_string_replacement(). There was some trouble with the (#39)
- connection var.
253
Support / Re: Class-DB changes?
« on October 1st, 2016, 10:38 AM »
Sorry. Only need to add the connection variable before the str variable in the new function definition.
And yes I'm not using that code on my current websites sorry.
And yes I'm not using that code on my current websites sorry.
254
Support / Re: Class-DB changes?
« on September 28th, 2016, 12:46 AM »Firefox fix for Overflow bug:
http://wedge.org/pub/bugs/8819/overflow-bug/msg297352/#msg297352
Don't ask me why this got committed too, normally I seperate all changes in different branches and let the master branch untouched. Maybe i committed this stuff once to the master branch, i don't know. Can reset my master, create a new branch and do a new pull request if you want, or you just change those two things on your own :D
I'd simply recommend posting a diff file, it's probably gonna be cleaner & faster for everybody. (Except I can't do a full merge from the github website, of course.)
Regarding Firefox, I'm on the fence. You're using hardcoded values (min-width: 49em, another one like that, and a final 'padding: 0 15px' that wasn't in the original css), it's usually bad practice for future browser versions & screen resolutions.
I'd need to test and see if I can find something better, but I'm having so many problems with Firefox in general, I'm not in a hurry.
255
Support / Re: Class-DB changes?
« on September 28th, 2016, 12:43 AM »@Nao, Can you explain what's the problem with 4-byte UTF8?
There are two ways to fix that:
- Either catch all utf8mb4 characters at MySQL insert time, and turn them into HTML entities (which is what Elk does, so that's emanuelle's recommended solution),
- Or ensure that the database uses utf8mb4 from the start, if supported. That way, the character will only take 4 bytes in the database, rather than the length of an entity... Which, okay, is barely twice that number.
I'm not a big fan of parsing all messages for character recognition. I don't know if the array_split followed with an ord() call on all array items would be really fast. (Probably faster than a regexp, but still...)