Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
226
Archived fixes / Re: Low flood/spam limits are ignored
« on October 24th, 2016, 01:18 AM »
Dunno why I didn't get a github notification for that...
I've moved up the lines a bit, to avoid a useless permission check as well. Please tell me if I did it incorrectly. I was busy fixing another complex bug ;)
I've moved up the lines a bit, to avoid a useless permission check as well. Please tell me if I did it incorrectly. I was busy fixing another complex bug ;)
227
Features / Re: New revs
« on October 24th, 2016, 01:16 AM »
[Commit revision 119f001]
Author: Nao
Date: Mon, 24 Oct 2016 01:16:23 +0200
Stats: 1 file changed; +4 (insertions), -0 (deletion)
Date: Mon, 24 Oct 2016 01:16:23 +0200
Stats: 1 file changed; +4 (insertions), -0 (deletion)
- If spamProtection is disabled ($timeLimit == 0), then we don't need to perform log queries. Should make things a little bit faster; also we don't get errors saying that the last request was 0 seconds ago. (Subs.php) (Thanks C3realGuy!)
228
Features / Re: New revs
« on October 24th, 2016, 01:08 AM »
[Commit revision 316a6c6]
Author: Nao
Date: Mon, 24 Oct 2016 01:08:06 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
Date: Mon, 24 Oct 2016 01:08:06 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- Fixed two bugs in the query string cleaner code... (QueryString.php)
- (1) I introduced a typo that probably broke some stuff on some installs using PHP as an Apache mod. This was my fault, dating back to April 2012, and was not caught until tonight.
- (2) parse_str() actually does an implicit urldecode() on the query string, so if $_GET was getting a value of '%2B', it would first be turned into '+' by the first urldecode(), then into a space by the second implicit one. Yes, definitely unwanted. I was going to mention this bug to the SMF guys, but it appears they fixed it on their side back in 2011. Well, good for them! As for me, this was the cause of an OpenID authentication problem, as signatures returned by the remote server would sometimes have a urlencoded '+' sign in them... So logins would randomly be refused. Nice, eh?
229
Features / Re: New revs
« on October 23rd, 2016, 04:03 PM »
[Commit revision 60d3de9]
Author: Nao
Date: Sun, 23 Oct 2016 16:02:45 +0200
Stats: 2 files changed; +113 (insertions), -112 (deletions)
Date: Sun, 23 Oct 2016 16:02:45 +0200
Stats: 2 files changed; +113 (insertions), -112 (deletions)
- Ah, I knew I'd forgotten to post a change for secure avatars... Hopefully they should work now. (Load.php)
- Spacinazi + making a detail simpler to grasp. (ScheduledTasks.php)
230
Features / Re: New revs
« on October 23rd, 2016, 03:55 PM »
[Commit revision 608035c]
Author: Nao
Date: Sun, 23 Oct 2016 15:55:21 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Sun, 23 Oct 2016 15:55:21 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- "You had one job!!" -- Fixed a regex whose delimiter was making it impossible for /~name/ profile URLs to work. Looks like nobody ever used those, eh..? Well I do now. (QueryString.php)
231
Features / Re: New revs
« on October 21st, 2016, 03:13 PM »
[Commit revision 6de24f9]
Author: Nao
Date: Fri, 21 Oct 2016 13:45:05 +0200
Stats: 1 file changed; +2 (insertions), -1 (deletion)
Date: Fri, 21 Oct 2016 13:45:05 +0200
Stats: 1 file changed; +2 (insertions), -1 (deletion)
- Safari 9+ implemented :matches into their CSS engine, so I should adapt the script to use that. Safari users please tell me if Safari's implementation is broken... (Subs-Cache.php)
232
Features / Re: New revs
« on October 19th, 2016, 03:59 PM »
(I don't think the avatar fix is complete; it's complete on my other site but I couldn't find more data to move over. Needs some testing, then!)
233
Features / Re: New revs
« on October 19th, 2016, 03:12 PM »
[Commit revision 238b833]
Author: Nao
Date: Wed, 19 Oct 2016 15:06:40 +0200
Stats: 1 file changed; +5 (insertions), -0 (deletion)
[Commit revision cb7412f]
Author: Nao
Date: Wed, 19 Oct 2016 15:09:49 +0200
Stats: 1 file changed; +14 (insertions), -2 (deletions)
[Commit revision b51f7d0]
Author: Nao
Date: Wed, 19 Oct 2016 15:11:05 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision b8ae0a2]
Author: Nao
Date: Wed, 19 Oct 2016 15:12:02 +0200
Stats: 1 file changed; +8 (insertions), -4 (deletions)
Date: Wed, 19 Oct 2016 15:06:40 +0200
Stats: 1 file changed; +5 (insertions), -0 (deletion)
- Tweaked PHP Information page to avoid long lines as much as possible (e.g. path lists.) (ManageServer.php)
[Commit revision cb7412f]
Date: Wed, 19 Oct 2016 15:09:49 +0200
Stats: 1 file changed; +14 (insertions), -2 (deletions)
- Allow passing an 'immediate' boolean parameter to imperative tasks. This allows the script to immediately delete the task to avoid executing it twice. (Subs-Scheduled.php)
[Commit revision b51f7d0]
Date: Wed, 19 Oct 2016 15:11:05 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Remote avatars didn't allow, surprisingly, for HTTPS or protocol-relative links. I hate replacing a strpos with a preg_match, but it's probably faster than 3 strpos'es, so let's do that. (Subs.php)
[Commit revision b8ae0a2]
Date: Wed, 19 Oct 2016 15:12:02 +0200
Stats: 1 file changed; +8 (insertions), -4 (deletions)
- Some fixes for the main window border in Wilde, as well as a tweak to large header fonts, so that they don't look too bad. (extra.css)
234
Off-topic / Re: Request
« on October 17th, 2016, 04:29 PM »
Oh.. sorry I must have misread your question.
I have no problem with multi language boards, but the problem is that there are only a handful of posts every month, so you wouldn't find many people writing in another language... ^^
I have no problem with multi language boards, but the problem is that there are only a handful of posts every month, so you wouldn't find many people writing in another language... ^^
235
Features / Re: New revs
« on October 16th, 2016, 12:41 PM »
[Commit revision c8b6c4a]
Author:
Date: Sun, 16 Oct 2016 12:23:44 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)
[Commit revision 41fb853]
Author: Nao
Date: Sun, 16 Oct 2016 12:41:32 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)
Date: Sun, 16 Oct 2016 12:23:44 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)
- Fix low spam/flood limits
- spamProtection() did not handle search limits correct.
- It was not possible to disable flood control for search,
- lowest possible value was 1. The new check also allows
- a value of 0.
- If user has moderator permissions, the limit was
- always overridden with 2. We now check if the limit is
- greater than 2 and if not, we override it with 2.
[Commit revision 41fb853]
Date: Sun, 16 Oct 2016 12:41:32 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)
- Merge pull request #40 from C3realGuy/fix_lowfloodlimits
- Fix low spam/flood limits
236
Off-topic / Re: Request
« on October 15th, 2016, 11:25 AM »
Well, I'm not comfortable with handling languages I dont speak. I also took over translating smf in French many years ago because it was so full of typos and errors...
So you'll never see me encourage anyone to start a translation by themselves. A team of at least 5 or 6 users (themselves electing a proofreading specialist) would be best. And most realistic.
So you'll never see me encourage anyone to start a translation by themselves. A team of at least 5 or 6 users (themselves electing a proofreading specialist) would be best. And most realistic.
237
Support / Re: Fatal Error index.php
« on October 15th, 2016, 11:17 AM »
Thanks, but the latest changes are really internal improvements ;)
I'd like to simplify all of the skins though... I mean, remove some stylings that weren't there to make subskins look better but different as a showcase.
I'd like to simplify all of the skins though... I mean, remove some stylings that weren't there to make subskins look better but different as a showcase.
238
Off-topic / Re: Request
« on October 14th, 2016, 06:52 PM »
It's an awful lot of work, you know...
240
Support / Re: Fatal Error index.php
« on October 10th, 2016, 04:56 PM »
Try to reupload your entire Wedge folder.