Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
1096
Archived fixes / Re: Media Gallery: Comment Preview not working
« on March 21st, 2014, 11:24 AM »
Unless someone tells me there IS ACTUALLY a full post page around for media comments, there's nowhere to post previews, and I'd rather just not bother anyway. Fixed in 317f05d by removing the Preview button.
Feel free to close or bump!
Feel free to close or bump!
1097
Features / Re: New revs
« on March 21st, 2014, 11:23 AM »
[Commit revision 317f05d]
Author: Nao
Date: Fri, 21 Mar 2014 11:22:59 +0100
Stats: 1 file changed; +1 (insertion), -7 (deletions)
Date: Fri, 21 Mar 2014 11:22:59 +0100
Stats: 1 file changed; +1 (insertion), -7 (deletions)
- AFAIK, media comments only have quick reply mode, not full page post mode. So, a preview page made no sense because it had nowhere to show its data. I could fix that into showing the data in the quick reply page, but... Seriously? Previewing a media item's comment? (Subs-Media.php)
- Fixed wrong width for media comment editor. (Subs-Media.php)
1099
Off-topic / Re: Happy Birthday Nao!
« on March 21st, 2014, 10:20 AM »
Thanks guys! :)
I'm only one year away from switching to the dark side! (The terrible 40s)
The only thing that keeps me sane is that I'm 30 posts away from switching to the cool 15k :P
I'm only one year away from switching to the dark side! (The terrible 40s)
The only thing that keeps me sane is that I'm 30 posts away from switching to the cool 15k :P
1100
Features / Re: New revs
« on March 21st, 2014, 12:03 AM »
[Commit revision 40bd3a9]
Author: Nao
Date: Fri, 21 Mar 2014 00:01:56 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
[Commit revision f14bb09]
Author: Nao
Date: Fri, 21 Mar 2014 00:02:29 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
[Commit revision 449e8d2]
Author: Nao
Date: Fri, 21 Mar 2014 00:03:13 +0100
Stats: 2 files changed; +3 (insertions), -18 (deletions)
Date: Fri, 21 Mar 2014 00:01:56 +0100
Stats: 1 file changed; +2 (insertions), -2 (deletions)
- Interestingly (your mileage may vary), I took a bit of code from June 2012 and pasted it somewhere else to fix a bug, but I should have taken the July 2012 version instead. So I added a (minor) bug by fixing a larger one. It only generated an undefined index in the error log with no other consequences, no big deal. (Post2.php)
[Commit revision f14bb09]
Date: Fri, 21 Mar 2014 00:02:29 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Saving milli-microseconds for SSI, just like in index.php... (SSI.php)
[Commit revision 449e8d2]
Date: Fri, 21 Mar 2014 00:03:13 +0100
Stats: 2 files changed; +3 (insertions), -18 (deletions)
- Removing theme code... Slowly, but surely. But mostly slowly, okay. (Themes.php, Themes.template.php)
1101
Features / Re: New revs
« on March 20th, 2014, 06:18 PM »
[Commit revision fde20c5]
Author: Nao
Date: Thu, 20 Mar 2014 18:17:00 +0100
Stats: 10 files changed; +8 (insertions), -79 (deletions)
Date: Thu, 20 Mar 2014 18:17:00 +0100
Stats: 10 files changed; +8 (insertions), -79 (deletions)
- If your default (and only!) template folder isn't there, well, can't do anything for you! (Subs-Template.php, Errors.english.php)
- Removed a remaining backslash transform. Feels so good, eh! (Subs-Cache.php)
- Removed path settings page. $boardurl is now set through the basic settings page. (Admin.php, ManageSettings.php, Admin.english.php)
- Removed remaining images_url, theme_url and theme_dir vars. (QueryString.php, ManageSettings.english.php)
1102
Features / Re: Language revs
« on March 20th, 2014, 06:18 PM »
[Commit revision e0f0799]
Author: Nao (Signed-off)
Date: Thu, 20 Mar 2014 18:18:00 +0100
Stats: 9 files changed; +0 (insertion), -15 (deletions)
Date: Thu, 20 Mar 2014 18:18:00 +0100
Stats: 9 files changed; +0 (insertion), -15 (deletions)
- And path strings removal should be finished, yay! (Admin, Errors, ManageSettings)
1103
Plugins / Re: Plugin suggestion - Prevent ALL CAPS
« on March 20th, 2014, 06:04 PM »
Hmm, how could we do that... Maybe just do a temp preg_replace (in the post code) that removes all [^a-zA-Z] characters, and then determines whether the resulting string is ~^[A-Z]+$~..? Also make sure not to test on posts that are less than 100 chars long or something... (SO THAT I CAN SCREAM FOR FUN AND STILL NOT BE REJECTED, AH AH!!!!!!)
1104
Support / Re: error 500 after server change
« on March 20th, 2014, 06:00 PM »
I'm SOOOO behind when it comes to providing tech support (Bunstonious, txcas and Wanchoppe, I think they're all waiting for my feedback on something, it's just that I don't remember what.)
I have no idea what the problem could be with FCGI, but quite honestly, last time I tried Wedge on such a server, it frigging worked....... :-/
Speaking of that, @Pandos, I know you're into fast servers... Have you tried G-Wan, from gwan.com? It's a non-open-source but free server from a Swiss team. Well, a team of one developer, with a business angel and a lawyer on top of it, apparently. This is usually not good news, but I've seen benchmarks, and apparently it's twice lighter than Cherokee, Nginx or Lighttpd. Twice.
I have no idea what the problem could be with FCGI, but quite honestly, last time I tried Wedge on such a server, it frigging worked....... :-/
* Nao hates lousy servers with weird settings.
Speaking of that, @Pandos, I know you're into fast servers... Have you tried G-Wan, from gwan.com? It's a non-open-source but free server from a Swiss team. Well, a team of one developer, with a business angel and a lawyer on top of it, apparently. This is usually not good news, but I've seen benchmarks, and apparently it's twice lighter than Cherokee, Nginx or Lighttpd. Twice.
1105
The Pub / Re: IE 11 and its funny developer tools...
« on March 20th, 2014, 05:56 PM »
The green gradient is missing because it doesn't support linear-gradient CSS.
However, it should be relying on a proprietary filter... I think. Doesn't it?
However, it should be relying on a proprietary filter... I think. Doesn't it?
1106
Support / Re: I can not install
« on March 20th, 2014, 05:55 PM »
Wedge needs at least PHP 5.3.
I fixed the __DIR__ bug yesterday (interesting that this was reported here today for the first time, when the bug was introduced 2 months ago!!
Anyway... As for the timezone problem, I have no idea what this means, BUT PHP < 5.3 handled timezones differently IIRC, so it doesn't really matter I suppose. I just need to make sure Wedge can survive until it gets to write the error message about PHP 5.3 being required. ;)
I fixed the __DIR__ bug yesterday (interesting that this was reported here today for the first time, when the bug was introduced 2 months ago!!
Anyway... As for the timezone problem, I have no idea what this means, BUT PHP < 5.3 handled timezones differently IIRC, so it doesn't really matter I suppose. I just need to make sure Wedge can survive until it gets to write the error message about PHP 5.3 being required. ;)
1107
Features / Re: Language revs
« on March 20th, 2014, 05:24 PM »
[Commit revision 27aed90]
Author: Nao (Signed-off)
Date: Wed, 19 Mar 2014 15:49:56 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
[Commit revision bd1bed7]
Author: Nao
Date: Thu, 20 Mar 2014 17:23:45 +0100
Stats: 3 files changed; +0 (insertion), -15 (deletions)
Date: Wed, 19 Mar 2014 15:49:56 +0100
Stats: 2 files changed; +2 (insertions), -2 (deletions)
- Capitalized a word. (Install)
[Commit revision bd1bed7]
Date: Thu, 20 Mar 2014 17:23:45 +0100
Stats: 3 files changed; +0 (insertion), -15 (deletions)
- Path removals. (ManageSettings)
1108
Features / Re: New revs
« on March 20th, 2014, 05:22 PM »
[Commit revision b8ffdee]
Author: Nao
Date: Thu, 20 Mar 2014 16:27:47 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)
[Commit revision 3969e46]
Author: Nao
Date: Thu, 20 Mar 2014 17:22:40 +0100
Stats: 12 files changed; +179 (insertions), -225 (deletions)
Date: Thu, 20 Mar 2014 16:27:47 +0100
Stats: 2 files changed; +4 (insertions), -4 (deletions)
- version_compare is core PHP, duh! No need to test for it! (Class-DB.php, Errors.php)
- Removed $pluginsdir from that place, while I'm at it. (Errors.php)
[Commit revision 3969e46]
Date: Thu, 20 Mar 2014 17:22:40 +0100
Stats: 12 files changed; +179 (insertions), -225 (deletions)
- $boarddir, $sourcedir, $cachedir, $pluginsdir, $cssdir and $jssdir are now all hard-coded, relative to ROOT_DIR (ex-$boarddir) which itself is determined through PHP. This is the second step towards making Wedge folder moves easier. (Class-CSS.php, Load.php, ManagePlugins.php, ManageSettings.php, OriginalFiles.php, QueryString.php, Subs-Plugins.php, Subs-Template.php, index.php, install.php, ManageSettings.english.php)
- Fixed a PHP 5.3-only constant (__DIR__) showing up before it was allowed to. My, didn't I already do that before..?! (index.php)
- Gained a portion of a microsecond or two for PHP 5.4+ by completely skipping the magic quote crap, including the function_exists test. It's approximately one billionth of the time it took me to type this, basically. But on every page. Don't complain. (index.php)
- Removed folder presence tests at the start. If you want to remove them, well... That's your problem. Plus, I get to use a geeky syntax in this code block. (index.php)
- Note: $pluginsdir/$pluginsurl and PLUGINS/PLUGINS_DIR are actually removed entirely, replaced by ROOT_DIR/ROOT hardcodings. They weren't used enough in the generic code flow to be worth a constant. Also removed CORE and CORE_DIR constants, for the same reasons, but I'm willing to restore constants by popular request.
- Also, ROOT_DIR now automatically turns backslashes into slashes, reverting the need for that manipulation later on. I can see no reason why it couldn't be done so early!
1109
Features / Re: New revs
« on March 19th, 2014, 07:37 PM »
[Commit revision 98cd9cf]
Author: Nao
Date: Wed, 19 Mar 2014 15:55:46 +0100
Stats: 3 files changed; +7 (insertions), -16 (deletions)
[Commit revision 4e06a33]
Author: Nao
Date: Wed, 19 Mar 2014 15:59:59 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)
[Commit revision e6872cb]
Author: Nao
Date: Wed, 19 Mar 2014 17:54:01 +0100
Stats: 4 files changed; +8 (insertions), -24 (deletions)
[Commit revision d5e9c81]
Author: Nao
Date: Wed, 19 Mar 2014 17:56:19 +0100
Stats: 1 file changed; +3 (insertions), -8 (deletions)
[Commit revision 1910c57]
Author: Nao
Date: Wed, 19 Mar 2014 19:22:53 +0100
Stats: 2 files changed; +18 (insertions), -13 (deletions)
[Commit revision 1015ede]
Author: Nao
Date: Wed, 19 Mar 2014 19:33:55 +0100
Stats: 3 files changed; +36 (insertions), -42 (deletions)
[Commit revision 667669a]
Author: Nao
Date: Wed, 19 Mar 2014 19:37:13 +0100
Stats: 1 file changed; +71 (insertions), -75 (deletions)
Date: Wed, 19 Mar 2014 15:55:46 +0100
Stats: 3 files changed; +7 (insertions), -16 (deletions)
- Moved $action_no_log to loadSettings, and removed extra_actions and nolog_actions variables. There are a couple of hooks where you can modify $action_list and $action_no_log, so I see no reason to have these features, apart from a very relative performance advantage. (index.php, Load.php)
- Capitalization. (Install.english.php)
[Commit revision 4e06a33]
Date: Wed, 19 Mar 2014 15:59:59 +0100
Stats: 1 file changed; +0 (insertion), -3 (deletions)
- $cachedir is always set, no need to unset it first. And that security problem was solved in PHP 5.1.4 anyway, which is not even supported by Wedge. (index.php)
[Commit revision e6872cb]
Date: Wed, 19 Mar 2014 17:54:01 +0100
Stats: 4 files changed; +8 (insertions), -24 (deletions)
- Moved random seed generator to loadSettings, since it used to be called only twice, and systematically after loadSettings. (SSI.php, index.php, Load.php, Subs.php)
[Commit revision d5e9c81]
Date: Wed, 19 Mar 2014 17:56:19 +0100
Stats: 1 file changed; +3 (insertions), -8 (deletions)
- Minor code tweaks, mainly to match SSI with index.php. (SSI.php)
[Commit revision 1910c57]
Date: Wed, 19 Mar 2014 19:22:53 +0100
Stats: 2 files changed; +18 (insertions), -13 (deletions)
- Moved scheduled task launcher to loadSettings. I'm not 100% sure it'll stay there though, as I had to add a SSI test before running it... Not very clean. For now, I'm just trying to shrink the index down to the bare minimum. (Load.php)
[Commit revision 1015ede]
Date: Wed, 19 Mar 2014 19:33:55 +0100
Stats: 3 files changed; +36 (insertions), -42 (deletions)
- Moved all security headers to loadSettings. This one's interesting: there was a duplicate X-Frame-Options header being generated by both QueryString and index.php, which is a bad idea generally. (index.php, Load.php, QueryString.php)
- Moved AJAX definition to loadSettings, while I was at it. (Load.php, QueryString.php)
- Important security note: SSI will no longer go through the X-Frame-Options header, but it's for the best. It's up to the parent script to determine what headers they want to send, generally.
[Commit revision 667669a]
Date: Wed, 19 Mar 2014 19:37:13 +0100
Stats: 1 file changed; +71 (insertions), -75 (deletions)
- And the biggest one: removed the wedge_main() function, and moved all of its straightforward code to the main code. The code that determines the action name is now executed from its own function, determine_action(), which helps readability. An awful lot, if you ask me. (index.php)
1110
Archived fixes / [Security issue] Re: /plugins/<name>/plugin-info.xml
« on March 18th, 2014, 09:30 PM »
You should know that preventing access to XML files won't make it impossible to try and access a folder with a known name... you can always check for a non-xml file's presence, if you're aware of what the plugin folder has.