Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
10261
Features / Re: New revs
« on September 23rd, 2010, 11:35 PM »
rev 137
! Fixed a good part of the RTL issues. Missing button strips, have yet to check more specific areas. (index.css, rtl.css)
! Fixed submenu positions in RTL mode. (script.js)
* Moved extra stylesheets to the top of the header, too. (index.template.php)
10262
Features / Re: New revs
« on September 23rd, 2010, 07:53 PM »
Quote from Nao/Gilles on September 23rd, 2010, 02:35 PM
* Moved menu/sidebar toggle to the left... I say it's a matter of logic. Now if you'll stop bothering me, I'm busy writing this changelog... (index.css)
Well, I was busy a lot... So much that I forgot that I'd put it back to the right of the screen after I noticed it didn't play well with most browsers :P
Will have to fix this at some point...
10263
Features / Re: New revs
« on September 23rd, 2010, 02:35 PM »
Y'know, there are people who hate documenting more than anything... ;)
I made my Kyodai Mahjongg help files under WordPad (sic), in RTF format (sic), and had to do both English and French versions at the same time (as for everything I do really), and didn't have a diff compare tool at the time... Oh, what fun it was!

Anyway... Finally!!

rev 136
@ The patch equivalent weighs in at 92KB... Yay.
@ This is only about templates, so add ".template.php" to the filenames.
- Replaced these horrible ie6_header/floatleft hacks with some actual common sense. Needs testing on all browsers! (Admin, BoardIndex, Display, GenericList, GenericMenu, Login, ManageMaintenance, ManageMembers, ManageNews, ManagePermissions, Memberlist, ModerationCenter, Notify, Packages, PersonalMessage, Profile, Recent, Search, SendTopic, Stats, Themes, index.css, ie6.css)
- Deleted png_fix and newupshrink classes/ids, which were not even used in a vanilla SMF2... (Admin, index.css)
- Deleted all img.icon classes, as they're all used within a title_bar/cat_bar and were replaced with contextual styling. (BoardIndex, Display, GenericMenu, Login, ManageNews, Memberlist, Notify, Packages, Profile, Recent, Search, SendTopic, Stats, Themes, index.css, admin.css, index.css, ie6.css, rtl.css)
* Added cellspacing="0" to table_grid declarations missing a cellspacing, and reverted table_grid border-collapse to separate, so that table headers can be properly rounded in a standards-compliant fashion. Also deleted border="0" declarations, as borders are set to 0 by default. (Admin, Errors, ManageBans, ManageMembergroups, ManageMembers, ManageNews, ManagePaid, ManagePermissions, Memberlist, ModerationCenter, Packages, PersonalMessage, Profile, Reports, SplitTopics, Stats, Themes, index.css)
! Fixed isset($config_var['postinput']) into !empty, as it was always set and would thus generate an extra tab in the HTML code. (Admin)
* Moved menu/sidebar toggle to the left... I say it's a matter of logic. Now if you'll stop bothering me, I'm busy writing this changelog... (index.css)
* Renamed generic menu classes, from their adm* and admin equivalents, as generic menus are supposed to be... generic. (GenericMenu, index.css, rtl.css)
* Spacing. (ManageBoards, Packages, PersonalMessage, Search)
* Moved profile summary's boxes a bit lower. Ideally, I should be doing this for every box that touches any dual-colspan cat_bar/title_bar... (index.css)
* Gave more padding to the hosted avatar selector. Seriously, were they asleep or something when they designed this? (index.css)
* Improved overall design. I'm actually starting to like it... I said started. Got rid of min-height in header (a leftover from the earlier frame). (index.css)
10264
Features / Re: New revs
« on September 23rd, 2010, 11:55 AM »
(Just getting rid of the quick update... Take note of my outrageous way to diminish the SMF team in a passive-aggressive way :P Interesting that it's happening on post #666 for me... Hmm.)

rev 135
* Updated to SMF rev 10127. Just a fix I reported, a minor security issue with word censorship, and some documentation which Pete will be rewriting from scratch anyway. (changelog.txt, install.php, create_backup.php, restore_backup.php, Admin.php, Class-Package.php, DbExtra.php, DbPackages.php, DbSearch.php, Display.php, Groups.php, LogInOut.php, ManageSearch.php, PackageGet.php, Subs-Database.php)
10265
Features / Re: New revs
« on September 22nd, 2010, 11:42 PM »
Eheh.

http://dev.simplemachines.org/mantis/view.php?id=4471
This is an incomplete report, and it's been fixed in an incomplete manner... There are dozens of places where the icon class isn't applied. I noticed that while removing the ie6_header... And then I thought, "what's the point of that anyway? I never see more than one icon per header... So we can just as well access it with .cat_bar img, .title_bar img, it'll save a few bytes each time...
Anyway, I started removing icon classes earlier today. Do you think it's okay if I keep doing it? I really don't see a reason for keeping these in... (And I can't reopen reports to tell them. Which is why I was complaining originally that I was put into a minor group on the tracker...)
10266
Features / Re: New revs
« on September 22nd, 2010, 10:05 PM »
Indeed! At last, you found a place to express the endlessly-fuelled creativity of your talkativeness. :eheh:
10267
Features / Re: New revs
« on September 22nd, 2010, 07:39 PM »
I'll commit today's changes ASAP. I'm not sure I'm done yet but my time for today is up.
I've also internally updated to the SMF rev 10127... Norv has started documenting the files! Well, by "documenting", I mean "replacing the "// !!!" with single-line descriptions of the functions ;)
10268
Features / Re: New revs
« on September 22nd, 2010, 11:21 AM »
A cleanup commit entiely...

rev 131
- Deleted help area styling. (index.css, rtl.css)
- Deleted rounded corner compatibility code... For good!! (theme.js)
- Deleted tags when an ID is specified for them, as it's useless and hurts performance. (index.css, rtl.css, admin.css)
- Deleted topslice_quote and botslice_quote placeholders from quotes, because, well... If you're going to emulate rounded corners, you don't need them. And don't tempt me into deleting the quotefooter placeholder entirely! (Subs.php)
* Renamed left_adm* and main_adm* classes because they're generic, not admin-centered. (index.css, rtl.css, ie6.css, GenericMenu.template.php)
! Fixed a few issues with rounded corners. (SplitTopics.template.php)
* Moved style.css linking a few lines above in the head section, so that the browser will notice it sooner in case the HTML page isn't gzipped. (index.template.php)
* Spacinazi. (PersonalMessage.template.php)
10269
Features / Re: New revs
« on September 21st, 2010, 07:36 PM »
rev 130
* Renamed MSN bot to Bing. (install_2-0.sql)
* Some help-related cleaning up. (*.dtd, Help.php)
- Dropped hover addon function for IE, because the new menu is cool and doesn't need that. (theme.js)
- Dropped rounded corner compatibility code, because... Well, screw IE! (index.css, old.css, theme.js)
- Dropped compat.css, in the same vein, because... Well, it sucks as a converter.
- Removed .rrc class from all templates. (Admin, BoardIndex, Calendar, Display, Help, Login, Memberlist, Notify, PM, Poll, Post, Profile, Register, Reminder, Search)
* A couple of fixes to IE6 layout, and IE7 cleanup. (ie6.css, ie7.css)
* Redesigned Curve layout. Mostly for the menu system. (index.css, menu.png, white-op85.png, grad*.png)
* Restarted menu layout code from the original SMF code, in a cleaner way. (GenericMenu.template.php, index.template.php)
@ TODO: Delete main_block.png, deal with rtl.css, and more cleanup.

Pete, hopefully you won't have the design changes too much! Remember, it's a work in progress. The header is to be redone. I just wanted to get rid of the SMF frame ASAP and couldn't find a suitable replacement!
10270
Off-topic / Re: Top funny source code comments
« on September 21st, 2010, 02:17 PM »
I'm not evil! Not now, at least!
10271
Features / Re: New revs
« on September 21st, 2010, 12:26 PM »
Good job.

You forgot to mention this one you committed:
rev 127
+ Added the ability to override banned users' avatars and simply hide them. More options will follow, hence building it like this. (ManageAttachments.php, Load.php, Admin.english.php, Help.english.php)

Also, as discussed earlier:

rev 128
- Removed converters folder, because right now we're only planning on supporting conversion from SMF2. Once it's ready, anyone can go from their forum system to SMF2, and then to Wedge.
Posted: September 21st, 2010, 12:22 PM

rev 129
- Deleted help_convert folder, as it's obviously a very outdated system related to the help templates.

(If you look at the copyright, it says Lewis Media 2006... I doubt it was updated after that!)
10272
Features / Re: New revs
« on September 20th, 2010, 11:27 PM »
Given that I have to edit everything manually everytime they change a template (because of the header changes), I'm getting used to diverging routes... ;)
10273
Off-topic / Re: 1kb Grid
« on September 20th, 2010, 11:08 PM »
Ah yes, it's one of the CSS frameworks that were reviewed in .net magazine (UK)'s framework roundup, a few months ago.
I've never "got" the point of CSS frameworks, really. And even less the point in using a grid system for forum layouts, so... Basically it's a non-issue for me.
I find it actually funny that there are actually people pushing for the return of styled table layouts now[1].
http://www.yourasoft.org/forum/index.php?topic=1802.0
 1. Wedgeo and Noisen are table-based when it comes to topic posts.
10274
Off-topic / Re: Top funny source code comments
« on September 20th, 2010, 11:05 PM »
Tell that to my girl! She would laugh at your face... See, you're witty :P
10275
Features / Re: New revs
« on September 20th, 2010, 11:04 PM »
Well, the proposed fix was to apply overflow: hidden to .post_wrapper, which is EXACTLY what was already done on Wedge... (I don't know if I did it -- I probably did, although I don't remember.) I didn't know about this bug report until I looked into the fix.
What was done instead, was to apply float: left; width: 100% to the class.
However, I applied this to wedgeforum.com and noisen.com, and the windowbg/windowbg2 classes ended up getting a height of 0px, and the contents were overflowing from them obviously. I re-established my overflow, and it worked again. So I figured, to hell with this fix... I prefer mine. While Antechinus says it "doesn't work on every browser", in my experience it does. Even in IE6... Specifying an overflow setting has saved me from numerous issues with floating divs, really.