Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
10231
Features / Re: New revs
« on September 10th, 2010, 12:39 AM »
What happened with your fix, was that selecting "Select font size" would add [size=0pt][/size] to the message box... :)
So I simply did it the way other boxes were done. Now it works, it simply returns "" (insteaf of "0") and thus doesn't show anything.

BTW, wrong place to discuss but I'm a bit lazy...

   $breaker = '<span style="margin: 0 -0.5ex 0 0;"> </span>';

This is in the code to fix long words. Uh... How about we use the proper tool -- &shy;?
Posted: September 9th, 2010, 03:06 PM

rev 75
- Removed setRequestHeader test for Opera... That issue was only in the 5yo Opera 8.00 (note the specific minor version number), so... what the heck?! (Post.template.php, topic.js)

(Looks like Wedge is on a diet, today... ;))
Posted: September 9th, 2010, 03:09 PM

rev 76
- Market share for IE 5.x was 0.08% in 2009... We're in 2010. IE5 support is out. (Load.php, Subs.php, Display.template.php, editor.js, script.js, topic.js)

rev 77
! Oops again. (Load.php) <-- crash

rev 78
! is_opera105up wasn't properly filled in. (script.js)
! document.body isn't always initialized. Replaced with a createElement. (script.js)
+ Re-introduced ActiveX hack, as IE6 also made use of it. Limiting to the newer namespace, though. (script.js)
* If browser supports querySelectorAll(), use that in the rounded corner emulator. Probably only Opera 9.x through 10.10 can make use of that. (script.js)

Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
I don't even have access to the console, for a reason unknown. :(
Posted: September 10th, 2010, 12:03 AM
Quote from Nao/Gilles on September 10th, 2010, 12:03 AM
Tested to work in O 9.01... However, I couldn't get to use the smiley/bbc boxes. Don't show up. O9 doesn't have Dragonfly, it started in v9.5, and I'm not sure I want to update it...
Grmpf... Did the update, and it works in O 9.5. Dunno if it was broken in O9 because I had some wrong configuration. Anyway... O9.5+ is 90% of the Opera userbase or so. Fine with it.
10232
Features / Re: New revs
« on September 9th, 2010, 02:45 PM »
Sometimes... I really feel like a small-time hacker with my minor revs :P

rev 68
- Removed needs_size_fix hack, as it was only used in Babylon themes. (Load.php)
- Removed nopadding from Admin template -- looked ugly for no reason. (Admin.template.php, admin.css)
* Pete... I'm afraid I'm a parenthesis nazi. (Load.php, Display.template.php)
! Fixed Register and SplitTopics templates to apply rounded corners to divs instead of lists and forms. This allows for faster parsing when in compatibility mode. (Register.template.php, SplitTopics.template.php)
Posted: September 9th, 2010, 11:25 AM

Okay, this one's a bit better actually :eheheh:
I'm not too sure about the is_opera105up though... And I'd be tempted to delete WAY MORE is_* variables at this point. (Discuss in related topic, thanks.)

rev 69
+ Added code to automatically detect browser support for border-radius and box-shadow. (script.js)
* Moved rounded corner emulation code to script.js, as it's likely to be more stable now. (index.template.php, script.js)
* Started conversion of roundframe divs to delete non-semantic code. (index.css, BoardIndex.template.php)
* Rewrote browser detection code to be more efficient. Dropped versions is_ie4, is_opera5/6/7/8 are now forced to false, is_safari is only set if not in a smartphone environment, dropped is_opera96 entirely (was it used at all?), added is_opera105up (not is_opera105 though... I don't want to overdo it), is_ff is really only set for the actual Firefox and assimilated, and added is_ie9 and is_ie9up. (script.js)
* Updated this.bRichTextPossible initialization code accordingly. (editor.js)
! Deleted more IE4 compatibility code and fixed typos. (script.js)
! Fixed admin sub-menus to avoid showing a scrollbar. (index.css)
Posted: September 9th, 2010, 11:37 AM

rev 70
* Plenty of cleaning up. @todo: what's with the random registration code hardcoded into this..?! (Help.template.php)
* Some cleaning up. (Memberlist.template.php)
- Removed legacy class innerframe. (Help.template.php, BoardIndex.template.php, Profile.template.php)
* Finished converting roundframe divs to the new system. Yay! (Templates: Admin, Calendar, Display, Help, Login, Memberlist, Notify, PersonalMessage, Poll, Post, Profile, Register, Reminder, Search)
Posted: September 9th, 2010, 12:13 PM

rev 71
- Removing securityPackages folder, as it's SMF-specific and being well behaved, we don't play with others' toys.
! Fixed undefined error 'submit_label'. (Display.php)

rev 72
! Fixed incorrect regex in browser detection. (script.js)

(Sorry, forgot to commit the second one at the same time...)
Posted: September 9th, 2010, 01:29 PM

rev 73
! Clean fix for the font size dropdown in Opera (see here), and added support for 6pt font size. (Class-Editor.php, editor.js)
* Another coup from the Parenthenazi. (Wireless.template.php)
10233
Features / Re: New revs
« on September 8th, 2010, 02:36 PM »
rev 64
* Updated to SVN rev 10098 (hmm, just a line to change. Cleaned up the function, too, as the comment was a bit contradictory.)
 ! Add attachments cleaning for IE as well, though it allows manually deleting the file input box (script.js)
10234
Features / Re: New revs
« on September 8th, 2010, 12:32 AM »
No... "((?:topic=)\d+)" would return "topic=1", I'm pretty sure of it. (I wouldn't bet my life on it, but I'm still quite certain.)
10235
Features / Re: New revs
« on September 7th, 2010, 11:43 PM »
I assure you that it means "topic or topic". :whistle:

Okay, bed time for me...
10236
Features / Re: New revs
« on September 7th, 2010, 11:35 PM »
- editor: I was surprised to have noticed that myself ;D
- Subs: (?:topic) really does nothing. The regex engine will disregard it. The only reason to use (?:) is if you provide a quantifier after the parenthesis. (?:topic)? is logical. It's either topic, or nothing. (?:topic) means it's even topic, or topic. :lol:
10237
Features / Re: New revs
« on September 7th, 2010, 10:56 PM »
rev 62
* URL prompt in editor should use [url] type instead of [url=] when no description is provided. (editor.js)
! Fixing on-the-fly rounded corners for IE when splitting topics. (SplitTopics.template.php)
* Minor stuff. (Recent.template.php, index.css, Subs.php)

--> when it comes to Subs.php, your modified regex had a "(?:topic)" in it... Just replaced it with "topic" ;)
10238
Features / Re: New revs
« on September 7th, 2010, 12:14 PM »
rev 60
* Renamed files with mysql in the filename to make it more generic. (install.php, create_backup.php, repair.php, repair_settings.php, restore_backup.php, smf_api.php, upgrade.php, detailed-version.js, Load.php, renamed: Db*-mysql.php to Db*.php, Subs-Db-mysql.php to Subs-Database.php)

--> I think "DbExtra.php" doesn't look good, but it's better than "DbExtra-mysql.php" which is redundant (MySQL *is* a Db.) Maybe "Data-Extra.php" or "Database-Extra.php"...? Dunno. It's not very important ;)

Okay, I should get back to my templating stuff now...
10239
Features / Re: New revs
« on September 7th, 2010, 11:40 AM »
It's just a matter of phrasing stuff correctly. I don't mean yours isn't correct -- just that it can be confusing.
I'm confused myself. With my post, not your phrasing. Or am I. Or is it.

I should go back to bed.
10240
Features / Re: New revs
« on September 7th, 2010, 08:00 AM »
"Please enter what text the link should say." -> Is this straightforward, or could people be confused with this? I would have said (with my limited English) something like, "You may enter a caption (description?) for the link if you'd like." It doesn't seem mandatory.
10241
Features / Re: New revs
« on September 7th, 2010, 07:25 AM »
Great news for everything :)
(Install script or upgrade script?)
10242
Features / Re: New revs
« on September 6th, 2010, 10:52 PM »
Quote from Arantor on September 6th, 2010, 10:47 PM
Unless you did something funky, I found I needed it since link= doesn't accept msg on its own (it requires either (board+)topic or threadid, optionally followed by the msg number for the # fragment, or action=profile with user id for PMs)
Yeah, that was totally needed and what I'd done in the first place. (See ticket #31)
Quote
Well, every time I do something half way big, I push it through a fresh install, so I'll be able to test. I'm not so worried about the upgrade script right now personally (since I'm not planning to test it anytime soon :P)
Unfortunately, the only way to properly test a forum install is to use it... ::)
(In the end, it's my goal to convert wedgeo to a vanilla Wedge, of course.)

PS: 1000+ posts on wedgeo :)
10243
Features / Re: New revs
« on September 6th, 2010, 09:22 PM »
Don't remember having ever touched the code you modified to add msg=... Are you sure it was needed? :)

rev 57
! Extra tabs/spaces, and typo fixes in comments, like its/it's and lets/let's. (Many files)
Posted: September 6th, 2010, 09:15 PM

Pete, I've re-read the install and upgrade scripts, and I really hope I got them done without breaking anything. In terms of logic, it should be okay. Just don't yell at me if you try running one of the scripts and it crashes :) I just wanted to be done with it...

rev 58
- Hopefully, removed all of the remaining multi-database code. (install.php, smfinfo.php, upgrade.php, DbPackages-mysql.php, DbSearch-mysql.php, Search.php, SearchAPI-Custom.php, SearchAPI-Fulltext.php)
10244
Features / Re: New revs
« on September 6th, 2010, 04:36 PM »
Quote from Arantor on September 6th, 2010, 04:30 PM
Just to clarify: FIND_IN_SET has its place, like everything else. But to use it to hunt through what is really relational data (user belongs-to group, board belongs-to group), which results in a table scan vs using indexes really is ridiculous.
Are you sure it's inefficient? I remember reading about performance issues and the conclusion was that it was just as fast as an extra table... Couldn't say, myself. Haven't been looking into {query_see_board} and stuff for a long time.
Quote
When you're done with that, I'll begin on replacing $scripturl with a constant (along with the other similar globals that shouldn't really be global variables but constants)
Hmm... You means replacing $scripturl with SCRIPTURL?
I noticed your use of constants inside SD...
May I give you my honest opinion?
It looks kinda ugly........... :unsure:
Actually takes me back to the days of SMF1, with $ID_MEMBER, $ID_BOARD and such.
Quote
Re Oracle: If we make the move to everything being properly relational anyway, it becomes so much easier to build for... but I don't like building for something I can't test, hahah.
Same here!

+1 for going relational, though. We already have plenty of tables... Why not add a few dozen more, people won't notice :P
10245
Features / Re: New revs
« on September 6th, 2010, 04:28 PM »
Quote from Arantor on September 6th, 2010, 03:58 PM
I think it can. Oracle has jettisoned the areas it's not interested in (OpenSolaris for one), and MySQL is a money maker for it, especially as it can sell very expensive training, then upgrades to Oracle gear later on (with support contracts)
I wouldn't add support for Oracle DB... My girlfriend could, though! (Well, she'd be my living documentation on their custom stuff, at least.)