Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
Off-topic / Re: Post count fever
« on September 12th, 2010, 07:58 PM »
And 30000 in a year, too!
I think my best ever for a day was around 250... (Estimated.) On my older forum over at
Features / Re: New revs
« on September 12th, 2010, 06:49 PM »
rev 95
! upgrade_2-0.sql file didn't get deleted after an upgrade process. (upgrade.php)
! Fixed Display template showing an error next to a guest poster. It currently links to a dummy URL, will fix when I had proper support for this feature. (Display.php)
* Moved conversation selector from left to center in PM homepage, as it takes less space there and might be placed more logically this way. But am I to talk... (PersonalMessage.template.php)
* Changed possibly_robot again, to use preg_match() and more generic search terms. (Load.php)

(Feel free to discuss!)
Off-topic / Re: Post count fever
« on September 12th, 2010, 05:46 PM »
Yes, that's what I said :P
Okay, you know what -- QUOTES ARE WAY UNDERUSED.

People don't multi-quote enough. People don't know the pleasure of replying everything line by line.
You know what? Because people use the Quote bbc button and it's so complicated.
Power-quoters like me, and perhaps Pete, do it manually. Quote message... Okay, focus on message, ctrl+end, ctrl+shift+left arrow until I select the entire [/quote], ctrl+c, ctrl+home (I use ctrl a lot, at this point...), go to end of the quote I want to reply to, ctrl+v, enter, enter, type answer... Enter, enter, ctrl+v, right arrow, del (this effectively turns it into an opening quote), go to end of the quote, keep doing it that way...

Now, you can try it if you never did. It works and, well, I don't see a better way of doing it quickly.

Until today.
I remembered these freaking' annoying e-mails.
Which were so easy to reply to, because they already were entirely quoted.

> Hello, world.
> Reply to this.
> Just below.

See? It's easy.

> More quotes.

---------------> Now what? Why can't we do that for Wedge?
That's the idea, really.

Quote message.
Show message. Instead of showing it inside a large quote tag, turn it into a post with limited width, add automatic carriage returns, and *add > signs in front of each line*.
Now, the user can reply like on any e-mail they may want to quote...
And then, when they hit the Send button, that's where the magic is supposed to be applied: we turn back this post into a properly quoted post. I don't know exactly how, but we can discuss it. Basically, it's simply about concatenating all lines with a starting ">" into a single quote. Special cases like code tags should be accounted for (we have to deal with them as a single block). We could keep a copy of the quoted post in memory, and compare it with the new post, and thus do some sort of diff on it -- you know, like Wikipedia. And then we quote everything that was inside the earlier post, and only that.

It could be exciting... Because it's something that actually talks to e-mail users. There are a few, I've heard. :whistle:
Off-topic / Post count fever
« on September 12th, 2010, 04:18 PM »
Congrats on reaching 500 posts, Pete!
Next stop: 500 more posts... in a day :P
I'm sure you can do it when we go public :lol:
Features / Re: New revs
« on September 12th, 2010, 04:17 PM »
I'm not very confident that we can actually keep both the internal Wysiwyg editor AND add support for others without too much hacking, but I'll let you play with it if you want ;) I wouldn't mind only supporting external editors, myself.

BTW, what tool do you use to do your site-wide searches, and search & replace events?
Personally, I'm with very old tools (outdated?): Super Text Search for searches (supports regex so I kept it so far), and BK ReplaceEm for search & replace.

Also, in PersonalMessage.php:
Code: [Select]
// Changing view?
if (isset($_REQUEST['view']))
$_GET['view'] = (int) $_GET['view'];
Is it wanted? $_REQUEST then $_GET? Not logical to me...

On to the boring stuff... (Haven't tested user menus yet. Excited about 'em.)

rev 93
- Removed support for Konqueror. (Load.php, Subs.php, Admin.template.php, Packages.template.php)
- Removed support for some browser version numbers: Opera 9/10, Firefox 1/2/3, as they're not known to have specific issues. Added user agent in $context['browser']['ua'] for modders to get a clean way to search for specific version numbers. (Load.php)
* After looking through Who.php, I realized I'm also an isset-nazi. Starting work on merging isset() && isset() calls together. (Subs-Editor.php, Subs-List.php, Subs-Menu.php, Subs-MessageIndex.php, ViewQuery.php, Who.php, Post.template.php, Wireless.template.php)
+ Added a msnbot (Bing) check in possibly_robot, but it should be useless anyway. Maybe just in case they decide to add "Mozilla" in their user agent string... (Load.php)

rev 94
! I don't know what a profie is... Is it a profitable profile? (Display.php, index.english.php)
- Deleted im_switch.gif. Goodbye, and please don't call, we won't miss you. (im_switch.gif, Help.template.php)
* Spacing nazi (index.css, Display.template.php, topic.js)
Features / Re: New revs
« on September 12th, 2010, 01:36 AM »
Quote from Arantor on September 12th, 2010, 01:22 AM
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()?
When it comes to having it in a random file that seems disjointed, or at least tied to the behaviour in which it is most directly used, I'd rather have it attached to where it is used.
Fine, but... In an editor object?
Look at Aeva-Media.php... It has the media object in it. See the extList function? I put it outside the object because I was getting errors when running in strict mode (dunno why.) Still, I think it's better in that place because basically it was mainly unrelated to the media object and made no use of it. The function is still in the better file, but doesn't have to be in the object itself.
There is no use within SMF/Wedge where preparsecode is used where the content hasn't come from the editor. Sure... it could come from a feed or a mod, but in that case it's still coming from an arbitrary place. As far as I'm concerned, we talking about the function being just in a file, versus being with the code that hands content to it.
Is this, anyway, really going to help the adding of TinyMCE, CKEditor etc?
I'd like to think we can make a useful changelog for people much like the AeMe one, in a way that's fun as well.
Of course we can :) If only for us to keep track of what makes Wedge great!
Features / Re: New revs
« on September 12th, 2010, 01:03 AM »
* Nao/Gilles is in a trance listening to the Atari ST Chambers of Shaolin soundtrack...
Quote from Arantor on September 11th, 2010, 08:51 PM
There is. My argument is, ultimately, that instead of loading a seemingly unrelated file every time you want to handle editor input, you load the editor's code - see, if you're instantiating the editor, you used Subs-Editor.php, but when you handled the editor's input... you load Subs-Post.php. The only logic I can find for that is that preparsecode was originally in Subs-Post.php for SMF 1, when Subs-Editor.php didn't exist.
I understand that... But what is the logic behind having to call the editor class when preparsing an innocent string for use in parse_bbc()? Nothing says it was added through the editor itself... It could have been imported through a feed, etc... (Or even generated by SMF or a mod...)
I liked how you did the AeMe changelog though I'll admit I never read it in detail.
Well, that only proves my point :P
I don't believe anyone ever admitted to me having read the changelog at all. It's okay with me. It's THERE to be read if you need to. If you don't, then that's okay. But it's just like buying a new car and thinking, "okay it's cool, I can drive a car already, I don't need to read the manual..." And then of course you realize some things are done differently, then you read the changelog, and discover in the meantime a feature you never knew had been added, so you figure you'll read the entire changelog to spot other hidden features, and all you end up finding is easter eggs... :P

Oh my... Chambers... of... Shaolin... It's so great, I can't focus on this post... Too bad the Amiga version sounds so dull...
Note: the strings were copied from the Profile, rather than loading the profile strings. I figured if we like this, we'll subsequently remove the option from the profile area anyway, but for now it's duplicated.
I'll have a look tomorrow...
Features / Re: New revs
« on September 11th, 2010, 04:18 PM »
Quote from Arantor on September 11th, 2010, 03:09 PM
Oops, I broke it :P
Told ya I hadn't looked into Class-Editor... ;)
I must say, I'm not too excited about having to type wedgeEditor::preparsecode instead of just preparsecode(), but I'm sure there's a good reason behind it, I trust you on that one. (If there isn't, then I'll kill you dead for it :P)
Are we going to update changelog.txt?
Well, one of the things that really piss me off with changelogs, is that NOBODY reads them, even when you're trying HARD to make them fun to read... (Just have a look at some of Aeva/SMG/AeMe's log entries. I even placed a Blade Runner quote in AeMe and nobody probably saw it :P)
So, having a 800KB changelog is totally useless in that respect. What people need is the kind of changelog I do for AeMe on big version updates: I categorize changes by interest. The biggest changes are put first, then the "cool" changes, then at the end I have a list of geeky, uninteresting changes, and finally the mandatory line "Plenty of bug fixes as usual", which is totally right.

I generate my changelogs at release time (or close to), by getting them from Tortoise and reordering them.
We could try having a changelog generated automatically from the svn (I'm sure there's a tool for that), and then we can go through it and delete anything that's not of interest to the reader.

Also, one of the things that piss me off in SMF's changelog, is that they document fixes for *unreleased revs*. Yay... Like it's going to be of any interest to non-testers! Even them don't read changelogs -- at best, they go through (most of) the bug tracker.
Also, did you see my proposed changes for the PM UI? (;ticket=18.msg253#msg253)
Yes, and that's precisely what got me to find the crash ;) And subsequently the ClassEditor missing a dash.
I was trying to send meself a PM to see if you had committed the change already (I wasn't sure.)
Anyway, yeah, do try and commit it. ANYTHING is better than what's up right now...! :) We'll fix it later if it needs anything.

Really, really -- let's all have fun with Wedge. It's been over 2 weeks now, and it's been a lot of fun already. I can't stop working on it, it's so thrilling to finally be able to get rid of legacy code and add features that have been waiting for so long. And I haven't even got started on converting Noisen features!! ;)

At some point, we'll have to consider posting a working copy of Wedge in private, for our users here. I'm sure they'll appreciate being able to browse through the changes instead of just discussing them. Since we're working on local copies, it won't be updated as often, but it could.
Features / Re: New revs
« on September 11th, 2010, 02:59 PM »
rev 87
! Sending PM and moving topics were broken due to wedgeEditor not being correctly loaded. (MoveTopic.php, Subs-Post.php)
* Renamed install/upgrade_2-0_mysql.sql to install/upgrade_2-0.sql, to match the 1.1 branch files. (install.php, upgrade.php, *.sql)
Features / Re: New revs
« on September 11th, 2010, 09:05 AM »
rev 86
* Updating to SMF rev 10101. Parenthenazi kills SD.
 ! fetch_web_data didn't properly parse ports (Subs-Package.php)
 ! constructPageIndex didn't respect flexible start for compact pagination (Subs.php)

(Yikes, I felt dirty committing this, even though the fixes were made by the reporters, not the committers... They're giving commit access to SlammedDime, after what he did to the team's rep?! Woohoo... And vbgamer45 made his first commit in something like *4 months*, to backport that fetch_web_data fix which isn't even perfect but... :P)

! Minor optimisation for participation icons (Recent.php) <--------- Hey, that was my find :P Thief! :lol:
Features / Re: New revs
« on September 11th, 2010, 01:26 AM »
rev 82
* If modder forgets to put empty quotes at the beginning of a smf_db_query call, let's fix it for them. Dunno if it could be useful. Just felt like it. (Subs-Database.php)
* Cleanup for script.js
- Removed all of the optional parameters in queries, as they were only used by PGSQL and SQlite. (All other files -- please don't make me list them!)

--> Don't bother testing the param stuff Pete, there are about 75 occurrences and I checked them all, one by one. (Automatic search & replace so it was unlikely to fail anyway.)
Features / Re: New revs
« on September 11th, 2010, 12:26 AM »
rev 81
* Uninteresting code cleanup and optimizations. (Class-Editor.php, Load.php, index.css, script.js)
! replaceText() could fail on Opera if run on a message without any carriage return. (script.js)
! Post editor smileys and bbcode buttons would fail on Opera < 10.5 and IE 6-8 because setting innerHTML or outerHTML on an object with dynamic events will reset the event list in these browsers. (script.js)
Features / Re: New revs
« on September 10th, 2010, 09:35 PM »
Yeah, I have a SVN and a SVN_2 folder to make my diff patches for SMF, and a SVN and SVN_all folder for Wedge, although it's a bit different (SVN is a shortcut to trunk, so I can't diff patch between the two, I have to specify SVN_all/trunk and it's boring... :P)
If I could find a way to automate the entire process, that'd be swell... Retrieve rev number in SVN folder, update SVN2 to that rev, then update SVN to latest rev. If different, generate a patch, with name "dev-CURRENT_REV.diff". Make coffee, too.
Features / Re: New revs
« on September 10th, 2010, 09:27 PM »
Yeah... ;) I actually considered changing the text to say some other thing, but then I decided against it, as I like chocobos, too :P Had it been a Pokémon reference, I would have changed it haha.

Good to see you're reading every fucking borin' line of my stuff!
How do you do it? I mean, I do it too, but sometimes when there are too many changes, I have to take a few minutes to build a diff patch out so I can read more comfortably instead of checking out the log and having to watch the changes file by file...