Wedge

rev 381

* Modified the php bbcode to use a proper html tag (code), and applied the same styling as with the code bbcode. The only thing missing is the "select" text, but it's not like anyone complained about its lack so far. (install.sql, index.css)

Forgot to add to the changelog that I've also changed the font size from "x-small" (which is apparently 7.5pt) to "8pt"... I don't know what "x-small" is supposed to fix, but I know that it's very small in Opera and makes it hard to read proper code. If you don't want to make it readable -- attach it as a zip file or something :lol:

rev 374

+ Added support for topic subscriptions to the RSS feed feature. (Feed.php)
* Save some time on each request by caching the value of $_REQUEST['action']. (index.php)
! A preg_replace's second parameter is a proper PHP string, it doesn't follow the regex engine's twisted rules. ;) (Class-String.php)
- SMF bug: A few queries are overly complicated, because $board is already taken into account in $query_this, and they're still testing for it. (Feed.php)
! SMF bug: cdata_parse() is a byte-aware function, as opposed to char-aware, so westr::substr would find full entities instead of just an ampersang, resulting in an infinite loop. (Feed.php)

A few things to note:
- Is it a SMF bug or a Class-String.php bug? I'm thinking SMF bug, very strongly, because $smcFunc['substr'] does indeed attempt to get full entities as a single character, but I'm not fluent on the conversion work and maybe they use an alternate codepath in some cases and these cases weren't taken into account properly? I don't know. Warrants another check!
- Seriously, why didn't anyone cache the $_REQUEST['action'] in all these years...? :lol:
- The per-topic RSS feed doesn't take unapproved posts into account. Could you look into that, Pete? After implementing that feature AND fixing the cdata_parse() function, let's just say I'm not too excited to look into Feed.php even for an extra minute ;)
- The $board optimization in queries is a last-minute fix. I tested it on my local install, but I don't have "hidden" boards or anything, but I don't think they'd be related to that anyway. Seriously, another waste of CPU cycles to me...

rev 375

! SMF bug: using PHP syntax to add a string (w00t!), and making that string an unknown variable... Assuming they mean this.opt.sUniqueId. It's a wonder this doesn't even throw an error, but it's still a nasty one. (editor.js)
! Nao bug: unknown variable in smfSelectText(). Oops. (editor.js)
- We don't need to deal with window.event in events that are initialized through jQuery. (script.js)
* Finishing the JSLint-induced changes. Most notably, adding semicolons at the end of prototype definitions. This should make it possible to compress files through Packer without the need for an extra pass of semicolon checks (see QueryString.php). Also, I didn't bother with the ==/=== suggested changes. Not confident enough in SMF's code strictness in that particular area. Finally, removed many unused variables. (admin.js, captcha.js, editor.js, profile.js, register.js, script.js, sha1.js, spellcheck.js, stats.js, suggest.js, topic.js)

rev 368

! Fixed BBC button layout in IE6. (ie6.css)

rev 365

* Moved storeCaret() to the footer, and made sure only IE runs it. Because only IE needs it... (Class-Editor.php)
* Made sure that the Quick Reply toggle text isn't selectable, and moved its JS call to the footer. (Display.template.php)
* Some tweaks in IE7... (ie7.css)
* ...And some other general CSS tweaks. (index.css)
- postAttachment3 doesn't exist... Does it? (index.css, rtl.css, Post.template.php)
* Replaced a few hardcoded input box sizes with CSS. Thanks live627! (Post.template.php)
* Missing capitals in a few entries. (Admin.english.php, Admin.french.php)
* Spacinazi. (Display.template.php, Post.template.php)
- What's the point in calling init() at the end of some object constructors, when we could just stay in these functions? (editor.js, topic.js)
+ Added animation effects in Quick Reply (opening, closing and switching to Wysiwyg), and started conversion to jQuery. (topic.js)
* The More Options area in the post template should be hidden immediately when collapsed, instead of triggering the relatively lengthy animation. (Post.template.php)
* Optimized spell-check JS and converted it to jQuery. (spellcheck.js)

Good luck for having a look at it all, Pete... My changes are sometimes a bit complicated -- but hopefully not buggy!!

So I'm working on suggest.js instead. :P

rev 360

* More jQuery optimization. Simplified help frame to avoid storing a variable in memory just for that. (script.js, Help.template.php, Register.template.php)
* Made submitThisOnce() work on Safari 3.0+, because the comment indicates the hack is for v1.3 beta... Logic dictates that recent builds should work fine. (script.js)
* Moved array_search() to editor.js, as it was only used over there. (editor.js, script.js)
* Spacinazi. (Subs.php, script.js)

rev 358

* Modified the menu system to turn it into a pure CSS menu when Javascript is not available. Oh yes. (index.css, script.js, GenericMenu.template.php, index.template.php)
* Changed toggle class animation to make it slide up and down, instead of shrink and fade. This should be a bit better for performance, and accomodate for weirder layouts, if ever needed. (script.js)
! Fixed remaining chars counter in the 'more' tag, to take multi-byte chars into account. Also, don't bother showing anything if the tag was put at the end of the message. (Subs.php)
! Fixed many CSS bugs in the main menu implementation for IE6 and IE7. (ie6.css, ie7.css)
* Couple of translation tweaks. (Admin.french.php)
* More jQuery conversion work... Errr... Just turned a 5-line loop into a 2-line parentsUntil() chain. So what. It's a cool geeky instruction. (script.js)
- Removed a 'move' bbcode leftover. Thanks Pete! (Post.template.php)

Ah... Finally done with that commit... -_-

rev 356

* Too bad jQuery doesn't support the pageshow event... Still, moving that to the footer. (Post.template.php)
- Replaced event listeners with jQuery's implementation. (register.js, topic.js)
* Replaced XMLHttpRequest tests with a can_ajax variable, and removed all tmpMethod hacks. The Themes template still has a different hack that needs to go. (upgrade.php, TEMPLATES: Display, MessageIndex, Packages, Search, SplitTopics, Themes, register.js, stats.js, suggest.js, topic.js)
* Style file inputs to get a default width of 300px. (index.css, Packages.template.php)
* Replaced Comic Sans MS with Segoe UI. Yeah, Comic is a popular font, but it doesn't make me laugh. That would actually be the opposite... Also replaced the ugly Courier with Courier New, and deleted an extra, unused copy of the font list from the script file. (Class-Editor.php, editor.js)
* Made main menu code faster, and saved an awful lot of code, too. (script.js)
* Been slightly more aggressive when minifying CSS... Saves a few bytes per file. (Subs.php)
* Renamed is_ie9 JS var to is_ie9up, as it's really what it does now... (script.js)
- getMousePosition() was no longer needed, as its task is already fulfilled by jQuery. (editor.js)
* The 'more' bbcode tag was hardcoded. I know it's not finished yet (add button, etc..?), but it still needed to get its own class and translations. (Subs.php, index.css, index.english.php, index.french.php)
@ Discuss: Shouldn't parse_bbc use UTF8-safe strlen/substr functions everywhere..?
@ Note for later: IE6 doesn't like $('<input>', { object }). Whatever they say on the web... It doesn't. It has to be fully formed in the HTML portion.