Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
9721
Features / Re: Recycling board by default
« on February 14th, 2011, 07:16 PM »
Quote from Arantor on January 28th, 2011, 11:01 PM
In that case, how about we get funky and make the recycled board 0 (since there's no technical reason I'm aware of that prevents it)?
I just looked into that.
I replaced with 0, and it said "duplicate primary key 1"; basically, MySQL considered the '0' to be '1'.
I could make sure it accepts 0, but then I get this warning:
http://dev.mysql.com/doc/refman/5.0/en/server-sql-mode.html#sqlmode_no_auto_value_on_zero
Basically, they don't recommend using 0 as a valid value.

What do you think...?
Quote
Or, failing that, 65535 and reset the board id back to 2 thereafter.
Is 65535 the maximum value? I hope it isn't, if we want users to be able to create their own blogs on a board... :P
9722
Features / Re: New revs
« on February 14th, 2011, 05:37 PM »
I think it's the first time I see you commit commented out code... Hang in there!

rev 589
(5 files, 13kb)

! Fixed CSS not showing up in the installer if the forum is installed in a sub-folder. Hopefully. (install.php)
* Moved censorText() to a more logical place. Again -- hopefully. (Load.php, Subs-BBC.php)
+ Added separators to the internal PM menu. (PersonalMessage.php)
! Fixed various obvious bad translations in the installer. Okay, what did I do during these two months I spent on fixing these files? Did someone throw them away or was I just that careless? (Install.french.php)

PS: Another commit coming up... Just sorting out the files for now. Also, I'm not too sure about that code I added in install.php... I think I should instead change Subs-Cache.php to return "cache/" instead of $boardurl . "/" when $boardurl is empty... That'd probably make more sense. The only reason I didn't do it is that it's unlikely $boardurl isn't set when the forum is installed. Meaning it just wastes a CPU cycle for nothing...
9723
Features / Re: New revs
« on February 13th, 2011, 05:32 PM »
rev 587
(3 files + 2 added, 157kb) (nothing changed really... Only renamed "permute()" to "bbc_permute()" to avoid potential conflicts in function names.)

+ Added Subs-Cache file, that includes all of the code for caching regular data, CSS and JS, thus off-loading Subs.php, Load.php and QueryString.php. (Load.php, QueryString.php, Subs-Cache.php, Subs.php)
+ Added Subs-BBC file, that includes all of the code for parsing BBCode, thus off-loading Subs.php, and... that's all. It's already a lot. (Subs-BBC.php, Subs.php)
* Moved match_cidr() to the IP function area. (Subs.php)
9724
Features / Re: New revs
« on February 13th, 2011, 01:08 PM »
rev 586
(5 files, 10kb)

+ Added separators to the profile menu. (Profile.php)
! The duplicate separator removal code was buggy. Rewrote it from scratch. (Subs-Menu.php, GenericMenu.template.php)
! Don't show top_template items in Ajax mode. (Subs.php)
! Fixed missing parens in a dynamic function. (ManageMail.php)
9725
Features / Re: New revs
« on February 13th, 2011, 12:12 AM »
rev 584
(1 file, 7kb)

! Fixed CSS parser bug where multiple selectors were given a same base (".class1, .class2 { base: .class }") and only the last one would correctly reflect that. (Class-CSS.php)
* Optimized inheritance parser to avoid running dozens of preg_replace's. (Class-CSS.php)
! Fixed handling of the 'final' keyword for finalized selectors' children. (Class-CSS.php)
! Fixed potential false positives when parsing selectors starting with an alphanumeric character. (e.g. a tag name) (Class-CSS.php)

@ Note: found another bug, will fix tomorrow... $this->getAncestorSelectors($this->rules[$node['parent']]['parent'])...? How does that work anyway? The function is expecting a node but it returns an ID. This works only if all cases where the selector is a root one.
Posted: February 12th, 2011, 11:50 PM

rev 585
(2 files, 5kb)

! Fixed extended selectors not applied correctly when they are themselves children of another selector. (Class-CSS.php)
* Spacinazi. (Warm/admin.css)

(Sorry for the last minute commit. I really didn't notice the bug until I reviewed the code for commit.)
9726
Features / Re: New revs
« on February 12th, 2011, 11:18 PM »
rev 583
(11 files, 15kb)

+ Added support for $context['top_template'], which holds the secondary menus and tab buttons, and is protected from overwrites. (Load.php, Subs-Menu.php, Subs.php)
- Removed $settings['catch_action']. Seriously, it's totally undocumented, I couldn't find any mod using it, and we're pushing for the use of hooks anyway. And there's a hook that does exactly the same task. (index.php, Themes.php)
! Another fix for user agents not specifying the type of contents they accept. (QueryString.php)
* Tweaked sub_template handling. (Errors.php, Load.php, Profile.php, Security.php)
! Fixed an undefined index error that you'll never get anyway. (GenericMenu.template.php)
! Fixed XHTML Mobile 1.0 validation. (Wireless.template.php)
9727
Features / Re: New revs
« on February 12th, 2011, 07:18 PM »
rev 582
(85 files, 83kb) (phew...)

* Important for modders -- $context['sub_template'] = $template has now become a function, showSubTemplate($template), which will automatically manage multiple sub-templates and sidebar sub-templates (showSubTemplate($template, 'sidebar')). (Activate.php, Admin.php, Announce.php, BoardIndex.php, Calendar.php, CoppaForm.php, Credits.php, Display.php, Findmember.php, Groups.php, Help.php, Jseditor.php, JSModify.php, Load.php, Login.php, Login2.php, ManageAttachments.php, ManageBans.php, ManageBoards.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMaintenance.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManagePosts.php, ManageRegistration.php, ManageScheduledTasks.php, ManageSearch.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, Memberlist.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Notify.php, PackageGet.php, Packages.php, PersonalMessage.php, Post.php, PostModeration.php, Profile-Actions.php, Profile-Modify.php, Profile-View.php, Profile.php, QuoteFast.php, Register.php, Reminder.php, RepairBoards.php, Reports.php, Reporttm.php, Search2.php, Security.php, SendTopic.php, Spellcheck.php, SplitTopics.php, Stats.php, Subs-Auth.php, Subs-Menu.php, Subs-Package.php, Subs.php, Suggest.php, Themes.php, Unread.php, Unreadreplies.php, VerificationCode.php, Xmlhttp.php)
* Rewrote menu system to use regular sub-templates rather than template layers, and allow putting them inside the sidebar flow. Still a bit buggy when it comes to tabs, though. (Subs-Menu.php, GenericMenu.template.php)
* I've always hated empty lines with tabs in source code. Yikes. (Profile.template.php)
* Simplified some CSS related to earlier implementations of the profile/admin sidebars, and made use of media queries instead of conditional refitting. (ie6.css, index.css, rtl.css, sections.css, Warm/ie6.css, Warm/index.css, Warm/rtl.css, Warm/sections.css)
- Removed #context .custom_field hack, as I couldn't find any issue with these in IE6 and Opera. (sections.css, Warm/sections.css)
- Removed support for old-style tabs, as pre-SMF2 themes aren't compatible with Wedge anyway. (GenericMenu.template.php, Recent.template.php, Reports.template.php)

@ Note: WrapAction() in Themes.php... Shouldn't this be removed, now that a hook caters for that?
@ Note: remove .left_menu and .side_section classes?
9728
Features / Re: New revs
« on February 11th, 2011, 09:21 PM »
rev 581
(13 files, 15kb)

* Renamed obfuscate_js back to obfuscate_filenames, as CSS filenames are now obfuscated just the same time as JS files. (install.php, ManageServer.php, QueryString.php, Help.english.php, Help.french.php, ManageSettings.english.php, ManageSettings.french.php)
* Restored alternating backgrounds in the board list, only horizontally this time... Not that I find this more exciting... Just wanna find out which is best. (BoardIndex.template.php)
! Toggle icon padding was incorrect in the news fader. (Warm/sections.css)
* Replaced toggle icons with way sexier ones (modified FamFam). Don't thank me. (collapse.gif, expand.gif)
* Prevent double-clicking the toggle icons. (script.js)
* Maintenance area was flooded with cat bars. Seriously, title bars are the way to go here. (ManageMaintenance.template.php)
9729
Features / Re: New revs
« on February 11th, 2011, 08:11 PM »
rev 579
(7 files, 13kb)

+ Added 'final' keyword to selectors, allowing to forbid another selector from inheriting a specific selector through the extends/base system. (Class-CSS.php, Subs.php, Warm/index.css)
* Tweaked header and reverted the order in which the user box and logo show up. Also did plenty of small tweaks to Warm based on user feedback. Thanks everyone! (css/index.css, Warm/index.css, index.template.php)
- Reverted <we:logo> code. I really felt it wasn't the right way to do it. (Load.php, Subs.php, css/settings.xml)

Note to Pete: I rewrote the 'final' code, as I wanted. Now it correctly cancels inheritance for nested selectors when the 'final' keyword is on a child, non-inherited level. If that means anything to you :P
Posted: February 11th, 2011, 07:46 PM

rev 580
(3 files, 9kb)

+ Added a short and sweet drag'n'drop function. Well, just the 'drag' part, but it's all I wanted anyway. (script.js)
+ Added ability to prevent an object from being dragged, by assigning the 'nodrag' class to it. (script.js, Help.template.php, Errors.template.php)
* Avoid initializing a HTML document if we're just coming through Ajax... (Errors.template.php)
- Removed all optimizations related to local variable/function names, because Parser supports them anyway. And if you're not using Parser, it means you don't care about filesize anyway... (script.js)
9730
Off-topic / Re: Restoring my love with iDevices
« on February 10th, 2011, 01:33 PM »
What's Bookworm?
Does it have a French dictionary? ::)
9731
Off-topic / Re: Restoring my love with iDevices
« on February 10th, 2011, 12:04 PM »
99% of the time, when I launch an iPod game, its name starts with "Scrab" and ends with "ble™".

Oh, I finished Chaos Rings, too. Was a really nice one.
9732
Features / Re: New revs
« on February 10th, 2011, 10:52 AM »
rev 578
(4 files, 10kb)

+ Added <we:logo>, a placeholder for putting your own text and logo and styling it like you want. It's totally uncool. Punish me, master. Or at least revert. (Load.php, Subs.php, css/settings.xml, index.template.php)
! Fixed a bug in the CSS parser introduced in rev 577. Just needed to replace $files with $css. (Subs.php)

(I've never hated more a commit of mine than this one, so you've been warned. Still, if we can't make this kind of thing, then we might as well immediately drop the idea of integrating Tox-G in the future.)
9733
Features / Re: New revs
« on February 10th, 2011, 09:56 AM »
rev 577
(5 files, 12kb)

+ Added ability to compress and cache more CSS files that aren't in the base set. (QueryString.php, Subs.php)
! Fixed installer to properly compress and cache JS and CSS. At last. No animals were harmed during the fixing of this bug. Several gigabytes of data, though, were savagely killed on my test bed because I forgot to set a value for $cachedir. (install.php)
! Fixed Wireless template to use nested CSS. (Wireless.template.php)
- The script tag doesn't need a type for JavaScript. Forgot that one line. (index.template.php)

Note: Should we remove $is_direct_url from add_css_file and add_js_file? It sounds to me like it's a legacy option...
9734
Features / Re: New revs
« on February 9th, 2011, 03:43 PM »
rev 576
(5 files, 8kb)

* Saved another tenth of a second at CSS compilation time, by replacing a preg_replace_eval with a preg_replace_callback. Seriously, for a single instruction to take a tenth of a second... That's crazy. (Class-CSS.php)
! Mixin declarations would fail if they only a single-line 'function'. (Class-CSS.php)
! Mixin declarations should stop at the first line that has a shorter indentation than the first line of the 'function', rather than the first empty new line. That should teach you to behave. (Class-CSS.php)
! Fixed a missing overflow in Pastel. (css/index.css)
! IE6 was behaving badly in Warm because I forgot to update one of its hacks. (Warm/ie6.css)
* More tweaking to the Warm layout and colors. (Warm/index.css)
* The theme picker could use a visible title, really. (Themes.template.php)

NB: I'm currently playing with drag & drop, trying to make my routine as small as possible, and compatible with position:fixed (which represents most of the difficulty in this exercise.) Still, it's a funny thing to implement, and I need it for our future Highslide replacement.
9735
Features / Re: New revs
« on February 8th, 2011, 11:34 PM »
rev 575
(9 files + 1 addition, ~10kb)

* Did some serious reworking of the header area. As always, it's a WIP, so feel free to share your ideas to improve on it (or just revert to what it was before.) Haven't tested in Pastel, I'm sure it'll be fun to see how broken it is. (index.template.php, Warm/index.css, images/theme/bg.jpg)
* Rewrote the cat bar and title bar to something else. Me likey.
- Don't waste time and bandwidth showing a clickable link on categories. They already have a collapse button next to them, that should be enough. Who uses collapsing anyway? (Subs-BoardIndex.php)
* Don't use windowbg overrides in the board list. Too many colors can kill the fun, really. (BoardIndex.template.php)
- Don't show the website's name next to "Info Center". The website's name is already in big large letters in the header. What's the point. (BoardIndexInfoCenter.template.php, index.english.php, index.french.php)
* The Search icon in the menu is off by one pixel. Or am I crazy? (Warm/index.css)
! Fixed issues with the channels() function. (Class-CSS.php)
+ Added ability to group properties together if they have the same value, e.g. "height, line-height: 20px". (Class-CSS.php, Warm/index.css)
* Various CSS tweaks. (Warm/index.css, Warm/sections.css, BoardIndexInfoCenter.template.php)

I'm expecting your feedback on the design tweaks, Pete! (And Bloc, maybe...?)
Not too happy with the part that prints the website's name, but the rest, I'm a bit happier with than with the earlier versions. And it's hard to please me really...