Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
9691
Features / Re: New revs
« on February 18th, 2011, 04:46 PM »
rev 602
(23 files, 167kb, plenty of search & replace but also plenty of manual fixing :P)
* Converted all remaining stylings to the new simplified CSS syntax. (styles/*)
! The clean_cache() function systematically deleted all files from the cache. As it is called by a scheduled task, added a parameter to prevent deleting CSS and JS files when they don't need it. They're still purged when going to the admin area and changing a file compression/obfuscation setting. (Subs-Cache.php)
! Typo in Pastel. (mad-width, ahah, that one should be standard.) (styles/index.css)
@ Moved Green stylings by mistake. Will move them back later... Don't want to screw up my svn copy again.
(23 files, 167kb, plenty of search & replace but also plenty of manual fixing :P)
* Converted all remaining stylings to the new simplified CSS syntax. (styles/*)
! The clean_cache() function systematically deleted all files from the cache. As it is called by a scheduled task, added a parameter to prevent deleting CSS and JS files when they don't need it. They're still purged when going to the admin area and changing a file compression/obfuscation setting. (Subs-Cache.php)
! Typo in Pastel. (mad-width, ahah, that one should be standard.) (styles/index.css)
@ Moved Green stylings by mistake. Will move them back later... Don't want to screw up my svn copy again.
9692
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 17th, 2011, 11:38 PM »I think we do, as a structure. The key thing for me is that we create the situation where, by default, a post being deleted is not permanent. It *can* be made to be default that a post being deleted is permanent, but that the default is a soft delete.
However, if soft deletes are default, then I think it should be associated with enabling post moderation -- so it should be enabled by default. IIRC if post moderation (core features) is disabled, SMF/Wedge don't check for the is_approved bit. We'd need to check it everytime because we'll probably use is_approved to store the state (unapproved/approved/deleted).
Okay I should probably check the actual code before I say things like that ahah...
Replacement for the delete button when the post is deleted, or if the admin so desires, replacing it normally. But the default should be to replace it in deleted mode.
Not yet, I felt like hell and went back to bed, only just got back up, just in time to do chores.
In the meantime I've converted all of the stylings to the simple css syntax. Phew! It was a bit nightmarish... It's not perfect and it's untested, so I'll probably wait until tomorrow to commit, but at least it's done. Means I can really move Warm to be the default...
Also, how do we display a deleted topic?
Either we don't show anything, and do it only in the admin area, or we show the deleted topic link only for admins but in the message index itself, or we show the 'deleted by...' mention for everyone. Red background probably ain't too good when you just say "deleted" without linking, btw (same for showing a "message deleted" mention inside topics for non-admins. Should be a bit grayish or something I guess...)
.approvebg, things like that... There are different background colors available for the message index. We just need to add a new one for deleted topics.
Topics also have a is_approved flag IIRC. (Or they use the one for the very first post. Either way, it shouldn't be a performance issue to have this.)
9693
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 17th, 2011, 04:56 PM »
So... Do we agree on getting rid of the recycle bin? Or do you want to keep it (just not with a recycle board added by default...)
Permdel: do you mean alongside the regular Delete button, or as replacement for the Delete button when the post is in Deleted mode? Second one, right?
Did you have a look at my WarmWine BTW? What do you think? You can compare the two easily. I'm planning to set Warm as the default styling soon, so I'll need to have the child stylings be based upon Warm rather than Pastel... Is it okay or not? The main difference is in the padding in the header, as well as the menu font. (I think I prefer Verdana, when I compare the two... But I prefer Tahoma for the div that pops up.)
I also just noticed that WarmWine is buggy in IE6: the menu popups don't show at all... That's probably due to the shiv showing up in front of the actual popup. Uh >_<
Permdel: do you mean alongside the regular Delete button, or as replacement for the Delete button when the post is in Deleted mode? Second one, right?
Did you have a look at my WarmWine BTW? What do you think? You can compare the two easily. I'm planning to set Warm as the default styling soon, so I'll need to have the child stylings be based upon Warm rather than Pastel... Is it okay or not? The main difference is in the padding in the header, as well as the menu font. (I think I prefer Verdana, when I compare the two... But I prefer Tahoma for the div that pops up.)
I also just noticed that WarmWine is buggy in IE6: the menu popups don't show at all... That's probably due to the shiv showing up in front of the actual popup. Uh >_<
9694
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 17th, 2011, 12:23 PM »
We also need to determine if regular users see a "This comment was deleted by a moderator/by its author" (like on imdb.com for instance) or just don't see the message at all...
I'd vote for showing them, because then we can keep the same page numbering for topics. (i.e. as long as a post isn't completely deleted, the start variable will bring you to the exact same list of posts in a page.)
I'd vote for showing them, because then we can keep the same page numbering for topics. (i.e. as long as a post isn't completely deleted, the start variable will bring you to the exact same list of posts in a page.)
9695
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 17th, 2011, 12:07 PM »
Different backgrounds should do the trick really...
Something like,
Blue: unapproved
Gray: ignored
Red: deleted
Something like,
Blue: unapproved
Gray: ignored
Red: deleted
9696
Features / Re: New revs
« on February 17th, 2011, 11:48 AM »
rev 601
(3 files + 6 added, 22kb)
+ Added WarmWine (temp name of course), a child styling for Warm that basically reproduces the original Wine. There are a few differences but mainly in padding and stuff. (Warm/Wine/*)
! is_ipv4() wasn't using the given parameter. (QueryString.php)
! A better fix for the infinite loop in add_css_file(). (Subs-Cache.php, install.php)
(3 files + 6 added, 22kb)
+ Added WarmWine (temp name of course), a child styling for Warm that basically reproduces the original Wine. There are a few differences but mainly in padding and stuff. (Warm/Wine/*)
! is_ipv4() wasn't using the given parameter. (QueryString.php)
! A better fix for the infinite loop in add_css_file(). (Subs-Cache.php, install.php)
9697
Plugins / Re: Wedge + SMF Mods
« on February 16th, 2011, 11:44 PM »
- File removal: none. If you don't want the features, don't use them. If you don't want the files, delete them manually (like, icon sets, etc.), if there's anything else that can't be deleted and you absolutely want it out, either edit the code, or just use SMF because we don't want to deal with weird people like you :P
- Aeva Media: it'll be in Wedge, 100% certain. That's the reason I stopped developing it for SMF. Also, I already spent a lot of time converting the code to Wedge, it's not done yet, I don't think I'm even halfway through it but it'll be completed eventually. And yes the idea is to get rid of regular attachments and replace them with media items. (Possibly for avatars, too -- allowing us to have several avatar sizes.)
- Highslide: it's a definite no-no to me. I've already settled on using something else, really. Probably Colorbox. I've written the drag'n'drop code, remember? Because that's the only feature that is in Highslide and in no other Lightbox, and the only reason why I chose Highslide over the rest originally... Plus, Colorbox is lighter (not if you add jQuery to it, but obviously jQuery is ALWAYS loaded, so...)
Too many posts, too many things to say, too little time! Hope I answered your questions.
- Aeva Media: it'll be in Wedge, 100% certain. That's the reason I stopped developing it for SMF. Also, I already spent a lot of time converting the code to Wedge, it's not done yet, I don't think I'm even halfway through it but it'll be completed eventually. And yes the idea is to get rid of regular attachments and replace them with media items. (Possibly for avatars, too -- allowing us to have several avatar sizes.)
- Highslide: it's a definite no-no to me. I've already settled on using something else, really. Probably Colorbox. I've written the drag'n'drop code, remember? Because that's the only feature that is in Highslide and in no other Lightbox, and the only reason why I chose Highslide over the rest originally... Plus, Colorbox is lighter (not if you add jQuery to it, but obviously jQuery is ALWAYS loaded, so...)
Too many posts, too many things to say, too little time! Hope I answered your questions.
9698
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 16th, 2011, 11:39 PM »
Grmpf... I like their "Deletion Type" UI.
Pete, if you want to vote for non-inline, you can still do it eh ;)
Plus, it's hard to determine common grounds based on half a dozen votes, see what I mean?
Pete, if you want to vote for non-inline, you can still do it eh ;)
Plus, it's hard to determine common grounds based on half a dozen votes, see what I mean?
9699
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 16th, 2011, 05:40 PM »I think inline is going to compete with moderated, and if I have a spam post that was moderated, I don't want it just to change colour :P
Or you could for instance, as I suggested, hold the Shift key when clicking 'Delete', and JavaScript will catch this and tell Wedge that you want to do an immediate and definitive delete ;)
9700
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 16th, 2011, 10:54 AM »
It's more of a style concern than UI issue right..?
BTW I added a poll yesterday, if you guys want to simply vote your preference without defending it.
BTW I added a poll yesterday, if you guys want to simply vote your preference without defending it.
9701
Features / Re: New revs
« on February 16th, 2011, 12:18 AM »
rev 598
(3 files, 11kb)
! Added a child div in the sidebar to account for a Chrome bug in "display: table-cell" blocks... Yay... (index.template.php, Warm/index.css)
! Fixed outdated JS code for the auto-resizer. Now it should correctly hide the sidebar before it starts doing crazy things. (index.template.php)
* Minor padding/margin/width tweaking in the sidebar. (index.css, Warm/index.css)
(3 files, 11kb)
! Added a child div in the sidebar to account for a Chrome bug in "display: table-cell" blocks... Yay... (index.template.php, Warm/index.css)
! Fixed outdated JS code for the auto-resizer. Now it should correctly hide the sidebar before it starts doing crazy things. (index.template.php)
* Minor padding/margin/width tweaking in the sidebar. (index.css, Warm/index.css)
9702
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 15th, 2011, 09:56 PM »
Interesting ideas from you both.
9703
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 15th, 2011, 07:44 PM »
Shift+del equivalent? ;)
9704
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on February 15th, 2011, 05:59 PM »
The question was about the Recycle Bin.
Pete thinks that it's best to create it by default, so that it's easier to find etc.
I think that we should drop the recycle bin and replace it with inline deletion --- i.e. if you delete a post, it shows up in the original topic, or if you delete a topic it shows up in the original board, only with a different color (also different from the "unapproved" color obviously), and only for those who can view them (original authors, admins). With the ability to restore them.
Well, that's my opinion but since we happen to disagree on UI matters, I think it can only be settled by checking for everyone else's opinion ;)
Pete thinks that it's best to create it by default, so that it's easier to find etc.
I think that we should drop the recycle bin and replace it with inline deletion --- i.e. if you delete a post, it shows up in the original topic, or if you delete a topic it shows up in the original board, only with a different color (also different from the "unapproved" color obviously), and only for those who can view them (original authors, admins). With the ability to restore them.
Well, that's my opinion but since we happen to disagree on UI matters, I think it can only be settled by checking for everyone else's opinion ;)
9705
Features / Re: New revs
« on February 15th, 2011, 01:32 PM »
rev 593
(22 files, 23kb)
* Modified add_css_file() to use less parameters, allow for extension-less filenames and get files from the current styling, or their closest parent if unavailable. (install.php, Subs-Cache.php, Packages.template.php, Reports.template.php, Wireless.template.php, Xml.template.php)
* Renamed 'css' folder to 'styles', and updated related code. Haven't done it on the SVN yet to make it easier to spot changes, the actual renaming will be in the next commit. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, ManageBoards.template.php, Themes.template.php, */settings.xml, */index.css)
! The Bad Behavior code was using $context['html_headers'] at some point, instead of $context['http_headers']. (Security.php)
rev 594
(n/a)
* Renamed css folder to styles.
rev 595
(n/a)
+ Added .htaccess files to styling folders, preventing reading the CSS files for regular users. I may be paranoid, but no an android.
(Currently fighting with a tree conflict... Did 'rename' on my css folder, then committed and forgot to update it BEFORE committing, which is never mentioning anywhere... Because of that, I can't even touch my work folder anymore, I have to work from a clean folder. Grrr...)
rev 596
(n/a)
+ Cleaning up my SVN... Committing two files that I thought I'd committed before: the actual button bevel (3D effect), and the script folder protection. (images/theme/bevel.png, scripts/.htaccess)
(Okay, I think my SVN is good now... Phew. I had to manually edit my SVN files, ah ah.)
rev 597
(2 files, 4kb)
- Removed legacy PHP code. (install.php)
! Fixed wrong param number in preg_match_all. (Security.php)
(22 files, 23kb)
* Modified add_css_file() to use less parameters, allow for extension-less filenames and get files from the current styling, or their closest parent if unavailable. (install.php, Subs-Cache.php, Packages.template.php, Reports.template.php, Wireless.template.php, Xml.template.php)
* Renamed 'css' folder to 'styles', and updated related code. Haven't done it on the SVN yet to make it easier to spot changes, the actual renaming will be in the next commit. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, ManageBoards.template.php, Themes.template.php, */settings.xml, */index.css)
! The Bad Behavior code was using $context['html_headers'] at some point, instead of $context['http_headers']. (Security.php)
Posted: February 15th, 2011, 11:13 AM
rev 594
(n/a)
* Renamed css folder to styles.
Posted: February 15th, 2011, 11:27 AM
rev 595
(n/a)
+ Added .htaccess files to styling folders, preventing reading the CSS files for regular users. I may be paranoid, but no an android.
(Currently fighting with a tree conflict... Did 'rename' on my css folder, then committed and forgot to update it BEFORE committing, which is never mentioning anywhere... Because of that, I can't even touch my work folder anymore, I have to work from a clean folder. Grrr...)
Posted: February 15th, 2011, 11:36 AM
rev 596
(n/a)
+ Cleaning up my SVN... Committing two files that I thought I'd committed before: the actual button bevel (3D effect), and the script folder protection. (images/theme/bevel.png, scripts/.htaccess)
(Okay, I think my SVN is good now... Phew. I had to manually edit my SVN files, ah ah.)
Posted: February 15th, 2011, 12:10 PM
rev 597
(2 files, 4kb)
- Removed legacy PHP code. (install.php)
! Fixed wrong param number in preg_match_all. (Security.php)