Wedge

Good. Because I could always add a shortcut to that somewhere but i prefer a menu link to begin with. :)

rev 958
(7 files, 12kb)

* Painstakingly rewrote the skin list function (in the Profile area) to fix a logic flaw. Add-type skins are now listed relative to their parent skin, and replace-type skins are listed on the top level, just like the root skin. (Themes.php, Themes.template.php)

* Tweaked language files to make a clearer statement about choosing the default skin when you choose a theme rather than a specific skin. (Themes.language.php)

- The skin list function was still avoiding the 'cache' folder, which was a remnant from the original skin system implementation... (Themes.php)

* Moved the menu toggler to the left of the menu -- where it makes a lot more sense having... (index.css, index.rtl.css)

* Number of theme users now uses number_context. (Themes.template.php, Themes.language.php)

* May not be necessary at all, but I ensured eAccelerator and other cache systems aren't detected if their 'put' function is detected but not callable. Consider it an extra safety. (ManageServer.php)

@ Minor issue with skins (as seen above): if the admin sets the guest skin (i.e. the default) to something else than the root skin, the thumbnail will still show the root skin. May have to change that, but there is only one default skin per website and there may be multiple themes... Dunno what's best. Any ideas...?

rev 957
(1 file, 5kb)

! Although newer Firefox versions seem to force resizing handles on smileys in Wysiwyg mode, we can *at least* convert these back to real smileys when saving, regardless of whatever dimensions are forced in. (Class-Editor.php)

@ Note: this doesn't seem to happen in SMF, so it was a bug in my earlier smiley rewrite.

Makes sense. Although the opposite does as well :P

Logging in with e-mail addresses may feel slightly more 'natural' to people these days, e.g. your login form has 'e-mail address' and 'password', while you may not be sure whether 'user name' may refer to your actual user name or current display name...

Hmm well, I'm not sure anyone bothered until now, though... If it ain't broke...

It's just something about login scrapers.

Hmm... Yes, I suppose it makes a lot of sense regarding forum username scrapers...
I think that'd be a definite yes, even if it adds an option to the profile area.

Unless we ask the user at registration time only...?

Like, we ask for an e-mail address, an account name and a display name. Then we ask the user what they want to use to login.... Errr.... Okay that's a bit overkill... :P

Most 'big' websites allow you to login with either email or username, your choice. How does that help them with scraping...? I suppose it doesn't.

rev 956
(1 file, 3kb)

! Typo in one of the disable_feed replacements. Note for later: have someone actually actively look for issues in our commits, especially late at night, so that we don't have to do it in the morning :P (Media.template.php)

I already discussed that bug elsewhere... It's a good I won't care fixing because the forum will eventually run Wedge anyway...

Re: relative timestamps. I just think "3 days ago" is not enough, it should still add the hour and be done with it. Other than that, perhaps we can save performance by doing a $(window).blur(is_disabled = true) or something, and thus stop the update process when the tab is hidden... In which case I'm okay with having it show by default. (See, I always have at least 150 tabs open... Currently I'm closer to 300 but shh!)