Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
8026
The Pub / Re: Copyrights
« on August 22nd, 2011, 09:19 PM »
It's linked in every file header innit..?
8027
The Pub / Re: Copyrights
« on August 22nd, 2011, 09:05 PM »
We can add a link to it on the webpage for the license.
8028
Off-topic / Re: Aeva Add Sites
« on August 22nd, 2011, 08:06 AM »
What do you think?
There's an embedding board on aeva.noisen.com -- for such requests. AND it says in the description that I'm not adding anything, ANYMORE, hence why that board is closed.
What is it exactly that is unclear to you?
There's an embedding board on aeva.noisen.com -- for such requests. AND it says in the description that I'm not adding anything, ANYMORE, hence why that board is closed.
What is it exactly that is unclear to you?
8029
The Pub / Re: Copyrights
« on August 22nd, 2011, 07:17 AM »
I did see that topic yesterday and thought the SMF team would annoy us.
Still. If they claim they're bsd then they should be satisfied with our method. We have license_smf.txt in the root now, remember?
Still. If they claim they're bsd then they should be satisfied with our method. We have license_smf.txt in the root now, remember?
8031
Features / Re: Login with eMail instead of username
« on August 22nd, 2011, 01:07 AM »
But some do. I suppose.
8032
Features / Re: These two bytes may not matter to you...
« on August 22nd, 2011, 12:59 AM »
I had a post above. Sob.
8033
Features / Re: New revs
« on August 21st, 2011, 04:51 PM »
rev 960
(7 files, 10kb)
* Changed some of the skin values to be set to an empty string by default, meaning it should use the theme's default skin, rather than always the theme's root skin. It's too hot in here to overthink it. (install.sql, Themes.php)
* Micro-optimization and translation tweak. (Admin.php, Themes.french.php)
! When picking a default theme for guests with the theme picker, the pick page was set as being from the profile area, rather than admin area. (Subs.php)
! Background issues on Warm menu in sucky browsers, including Safari Mobile. (Warm/index.css)
* Tweaked font size in main menu to help usability on iOS. (index.iphone.css)
(7 files, 10kb)
* Changed some of the skin values to be set to an empty string by default, meaning it should use the theme's default skin, rather than always the theme's root skin. It's too hot in here to overthink it. (install.sql, Themes.php)
* Micro-optimization and translation tweak. (Admin.php, Themes.french.php)
! When picking a default theme for guests with the theme picker, the pick page was set as being from the profile area, rather than admin area. (Subs.php)
! Background issues on Warm menu in sucky browsers, including Safari Mobile. (Warm/index.css)
* Tweaked font size in main menu to help usability on iOS. (index.iphone.css)
8034
Features / Re: These two bytes may not matter to you...
« on August 21st, 2011, 09:43 AM »Thanks for publishing the license.
I see that it is similar in some respects to the old SMF license, and different too.
(So, basically, the more you help Wedge grow, the faster it gets to a more permissive license :P)
Condition 1.e. is of a very unusual type.
I have read your reasons for these restrictions. I only wish things could have gone differently.
Okay, Pete -- back to the topic... I was looking into the wedge_themes table (the per-theme per-user settings), and noticed that there is a 'skin' variable in theme id = 1. I'm a bit in a hurry and should leave and have been unable to find this for now -- could you look into the code (or anyone with svn access) and tell me where this variable is retrieved and used, exactly...? I'm considering either dropping it, or using it more... :P
8035
Features / Re: New revs - Public comments
« on August 21st, 2011, 09:37 AM »
I've found the thing that doesn't work correctly in the menu code.
Admin.php:645 calls createMenu().
Admin.php:704 calls the admin function from the long admin array.
$_REQUEST['sa'] is reset to the default in the list only from within the later admin function, so at this point, createMenu was already created, and $menu_context['current_subsection'] was set in that function. There is one final opportunity to fix current_subsection but it's still in Admin.php and before line 704 (and this is something you added but I doubt it has any influence here.)
I suppose one simple fix would be to check for $_REQUEST['sa'] beforehand, and if empty (and the area is known), get the first working item from the 'subsections' sub-array. And work from that... We'd just need to ensure they're in harmony with the corresponding default from each individual function. I guess. Or we could even specify the fallback subsection as a new array entry in each area...
Admin.php:645 calls createMenu().
Admin.php:704 calls the admin function from the long admin array.
$_REQUEST['sa'] is reset to the default in the list only from within the later admin function, so at this point, createMenu was already created, and $menu_context['current_subsection'] was set in that function. There is one final opportunity to fix current_subsection but it's still in Admin.php and before line 704 (and this is something you added but I doubt it has any influence here.)
I suppose one simple fix would be to check for $_REQUEST['sa'] beforehand, and if empty (and the area is known), get the first working item from the 'subsections' sub-array. And work from that... We'd just need to ensure they're in harmony with the corresponding default from each individual function. I guess. Or we could even specify the fallback subsection as a new array entry in each area...
8036
Features / Re: New revs - Public comments
« on August 21st, 2011, 09:10 AM »
Why don't you try and clean up the mysql/php configuration files from your system and your registry...?
8037
Features / Re: New revs - Public comments
« on August 21st, 2011, 12:41 AM »
I don't know what you're talking about... :^^;:
Oh, that theme picker is a real bitch when it wants... First of all, SMF bug: it sets the $current_action to 'admin' if 'sa=pick' isn't set in the URL... Even though it uses sa=pick when setting global and default themes within the admin area -- I changed that to checking for 'u=' in the URL. If it's set and u is > 0, it means we're editing a profile.
Also, if the user chooses the default theme, it also uses the default skin, right...? id_theme is set to 0, and skin is set to... Well, it's set to 'skins'. Which is totally wrong if you set the default theme to use a different skin than what it uses by default... Argh.
I'll have to check every single use of 'skin' to make sure it doesn't screw that up... >_<
Oh, and something I haven't time to look into... If you use ;area=permissions in the admin area (e.g. the main menu's Admin > Permissions shortcut), you get an index page as expected, but neither the contextual buttons not the page description are correctly output. If I had ;sa=index manually at the end, it works. Only, $_REQUEST['sa'] at this point is always 'index', even when not set... Where does the error come from? Maybe it's checking into $_GET instead? Can you have a look, Pete?
Oh, that theme picker is a real bitch when it wants... First of all, SMF bug: it sets the $current_action to 'admin' if 'sa=pick' isn't set in the URL... Even though it uses sa=pick when setting global and default themes within the admin area -- I changed that to checking for 'u=' in the URL. If it's set and u is > 0, it means we're editing a profile.
Also, if the user chooses the default theme, it also uses the default skin, right...? id_theme is set to 0, and skin is set to... Well, it's set to 'skins'. Which is totally wrong if you set the default theme to use a different skin than what it uses by default... Argh.
I'll have to check every single use of 'skin' to make sure it doesn't screw that up... >_<
Posted: August 21st, 2011, 12:39 AM
Oh, and something I haven't time to look into... If you use ;area=permissions in the admin area (e.g. the main menu's Admin > Permissions shortcut), you get an index page as expected, but neither the contextual buttons not the page description are correctly output. If I had ;sa=index manually at the end, it works. Only, $_REQUEST['sa'] at this point is always 'index', even when not set... Where does the error come from? Maybe it's checking into $_GET instead? Can you have a look, Pete?
8038
Features / Re: New revs
« on August 21st, 2011, 12:09 AM »
rev 959
(4 files, 8kb)
* Tweaked theme selector to be a bit more user-friendly. The currently selected theme is now indicated as such ('Current theme'). The currently selected skin also gets its own class (should probably use a caption like for the theme), and doesn't show the Pick links. Child skins also get more left padding, to emphasize their nature as a child, and their thumbnails are resized to ensure they don't use up too much vertical space. (Themes.template.php, index.css)
* Commenazi. (latest-themes.php, Themes.php)
(4 files, 8kb)
* Tweaked theme selector to be a bit more user-friendly. The currently selected theme is now indicated as such ('Current theme'). The currently selected skin also gets its own class (should probably use a caption like for the theme), and doesn't show the Pick links. Child skins also get more left padding, to emphasize their nature as a child, and their thumbnails are resized to ensure they don't use up too much vertical space. (Themes.template.php, index.css)
* Commenazi. (latest-themes.php, Themes.php)
8039
Features / Re: New revs - Public comments
« on August 20th, 2011, 11:32 PM »
If it's about an Ajax-driven theme changer in the footer, I already have the idea but too lazy to implement it :P
8040
Features / Re: Login with eMail instead of username
« on August 20th, 2011, 10:32 PM »
Now that is a good idea!