Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
7786
Off-topic / Re: Post count fever
« on September 15th, 2011, 06:45 PM »
Bit of stats...
386 days after we started work on Wedge, we reached today the 1000th commit milestone.
That makes for an average of 2.6 commits a day :)
Busiest months: september 2010 (over 150 commits, mainly to remove many outdated SMF features and fix its bugs), december-january with about 120 (january was when I wrote the CSS preparser so it's also my best month with about 90 commits), the global monthly average is about 80 commits (excluding the end of august 2010 and this month).
Slowest month was by far June 2011 with about 30 commits.
Of all commits, 71% were made by me, mainly because I spent all of that time on Wedge when Pete had other commit-ments (check out his work on SimpleDesk).
The diff patch between revision 1 and revision 1000 would represent about 6 megabytes, i.e. pretty much the size of an SMF install. We added 554 files, deleted 161 and updated 259.
That's all I can get without resorting to command-line stuff :P
386 days after we started work on Wedge, we reached today the 1000th commit milestone.
That makes for an average of 2.6 commits a day :)
Busiest months: september 2010 (over 150 commits, mainly to remove many outdated SMF features and fix its bugs), december-january with about 120 (january was when I wrote the CSS preparser so it's also my best month with about 90 commits), the global monthly average is about 80 commits (excluding the end of august 2010 and this month).
Slowest month was by far June 2011 with about 30 commits.
Of all commits, 71% were made by me, mainly because I spent all of that time on Wedge when Pete had other commit-ments (check out his work on SimpleDesk).
The diff patch between revision 1 and revision 1000 would represent about 6 megabytes, i.e. pretty much the size of an SMF install. We added 554 files, deleted 161 and updated 259.
That's all I can get without resorting to command-line stuff :P
7787
The Pub / [Archive] Re: Logo Madness
« on September 15th, 2011, 02:31 PM »
lol, right when I'm finished with my logo commit, I come back here and find these posts... :lol:
Where were you guys when I posted it and asked for feedback? :P
Anyway, if Pete vetoes it, I can't do much about it. I'll still look into making a proper poll between the two.
Where were you guys when I posted it and asked for feedback? :P
Anyway, if Pete vetoes it, I can't do much about it. I'll still look into making a proper poll between the two.
7788
Features / Re: New revs
« on September 15th, 2011, 02:28 PM »
rev T-1000
(4 files +3, 21kb)
* 1000 R.E.V. shalt be the year of the Apocalypse. Thou shalt brandish thy new logo and adore it. Unless it gets changed again, it goes without saying. What?
* Replacing minilogo.png with the new style logo. Still a work in progress...? (minilogo.png)
+ Added a minilogo with white text for darker backgrounds, notably in Wine. (minilogow.png, index.css)
* Warm makes use of the rarely used @remove tag to replace the minilogo and avoid including the other one in the CSS. I should probably rewrite it to make it easier to simply remove filtered *files* instead of filtered properties... (Warm/index.css)
+ Added media/avatars and media/files folders, for later use by the media code. Gotta start somewhere. (media/*)
- Removed an used $sc global. Should also remove it from dozens of other places... It's gonna be fun. Or not. (Admin.php)
@ FWIW, I was also the one who committed rev 10.000 to the SMF SVN... I like collecting SVN milestones 8-)
(4 files +3, 21kb)
* 1000 R.E.V. shalt be the year of the Apocalypse. Thou shalt brandish thy new logo and adore it. Unless it gets changed again, it goes without saying. What?
* Replacing minilogo.png with the new style logo. Still a work in progress...? (minilogo.png)
+ Added a minilogo with white text for darker backgrounds, notably in Wine. (minilogow.png, index.css)
* Warm makes use of the rarely used @remove tag to replace the minilogo and avoid including the other one in the CSS. I should probably rewrite it to make it easier to simply remove filtered *files* instead of filtered properties... (Warm/index.css)
+ Added media/avatars and media/files folders, for later use by the media code. Gotta start somewhere. (media/*)
- Removed an used $sc global. Should also remove it from dozens of other places... It's gonna be fun. Or not. (Admin.php)
@ FWIW, I was also the one who committed rev 10.000 to the SMF SVN... I like collecting SVN milestones 8-)
7789
Features / Re: New revs
« on September 15th, 2011, 02:15 PM »
rev Galaxy Express 999
(5 files, 8kb)
- No need for loadBlock('main')... Uh. That one wasn't in SMF, I don't know where it came from really. (Calendar.php)
! Was a bit too quick to remove $hard_limit from aeva_string() when it's actually used in westr::cut()... (Aeva-Subs-Vital.php)
! Fixed a CSS error generated by the menu JavaScript when hovering a top-level item in non-main menus. (script.js)
! French translation used the third person unlike the first person used in other strings. (Profile.french.php)
- A forgotten comment from a forgotten era. (Profile-Modify.php)
(5 files, 8kb)
- No need for loadBlock('main')... Uh. That one wasn't in SMF, I don't know where it came from really. (Calendar.php)
! Was a bit too quick to remove $hard_limit from aeva_string() when it's actually used in westr::cut()... (Aeva-Subs-Vital.php)
! Fixed a CSS error generated by the menu JavaScript when hovering a top-level item in non-main menus. (script.js)
! French translation used the third person unlike the first person used in other strings. (Profile.french.php)
- A forgotten comment from a forgotten era. (Profile-Modify.php)
7790
Features / Re: New revs
« on September 15th, 2011, 02:13 PM »
rev 998
(2 files, 7kb)
* Moved the PM draft saving code up in the code path, so that it doesn't waste time initializing the PM template and menus. The Subs-Menu change is not needed, but I'd like to see if it generates errors in the log. Let's call it an experiment. (PersonalMessage.php, Subs-Menu.php)
! The page index for PM drafts had an incorrect URL (area instead of sa). (PersonalMessage.php)
+ Started added placeholders for menu notices. Or warnings. Or notifications. Or whatever. (PersonalMessage.php)
@ Note: I'm starting a series of a few short commits because I changed files in various areas and I'm still trying to keep these in a logical order.
(2 files, 7kb)
* Moved the PM draft saving code up in the code path, so that it doesn't waste time initializing the PM template and menus. The Subs-Menu change is not needed, but I'd like to see if it generates errors in the log. Let's call it an experiment. (PersonalMessage.php, Subs-Menu.php)
! The page index for PM drafts had an incorrect URL (area instead of sa). (PersonalMessage.php)
+ Started added placeholders for menu notices. Or warnings. Or notifications. Or whatever. (PersonalMessage.php)
@ Note: I'm starting a series of a few short commits because I changed files in various areas and I'm still trying to keep these in a logical order.
7791
The Pub / [Archive] Re: Logo Madness
« on September 15th, 2011, 12:14 PM »
Don't worry, I've been working on the favicon and it works well as an actual logo... :)
Better than most other logos. Okay, not PERFECTLY maybe, but still well.
I was sorting through all of my old tests, and really, one of my favorites by far, as a stand-alone shape, along with the current one, has to be --
I don't know, I just liked the font + 'puzzle' shape combination for that one, too ;) I also liked the fact that the blue triangle fit exactly the text height (same position, same height), and the brown triangle fit the height of the 'd' and 'g' together. Also, I tried removing the font and it was still quite distinctive. Still, it's not exactly something that's poll-worthy. Is it...?
tl:dr, as a square shape, it doesn't work as well in the Wedge software footer, for instance, like the ship design did. I've replaced it with a reduced logo with a plain 'wedge' next to it, and it works great. Once brand awareness is old enough, I suppose we can start doing the shape-only thing more ;)
Better than most other logos. Okay, not PERFECTLY maybe, but still well.
I was sorting through all of my old tests, and really, one of my favorites by far, as a stand-alone shape, along with the current one, has to be --
I don't know, I just liked the font + 'puzzle' shape combination for that one, too ;) I also liked the fact that the blue triangle fit exactly the text height (same position, same height), and the brown triangle fit the height of the 'd' and 'g' together. Also, I tried removing the font and it was still quite distinctive. Still, it's not exactly something that's poll-worthy. Is it...?
tl:dr, as a square shape, it doesn't work as well in the Wedge software footer, for instance, like the ship design did. I've replaced it with a reduced logo with a plain 'wedge' next to it, and it works great. Once brand awareness is old enough, I suppose we can start doing the shape-only thing more ;)
7792
The Pub / [Archive] Re: Logo Madness
« on September 15th, 2011, 08:04 AM »
Yeah it looks great but it's less readable ;)
7793
The Pub / [Archive] Re: Logo Madness
« on September 15th, 2011, 01:47 AM »
Blame the beta testers :niark:
7794
Features / Re: These two bytes may not matter to you...
« on September 15th, 2011, 01:39 AM »
You don't know? That's a first 8-)
Well, from what I gathered, it updates your session with a list of unread topics. If all topics in a board are read, it marks the board as read (i.e. saves space in the logs.)
I suppose it doesn't do it automatically because it can be expensive in CPU cycles or something like that...
Ah, long time since I found an option we could remove from Wedge: compactTopicPagesEnable. I don't really see the point in having fully expanded page links...?
Bump for message above.
Also: pm_email_notify -- it's set to 0 by default. It seems that this means "never send an e-mail notification". I thought that SMF's default was to send them...? It makes more sense to have this on by default...
Well, from what I gathered, it updates your session with a list of unread topics. If all topics in a board are read, it marks the board as read (i.e. saves space in the logs.)
I suppose it doesn't do it automatically because it can be expensive in CPU cycles or something like that...
Ah, long time since I found an option we could remove from Wedge: compactTopicPagesEnable. I don't really see the point in having fully expanded page links...?
Posted: September 9th, 2011, 10:46 PM
Bump for message above.
Also: pm_email_notify -- it's set to 0 by default. It seems that this means "never send an e-mail notification". I thought that SMF's default was to send them...? It makes more sense to have this on by default...
7795
The Pub / [Archive] Re: Logo Madness
« on September 15th, 2011, 01:32 AM »
Pete, just so you know -- there were other bugs, like area=drafts used at one point in the PM area when it's sa in that area. Also, I noticed that if you don't have a recipient, it actually saves a different draft every 30 seconds... I left a PM send tab open for a copule of days and had a couple hundred pages of drafts... (Thankfully there's a delete all button now :)) After fixing the various bugs I tried again and it didn't do it, phew...
All in all I still have a few things to commit, notably in PersonalMessage.php, I'll do it tomorrow morning because it's very late here... (Plus, I'm trying to do thematic commits. The PM commits are only loosely related to the layer fixes.)
Oh and I hope it doesn't bother anyone that I decided to rebuild the skeleton array more often. I don't think it's a big deal to call, on most layer/block modifications, a recursive function with a simple isset() for each layer/block in the skeleton. I could probably get away with a few millions before I'd have to optimize actually... :P
@Aaron> Thanks :) I'm 95% happy with it, which is very high for me and as far as I'll be able to go I suppose. I was only 75% happy with the good ol' green logo ;)
All in all I still have a few things to commit, notably in PersonalMessage.php, I'll do it tomorrow morning because it's very late here... (Plus, I'm trying to do thematic commits. The PM commits are only loosely related to the layer fixes.)
Oh and I hope it doesn't bother anyone that I decided to rebuild the skeleton array more often. I don't think it's a big deal to call, on most layer/block modifications, a recursive function with a simple isset() for each layer/block in the skeleton. I could probably get away with a few millions before I'd have to optimize actually... :P
@Aaron> Thanks :) I'm 95% happy with it, which is very high for me and as far as I'll be able to go I suppose. I was only 75% happy with the good ol' green logo ;)
7796
Features / Re: New revs
« on September 15th, 2011, 01:20 AM »
rev 997
(6 files, 18kb)
! Fixed broken Wireless and XML handling. Basically, their skeletons were erased before it was even created, so Wedge was using default settings for them anyway. Also fixes an SMF bug, where a lot of init code was executed even when templating was already disabled or overridden. (Load.php, Subs.php)
* Renamed the 'main' layer to 'context', to avoid confusing it with the 'main' block. (Load.php, Profile.php, Security.php, Subs.php, index.template.php, Warm/skin.xml)
* Added a few safeguards and fallbacks for the skeleton handling code. Not that it was needed, again, but in some situations it avoids obscure error messages at virtually no cost. (Load.php, Subs.php)
! loadBlock(...'erase') should regenerate the layer list, because it might delete layers without even checking. (Load.php)
! Fixed hideChrome() to always insert a dummy layer at the top when resetting the skeleton array. This makes it possible to add layers before and after the only remaining one. If that's ever needed. (Subs.php)
* Reworked build_skeleton_indexes() to avoid having to use a parameter. Also pestering about the uselessness of array_walk_recursive(). (Load.php, Subs.php)
! skeleton_insert_layer() had an extra parameter that was forgotten from a prior commit, and would make the process fail. Also admitted failure when it comes to the layer update. Although in most cases a rebuild isn't needed, I've found a few places where it is. Rebuilding is thus a tad slower, but more robust. (Load.php)
(6 files, 18kb)
! Fixed broken Wireless and XML handling. Basically, their skeletons were erased before it was even created, so Wedge was using default settings for them anyway. Also fixes an SMF bug, where a lot of init code was executed even when templating was already disabled or overridden. (Load.php, Subs.php)
* Renamed the 'main' layer to 'context', to avoid confusing it with the 'main' block. (Load.php, Profile.php, Security.php, Subs.php, index.template.php, Warm/skin.xml)
* Added a few safeguards and fallbacks for the skeleton handling code. Not that it was needed, again, but in some situations it avoids obscure error messages at virtually no cost. (Load.php, Subs.php)
! loadBlock(...'erase') should regenerate the layer list, because it might delete layers without even checking. (Load.php)
! Fixed hideChrome() to always insert a dummy layer at the top when resetting the skeleton array. This makes it possible to add layers before and after the only remaining one. If that's ever needed. (Subs.php)
* Reworked build_skeleton_indexes() to avoid having to use a parameter. Also pestering about the uselessness of array_walk_recursive(). (Load.php, Subs.php)
! skeleton_insert_layer() had an extra parameter that was forgotten from a prior commit, and would make the process fail. Also admitted failure when it comes to the layer update. Although in most cases a rebuild isn't needed, I've found a few places where it is. Rebuilding is thus a tad slower, but more robust. (Load.php)
7797
The Pub / [Archive] Re: Logo Madness
« on September 14th, 2011, 10:54 PM »I actually find myself really liking the header one even though the font is thinner than something I'd have chosen myself.
Although I'm still debating whether I shouldn't be using Myriad... If I could find a version between Regular and Bold... Hmm. Or just another slick font.
And since I posted, it looks like the header image changed slightly, to use the one that had the triangles more offset. Either that or I'm imagining it :/
Also, since no one seems to be reading the Skeleton topic, I'll post here... :whistle: I fixed the problems with Wireless (it was my fault basically), but I found the origin of the problem for my server crash on ?action=do;sa=send2;xml... In fact, that URL is only used by the PM draft code, and from what I can see, the generic PM code isn't optimized for handling a XML version, at all. Thus, it tends to rewrite the XML template with the PM and GenericMenu templates, and it also initializes the menu entirely... At this point it'd probably make more sense to re-route the XML codepath to end much shorter in the process, what do you think?
Posted: September 14th, 2011, 09:20 PM
Also, it would seem that PMs sent to drafts via Ajax will go through the same codepath as with non-Ajax stuff...
Hence, if the PM has no recipient (i.e. I started typing my PM without specifying one), the XML codepath will return, instead of XML code, a HTML block saying that no recipient was indicated, etc, etc. All of the possible errors really...
It's actually surprising that the code used to work :P But I admit it's particularly annoying to debug Ajax code. I had to change all of the $_POST to $_REQUEST in saveDraft() just so that I could pass a dummy URL requesting to save a draft, and see the resulting code in plain view.
Posted: September 14th, 2011, 10:52 PM
Oh, and saveDraft defines a fatal_error('empty_draft'), when no language files have $txt['empty_draft'] in them. I've checked the original mod, it *is* in its language file. Just not in ours... Should we remove the error or add the error message back in?
There may be other strings missing but it's the only one I checked.
7798
The Pub / [Archive] Re: Logo Madness
« on September 14th, 2011, 05:57 PM »
Header & footer were updated with this new version. I also updated minilogo.png so that all of you guys with a logo in your signatures will have it updated as well. (I can reupload the old one if you'd like to keep it though.)
7799
The Pub / [Archive] Re: Logo Madness
« on September 14th, 2011, 05:46 PM »The logo thing is making me sick, anyone kindly make me a new logo? :P
Made with Paint Shop Pro in 8 hours.
7800
The Pub / [Archive] Re: Logo Madness
« on September 14th, 2011, 05:36 PM »
Let's try these... One for the dark backgrounds, one for bright backgrounds.
Since there are fans of the skewed version and fans of the square version, I tried to do something halfway between the two. (The light version isn't very readable but I'm on an odd-numbered post so I've got a light background for it.)
:edit: Updated white version.
:edit: And again...
Since there are fans of the skewed version and fans of the square version, I tried to do something halfway between the two. (The light version isn't very readable but I'm on an odd-numbered post so I've got a light background for it.)
:edit: Updated white version.
:edit: And again...