Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
7696
Plugins / Re: Converting WedgeDesk
« on September 23rd, 2011, 12:27 PM »Look familiar, much? :lol:
7697
Plugins / Re: Add-on Manager: Mechanics
« on September 23rd, 2011, 12:26 PM »
Now we'll be able to move this to the Wedge documentation and split it into several areas or something because it's probably a bit too monolithic to digest... ;)
7698
The Pub / Re: Copyrights
« on September 23rd, 2011, 12:21 PM »The wording of the licence says, and I quote:So, let's parse that first clause because that's the one that really applies to us:Quote Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
* Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimers.
* Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimers in the documentation and/or other materials provided with the distribution.
* Neither the names of Simple Machines Forum, Simple Machines, nor the names of its contributors may be used to endorse or promote products derived from this Software without specific prior written permission.
* redistribution of source code
- any source code derived from their source, meaning and any all code originally belonging to SMF
Anyway, it can be read in two ways. The REDISTRIBUTION must retain the copyright stuff. It doesn't say EVERY file should have it, does it...?
Seriously. Their LICENSE file says it must be kept. Then we keep the license file. As for the rest... Well, the only thing common to both the license file and all remaining files is the copyright line indeed. So it can be argued that they want it to be left. I personally don't think it's worth worrying about... It's not like we're hiding that it's SMF to begin with.
I'd tend to ask them.
Guys, either we keep your license file and your copyright line (only that) in all files you created. Or, we only keep your license file, but we acknowledge SMF in the credits area with a link to its site. Your choice.
* must retain the above copyright notice
- must retain a statement to the effect of @copyright 2011 Simple Machines, it does not state anywhere that the @author entry must be retained, but the copyright notice
Now, they don't include the licence text on every file, they only include a reference in the file itself, under the license tag.
To me, I think that to comply with their attitude, we need to do the following:
* Alter the @copyright in the file headers to read:Quote @copyright 2010-2011 Wedgeward, wedge.org, portions copyright 2011 Simple Machines
Too bad phpDoc doesn't "support" a @contributor(s) line, but why wouldn't we simply add such a line...?
@copyright © 2010-2011 Wedgeward, wedge.org
@author Wedgeward (René-Gilles Deberdt, Peter Spicer)
@contributor contains portions © 2011 Simple Machines
* Make sure the licence page that we list states that Wedge is derived from SMF 2.0, under the terms of http://www.simplemachines.org/about/smf/license.php
and that only original SMF code is BSD, while any code that isn't is covered by the Wedge licence
Then: we have retained the copyright notice, in both source and binary distributions without the weight of multiple tags that are unnecessary. As per above, we're required to keep the copyright and state the terms of licence, and we are following their example in the latter and holding to the former by letter of their licence.
7699
Features / Re: New revs
« on September 23rd, 2011, 11:36 AM »
rev 1025
(3 files, 7kb)
- Reverting a useless fix which was due to my setup not being up to date. (Errors.php)
! More menu CSS fixes for IE8 and IE9. Microsoft, please kill IE. Now. (index.ie*.css)
(3 files, 7kb)
- Reverting a useless fix which was due to my setup not being up to date. (Errors.php)
! More menu CSS fixes for IE8 and IE9. Microsoft, please kill IE. Now. (index.ie*.css)
7700
Features / Re: New revs - Public comments
« on September 23rd, 2011, 07:41 AM »
The function will be moved to the index template as discusses earlier. ;)
7701
Features / Re: New revs - Public comments
« on September 23rd, 2011, 12:46 AM »
@John> ?Quote from Arantor on September 20th, 2011, 11:56 AM I think 'default' will be just fine. I haven't felt a desire to change it, which is a good sign :PQuote The fact that $where defaults to 'replace' when $target == 'default and defaults to 'add' everywhere else...Quote Although I'm totally pro-objectifying (?) stuff, including mine, I wouldn't know where to start (i.e. I can maintain an object but convert something to an object is something I can't do with confidence), I'm also not sure whether it's actually worth the hassle... I mean, if a mod removes 'default', their author will notice soon enough...Quote I'd tend to say that admins are in the same crap as users here -- it's really the themer we should be talking to...Quote No, that's not what I was saying... If a board has a default language, different than the forum's, *and* the admin disabled the ability to change languages for users, i.e. $modSettings['userLanguages'] or whatever is false, then getLanguages() is not called... And my test code isn't, either.Quote from Arantor on September 23rd, 2011, 12:40 AM I haven't written it down, but XDebug basically crashed saying "delimiter is empty", IIRC.
Although... Come to think of it, $addonsdir is defined in Settings.php, right? Then yeah, my mistake-- I haven't updated my Settings.php files to add them. I'm not in a hurry to do it... Would have to do it for my local install, as well as the demo and the import demo... :^^;:
Feel free to revert that one in your next commit, btw. Or whatever.
'default' works, as incidentally does 'context'. I'd avoid main though, for precisely the reason you give.
OK, what part are you not sure about, exactly? It seems to me the current behaviour is pretty logical.Quote I'm still not sure about the default behavior for $where. I'd like to have more opinions... Especially from all of our mod developers out there!
Oh, yeah, oops. You know, there is a solution to that: turn it into an object, make the list a private variable of that object so only the object's methods can modify it. You'd have to move a bunch of stuff from Subs-Template into a class but it would effectively nail the problem.
It's fine for users but not a lot of help for an administrator. Much better, then, is if we can provide a separate error for administrators with a little more detail in it.
Re languages: in theory if the language that a board (or user, for that matter) doesn't exist, it should still be falling back to the forum default.
Re r1024: Um, $addon_dir shouldn't ever be empty because it should be set earlier in the file (lines 37-8)... what exactly was the error you were getting?
Although... Come to think of it, $addonsdir is defined in Settings.php, right? Then yeah, my mistake-- I haven't updated my Settings.php files to add them. I'm not in a hurry to do it... Would have to do it for my local install, as well as the demo and the import demo... :^^;:
Feel free to revert that one in your next commit, btw. Or whatever.
7702
Features / Re: New revs
« on September 23rd, 2011, 12:34 AM »
rev 1024
(7 files +1, 23kb)
+ Re-introducing the top menu arrow. Holy cow, did I miss that one. Used a clever CSS trick to add it through JavaScript without even breaking validation. (menurow.gif, script.js, index.css, Warm/index.css)
+ Added support for average() color function. It returns a color that is the average of two colors passed to it. Note that this is the HSLA average, not RGBA, so it's more accurate. Also used the function on menu background for IE9, as an example. (Class-CSS.php, index.css)
* Updated minilogos to PT Sans. Hmm, I think Helvetica looks best at that size though... (minilogo.png, minilogow.png)
! Error when errors occur. But only if no add-ons are installed, if I'm not in error. (Errors.php)
! Fixed minor glitch on menu corners. (index.css)
(7 files +1, 23kb)
+ Re-introducing the top menu arrow. Holy cow, did I miss that one. Used a clever CSS trick to add it through JavaScript without even breaking validation. (menurow.gif, script.js, index.css, Warm/index.css)
+ Added support for average() color function. It returns a color that is the average of two colors passed to it. Note that this is the HSLA average, not RGBA, so it's more accurate. Also used the function on menu background for IE9, as an example. (Class-CSS.php, index.css)
* Updated minilogos to PT Sans. Hmm, I think Helvetica looks best at that size though... (minilogo.png, minilogow.png)
! Error when errors occur. But only if no add-ons are installed, if I'm not in error. (Errors.php)
! Fixed minor glitch on menu corners. (index.css)
7703
Off-topic / Re: I am looking for a favour
« on September 22nd, 2011, 10:01 PM »
Okay so I guess it's a regression...
Documented and posted ALL of the main Opera bugs here:
http://my.opera.com/community/forums/topic.dml?id=1102652
Including this one...
Ah, well... 11 hours into it, and the topic is still ignored. :(
Posted: September 22nd, 2011, 07:47 AM
Documented and posted ALL of the main Opera bugs here:
http://my.opera.com/community/forums/topic.dml?id=1102652
Including this one...
Posted: September 22nd, 2011, 11:03 AM
Ah, well... 11 hours into it, and the topic is still ignored. :(
7704
Features / Re: New revs
« on September 22nd, 2011, 09:54 PM »
rev 1023
(8 files, 13kb)
- Removed compactTopicPagesEnable setting. I've never seen a single SMF forum disable it anyway. (install.sql, Display.php, ManageSettings.php, Subs.php, Help.language.php, ManageSettings.language.php)
@ Note to SMF: if you keep the option, I'd just like you to know the help popup for it is completely screwed up... It looks like it's the help for compactTopicPagesContiguous, in fact (which is repeated below). Plus, the help never mentions it's for the page index.
(8 files, 13kb)
- Removed compactTopicPagesEnable setting. I've never seen a single SMF forum disable it anyway. (install.sql, Display.php, ManageSettings.php, Subs.php, Help.language.php, ManageSettings.language.php)
@ Note to SMF: if you keep the option, I'd just like you to know the help popup for it is completely screwed up... It looks like it's the help for compactTopicPagesContiguous, in fact (which is repeated below). Plus, the help never mentions it's for the page index.
7705
Features / Re: New revs
« on September 22nd, 2011, 06:47 PM »
rev 1022
(7 files, 12kb)
+ Added ability to remove index.php from the URL in the Pretty URLs area. You no longer have to enable Pretty URLs just to remove index.php, for those who don't like them. (ManageSettings.php, QueryString.php, Admin.template.php, Admin.language.php)
- Don't repeat comments twice in the htaccess file. Don't repeat comments twice in the htaccess file. (other/.htaccess)
- Shortened the debug HTML code. (Subs-Template.php)
(7 files, 12kb)
+ Added ability to remove index.php from the URL in the Pretty URLs area. You no longer have to enable Pretty URLs just to remove index.php, for those who don't like them. (ManageSettings.php, QueryString.php, Admin.template.php, Admin.language.php)
- Don't repeat comments twice in the htaccess file. Don't repeat comments twice in the htaccess file. (other/.htaccess)
- Shortened the debug HTML code. (Subs-Template.php)
7706
Off-topic / Re: PHP IDE for windows
« on September 22nd, 2011, 11:20 AM »
Installed Win8 64-bit and a bit 'meh'...
Dunno why but it's very slow in my VirtualBox window (when I get full speed on other OSes.)
I like the Metro UI but I don't like the scrollbars (can't they make them less intrusive and push them away from the icon content...?), as well as the fact that it's obviously built for tablets only... Heck, why is this the default UI anyway...?
I'd love to know what fonts they used, apart from the now obvious Segoe UI Light... I looked through the Fonts folder and didn't find anything that wasn't already in Win7.
Oh, and it's a bit buggy BTW... I launched the 'card quiz' or something, and some of the questions were asked over two lines and the second line would be severely cut off at the bottom... Lol.
Dunno why but it's very slow in my VirtualBox window (when I get full speed on other OSes.)
I like the Metro UI but I don't like the scrollbars (can't they make them less intrusive and push them away from the icon content...?), as well as the fact that it's obviously built for tablets only... Heck, why is this the default UI anyway...?
I'd love to know what fonts they used, apart from the now obvious Segoe UI Light... I looked through the Fonts folder and didn't find anything that wasn't already in Win7.
Oh, and it's a bit buggy BTW... I launched the 'card quiz' or something, and some of the questions were asked over two lines and the second line would be severely cut off at the bottom... Lol.
7707
Off-topic / Re: I am looking for a favour
« on September 22nd, 2011, 12:31 AM »
Hey, might as well reuse this topic title...... :whistle:
Okay, can anyone here fire up Opera? Interested in knowing the version number, too. I'm using v12 and here's what I want you to do.
Right click on any element on any web page.
Click "Inspect element" to fire up Dragonfly.
In the right side of the Dragonfly window, click the 'Properties' tab.
Scroll to the bottom and unfold the 'style [CSSStyleDeclaration]' parameter.
Scroll again to the bottom, and tell me if you see this show up in the list:
zoom: ""
Normally, this should NOT show up, because zoom is IE-only and Opera has no reason to define it -- even empty. It doesn't even support it -- if you try doing a zoom:1, it'll fire up a CSS error.
Problem is -- jQuery, at some point, creates an empty dummy div and proceeds to check (~line 1242 in v1.5.2 uncompressed) for 'style' in div.style, which will return true, because it's set (even if empty.)
As a result, it executes that codepath which normally is only for IE... And it triggers said CSS error.
I'm a bit pissed off. Dunno if I should complain at Opera or jQuery, to begin with... Probably Opera! But they're slow to react to bug reports...
Okay, can anyone here fire up Opera? Interested in knowing the version number, too. I'm using v12 and here's what I want you to do.
Right click on any element on any web page.
Click "Inspect element" to fire up Dragonfly.
In the right side of the Dragonfly window, click the 'Properties' tab.
Scroll to the bottom and unfold the 'style [CSSStyleDeclaration]' parameter.
Scroll again to the bottom, and tell me if you see this show up in the list:
zoom: ""
Normally, this should NOT show up, because zoom is IE-only and Opera has no reason to define it -- even empty. It doesn't even support it -- if you try doing a zoom:1, it'll fire up a CSS error.
Problem is -- jQuery, at some point, creates an empty dummy div and proceeds to check (~line 1242 in v1.5.2 uncompressed) for 'style' in div.style, which will return true, because it's set (even if empty.)
As a result, it executes that codepath which normally is only for IE... And it triggers said CSS error.
I'm a bit pissed off. Dunno if I should complain at Opera or jQuery, to begin with... Probably Opera! But they're slow to react to bug reports...
7708
The Pub / [Archive] Re: Logo Madness
« on September 21st, 2011, 09:46 PM »
Bjorn,
There's nothing I can say to make you stay -- because, yes, we're not equal until Wedge 1.0 comes out, because as I said, I'm adamant that Pete and I will be the only developers on the first release. It doesn't mean we can't and won't work with others, of course, but we have the final word. So yes, in a sense, you are right.
However, I never ever doubted your talent and ability to do something different, and to do something different *for a good reason*. I've spent more time than I'd like to admit analyzing your logo submissions, even the last one (which you probably assumed I promptly rejected -- it actually stands there in my list of possible logos.)
As I said, Curve was something I disliked at first, then learned to like better than Core (I think my fave 'default' theme for SMF is still Babylon...), and it actually helped me forge my design skills (among plenty other things -- my biggest influence being .net magazine screenshots, I'd say.) And I love your website's recent themes. Sure thing, I'd probably be ready to use one of your existing themes as the default theme in Wedge. I simply need time to adjust to your ideas.
But yes, in the end, Pete and I will have the final word, and as willing as I am to give you creative freedom and let you do things you couldn't even consider doing for Curve, I know we're going to fight over details eventually. Probably not a LOT of details, but I see we're both quite stubborn and I doubt such an endeavour would be realistic -- not with the amount of work it would require from you, and subsequently the amount of ego bashing you'd take even involuntarily. The only way to make it work would be to take one of your pre-existing themes, but that's pretty much all.
So, I understand your point. And I think I did a lot to accomodate for you (e.g. layer hints), and in the end I'm just running away from the truth -- I probably can't work alongside with you because I'm more conservative, as much as I hate thinking about myself as a 'conservative'. But I'm certainly not the innovator that Pete would like to think I am.
There's nothing I can say to make you stay -- because, yes, we're not equal until Wedge 1.0 comes out, because as I said, I'm adamant that Pete and I will be the only developers on the first release. It doesn't mean we can't and won't work with others, of course, but we have the final word. So yes, in a sense, you are right.
However, I never ever doubted your talent and ability to do something different, and to do something different *for a good reason*. I've spent more time than I'd like to admit analyzing your logo submissions, even the last one (which you probably assumed I promptly rejected -- it actually stands there in my list of possible logos.)
As I said, Curve was something I disliked at first, then learned to like better than Core (I think my fave 'default' theme for SMF is still Babylon...), and it actually helped me forge my design skills (among plenty other things -- my biggest influence being .net magazine screenshots, I'd say.) And I love your website's recent themes. Sure thing, I'd probably be ready to use one of your existing themes as the default theme in Wedge. I simply need time to adjust to your ideas.
But yes, in the end, Pete and I will have the final word, and as willing as I am to give you creative freedom and let you do things you couldn't even consider doing for Curve, I know we're going to fight over details eventually. Probably not a LOT of details, but I see we're both quite stubborn and I doubt such an endeavour would be realistic -- not with the amount of work it would require from you, and subsequently the amount of ego bashing you'd take even involuntarily. The only way to make it work would be to take one of your pre-existing themes, but that's pretty much all.
So, I understand your point. And I think I did a lot to accomodate for you (e.g. layer hints), and in the end I'm just running away from the truth -- I probably can't work alongside with you because I'm more conservative, as much as I hate thinking about myself as a 'conservative'. But I'm certainly not the innovator that Pete would like to think I am.
7709
Off-topic / Re: After your final status update
« on September 21st, 2011, 09:34 PM »
That's because he added a YT link to his custom title, and Wedge.org parses them.
Just edit your custom title, DS :P
Just edit your custom title, DS :P
7710
Features / Re: New revs
« on September 21st, 2011, 09:32 PM »
rev 1021
(10 files, 19kb)
- Removed layer hints. They would probably have been a bit confusing to part-time themers and modders. Here's hoping themers will make sure their skeletons have all of the regular layers in them. (Aeva-Gallery.php, Profile.php, Subs-Menu.php, index.template.php, Warm/skin.xml)
! Fixed some logic errors when providing wrong values to the skeleton. (Subs-Template.php)
+ Added a skeleton_find_parent() function to get the parent layer's name for a given block or layer. (Subs-Template.php)
* Shortened a few JS functions. I'm particularly proud I managed to shorten my menu code by a few more lines. Nerd alert. (ManageMaintenance.template.php, mediadmin.js, post.js, script.js)
(10 files, 19kb)
- Removed layer hints. They would probably have been a bit confusing to part-time themers and modders. Here's hoping themers will make sure their skeletons have all of the regular layers in them. (Aeva-Gallery.php, Profile.php, Subs-Menu.php, index.template.php, Warm/skin.xml)
! Fixed some logic errors when providing wrong values to the skeleton. (Subs-Template.php)
+ Added a skeleton_find_parent() function to get the parent layer's name for a given block or layer. (Subs-Template.php)
* Shortened a few JS functions. I'm particularly proud I managed to shorten my menu code by a few more lines. Nerd alert. (ManageMaintenance.template.php, mediadmin.js, post.js, script.js)