Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
7666
Plugins / [Naming poll] Re: Packages
« on September 28th, 2011, 12:26 AM »
So... Given that after months of discussion, I'm still unsure about the use of the word 'add-ons' and its variation(s) (addons), I'm relaunching the poll from scratch, with just two options this time.
Pete prefers add-ons but doesn't mind either way.
I prefer plugins because that's the word we use even when discussing add-ons --- and I prefer to see us use actual words to represent something, rather than a "target word" that nobody will use and everyone will replace with someone else. Just like it doesn't make sense for SMF to keep using the word "package" when everyone over there is saying "mod"...
I also like plugins because we made sure that plugins would never modify any Wedge files (except in some rare situations where no alternative solution is available). And plugins, to me, represent the easiness of enabling/disabling the things: you don't even have to install them in the first place... It's plug-and-play.
So, either plugin or add-on! Thanks!
Pete prefers add-ons but doesn't mind either way.
I prefer plugins because that's the word we use even when discussing add-ons --- and I prefer to see us use actual words to represent something, rather than a "target word" that nobody will use and everyone will replace with someone else. Just like it doesn't make sense for SMF to keep using the word "package" when everyone over there is saying "mod"...
I also like plugins because we made sure that plugins would never modify any Wedge files (except in some rare situations where no alternative solution is available). And plugins, to me, represent the easiness of enabling/disabling the things: you don't even have to install them in the first place... It's plug-and-play.
So, either plugin or add-on! Thanks!
7667
Off-topic / Re: MySQL Website Compromised; Serves Malware to Visitors
« on September 27th, 2011, 11:25 PM »
Maybe it's Oracle doing this to themselves to encourage people to upgrade to Oracle DB? :P
7668
Features / Re: New revs - Public comments
« on September 27th, 2011, 07:27 PM »
We are talking about renaming to plugins not addons :P
7669
Features / Re: New revs - Public comments
« on September 27th, 2011, 06:38 PM »
Yeah, I suppose they don't care...
Let's just say it'll be up to that lang tag.
WP:BOLD I can understand through googling, but citation needed? Don't see the relationship with what we're talking about -- even with Wikipedia in mind.
Still, I can't suddenly rename everything when most people voted for 'add-on', including *you*... That makes a clear majority for add-ons. I just hate that hyphen, and even if I remove it, the word looks odd to me :P
Let's just say it'll be up to that lang tag.
WP:BOLD I can understand through googling, but citation needed? Don't see the relationship with what we're talking about -- even with Wikipedia in mind.
Still, I can't suddenly rename everything when most people voted for 'add-on', including *you*... That makes a clear majority for add-ons. I just hate that hyphen, and even if I remove it, the word looks odd to me :P
7670
Features / Re: New revs - Public comments
« on September 27th, 2011, 06:22 PM »The idea was to parse the post then cache it, which seemed more logical to me than force whatever changes there were every time. In the case which prompted that, the hook makes DB queries.
Yes, it should be $s not $d, oops.
Fairly sure I just reused the same language string there, out of laziness. The whole disable/remove part is distinctly less polished.
I changed the mention because it referenced Modifications.english.php which doesn't exist now.
Re PHP 5.4 stuff, I read it as break x being broken, not break $var but it's easily possible that I misread it.
I must have missed the use of plugin at the time but it was quite late at night :P
And $can_use... pass, can't remember, sorry.
* Arantor says a rude word.
7671
Features / Re: New revs
« on September 27th, 2011, 06:09 PM »
rev 1034
(8 files +3 -2, 39kb)
* Upped the maximum file count in media folders to 500 (from 150). (install.sql)
* Renamed Homepage custom page to Welcome, so that you can create your own Homepage. (Homepage.php, Homepage.template.php)
* Spacinazi, parenthenazi, typo and code cleanup. (ManageAddons.php, Subs-Media.php, Subs-Boards.php, Subs-Cache.php, Admin.template.php, ManageAddons.english.php)
* French translation. (Admin.french.php, ManageAddons.french.php)
(8 files +3 -2, 39kb)
* Upped the maximum file count in media folders to 500 (from 150). (install.sql)
* Renamed Homepage custom page to Welcome, so that you can create your own Homepage. (Homepage.php, Homepage.template.php)
* Spacinazi, parenthenazi, typo and code cleanup. (ManageAddons.php, Subs-Media.php, Subs-Boards.php, Subs-Cache.php, Admin.template.php, ManageAddons.english.php)
* French translation. (Admin.french.php, ManageAddons.french.php)
7672
Features / Re: New revs - Public comments
« on September 27th, 2011, 06:05 PM »
Okay, good then.
Looking through Subs-BBC. You added a hook right before the code that caches parsed data. Wouldn't it make more sense to add it after, so that the hook is always called, even if the post is cached? (One would have to call the same hook much earlier when returning the cached data, of course.)
Although I'm not exactly sure of the point of caching parsed data for only six minutes... It's very likely to be called only once or twice in that time...
Also, I'm doing the language files...
fatal_install_error_minmysql and minphp have two sprintf params, %1$d and %2$s, which both correspond to a version number. Wouldn't it make more sense to have %1$s for the first as well...?
fatal_install_error_missinghook has a typo (avaialble). Fixed on my side. I'm saying that but there's bound to be typos in my translation as well, given how fast I'm working on it... :whistle:
fatal_install_remove_missing is using the term 'disabled' instead of 'removed' or 'uninstalled'.
Why did you remove the media_welcome mention from the help files...? (media_admin_settings_welcome_subtext)
Template stuff:
+ // Add-on buttons. They're floated right, so need to be first. Besides which, the floating means they need to be in reverse order :/
Why not use inline-blocks then...?
I think that's all for now... I'm committing my changes thus far. 2800KB left to check......... :( :( :(
Oh, and do you know your Dragooon-contributed code in rev 1032 uses the word 'plugin'? :P :P
rev 1032 has:
+ break; // I'd use break 2 but that's deprecated in PHP 5.4.
Actually they removed break $var, not break (constant number)... :^^;:
(And yes it's not something that was added in 1032.)
The same function with 'break 2' defines a variable that's never used -- $can_use... I'm removing it.
Just saying ;)
Looking through Subs-BBC. You added a hook right before the code that caches parsed data. Wouldn't it make more sense to add it after, so that the hook is always called, even if the post is cached? (One would have to call the same hook much earlier when returning the cached data, of course.)
Although I'm not exactly sure of the point of caching parsed data for only six minutes... It's very likely to be called only once or twice in that time...
Also, I'm doing the language files...
fatal_install_error_minmysql and minphp have two sprintf params, %1$d and %2$s, which both correspond to a version number. Wouldn't it make more sense to have %1$s for the first as well...?
fatal_install_error_missinghook has a typo (avaialble). Fixed on my side. I'm saying that but there's bound to be typos in my translation as well, given how fast I'm working on it... :whistle:
fatal_install_remove_missing is using the term 'disabled' instead of 'removed' or 'uninstalled'.
Why did you remove the media_welcome mention from the help files...? (media_admin_settings_welcome_subtext)
Template stuff:
+ // Add-on buttons. They're floated right, so need to be first. Besides which, the floating means they need to be in reverse order :/
Why not use inline-blocks then...?
I think that's all for now... I'm committing my changes thus far. 2800KB left to check......... :( :( :(
Posted: September 27th, 2011, 05:58 PM
Oh, and do you know your Dragooon-contributed code in rev 1032 uses the word 'plugin'? :P :P
Posted: September 27th, 2011, 05:59 PM
rev 1032 has:
+ break; // I'd use break 2 but that's deprecated in PHP 5.4.
Actually they removed break $var, not break (constant number)... :^^;:
(And yes it's not something that was added in 1032.)
Posted: September 27th, 2011, 06:02 PM
The same function with 'break 2' defines a variable that's never used -- $can_use... I'm removing it.
Just saying ;)
7673
Features / Re: New revs - Public comments
« on September 27th, 2011, 05:15 PM »
Re: too many blocks -- yeah, I suppose index.template.php is really a special case... And a dozen extra blocks aren't going to kill performance -- it's all very fast. Although we might wanna do a get_defined_functions() once and for all, and then test through isset() instead of function_exists()...
Re: injection, as I answered somewhere else, one can easily hook their function into 'display_post_done' and use $counter to determine the position in the list. :)
Re: addon code, I'm looking through it again (still over 3000 lines to go through, WTF...), and noticed the menu entry for addons has a lot of content commented out. I suppose you're aware of that, but you might wanna clean it up... I generally dislike commented out code being committed without a good reason :P
Re: injection, as I answered somewhere else, one can easily hook their function into 'display_post_done' and use $counter to determine the position in the list. :)
Re: addon code, I'm looking through it again (still over 3000 lines to go through, WTF...), and noticed the menu entry for addons has a lot of content commented out. I suppose you're aware of that, but you might wanna clean it up... I generally dislike commented out code being committed without a good reason :P
7674
Features / Re: New revs
« on September 26th, 2011, 11:43 PM »
rev 1033
(14 files, 23kb)
+ Introducing pretty URL prefixes for actions and profiles. Basically, when enabling pretty actions or pretty profiles, you also get to choose between various URL styles for them. Supporting "/" and "/do/" for actions, and "/~" and "/profile/" for profiles. Defaults to the long versions. Need to add some documentation about this, and some code at board creation time to prevent them from having a name in the protected action list...[1] (install.sql, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, Admin.template.php, Admin.language.php, admin.css)
* Updated credits page to merge library copyrights with other copyrights. (Credits.php, Who.template.php, Who.language.php)
* Added Pretty URLs admin page to the internal admin search engine. Heck, we need to add many more sub-actions to that array... I'll let Pete handle this after he finishes reworking the admin area. (Admin.php)
* Spacinazi. (Subs-Cache.php)
(14 files, 23kb)
+ Introducing pretty URL prefixes for actions and profiles. Basically, when enabling pretty actions or pretty profiles, you also get to choose between various URL styles for them. Supporting "/" and "/do/" for actions, and "/~" and "/profile/" for profiles. Defaults to the long versions. Need to add some documentation about this, and some code at board creation time to prevent them from having a name in the protected action list...[1] (install.sql, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, Admin.template.php, Admin.language.php, admin.css)
* Updated credits page to merge library copyrights with other copyrights. (Credits.php, Who.template.php, Who.language.php)
* Added Pretty URLs admin page to the internal admin search engine. Heck, we need to add many more sub-actions to that array... I'll let Pete handle this after he finishes reworking the admin area. (Admin.php)
* Spacinazi. (Subs-Cache.php)
| 1. | Feel free to add it to your to-do list, Pete... I'm so horribly busy these days. :( |
7675
Development blog / Re: The saga of the Add-on Manager
« on September 26th, 2011, 02:51 PM »
He's no longer here. French proverb. Those missing are always wrong :P
7676
Off-topic / Re: OMG MUST HAVE NEW SEO
« on September 26th, 2011, 02:30 PM »
Does google news even support forums?
7677
Off-topic / Re: The Epic Turnabout
« on September 26th, 2011, 01:12 PM »
And it's a *game*? Why does it only have CG then...? How come they could mix up such drastically different character designs? Meh...
I love Layton (I only saw the movie though), but I was bored to death by the first Wright game -- stopped after the first case I believe. Never bought a DS game after that. Hmm... No, I bought FF12 for DS, and it was yet another mistake. <sigh>
I love Layton (I only saw the movie though), but I was bored to death by the first Wright game -- stopped after the first case I believe. Never bought a DS game after that. Hmm... No, I bought FF12 for DS, and it was yet another mistake. <sigh>
7678
Development blog / Re: The saga of the Add-on Manager
« on September 26th, 2011, 01:07 PM »
So we might as well make files NON-editable... :niark:
7679
Off-topic / Re: Post count fever
« on September 26th, 2011, 09:28 AM »
I think I removed it manually.
7680
Plugins / Re: Hooking up data loading
« on September 25th, 2011, 11:36 PM »
Google likes topic pages more, so they optimized that. It's for the long run. Rarely accessed pages won't bring your server down. Makes sense to me...