Wedge

rev 1049
(16 files +6, 33kb -- too tired to take time splitting into smaller commits.)

+ Because I was bothered by a lousy Google PageSpeed rating on admin menus, due to menu icons, I gathered them together and multiplied said rating by two. Known issue: if you modify the admin menu, you'll need to manually remove the cache file, or run clean_cache('css', 'admenu') through a hook or something. Needs discussing. (Admin.php, Subs-Cache.php, Subs-Menu.php, admenu.css)

+ Added cache control htaccess files to avatar and smiley folders. Smileys don't need this, unless they're too big to be cached by WeCSS. Also note that $admin_areas is now a global, so the admin menu hook doesn't need to specify it as a param. (avatars/.htaccess, Smileys/.htaccess)

+ Added three icons to the topic moderation menu. Only visible to members with the correct permissions. Asking for feedback on whether I should remove them or add icons to the rest. (index.member.css, sections.css)

* Modified CSS dynamic plugin to force requiring a dynamic_ prefix on the function name. Should make it safer to use. (Class-CSS.php, index.css)

* Got real when it comes to clean_cache(), and made it simpler to remove CSS and JS files with it. You just need to specify 'css' now, and Wedge will extend it to all extensions used for CSS files. (ManageServer.php, ManageSmileys.php, Subs-Cache.php)

! Error URLs were recently broken if using Pretty URLs. (Errors.php)

! Package functions don't need to declare admin.css, since it's already declared by that time. (PackageGet.php, Packages.php)

! jQuery was being used in an inline function. (Subscriptions-PayPal.php)

* Super-minor fixes. (avatars/xkcd/index.php, Load.php, ManageErrors.php)

NB: would appreciate feedback on this commit, thanks...

rev 1047
(4 files, 7kb)

* Swapped parameter order for clean_cache() to put the emphasis on the most used param. Also cleaned up related data. (ManageServer.php, ManageSmileys.php, Subs-Boards.php, Subs-Cache.php)

* Delete CSS cache when language files are modified. (Subs-Cache.php)

rev 1046
(13 files +5-5, 45kb)

* clean_cache filter can now be a string anywhere inside the filename. (Subs-Cache.php)

+ Added a 'dynamic' plugin for WeCSS, where one may define a dynamic_function() anywhere (whatever the name), and then call it from within a CSS file via {%dynamic_function:params%}. Will have to look into potential security issues, though... (Class-CSS.php, Subs-Cache.php)

+ Added a dynamic function to cache language flags into index.css... Yay. This gets me one more percent on Google PageSpeed. (Subs-Cache.php, index.css, index.template.php)

! Forgot to update a few files with the Plugin rename. (other/*, ManagePlugins.language.php, ManagePlugins.template.php, admin.css)

! Fixed margin glitch when showing a .wrc div that only contains a single p (paragraph). (index.css)

! Fixed bug with is_replied_to in PM searches. (PersonalMessage.php)

- Saving one line of code. Beautiful. (Display.template.php)

Oh oh, don't get me started on hasLayout... :P
Last week I was actually trying to *remove* hasLayout from an item. Which turns out to be pretty much impossible! :(

Another, in Class-DB.php:

      // A database error is often the sign of a database in need of upgrade. Check forum versions, and if not identical suggest an upgrade... (not for SVN versions!)
      if (allowedTo('admin_forum') && defined('WEDGE_VERSION') && WEDGE_VERSION != @$modSettings['weVersion'] && strpos(WEDGE_VERSION, 'SVN') === false)
         $context['error_message'] .= '<br><br>' . sprintf($txt['database_error_versions'], WEDGE_VERSION, $modSettings['weVersion']);

$modSettings['weVersion'] isn't defined anywhere by Wedge. It may be some variable we used to set but removed eventually... Since I believe you recently discussed this particular error message, do you remember anything about it?

Reported bug to the Chrome team... (reproduced on the demo site.)

And it's not jQuery, as it can be triggered by changing the border-radius value on the fly.

rev 1045
(8 files, 9kb)

- clean_cache('member_data') doesn't do anything. It didn't back in SMG days, it still doesn't. Might as well remove it... (Subs-Media.php)

! Default clean_cache type should be empty, and redirect to the data sub-folder. The type is only overridden for the smiley cache anyway. (Subs-Cache.php)

! Fixed padding for the quick reply textarea. (Class-Editor.php, editor.css, sections.css)

* Moved 'mark unread' link next to 'report to moderator' in PM template. (PersonalMessage.template.php)

* Quick reply opening speed was fast, but not fast enough for a 'quick' reply. Increased speed by 25%. (topic.js)

- Moderation notes? Thank you, Captain Obvious! (admin.css)

rev 1044
(7 files, 11kb)

+ At last, started implementing id_parent in messages for the future threaded view (whether as a plugin or in core). Currently works on Reply, Quote and new posts. Doesn't work on Quick Reply for now. (Post.php, Post2.php, Subs-Post.php, Post.template.php)

! Fixed and tweaked PM post layout -- straightened up the padding and margin, used on_timeformat() where it applies, made Delete button visible, etc. And my apologies for the minor hack in the PM layer's above(). (PersonalMessage.php, PersonalMessage.template.php, index.member.css)