Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
7501
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 9th, 2011, 06:25 PM »
I started work on a blog post yesterday but it was cheesy so I dropped it. I hate apologizing for the lack of progress. I'm not paid. We are doing more work than smf. Only thing that makes me feel bad is that nightwish is more active than I am. I wish I'd be as fresh as I was a year ago.
7502
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 9th, 2011, 03:31 PM »
Do you want the rest of my to-do? :lol:
(Well, anything not related to French fixes or whatever... And minor AeMe tidbits...)
7503
The Pub / Re: Spell checker
« on October 9th, 2011, 03:30 PM »
One solution to problems would be to present plugins in a way that makes them as much a part of the admin area as the rest, i.e. allow to enable/disable them directly within the *homepage* of the area...
7504
The Pub / Re: Spell checker
« on October 9th, 2011, 03:09 PM »
Calendar is okay because there aren't much feelings (hard or good) for it I guess :P
Overall, yes we could bundle a few plugins in the main file, but mainly as examples of how they're used, more than ways to separate core from plugin.
7505
Features / Re: New revs
« on October 9th, 2011, 03:06 PM »
rev 1078
(25 files, 19kb)

* Telling users their latest posts are going to disappear isn't very smart, especially if you're not going to delete them in the first place. Replaced default maintenance mode string with a more... suitable default. (other/Settings.php, other/Settings_bak.php)

* French translation fixes and minor grammar. (ManageSmileys.french.php, Post.french.php, Profile.language.php, Themes.french.php)

* Moved $security_file into the relevant language string. (Subs-Template.php, index.language.php)

* Micro-optimized westr_entity. A bit. As far as I know. I think. (Class-String.php)

* Indenazi, commenazi. (other/plugin-info.rng, ManageMaintenance.php, ManagePlugins.php, ManageServer.php, ManageMedia.php, Reminder.php)

- A few backup-related strings weren't removed entirely. (other/readme_up*.html, Admin.language.php, Errors.language.php)

- And some unused language strings. (index.language.php)

! Syntax error. (Activate.php)
7506
The Pub / Re: Spell checker
« on October 9th, 2011, 02:42 PM »
I'd tend to keep all of it in the core, myself. Just my opinion.
7507
Features / Re: New revs - Public comments
« on October 9th, 2011, 02:17 PM »
Okay, I'm finished with the review... Well, not completely, but I have committable material.
It's going to be a relatively big one, and I have to go for now, I hope to have it up and running within an hour.
Quote from Arantor on October 9th, 2011, 02:06 PM
I used a mix of my own memory and Google Translate when my memory failed me. I knew it probably wasn't perfect but I figured I'd give it a shot, and while I haven't had time to check the fixed translation, I'm willing to bet that not having 'here' in a separate string (for example) allows for better translation.
Definitely (although in French, it's not going to change anything.)
I also merged two strings for the same reason ('not_removed' error string.) Next commit.
Quote
No, it shouldn't be $txt[$error] passed to the update counter, it should be the $error on its own - the second parameter indicates where it came from, false for fatal_error, true for fatal_lang_error, because it deliberately doesn't stuff the entire message into the online table if it doesn't have to.
Okay, to save space... Good to know. As long as it's decoded back into $txt[$error] on the other side of the log viewing code... ;)
Still, what do you think of merging them?
Quote
The removal of the %p test in Subs... At the time I concluded it was redundant; the only language that I'm aware of that uses AM/PM in a 12-hour context is English, and I don't know any other language that prefers a 12 hour context over a 24 hour one.
I don't know either but I'm no specialist... Actually, in France, orally we use "5pm/5 o'clock" a lot, just like you British lot will say "teatime", we'll say "le quatre heures" (the 4pm). i.e. what we eat at teatime.
Now, with that said -- it's only oral, rarely written, because we don't have "pm" or "am", so we'll write "il est 20h" but we'll often say "il est 8h" and depending on the day time, it'll obviously mean 8h du matin (8am) or 8h du soir (8pm). There are also people, like me, who have a problem using *anything* else than military time. This morning, my girlfriend asked me for the time. I said "il est 11 heures 45". She replied, "why don't you just say midi moins le quart ?" (midi moins le quart = a quarter to noon.) I guess that's a problem with me mainly... Or because we geeks like to be precise. So the 2400 format is a blessing.
Quote
I can reinstate it but frankly I'd rather push English to 24 hour before I supported 12 hour more...
Do... Do you mean you actually removed support for am/pm entirely?! Really? (I like the idea... It's quite bold :lol:)
Quote
Where else is $txt['with'] used?
Nowhere...
Quote
If it's not used anywhere, remove it. Also check for merge_ on its own, strings get compounded a lot in the code.
I know, with strings like _desc or _info you have to be careful... But I just couldn't find anywhere the confirmation code for merging topics.
7508
Features / Re: New revs - Public comments
« on October 9th, 2011, 01:37 PM »
Pete, did you actually translate the new English strings to French? :lol:
Did you use a tool, or your own memories of the French language?

Well it's not perfect but I find it endearing to see you try ;)
Quote from Arantor on October 9th, 2011, 12:38 PM
With the changes to user, I had to specify a parameter (error type is param 2, sprintf vars is parameter 3). Where the type was specified I was fairly sure I'd got it right and where it wasn't specified (and thus it would be logged as general), I changed it, at the time it seemed more logical to flag it as a user error rather than a general error. It's not a general error in processing, it's because the user has done something wrong - and that to me makes more sense to flag as a user error.
If that's not an oversight, then that's fine with me ;)
Posted: October 9th, 2011, 12:58 PM

(Bump!)
Quote from Nao on October 9th, 2011, 11:28 AM
Pete -- there are so FEW fatal_error() calls left, I think it'd make sense to actually rename them to fatal_error_hardcoded() or something (who cares), and rename fatal_lang_error() to fatal_error()...
Posted: October 9th, 2011, 01:09 PM

In fatal_lang_error, we have this at some point:

   updateOnlineWithError($error, true, $sprintf);

At this point, $error is still the key to the $txt string, not the string itself. I'm changing this to $txt[$error], is it okay? (I suppose you're more acquainted to the Errors.php file than I am right now.)

Also, maybe we could simply remove fatal_error() and use the fatal_lang_error codepath all the time... I mean, if $txt[$error] isn't set, it simply shows $error... In both situations. (Well, it'd need some tweaking in fatal_lang_error though.)
Posted: October 9th, 2011, 01:20 PM

Any reason for removing the (strpos($str, '%p') !== false) test in Subs.php? (Not that I mind... :P)

Phew, only 600 lines left to check and I'll be 100% up to date with the newest rev... Yippie!
Posted: October 9th, 2011, 01:23 PM

index.language.php has:

$txt['merge_confirm'] = 'Are you sure you want to merge';
$txt['with'] = 'with';

I suspect the two are mixed together... And anyway, I couldn't find 'merge_confirm' used anywhere else. There's not even a single 'confirm' in SplitTopics.template.php... :-/
I'd remove these immediately (index language, hey! Waste of time!), but... $txt['with'] might be seen as 'important' for modders. So I'm at least asking whether there are objections to me deleting these ;)
7509
Features / Re: New revs - Public comments
« on October 9th, 2011, 11:28 AM »
Quote from TE on October 9th, 2011, 08:37 AM
just a small bug report:
Security.php line 419 starts with:
Thanks, fixed for Security... As for Errors, I can add an extra test, but are you sure you updated your local copy's Settings.php file? I know I didn't, originally, so $pluginsdir was empty...

I'm currently going through Pete's commits. 2000 more lines to go... Known song, this week :lol:
Unfortunately I can't devote a lot of time to Wedge this week. RL stuff :(
Quote
btw, how to enable or disable "Core Features"? I had disabled the gallery a while ago and now I cant find an option to enable the gallery again.. Maybe I'm blind but the "Core features" don't allow me to enable / disable a feature...
I don't believe the feature is buggy, but OTOH, Pete is adamant on deleting that page IIRC, so it'll end up being somewhere else.

If you want to re-enable it manually, that's in $modSettings/wedge_settings ;)
Posted: October 9th, 2011, 10:46 AM

Oh... And did you see the question for you above? (reply #183)
Posted: October 9th, 2011, 10:52 AM

(Found another syntax error in Activate.php, will fix in the next commit.)
Posted: October 9th, 2011, 11:21 AM

Pete -- there are so FEW fatal_error() calls left, I think it'd make sense to actually rename them to fatal_error_hardcoded() or something (who cares), and rename fatal_lang_error() to fatal_error()...
Posted: October 9th, 2011, 11:23 AM

Also, there are some places where the fatal error gets a 'user' value to it when the original was either false or 'general' (or empty, = 'general'). They're in Aeva-Gallery.php and Reminder.php:

-               fatal_error(sprintf($txt['media_cf_empty'], $field['name']));
+               fatal_lang_error('media_cf_empty', 'user', array($field['name']));

Any reason, Pete?
7510
Features / Re: New revs
« on October 9th, 2011, 11:00 AM »
rev 1077
(7 files, 9kb)

! Potential empty delimiter error. (Errors.php)

! Another syntax error in fatal_lang_error. (Security.php)

* Don't show security warnings within Ajax pages. (Subs-Template.php)

* French translation. (Admin.language.php, index.french.php, ManageMaintenance.french.php)
7511
The Pub / [Archive] Re: Logo Madness
« on October 9th, 2011, 12:54 AM »
Logo or logo+font-wise?
7512
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 9th, 2011, 12:42 AM »
I posted the list in the related topic.
7513
The Pub / [Archive] Re: Logo Madness
« on October 9th, 2011, 12:41 AM »
Lulz ;) I was thinking of the Phantom's mask in Phantom of the Paradise, myself ;)

Here's another one... Maybe not as good, but it's more organic. I think the brown shape is a bit too thick here.
Posted: October 8th, 2011, 11:08 PM

Or maybe this...
7514
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 8th, 2011, 11:30 PM »
I'll post a selection of my to do later. Tomorrow maybe.
Related posts would require implementing topic tags first. I'd say.
7515
The Pub / Re: Spell checker
« on October 8th, 2011, 11:14 PM »
Which limitations? Apart from the one where you can't post attachments in PMs and they're 'stuck' to a post...