This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
7441
Off-topic / Re: Post count fever
« on October 12th, 2011, 06:45 PM »
I'm a nerd myself. No shame about that.
7442
Features / Re: New revs - Public comments
« on October 12th, 2011, 04:25 PM »
Regarding the latest few commits... Wouldn't it make sense to have a function like, 'complex_string', whose purpose would be to do the common string replacements? (boardurl, scripturl...)
It wouldn't be as fast, though. But from the moment you implemented {variables}, I suppose it mattered less than having a non-dynamic list of text strings.Quote from Arantor on October 9th, 2011, 02:28 PM I totally forgot that this was recent, indeed...
I don't even know why people would need to translate this, meh.
Oh, and so... What about this %Y problem?
We *could* do it in a complicated way, such as {, %Y} where everything between {} would be removed if %Y is empty, but we'd need to apply this to all occurrences, which isn't cool... (Well, of course we could simply integrate the removal in the same code that gets rid of %Y in the first place.)
$show_today = str_replace(' %Y', '', $user_info['time_format']);
->
$show_today = preg_replace('~,? %Y~', '', $user_info['time_format']);
or
$show_today = str_replace(array(', %Y', ' %Y'), '', $user_info['time_format']);
(The second one is faster. strtr() has similar performance, can be 10%-20% faster or slower, totally randomly.)
Or simply remove the comma entirely..?
I really like not having the year when it's a recent post... It's halfway between hardcoded and dynamic dates. And it saves precious space.Quote Definitely better...Quote We could also kill $txt['by']... Either do $txt['by_person'] = 'by %1$s', or a series of more strings that would allow for 'by <strong>%1$s</strong>', etc...
Dunno.
It's just that in Japanese, the 'by' is usually shown after the name. But I think it can be put before the name as well, if needed. It just doesn't feel as natural. (And yeah, I know, even SMF doesn't have a Japanese version... But Kyôdai Mahjongg does :P)
It wouldn't be as fast, though. But from the moment you implemented {variables}, I suppose it mattered less than having a non-dynamic list of text strings.
Remember that AM/PM support was very late in the day, not only as a fix but as a report. It can't be that big a problem. It would be interesting to see what languages actually have updated $txt['am'] and $txt['pm'].
I don't even know why people would need to translate this, meh.
Oh, and so... What about this %Y problem?
We *could* do it in a complicated way, such as {, %Y} where everything between {} would be removed if %Y is empty, but we'd need to apply this to all occurrences, which isn't cool... (Well, of course we could simply integrate the removal in the same code that gets rid of %Y in the first place.)
$show_today = str_replace(' %Y', '', $user_info['time_format']);
->
$show_today = preg_replace('~,? %Y~', '', $user_info['time_format']);
or
$show_today = str_replace(array(', %Y', ' %Y'), '', $user_info['time_format']);
(The second one is faster. strtr() has similar performance, can be 10%-20% faster or slower, totally randomly.)
Or simply remove the comma entirely..?
I really like not having the year when it's a recent post... It's halfway between hardcoded and dynamic dates. And it saves precious space.
Support is very limited. All it does is search for %p, work out whether it's AM or PM and substitute in the relevant $txt item. Since I removed the $txt items and the test... it is all gone. Basically it just brings us back to around 2.0 RC4 - but the language itself now dictates what format to use, rather than a language independent version set by the admin.
Kill it. If it isn't being used, get rid of it, pure and simple.Quote Nowhere...
Dunno.
It's just that in Japanese, the 'by' is usually shown after the name. But I think it can be put before the name as well, if needed. It just doesn't feel as natural. (And yeah, I know, even SMF doesn't have a Japanese version... But Kyôdai Mahjongg does :P)
7443
Off-topic / Re: Post count fever
« on October 12th, 2011, 03:45 PM »
Hey you're only 190 posts away from my own count ;)
The 7500 mark will be for you, in the end!
Quote from Arantor on September 26th, 2011, 08:50 AM You only removed it yesterday ;)
The 7500 mark will be for you, in the end!
Posted: October 12th, 2011, 03:44 PM
No, that easter egg was removed in Wedge. Don't know about here though :P
7444
Development blog / Re: Plugging in the Plugin Manager
« on October 12th, 2011, 08:38 AM »
It's a bug that was on noisen as well.i never bothered to fix it. Shane on me :P
7445
Development blog / Re: Plugging in the Plugin Manager
« on October 11th, 2011, 03:56 PM »
I don't know, I want to put tags and tag types everywhere I can... If one day you see me walking with a limp, you can probably assume I tried putting them there as well :P
7446
The Pub / Re: English British support
« on October 11th, 2011, 03:54 PM »
I'd tend to say it's more amusing/exciting to only keep the relevant entries.
The load fallback is here to stay, if you ask me. I think most people really prefer to have an English string rather than nothing.
Possibilities to explore...
- add a version number to every single language file. Increase version number whenever a change is made to the English version. Compare current version against English version to determine whether we need to load the English fallback (and warn the admin that their language file is broken.)
- store language files in a serialized array in the database. (or in the cache. I think there's already a cache level for language files. A bad one IIRC, because of the variables involved.) When caching fallback & non-fallback, check whether the English version has some extra strings, and only store those.
The load fallback is here to stay, if you ask me. I think most people really prefer to have an English string rather than nothing.
Possibilities to explore...
- add a version number to every single language file. Increase version number whenever a change is made to the English version. Compare current version against English version to determine whether we need to load the English fallback (and warn the admin that their language file is broken.)
- store language files in a serialized array in the database. (or in the cache. I think there's already a cache level for language files. A bad one IIRC, because of the variables involved.) When caching fallback & non-fallback, check whether the English version has some extra strings, and only store those.
7447
Development blog / Re: Plugging in the Plugin Manager
« on October 11th, 2011, 03:46 PM »
I was thinking mainly about tags along with tag types... Only the tag types would need to be fixed, not the tags themselves.
7448
Features / Re: New revs
« on October 11th, 2011, 03:40 PM »
rev 1097
(6 files, forgot to check size)
* The PM area in the info center should use $txt['personal_messages'] rather than $txt['personal_message'] as its title. Also removed the odd duplicate, added whitespace and increased the font size for the previously smalltext details. (InfoCenter.template.php)
- Removed $txt['msg_alert_you_have'], $txt['msg_alert_messages'] and $txt['your_pms'], unused in Wedge. Or even SMF probably. (index.french.php)
- Removed support for Imeem from Aeva. That's three entries in the sitelist. Apparently they were bought out by MySpace two years ago and nobody bothered to tell me, eh eh. I suspect there are dozens more such dead websites in the list... Anyone willing to test them? (Subs-Aeva-Sites.php)
- Removed an unused parameter in setFocus(). (editor.js)
* French translation. (index.french.php, ManagePlugins.french.php)
! Undefined global in is_already_taken(). (Subs-PrettyUrls.php)
(6 files, forgot to check size)
* The PM area in the info center should use $txt['personal_messages'] rather than $txt['personal_message'] as its title. Also removed the odd duplicate, added whitespace and increased the font size for the previously smalltext details. (InfoCenter.template.php)
- Removed $txt['msg_alert_you_have'], $txt['msg_alert_messages'] and $txt['your_pms'], unused in Wedge. Or even SMF probably. (index.french.php)
- Removed support for Imeem from Aeva. That's three entries in the sitelist. Apparently they were bought out by MySpace two years ago and nobody bothered to tell me, eh eh. I suspect there are dozens more such dead websites in the list... Anyone willing to test them? (Subs-Aeva-Sites.php)
- Removed an unused parameter in setFocus(). (editor.js)
* French translation. (index.french.php, ManagePlugins.french.php)
! Undefined global in is_already_taken(). (Subs-PrettyUrls.php)
7449
The Pub / Re: Spell checker
« on October 11th, 2011, 12:28 PM »
Had a quick look at the overall code for spellchecking...
- It represents a sizeable amount of code. Most entries don't take extra CPU cycles when spellchecking is disabled, but it does for instance add 1.5KB of data to the JS editor, even if disabled/not available.
- There is nothing that prevents us from using pspell in the search feature to show potential typos *EVEN* with spellchecking disabled or removed entirely. Actually, I don't even know why the setting is linked to whether you enable the spellchecker or not... Search is expensive in general, might as well make use of pspell if available.
- It represents a sizeable amount of code. Most entries don't take extra CPU cycles when spellchecking is disabled, but it does for instance add 1.5KB of data to the JS editor, even if disabled/not available.
- There is nothing that prevents us from using pspell in the search feature to show potential typos *EVEN* with spellchecking disabled or removed entirely. Actually, I don't even know why the setting is linked to whether you enable the spellchecker or not... Search is expensive in general, might as well make use of pspell if available.
7450
Development blog / Re: Plugging in the Plugin Manager
« on October 11th, 2011, 10:29 AM »
Lookin' nice :)
Maybe we could also sort by author... Or plugin type... Dunno.
Maybe we could also sort by author... Or plugin type... Dunno.
7451
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 11th, 2011, 09:51 AM »
Btw I'm not a calendar user myself. I could care less about it. But I think it has potential for being useful like having a link in all dates that would point to that days posts.
I'm just saying I thought more people liked the calendar. Per se it's not important to have it in the core but if we change our minds later we can always rebuild it into the core in 2.0 or so.
I'm just saying I thought more people liked the calendar. Per se it's not important to have it in the core but if we change our minds later we can always rebuild it into the core in 2.0 or so.
7452
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 11th, 2011, 09:47 AM »
Event topics are a social thing though.
7453
Development blog / Re: Plugging in the Plugin Manager
« on October 11th, 2011, 09:43 AM »
It would be nice yeah :)
7454
Features / Re: Template skeleton!
« on October 11th, 2011, 01:18 AM »
I'm just pretty sure there's a way to minify these with little overhead even at the cost of limited gains.
7455
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 11th, 2011, 01:09 AM »
Zero votes for core? Calendar isn't loved much :P