Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
736
Archived fixes / Re: Install error get_preferred_language()
« on May 31st, 2014, 12:59 AM »
Ouch, forgot to check non-core files...
I think your fix has a limitation, in that it will always return English...
Can you test by replacing the line with this..?
Code: [Select]
Does it return your browser's preferred language pack, now..?
I think your fix has a limitation, in that it will always return English...
Can you test by replacing the line with this..?
$settings['language'] = 'english';
$settings['userLanguage'] = 1;
$lang = we::get_preferred_language();Does it return your browser's preferred language pack, now..?
737
Bug reports / [Proxy Settings] Re: X-Forwarded-For not recognized
« on May 30th, 2014, 01:59 PM »
So, it's not for the Bug Reports board but for some FAQ, right...? ;)
738
Archived fixes / [switch languages] Re: Weird error
« on May 30th, 2014, 01:59 PM »
I think this is fixed...
I was able to reproduce by logging off from my mobile phone, and then trying to go to a board.
After some backtracking, I figured out that it was due to a missing we::permissions() call in the loadPermissions function.
Nasty one, and my fault I'm afraid!
(Still can't figure out why you got this in that situation, though, but please confirm whether it's fixed...)
I was able to reproduce by logging off from my mobile phone, and then trying to go to a board.
After some backtracking, I figured out that it was due to a missing we::permissions() call in the loadPermissions function.
Nasty one, and my fault I'm afraid!
(Still can't figure out why you got this in that situation, though, but please confirm whether it's fixed...)
739
Features / Re: New revs
« on May 30th, 2014, 01:54 PM »
[Commit revision d1085d7]
Author: Nao
Date: Fri, 30 May 2014 13:54:33 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
Date: Fri, 30 May 2014 13:54:33 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)
- Enabling cache level >= 2 would generate 'query_see_topic' errors for guests visiting board indexes. (Load.php)
740
Features / Re: New revs
« on May 30th, 2014, 12:28 AM »
[Commit revision 9ab15f5]
Author: Nao
Date: Fri, 30 May 2014 00:28:27 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)
Date: Fri, 30 May 2014 00:28:27 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)
- One of those inheritance thingies... (Wine/extra.css)
741
Features / Re: New revs
« on May 29th, 2014, 11:55 PM »
[Commit revision e4fbaa3]
Author: Nao
Date: Thu, 29 May 2014 23:55:10 +0200
Stats: 3 files changed; +23 (insertions), -1 (deletion)
Date: Thu, 29 May 2014 23:55:10 +0200
Stats: 3 files changed; +23 (insertions), -1 (deletion)
- Having some wicked fun with blog comment styling, adding a bubble speech effect next to the avatar. I used the 'traditional' triangle technique for this, because it's easier to position it precisely. Also disabled it on mobile-friendly skins, because it wouldn't make sense in there. (Wilderless/extra.css, Wireless/extra.css, sections.css)
- I'll remove the effect if it's rejected by the community. I just thought it would be fun for a change, plus it shows that you can easily remove the effect through a .blog reset command.
742
The Pub / Re: Hosting
« on May 29th, 2014, 10:53 PM »
Generation times indicated at the bottom of the page are only related to server performance, not network performance.
You can have a page generated in 0.02s and still need 10 seconds to load it, just as you could have a page generated in 0.5s and need 2 seconds to load it. Network performance is critical in getting people to stay on your website.
You can have a page generated in 0.02s and still need 10 seconds to load it, just as you could have a page generated in 0.5s and need 2 seconds to load it. Network performance is critical in getting people to stay on your website.
743
Archived fixes / Re: follow_me() bug, shows up from time to time.
« on May 29th, 2014, 10:20 PM »
It was turning me crazy ;)
Current browser implementations of flexbox just aren't fault-free, and I need them to work yesterday!
Current browser implementations of flexbox just aren't fault-free, and I need them to work yesterday!
744
The Pub / Re: Dsitributed Project Translation (Transifex)
« on May 29th, 2014, 09:19 PM »That's what i want to ask you :unsure: .....Quote from Nao How are we supposed to retrieve completed (or ongoing) translations, apart from downloading files one by one..?
From what I could see, these guys expect us to use a command-line tool to communicate with their API and retrieve multiple files at the same time... It's that, or manually downloading every file! That sucks big time.
As for array() strings, there is no way to have Transifex recognize them. I couldn't find any way to manually tell them, "this place in this file can and should be translated..."
I don't know, but I figured there MUST be a better tool somewhere on the web than... THAT?!
745
Features / Re: New revs
« on May 29th, 2014, 09:00 PM »
[Commit revision 553d66e]
Author: Nao
Date: Thu, 29 May 2014 21:00:05 +0200
Stats: 1 file changed; +0 (insertion), -2 (deletions)
Date: Thu, 29 May 2014 21:00:05 +0200
Stats: 1 file changed; +0 (insertion), -2 (deletions)
- Transifex thinks that commented-out strings are still translatable, so until I determine whether we'll use that for distributed translations, I'm removing the only commented out string I could find. (Profile.english.php)
746
Features / Re: Language revs
« on May 29th, 2014, 08:59 PM »
[Commit revision de124fa]
Author: Nao
Date: Thu, 29 May 2014 20:59:21 +0200
Stats: 2 files changed; +0 (insertion), -4 (deletions)
Date: Thu, 29 May 2014 20:59:21 +0200
Stats: 2 files changed; +0 (insertion), -4 (deletions)
- Transifex thinks that commented-out strings are still translatable, so until I determine whether we'll use that for distributed translations, I'm removing the only commented out string I could find. (Profile)
747
Features / Re: New revs
« on May 29th, 2014, 05:04 PM »
[Commit revision c55862b]
Author: Nao
Date: Thu, 29 May 2014 17:03:40 +0200
Stats: 1 file changed; +15 (insertions), -10 (deletions)
Date: Thu, 29 May 2014 17:03:40 +0200
Stats: 1 file changed; +15 (insertions), -10 (deletions)
- Fixed a Pete bug from exactly a year ago: if the cache entry for $context['languages'] had expired, the newly cached version would return (for this page load) the full list of languages, not just the available ones. As a result, purging the entire cache tended to cache unused language icons, which was a really bad thing until recently when I optimized their sizes. Anyway, that one's finally fixed... (Load.php)
748
Features / Re: New revs
« on May 29th, 2014, 02:32 PM »
[Commit revision 03a3393]
Author: Nao
Date: Wed, 28 May 2014 09:11:03 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)
[Commit revision 8b654af]
Author: Nao
Date: Wed, 28 May 2014 16:05:46 +0200
Stats: 3 files changed; +33 (insertions), -34 (deletions)
[Commit revision dfa1bdf]
Author: Nao
Date: Thu, 29 May 2014 14:31:32 +0200
Stats: 2 files changed; +56 (insertions), -58 (deletions)
[Commit revision 9c6859b]
Author: Nao
Date: Thu, 29 May 2014 14:32:11 +0200
Stats: 3 files changed; +14 (insertions), -2 (deletions)
Date: Wed, 28 May 2014 09:11:03 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)
- Bad aspect ratio in Wilderless avatars. (extra.css)
[Commit revision 8b654af]
Date: Wed, 28 May 2014 16:05:46 +0200
Stats: 3 files changed; +33 (insertions), -34 (deletions)
- Went for a better styling of the board list. It's shorter code, gets us rid of eight !important hacks, looks better in all situations, and I used the opportunity to move the board icon to a variable, so that you can change it without having to update sizes and margins at the same time. (Boards.template.php, common.css, sections.css)
[Commit revision dfa1bdf]
Date: Thu, 29 May 2014 14:31:32 +0200
Stats: 2 files changed; +56 (insertions), -58 (deletions)
- Moved get_preferred_language to a we:: method, as it's only used there anyway... (Class-System.php, Subs.php)
- Browser-preferred language map is no longer built manually, but rather from the list of installed packs. Much, much better... (Class-System.php)
- This should also fix a few language bugs that were reported before (needs more testing). Thanks to CerealGuy for prompting me to do this rewrite!
[Commit revision 9c6859b]
Date: Thu, 29 May 2014 14:32:11 +0200
Stats: 3 files changed; +14 (insertions), -2 (deletions)
- Minor tweaks to make Warm, Wireless and Wilderless more tolerable. (*/extra.css)
749
Archived fixes / Re: More language bugs
« on May 29th, 2014, 01:12 AM »
French (what an odd name for a Dutch person :P), why should language packs influence the project's release date? The more used it is, the more people are likely to help translate it...?
Also, I have my own personal timeline on this (i.e., I have a kid coming up in 6 weeks), and I'd rather not rely on anyone else to follow it. A certain P**e systematically postponed the Wedge release date to add new "ballsy" features, and without him it'd have been out 3 years ago........
CerealGuy, thanks for your attention overall. I just wanted to add that the isset($context) test should also be done from within get_preferred_language, when about to give an automatic language choice according to the browser preference. I totally forgot about doing that, so it's good you spotted the original problem..!
I also fixed $languages not being declared in the function (it was declared in the system class, rather than in Subs.php... Woops.)
Also, I have my own personal timeline on this (i.e., I have a kid coming up in 6 weeks), and I'd rather not rely on anyone else to follow it. A certain P**e systematically postponed the Wedge release date to add new "ballsy" features, and without him it'd have been out 3 years ago........
CerealGuy, thanks for your attention overall. I just wanted to add that the isset($context) test should also be done from within get_preferred_language, when about to give an automatic language choice according to the browser preference. I totally forgot about doing that, so it's good you spotted the original problem..!
I also fixed $languages not being declared in the function (it was declared in the system class, rather than in Subs.php... Woops.)
750
The Pub / Re: Project Dutch Translation (Transifex)
« on May 29th, 2014, 01:04 AM »
Stupid question, but...
How are we supposed to retrieve completed (or ongoing) translations, apart from downloading files one by one..?
Also, I noticed their software disregards comment signs, so "// $txt['something'] = 'Something not to translate';" will STILL be available in the interface, e.g. Profile.english.php has $txt['ignoretopics'] disabled because it's an unimplemented feature, and I certainly don't want people to waste their time translating this kind of string.... :^^;:
Another limitation of Transifex is that it doesn't accept language strings when they're stored in arrays ($txt['something'] = array(0 => 'zero', 1 => 'one')).
That's a problem, because there are dozens such strings...!
How are we supposed to retrieve completed (or ongoing) translations, apart from downloading files one by one..?
Also, I noticed their software disregards comment signs, so "// $txt['something'] = 'Something not to translate';" will STILL be available in the interface, e.g. Profile.english.php has $txt['ignoretopics'] disabled because it's an unimplemented feature, and I certainly don't want people to waste their time translating this kind of string.... :^^;:
Posted: May 29th, 2014, 12:57 AM
Another limitation of Transifex is that it doesn't accept language strings when they're stored in arrays ($txt['something'] = array(0 => 'zero', 1 => 'one')).
That's a problem, because there are dozens such strings...!