Wedge

rev 1193
(1 file, 8kb)

* More size optimizations in the jQuery-Proto area. Sometimes, using local variables to stand for strings will actually increase the size, not after packing the file but after gzipping it. Also, accessing an object property by dot compresses better than by brackets. Also removed support for $.getObject() and function throttling, since we don't use these plugins. Removed 'above' class from drop-up list boxes (i.e. when it opens from the bottom), until I have a good reason to style that. Will probably re-introduce later. Gzipped size for sbox.js is now down to 2941 bytes[1]. (sbox.js)

1.

As a reminder, I started at 3579 bytes, and that's without removing any features -- only removed the ability to change some uninteresting features on the fly. Also, jquery.selectBox.js compresses at 2977 bytes so it's as if I'd started with this one, compressed it even more and added the extra features from the plugin I eventually chose...

rev 1192
(2 files + 1, 33kb)

+ Added select box code. Forgot it in the last commit... The starting comment has /** instead of /*! because it's added to script.js so we don't need the duplicate copyright lines in the packed version. (sbox.js, Load.php)

* Use proper nesting on select box styling. Added some padding around the list box. (index.css)

- It was fixed and working great, at least when I last dealt with it... i.e. it must have broken after that, while fixing something else in an unrelated place. Can you confirm and look into it?

- Just to be clear: if I ever commit "work in progress" code with shitty commented out stuff, it is NOT as planned, unless I'm clearly specifying it in the changelog (I usually apologize for this kind of thing.) I also found out that rev 1186 has my work-in-progress script.js committed... Just the same: it's shitty and not as planned. And again, it's not mentioned in the changelog.

Every time you commit something, I'll make sure to ensure you haven't committed any 'weird' stuff that's not in the changelog, and if there is, I'll ask you about it... I can do that kind of mistake, too, so I was kinda hoping someone was checking on my commits...

Oh my... It would appear the little f*cker is dead.

I don't know why or how. It just doesn't register when I edit or type in a new thought.

Can anyone who tested the thought system (on a local copy) so far give me some feedback on this...? Did you ALWAYS see that issue? Send a thought -> the return copy is empty and nothing is entered into the DB. No errors either...
I really don't want to bother with Ajax debugging right now :(

Oh, and I also messed up rev 1179... It was last month already -- and I committed a file that wasn't supposed to be (index.css), with selectbox styling for a feature that wasn't even in...

Pete or anyone, when you see that kind of file and it's NOT documented, can you report it please...? It usually means I forgot to uncheck a file that's not ready for consumption... (And yes I do have a fair share of files I have to uncheck every time. Pretty annoying really. But if I start putting them on Ignore, I'll just forget to deal with them in the future...)

This one's funny, too...
(packed version)

var b,e,h,b=c(this);

Realized my mistake, turned it into this...

var e,h,b=c(this);

And voilà! 3 extra bytes to the filesize, ah ah...

Bump on the above... :whistle:

So, now that I'm done with mismatched tags, I'm trying to get back into the select box stuff.
Decided to try for jquery.sb.js for now, and try to optimize the size (since it's really the only thing I have against it.)

Pete, you remember the discussion we had on the oddities of gzipping? Well, it's back in full force...

something = function (event, params) { otherthing.call(event, params); };

So... I figured out that params was never used, so I removed both params calls.
As a result, the gzipped file is 5 bytes larger. Ah ah.

Now... I have plenty of if (...) { one_instruction(); } in the code. I removed the curly braces. As a result, the more braces I remove, the LARGER the gzipped file becomes.
Okay, so I figured, if it's crazy enough to do things like that, let's tag along and add a preg_replace[1] to add curly braces to all single-line tests...
And guess what? It's the exact same size as before it was modified. I looked into it a bit more, and there's just TWO cases where removing the curly braces will make the file bigger, while in other situations it'll usually save a byte.

Anyway, I'm pretty much done and saved about 350 bytes off the original ~3700 bytes. It's not fantastic, but at least it's getting closer to the other selectboxes, and with the extra features.

Now it's going to be realllllly funny when I actually try to run the plugin on Wedge... Yeah, I didn't even try :P

And... it works :)

1.	for the record, preg_replace('~(\tif \([^{}\n]+\n\t+)([^{}\n]+);(\n)~', '$1{$2}$3', $cont)

I'll leave it up to you to look into all of this... I feel I have done my share of the work on this for now! :P

Okay, done...

I've made so many tests using my test code, it should really be okay at this point... But you never know.
Also, I need to fix that bug with nb parsing... Grmpf. It's like it never ends... And my code is pretty useless -- I mean, the auto-fixer doesn't really have a point because parse_bbc already accounts for most errors...