Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
6871
Features / Re: New revs
« on December 15th, 2011, 08:37 PM »
rev 1200
(3 files, 1kb) (oh, come on... It's gotta be more than that! Especially the JumpTo rewrite!)
* Rewrote the JumpTo class into a single function. Categories are no longer selectable (what's the point anyway?), and they're shown, more logically, as option groups. As a result, the code is clearer and shorter. (script.js, Xml.template.php)
! Folding out years in the stats section would never register internally, because of a wrong method name. (script.js, stats.js)
- Got rid of the 'hoverable' menu code because rev 1024's clever hack was pretty much doing the same. (script.js)
* Boolean to integer is done just by adding a + before the var name, like +is_ie8down... I should do that more often. (script.js)
(3 files, 1kb) (oh, come on... It's gotta be more than that! Especially the JumpTo rewrite!)
* Rewrote the JumpTo class into a single function. Categories are no longer selectable (what's the point anyway?), and they're shown, more logically, as option groups. As a result, the code is clearer and shorter. (script.js, Xml.template.php)
! Folding out years in the stats section would never register internally, because of a wrong method name. (script.js, stats.js)
- Got rid of the 'hoverable' menu code because rev 1024's clever hack was pretty much doing the same. (script.js)
* Boolean to integer is done just by adding a + before the var name, like +is_ie8down... I should do that more often. (script.js)
6872
Features / Re: New revs
« on December 15th, 2011, 06:50 PM »
rev 1199
(9 files, 4kb) (another one coming up.)
! Fixed the 'extends' keyword appearing directly in compiled CSS files for IE6. (Class-CSS.php)
! Fixed submenu arrows and post backgrounds in IE6. Hey, first actual use of 'unextends' in my code! (index.ie6.css, skin.xml)
! Fixed menu arrow positions in all browsers, and a few color issues in Wuthering. (index.ie7.css, Warm/index.css, Wuthering/index.css, Wuthering/index.ie6.css)
! Syntax error (: instead of ::). (ManageMedia.php)
! $txt['who_index'] contains {forum_name}, yet was set in a code block that didn't through the {forum_name} replacement. (Who.php)
(9 files, 4kb) (another one coming up.)
! Fixed the 'extends' keyword appearing directly in compiled CSS files for IE6. (Class-CSS.php)
! Fixed submenu arrows and post backgrounds in IE6. Hey, first actual use of 'unextends' in my code! (index.ie6.css, skin.xml)
! Fixed menu arrow positions in all browsers, and a few color issues in Wuthering. (index.ie7.css, Warm/index.css, Wuthering/index.css, Wuthering/index.ie6.css)
! Syntax error (: instead of ::). (ManageMedia.php)
! $txt['who_index'] contains {forum_name}, yet was set in a code block that didn't through the {forum_name} replacement. (Who.php)
6873
The Pub / Re: Jump box and its stupid Go button
« on December 15th, 2011, 06:23 PM »
Categories have always been selectable from the jumpto box... At least AFAIK. Of course, in SMF it's always the board index with an anchor, so it's doesn't matter... In Wedge it's a little different, though.
I'll go for optgroup now, if no one is bothered by this.
BTW, the server issues at wedge.org are documented here:
http://status.alwaysdata.com/operation/17/
I'm afraid it's going to last for a bit more, but at least "they're on it"... To each their bugs ;)
I'll go for optgroup now, if no one is bothered by this.
BTW, the server issues at wedge.org are documented here:
http://status.alwaysdata.com/operation/17/
I'm afraid it's going to last for a bit more, but at least "they're on it"... To each their bugs ;)
6874
Off-topic / Re: Doctor Who
« on December 15th, 2011, 06:14 PM »
Well then he'll regenerate into 13, get killed immediately by his companion on his request prior to regenerating, and then become 14 on the way to 500.. :P
6875
Off-topic / Re: Doctor Who
« on December 15th, 2011, 05:12 PM »
Yes you can.
And congrats on being the 4th member to reach the 1000-post milestone!
And congrats on being the 4th member to reach the 1000-post milestone!
6876
The Pub / Re: Jump box and its stupid Go button
« on December 15th, 2011, 01:48 PM »
Okay, so... I've been rewriting the jumpto code to use the new select box.
It struck me as odd that <optgroup> tags weren't being used for categories, as would be customary when trying to show two different types (categories and boards).
Of course, the reason it was done this way was for categories to be a valid target, because you can't select an optgroup, only an option.
So, I did my little rewrite with optgroups, and it just feels more natural to me, but I can't commit it without asking for opinions around here. I know the quick board access selector isn't used by a lot of people, so... to those who actually use it at least once a year:
- did you ever click a category instead of a different board? do you prefer to use the quick access to jump to the current category, or to simply click the category name in the bread crumb?
- do you think maybe I should add support for optgroup values, i.e. <optgroup value="http://website/category/" label="This is a group">? This totally wouldn't validate, but it'd only be done through JS. I don't like this solution though...
- do you like the jump box just the way it is, and are okay with the script.js file being a few dozen bytes larger to keep that...?
It struck me as odd that <optgroup> tags weren't being used for categories, as would be customary when trying to show two different types (categories and boards).
Of course, the reason it was done this way was for categories to be a valid target, because you can't select an optgroup, only an option.
So, I did my little rewrite with optgroups, and it just feels more natural to me, but I can't commit it without asking for opinions around here. I know the quick board access selector isn't used by a lot of people, so... to those who actually use it at least once a year:
- did you ever click a category instead of a different board? do you prefer to use the quick access to jump to the current category, or to simply click the category name in the bread crumb?
- do you think maybe I should add support for optgroup values, i.e. <optgroup value="http://website/category/" label="This is a group">? This totally wouldn't validate, but it'd only be done through JS. I don't like this solution though...
- do you like the jump box just the way it is, and are okay with the script.js file being a few dozen bytes larger to keep that...?
6877
Features / Re: New revs
« on December 15th, 2011, 12:22 PM »
rev 1198
(5 files, 3kb)
+ Down from 2700 to 2696, but added support for per-option CSS (used in quick access). The next commits will probably see the size go a bit up, which is okay. I'm really only trying to keep it below 3000... (sbox.js)
! Fixed optgroup support (was broken by a careless edit), and apparently optionFormat doesn't even require to retrieve the label for optgroups, text() will figure it out for itself. (sbox.js)
! Fixed optgroup styling, too, and improved box shadow. (sbox.js, index.css)
* Moved message_index_jump_to's associated floatright to the ID itself, and fixed top padding. (MessageIndex.template.php, sections.css)
* Incomplete comment. (index.member.css)
(5 files, 3kb)
+ Down from 2700 to 2696, but added support for per-option CSS (used in quick access). The next commits will probably see the size go a bit up, which is okay. I'm really only trying to keep it below 3000... (sbox.js)
! Fixed optgroup support (was broken by a careless edit), and apparently optionFormat doesn't even require to retrieve the label for optgroups, text() will figure it out for itself. (sbox.js)
! Fixed optgroup styling, too, and improved box shadow. (sbox.js, index.css)
* Moved message_index_jump_to's associated floatright to the ID itself, and fixed top padding. (MessageIndex.template.php, sections.css)
* Incomplete comment. (index.member.css)
6879
Features / Re: New revs
« on December 15th, 2011, 10:38 AM »
rev 1197
(1 file, 1kb)
! Forgot to load Class-Editor before preparsing thoughts. Now this is where that auto-loader would have been useful eh... (Ajax.php)
(1 file, 1kb)
! Forgot to load Class-Editor before preparsing thoughts. Now this is where that auto-loader would have been useful eh... (Ajax.php)
6880
Off-topic / Re: Doctor Who
« on December 15th, 2011, 08:02 AM »
What's with your name change btw? ;)
6881
Off-topic / Re: Doctor Who
« on December 15th, 2011, 08:01 AM »
She said it on the show?
Because afaik she doesn't die in it... Only Brigadier has a cannon death.
Because afaik she doesn't die in it... Only Brigadier has a cannon death.
6882
Features / Re: New revs
« on December 14th, 2011, 06:19 PM »
rev 1196
(1 file, 5kb) -- hey, this one actually has bug fixes and all! :P
* Down from 2751 to 2700. Removed the triggerHandler helper because it turned out closeAll() was never used, and thus there was only one actual use of it. Saved a few bytes by replacing some events and function calls (blurOrig, focusOrig, getEnabled, getSelected, positionSBIfOpen) with their actual contents. And finally, some local vars don't need to be set to null because they're set anyway as soon as the object is created. (sbox.js)
- Removed .options({...}) public method. I can't think of any good reason to actually change an option for a select box *after* it was created... (sbox.js)
! Fixed that annoying bug with hover states. It adds ~20 bytes to the gzipped file (the is_closed stuff) but it's better than a frigging bug! (sbox.js)
! Prevented consecutive select box clicks from selecting text around the select box (the mousedown stuff). Gzipping will always fascinate me: adding an extra line of code actually removed an extra byte from the final file... (sbox.js)
(1 file, 5kb) -- hey, this one actually has bug fixes and all! :P
* Down from 2751 to 2700. Removed the triggerHandler helper because it turned out closeAll() was never used, and thus there was only one actual use of it. Saved a few bytes by replacing some events and function calls (blurOrig, focusOrig, getEnabled, getSelected, positionSBIfOpen) with their actual contents. And finally, some local vars don't need to be set to null because they're set anyway as soon as the object is created. (sbox.js)
- Removed .options({...}) public method. I can't think of any good reason to actually change an option for a select box *after* it was created... (sbox.js)
! Fixed that annoying bug with hover states. It adds ~20 bytes to the gzipped file (the is_closed stuff) but it's better than a frigging bug! (sbox.js)
! Prevented consecutive select box clicks from selecting text around the select box (the mousedown stuff). Gzipping will always fascinate me: adding an extra line of code actually removed an extra byte from the final file... (sbox.js)
6883
Features / Re: New revs
« on December 14th, 2011, 01:22 PM »
rev 1195
(2 files, 5kb)
* Down from 2827 to 2751. It's harder to save space now... I won't save much if I don't disable more features, like ARIA, so I need a bit of reading on this. Changing .size() to .length is faster (no function call overhead), and compresses better. The optionFormat simplification saves a lot. optgroup handling wasted a local var. Also, flickerDisplay doesn't need its own function as it's called only once (plus, I couldn't see any issues in IE7 even when disabled.) And a newly created option tag doesn't need a default empty value because that's what it gets anyway. (sbox.js)
* Menu arrows were off by a pixel. (index.css)
(2 files, 5kb)
* Down from 2827 to 2751. It's harder to save space now... I won't save much if I don't disable more features, like ARIA, so I need a bit of reading on this. Changing .size() to .length is faster (no function call overhead), and compresses better. The optionFormat simplification saves a lot. optgroup handling wasted a local var. Also, flickerDisplay doesn't need its own function as it's called only once (plus, I couldn't see any issues in IE7 even when disabled.) And a newly created option tag doesn't need a default empty value because that's what it gets anyway. (sbox.js)
* Menu arrows were off by a pixel. (index.css)
6884
Features / Re: New revs
« on December 13th, 2011, 07:13 PM »
rev 1194
(1 file, 4kb)
* And again, optimizing the select box for size... obj.access is never used so it's gone, obj.init is always there so it's not tested, getDDCtx will now always return o.ctx (couldn't find a reason to support setting 'self' or a function on it), moved the init code to the top of the object (only saves 6 bytes but it's also cleaner), replaced a substring() with the [0] equivalent, hardcoded acTimeout (who needs to fine-tune the timeout between key presses when typing a string? I doubt people even know they can do that), hardcoded the space threshold to 50 pixels (and would probably benefit from being even smaller), and rewrote positionSB in a smarter and shorter way. Current gzipped size: 2827 bytes, down from 2941. Now we're talking... (sbox.js)
@ I doubt I can go below 2500 bytes, BTW... Even going below 2800 is going to be hard, at this point. The only thing I can see here is getting rid of $ddCtx but that would imply that skins are no longer able to set a margin on the body... OTOH, why would they do that? It's just that if someone doesn't think of adding an extra div, I'm just not sure I want to see them ask for support because suddenly their select boxes are broken...
@ Also, I just noticed a small bug in the plugin. If you select an item and close a SB, if you reopen it, sometimes the selected item will still have the hover class on it, even though the code correctly removes it... Oh, I don't feel like hunting that one... :-/
(1 file, 4kb)
* And again, optimizing the select box for size... obj.access is never used so it's gone, obj.init is always there so it's not tested, getDDCtx will now always return o.ctx (couldn't find a reason to support setting 'self' or a function on it), moved the init code to the top of the object (only saves 6 bytes but it's also cleaner), replaced a substring() with the [0] equivalent, hardcoded acTimeout (who needs to fine-tune the timeout between key presses when typing a string? I doubt people even know they can do that), hardcoded the space threshold to 50 pixels (and would probably benefit from being even smaller), and rewrote positionSB in a smarter and shorter way. Current gzipped size: 2827 bytes, down from 2941. Now we're talking... (sbox.js)
@ I doubt I can go below 2500 bytes, BTW... Even going below 2800 is going to be hard, at this point. The only thing I can see here is getting rid of $ddCtx but that would imply that skins are no longer able to set a margin on the body... OTOH, why would they do that? It's just that if someone doesn't think of adding an extra div, I'm just not sure I want to see them ask for support because suddenly their select boxes are broken...
@ Also, I just noticed a small bug in the plugin. If you select an item and close a SB, if you reopen it, sometimes the selected item will still have the hover class on it, even though the code correctly removes it... Oh, I don't feel like hunting that one... :-/
6885
Features / Re: Thought system
« on December 13th, 2011, 03:25 PM »
Found the culprit... In Ajax.php, rev 1184, I added a wedit::preparsecode($text) on the thought. Uh...
So... It doesn't generate an error in the database. Hard to trace. I simply removed the line from my current rev and it works. And it's not related to my fixNesting stuff because it wasn't already there in rev 1184... :-/
So... It doesn't generate an error in the database. Hard to trace. I simply removed the line from my current rev and it works. And it's not related to my fixNesting stuff because it wasn't already there in rev 1184... :-/