Wedge

It's all in here...
http://svnbook.red-bean.com/en/1.4/svn.advanced.props.special.keywords.htmlAgreed...

Wanna do it?

And for the jumpto on this field? You or me? Can add to my to-do (although it's a bit crowded...), as you like.

DS, I think you need to read a Song timeline because it's easy to get it wrong ;)

http://tardis.wikia.com/wiki/River_Song

(Oh, and to anyone who hasn't seen "Night and the Doctor" yet -- there's a spoiler in this article, so don't read it!!)

rev 1243
(3 files, 2kb)

* Simplified the HTML markup for the scrollbar. Gone is the track div (the scrollbar div itself does the job perfectly), the thumb div loses its class, and viewport/scrollbar are now floated instead of absolutely-positioned (note to self: .viewport doesn't need to be floated, it just makes the file shorter), which makes for simpler code in the end, and this actually... (index.css)

! ...Fixed the scrollbar in IE6. Phew, at last. Tested final code on IE 6/7/8/9, Safari 5.1, Chrome 17, Firefox 9 and Opera 12. Works flawlessly everywhere (except for the odd margins on IE 6/7, probably due to an issue in styling unordered lists.) (sbox.js, index.css)

* The credits page needed a small update. (Credits.php)

@ 2669 bytes. Need I say more, ladies and gentlemen...? (sbox.js)

Hmm yeah I guess it's technically possible but it'd have to be done manually or we'd have to learn about svn a bit more. I remember looking into it...

Pete: Neochrome? deluxe Paint? Degas Elite? :P

rev 1242
(2 files, 2kb)

* $(document).click() is now $(document).mousedown(), thus $display.click() no longer needs to return false. (sbox.js)

* Select box entries are now clickable through .mousedown() instead of .click(), which fixes a problem with IE 6/7 when dragging the scrollbar and releasing the mouse button outside of the select box (guess what, it would close it.) (sbox.js)

! ...And the fix above caused IE 6/7/8 to select the item text in some cases, so I added an onselectstart event that adds 12 bytes to the gzipped file, which I compensated in other areas to retain the exact same final size. I am absolutely mental. Please help me. (sbox.js)

- Got rid of setting maxHeight in dropdown CSS, to add support for scrollbars in IE6. It's ongoing though, so it still actually doesn't work in IE6 but it'll be done soon enough. (sbox.js)

- Select box 'text' class doesn't need to be an inline block, really. Also, 'items' class (unordered list) behaves better as inline. (index.css)

+ Added a hover effect on select box scrollbar thumbs. (index.css)

As I said, the issue only happens with IE (6/7/8, not 9), so even the -ms prefix would be useless because only IE10 supports it. I could use the unselectable property, but even then I don't want to complicate things.

There are two dynamic select boxes that I know of: the JumpTo, and the PM global label selector -- it takes a list of available labels, determines which selected PMs already have it, and recreates the "Add label" and "Remove label" entries accordingly. I rewrote the code to simplify it -- now it generates two optgroups, so it helps with readability, but obviously it still repopulates the box. I could have the box contain every single entry and then simply 'hide' them which would make it easier to re-create, but there's no point in doing that. And yes, if I implemented some kinds of tricks, I could get away with removing at least 200 bytes of code (possibly a bit more) from the select box, but I don't want to impair any plugins by forcing them to do tricks when it's so elegantly handled by my code.

Anyway, that's irrelevant to the issue at hand...

When I say 'dynamically', I really mind the simple fact of doing manipulations on select boxes without referring to them as select boxes.


Consider this:


And this:


They will both do the same thing... However, the second one forces me to go through every single select box in the code, take note of their IDs and their option IDs, and then go through the entire code again to search for possible manipulations. The point is, because SMF didn't use jQuery, and I didn't convert every single JS statement inside templates themselves, it's easier to do getElementById() on an option than going through getElementByTagName or something...
The problem is unlikely to happen in any non-admin pages, but the admin area... Some of its code is so convoluted... :-/

I should specify that the selection bug only happens when trying to 'drag' the text (copy it) at the moment you click it (which is unlikely to happen..?), while the 'select box closing itself' bug happens everytime your cursor ends up outside of the box.
Also, the selection bug can be 'reproduced' by simply trying to drag smileys in the smiley list (basically, LOTS of areas can reproduce the bug..), and it only happens in IE.

iframes? Over my dead body...!
(My only fear is that Wedge somehow has an obscure area where select boxes are manipulated dynamically in a way that they can't be found by doing a regex search on your project files. Then again -- if nobody uses said feature, it won't matter, and if someone does, they're bound to tell us what we should fix...)

rev 1241
(6 files +2, 9kb)

* Improved thumb styling in select box scrollbars. (index.css)

* More space optimizations... Reached 2707 bytes, another 27 bytes less. As you can imagine though -- it's going to be pretty much impossible to go below 2700 bytes at this point. But it's okay, the code looks great. (sbox.js)

! Fixed select box closing itself when clicking on the scrollbar outside the thumb (instead of actually moving the thumb to that position.) Note to self: that 'return false' in drag() was important, it just needed to be moved to another event type... (sbox.js)

! Fixed IE6's tendency to enlarge select boxes to full width. (index.ie6.css)

! Fixed broken button layout in IE6 and IE7. Copied the .inline-block method to the editor CSS files, since they can't inherit from index.css (not the same final cache file), and said method is solid enough. (editor.css, editor.ie6.css, editor.ie7.css, index.ie7.css)

@ Note: scrollbars are broken in IE6, most likely because of a bug when calculating the required height. Should I care about that...? I'm thinking not... Also, releasing the mouse button outside of a select box after dragging its thumb will close the select box in IE 6/7/8/9. Dunno why, but it seems to doesn't take the 'return false' into account (yeah, the one mentioned above), as it bubbles up the DOM tree.