Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
6646
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 03:54 PM »
Pete. Why would a hook be able to test for dupes more than a handler relying on a hook?

Farjo. The goal of credits is usually to spread links to your site. I assume people would be happy with a credit page that has exposure. Remember that Smf's credit page is well hidden, hence why no one uses it...
Themes I don't know about. Honestly I've never ever installed a third party theme on my sites.
We are keeping the usual SMF credits as you could see. We just shortened them (only kept the nicknames).
6647
Features / Re: New revs
« on January 13th, 2012, 03:19 PM »
rev 1253
(2 files, 2kb)

! Fixed select box glitch where long optgroups would sometimes generate an extra 15px whitespace on the right side. (sbox.js)

! Fixed select box glitch where the display area's width after selecting an item would be calculated incorrectly if display used different styles compared to the dropdown. (sbox.js)

! And a third select box bug fix I forgot to commit... Whatever that was, it was annoying. (index.css)

@ The first two fixes basically use the same technique (setting width to auto), and cost an extra 21 bytes. Well, at least it's still under 2600... Hello? Is anyone listening? Oh, I should have guessed... The rascals. Tomorrow's lottery numbers will be 3, 12, 21, 42 and... Oh, now everyone is listening uh? I'm telling you. Rascals.


@ Okay, I think I'm mostly done with select box fixes... Well, never say never. But it's all around very solid for now. And please, for the love of Carmack, don't try and modify sbox.js any longer!
6648
Features / Re: Post moderation
« on January 13th, 2012, 02:15 PM »
I can already smell the 'feature that will take weeks to develop'...

At this point, I'd be tempted to say, "postpone for Wedge 1.1"..?
6649
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 02:14 PM »
Quote from Lurker on January 13th, 2012, 02:05 PM
Unless they own a 1 letter domain name in a 2 letter TLD (i.e. something like t.co), 16 bytes doesn't help enough ;)
Seriously though, I think a good guideline would be to simply say, "one line of credits"... Because Plugin credits are using a single column in the otherwise 2-column layout in this page, there's plenty enough place. And I suppose having 2 lines would be okay if justified -- we just don't want every single plugin to have several lines of credits or whatever.

Maybe we could give a helper function to add credits, instead of just a hook... (It would internally use the hook, of course.)
And/or maybe we could show plugin credits inline, instead of as an unordered list. Bit messy, that could be...
Quote
Especially because you know who the worst offender for footer copyrights is.
Aeva Media and its stupid advertisement for Wedge! :eheh:
6650
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 01:59 PM »
Quote from Lurker on January 13th, 2012, 01:49 PM
Aw, you're a bit mean, I was going to allow at least 16 bytes per plugin :P
Well, over 12 bytes they'd be tempted to add [url=][/url] to their credit... :niark:
Quote
I'm all for developers being credited for their work, I just don't want them to take the piss as they're currently doing for SMF.
Sure.
6651
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 01:47 PM »
Rule #1: if you're Nao or Arantor, you can add up to 10 kilobytes of credits per plugin.

Rule #2: if you're not, then you may add up to 4 bytes of credits per plugin, or 10 bytes if you're showing them in a <div class="hide">.

I think that should cover for everythin'...
6652
Plugins / Re: Plugins NOT modifying core files
« on January 13th, 2012, 01:46 PM »
And that's the thing with Wedge: we can add new hooks at will... People will know that they can safely overwrite their files with new versions of Wedge that add new hooks that allow them to install plugins that make use of these new hooks. (And that's a lot of that!)
6653
Plugins / Re: Plugins NOT modifying core files
« on January 13th, 2012, 11:45 AM »
It can always be reallowed later.

Wedge is complicated enough as it is internally. Might as well make things easier for everyone ;)
6654
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 11:44 AM »
+1.
6655
Features / Re: New revs
« on January 13th, 2012, 09:50 AM »
rev 1252
(6 files +2, 4kb)

* It feels better to use monospaced fonts for regex input fields. (Admin.template.php, admin.css)

! Selecting a profile field template like Facebook etc. wouldn't properly update the select box selections. (Admin.template.php)

! Fixed CSS caching process failing at install time, hopefully. (Subs-Cache.php)

! Fixed Wuthering header styling in IE 6-10. (Wuthering/index.ie*.css)
6656
Features / Re: New revs - Public comments
« on January 13th, 2012, 08:12 AM »
Priority should be on fixing skin_folders for now.
6657
Plugins / Re: Exposing bbcode to the plugin manager
« on January 13th, 2012, 08:10 AM »
Yeah. vB sucks, no need to specify it again :lol:
What about xF?
6658
Features / Re: New revs - Public comments
« on January 13th, 2012, 08:07 AM »
I'll do a sitewide global replace if you want.

Congrats on your return!
I will have made a total of 67 consecutive commits, my personal record. 81 if not counting your single-character commit of a semi-colon ;)
6659
Features / Re: New revs
« on January 13th, 2012, 12:11 AM »
rev 1250
(1 file, 4kb)

* Rewrote add_css_file() to merge it with wedge_cache_css(). Should make the whole code cleaner this way... To do: merge it with add_plugin_css_file() as well. For now, I simply rewrote its webkit regex to use \b. (Subs-Cache.php)

! Fixed inherited skins where non-main files, such as admin.css, wouldn't properly inherit their parents' contents. Can't believe I finished working on this a year ago and never noticed any problem with it... (Subs-Cache.php)
6660
Features / Re: New revs
« on January 13th, 2012, 12:10 AM »
rev 1249
(2 files, 3kb)

! Fixed situation where de-focusing a select box by clicking somewhere else in the document, and then pressing a navigation keyboard shortcut, would actually trigger said shortcut in the blurred select box. Costs an extra byte at compression time. (sbox.js)

* Moved all drag'n'drop code inside the plugin itself, to avoid setting up a mousemove event on $(document) on all page loads, instead of when it's actually needed. I don't see any drawbacks to that...? And it saves half a dozen bytes. I like fixing bugs and shortening my gzipped files at the same time, if you didn't notice. You must be blind. And deaf. And if you really are, please tell me where you think I could improve accessibility. (script.js)