Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
6466
Features / Re: Selectbox
« on February 13th, 2012, 01:51 PM »
Very sorry about the misunderstanding.
I could implement it, still. But I figured it'd add at least 300-500 bytes and for just a few underused places, avatar selection being the most prominent...
6467
Features / Re: Selectbox
« on February 13th, 2012, 01:19 PM »
You can always remove stuff you don't like, you know... I won't blame you for that ;)
I'm just saying that Sbox doesn't support non-dropdown select boxes, so it leaves it to the regular GDI drawing, and thus gets to benefit from its features.
6468
Features / Re: Selectbox
« on February 13th, 2012, 01:14 PM »
Well -- technically, what you wanna do is use <select size="something"> instead of just a select. Set something to > 0 and you'll get the multi-select feature.
6469
Features / Re: Disallowing edits to posts
« on February 13th, 2012, 11:43 AM »
Suggesting to simply check for modified_member when deleting a member, and if found, unserialize data and serialize with last known member name.

Although I'd rather we store the actual username as modified_name in data, instead of real_name (display name), and we put the priority on showing the (display) name as found through modified_member. Then if modified_member is associated to no name, we can use modified_name in its place.
6470
Features / Re: Disallowing edits to posts
« on February 13th, 2012, 11:36 AM »
That's why I didn't suggest moving modified_member over there, but I think modified_name could go, because, technically, we're never updating the name as it's being changed/deleted... Are we?
6471
The Pub / Re: Quick moderation
« on February 13th, 2012, 11:34 AM »
Perfect then, thank you :)
6472
Features / Re: New revs
« on February 13th, 2012, 11:24 AM »
rev 1331
(9 files, 4kb)

* Replaced <div class="note"> with <a class="note">, as context permits, and as suggested by Aaron, who will pay for this, mwahahaha. Updated the note styling to be a bit closer to the original New icon. Requires the use of inline blocks, though. Plus, a couple of spans were used instead of divs to make them validate in the index template. (Profile-Modify.php, SSI.php, Boards.template.php, index.template.php, MessageIndex.template.php, Recent.template.php, index.css)

- Removed moderation report in sidebar, as suggested by Pete. (index.template.php, index.language.php)
6473
Features / Re: Disallowing edits to posts
« on February 13th, 2012, 10:55 AM »
I can imagine that this is a bit frustrating -- if anything, adding a flag for "can edit" isn't really linked to knowing whether an admin edited the post -- e.g. they can simply not edit a post but prevent someone from editing their post, so that makes the storing of editor IDs a bit less useful than if an admin editing a post would block it automatically. If you know what I mean.
Posted: February 13th, 2012, 10:54 AM
Quote from Arantor on February 13th, 2012, 12:13 AM
Subject, no, but the others could be I guess.

But I don't see that as a 'right now' thing, though certainly now would be the sort of time if it were going to happen.
It's not like the messages table has too many fields, like the members table that really, really needed a data field (even though we're not using it much for now... I think?), but it can be seen as betting on the future, especially for plugins. :)
6474
The Pub / Re: Quick moderation
« on February 13th, 2012, 10:50 AM »
Re: latest revs -- haven't checked thoroughly, but are you sure $context['open_mod_reports'] is always available, Pete...? It's going to be accessed even when not logged in, etc, as far as I'm aware...? And it seems to be set only in ModerationCenter.php and Security.php...?

Other than that -- great to see you tackled this, thank you :)
6475
Features / Re: Disallowing edits to posts
« on February 12th, 2012, 11:59 PM »
Maybe this kind of 'post can't be edited by author' thing should be part of a future 'data' field.
Other elements that could be part of it (i.e. anything that's not searchable, but only used when showing the post):
- modified_time
- modified_name
- smileys_enabled?
- poster_email?
- subject??? (maybe not -- topic-wide renames, etc.)

That's still quite a lot of data that could be moved there.
6476
The Pub / Re: Wap is that?
« on February 12th, 2012, 11:54 PM »
I think 15 votes is enough. I'll try to get started and remove the feature tomorrow. :)
(As always, everything in a single commit, so that we can easily revert if ever needed.)
6477
Features / Re: New revs
« on February 12th, 2012, 10:33 PM »
rev 1328
(3 files -1, 2kb)

! A couple of pages wouldn't correctly update the selected item if canceling a change. (ManageMembergroups.template.php, Profile.template.php)

* As much as it hurts me, reverting my Opera fix for select boxes. It just doesn't work when select boxes are inline, such as the post editor and the thought system. I could have looked and added exceptions for every single inline box, but it's really not realistic. So it's an additional 11 bytes for sbox.js, sorry about that, and for Opera: a slightly less eye-candy opening/closing animation, minor width issues when selecting and a glitch in the last list entry when navigating boxes with the keyboard -- don't ask me why, I have no frigging idea. The rest should be okay, so it's an acceptable alternative. Until someone finds the reason for all these Opera bugs. There are limits to my Opera fanboyism, I guess. (sbox.js, Worg/index.opera.css)
6478
Features / Re: New revs
« on February 12th, 2012, 09:23 PM »
rev 1327
(1 file +1, 14kb -- really, 1kb worth of changes + 6kb for the new file)

! Fixed Reply to Thought button incorrectly hiding the original text. (script.js)

! Fixed Thought system's ajax editing -- was broken by my recent change for ';' separators, when the code really only expects ampersands. (script.js)

+ Added a temp thumbnail for Worg. (Worg/thumbnail.jpg)
6479
The Pub / Re: Quick moderation
« on February 12th, 2012, 02:31 PM »
Quote from Arantor on February 12th, 2012, 01:53 PM
OK, the poll is definitely confirming my suspicions: that not only should quick moderation be just turned on and set to checkboxes, but that the very fact it wasn't turned on by default did confuse some people.

So yeah, time to get busy on the phasing out of stuff :D
Quick mod is just a single checkbox, so it doesn't take space and even if I never really use it, it's still okay to have the checkbox in there...
Quote from Arantor on February 12th, 2012, 02:29 PM
Then I discovered, for each thing it's testing for, there's a query being made. There's 3 queries being run per search without quickmod, and 11 queries being run - per search - with quickmod enabled.

Needless to say, I'm changing how boardsAllowedTo works when confronted with an array, so that it can be made faster than one query per permission.
Yeah, that sounds quite odd to me.. Then again, if it's just for people with moderation powers, it's bearable...
6480
Features / Re: New revs
« on February 12th, 2012, 02:28 PM »
rev 1322
(6 files, 3kb)

+ Added support for @import and @charset in CSS files. Well, at least the generated CSS is okay now... (Class-CSS.php)

! Fixed CSS parser sometimes screwing up absolute URLs. (Class-CSS.php)

! Wedge's rewrite of ssi_recentTopics() wouldn't return posts in the correct order. (SSI.php)

! Plus, SMF's conservative use of minimum post IDs in these functions has never worked for me. Removed the min() thingy. (SSI.php)

* Layout details. (Worg/index.css, Worg/index.member.css, Worg/sections.css)

* Micro-optimizations. What's the greek root after micro, already? Pica? (Subs-Cache.php)