Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
6421
Features / Re: Privacy options
« on February 15th, 2012, 11:01 PM »
I'm going to have to get started on this before I use Wedge on Wedge.org, I guess...

So, things to do: (feedback welcome.)

- query_see_topic everywhere (gonna be a lot of fun...)

- contacts table (still unsure whether 'contacts' is the right term to replace the awful 'buddies'. I still like 'friends' better, but if we want it to be usable by work colleagues and family etc, it should be a more generic term I think.)

- importing 'buddies' into contacts table at SMF import time, writing the UI to manipulate contact lists (will take it mostly from wedge.org...)

- would like to know the current 'official' positions of everyone on contact lists -- is it okay to use a contacts table, or should we ditch the whole concept of contacts, and instead allow everyone to create their own private/public membergroups?
6422
Features / Re: New revs - Public comments
« on February 15th, 2012, 10:45 PM »
Quote from Arantor on February 15th, 2012, 03:54 PM
Though, looking at it, I think somewhere we broke something, I go to a profile, and 'send a message' just goes to the base send-PM page, no user id is being passed.
Posted: February 15th, 2012, 03:53 PM

That is, going through the menu; the send-PM link in the personal info area is fine.
Okay fixed, thanks!
Posted: February 15th, 2012, 10:37 PM
Quote from Arantor on February 15th, 2012, 05:57 PM
I was concerned that it would break things, because there is more than one place where a default value should be thrown at the user so they have to do something but it looks like it all works properly :)
There are probably dozens of places where sbox broke something. That's what public beta testing is for ;)
Quote
See, I forget stuff like that. It doesn't help that I haven't touched jQuery much in the last 3 months, I've been working mostly in Impact which is a very different beast, though it does all kinds of neat stuff with classes and extending thereof.
Hey I'm the front-end guy, I'm not expecting you to delve into JS on a daily basis :P
Quote
Quote
I'd love to be able to do ($something = $param || 0) in PHP
As an expression? What should that expression mean logically? (Seems to me like it means $something = (bool) $param)
Would be the equivalent of... Hmm...
$something = isset($param) ? $param : 0;
More importantly, it also sets the fallback variable type. i.e. if you have "undefined || false", it the final variable will be a boolean, not undefined.
Quote
Oh, essentially being shorthand for $something = isset($param) ? $param : 0, I see. The thing is, JS has a very different idea of what a variable is compared to PHP and I think I prefer PHP's idea in that direction.
I just never was fond of isset()... Even in later versions of PHP, they added "?:", which is a nice idea, but WHO will use that anyway? Since it doesn't work on variables you're not sure have been initialized...
6423
Features / Re: New revs
« on February 15th, 2012, 10:38 PM »
rev 1346
(2 files, 1kb)

! The menu links for sendpm and banuser in profile pages were broken. (Profile.php)

* Translation update. (ManageMedia.french.php)
6424
Features / Re: New revs
« on February 15th, 2012, 06:45 PM »
rev 1345
(39 files, 6kb)

* Finished text alignment conversions. (ManageMemberOptions.php, ManageServer.php, ManageSettings.php, ManageSettings.language.php, TEMPLATES: Admin, Errors, ManageBoards, ManageMembergroups, ManageMembers, ManageModeration, ManageNews, ManagePaid, ManagePermissions, ManagePlugins, ManageScheduledTasks, Media, ModerationCenter, MoveTopic, Packages, PersonalMessage, Poll, Post, Printpage, Profile, Recent, Register, Reports, SendTopic, SplitTopics, Stats, Themes, SKINS: index.css, index.member.css, index.rtl.css, sections.css, Worg/index.member.css, Worg/sections.css, Wuthering/index.rtl.css)

* Slightly better presentation for Unread Posts/Replies page, when no posts are found. (Recent.template.php)

! Fixed unclosed div in the admin homepage. (Admin.template.php)
6425
Features / Re: New revs
« on February 15th, 2012, 06:08 PM »
rev 1344
(28 files, 5kb)

* Added a 'centered' class that will center a div horizontally. Obviously, it has to have a set width, otherwise it'll use up all of the space. Started renaming all text alignment classes. Hopefully I didn't break the left/right/center BBC tags in the process. Logic says I didn't. (install.php, install.sql, upgrade.sql, upgrade.php, 7 tools, Aeva-Embed.php, Aeva-Foxy.php, Subs-Media.php, Modlog.php, Profile-Modify.php, TEMPLATES: Admin, Display, Help, Login, ManageBans, ManageBoards, Notify, PersonalMessage, Profile, Register, Reminder)

+ Forgot to submit my bindEvents change. It will now accept a limited subset of DOM elements. (script.js)

* Translation. (ManageSettings.french.php)
6426
The Pub / Re: Logo Madness
« on February 15th, 2012, 05:48 PM »
Hey guys... Added 3 more logos to post #907.
Anything catching your attention in that post? Font/color/logo/layout, anything you want to talk about...
6427
Features / Re: New revs - Public comments
« on February 15th, 2012, 05:36 PM »
Quote from Arantor on February 15th, 2012, 05:29 PM
Quote
- A class="hr" doesn't need to declare disabled, it's done by sbox automatically,
Cool, wasn't sure exactly what it did or didn't do.
It does everything (you don't need to set a blank value either, although it's also the case on anything that's set to disabled ;)), it just is underused in Wedge now that I've replaced most of the calls with data-hide ;)
Quote
Quote
- I added a couple of data-hide's
With the result that a selectbox now has a pre-filled value where it wouldn't have had one before?
No no. It doesn't change a thing... data-hide will simply mark the item to not show up in the list. It's one of these neat little 'extra' sbox features I'm proud of :)
Quote
I've been careful with that, to make sure things have a forced empty value to work with, most importantly the selectbox that's populated with the list of rule types (name="condtype") because if it's not done that way, it's actually going to break functionality.
It only broke because I'd removed the empty value on the data-hide. After noticing that it showed an area it shouldn't, I quickly restored the empty value and all was well.

BTW, that UI is really cool :) It's like a conversation between the admin and the website...! Or a wizard, if you like!
Quote
Quote
- Some .show()/.hide() combinations were turned into .toggle()
Which ones? With some of them, there's no certainty over whether the content is hidden or shown, and it needs to be pushed to a specific state.
.toggle(true) = .show()
.toggle(false) = .hide()
.toggle(hello) = {
  if (hello)
    .show()
  else
    .hide()
}
Quote
I always forget whether JS supports this syntax or not :/
It does. Actually, I'd tend to say that JS supports more quirks than PHP does. I'd love to be able to do ($something = $param || 0) in PHP... :P (Well, it's just an example. Of course PHP has default values for function parameters, but it'd be nice to have it everywhere.)
Quote
I was gonna ask you about that, actually.
See, you didn't even have to :)
6428
Features / Re: New revs
« on February 15th, 2012, 05:29 PM »
rev 1343
(2 files, 2kb)

* Tweaked Manage Moderation template's JavaScript, CSS and HTML for efficiency. (ManageModeration.template.php, Worg/index.css)

* Replaced lefttext/righttext/centertext classes with left/right/center, to eliminate repetitive patterns. Use floatleft/etc if you need to center the container, rather than the contents. Also, quotes had too much padding around them, switching to pixel values instead. (Worg/index.css)
6429
Features / Re: New revs - Public comments
« on February 15th, 2012, 05:25 PM »
Yeah it works, I'm just wary it'll break any of your local changes...

Among the things I changed:

- A class="hr" doesn't need to declare disabled, it's done by sbox automatically,
- I added a couple of data-hide's
- Replaced text-align styles with left/right/center classes.
- Some .show()/.hide() combinations were turned into .toggle()
- Removed {} when there's only one line. I don't like this jQuery "habit" :P
- Used bindEvents at one point, instead of reproducing the function. I just modified bindEvents to allow passing specific DOM elements to it.

Which also led me to notice that I'd left alone an annoying thing in Wedge's CSS -- the over-use of .lefttext and such, instead of .left... So I'm in the process of changing all templates to harmonize this. I guess it will break some areas (only when it comes to alignment, obviously) because I'm doing it quickly, but for what I've seen, it works fine.
Posted: February 15th, 2012, 05:23 PM

(:edit: Added a couple of items)
6430
Features / Re: Moderation filters UI
« on February 15th, 2012, 04:54 PM »
I don't believe it's the same thing... :whistle:
6431
Features / Re: New revs - Public comments
« on February 15th, 2012, 04:42 PM »
@TE> Didn't touch these areas, so if Wedge doesn't do it already, it won't do it more now.

@Pete> I hope you don't mind -- I was fixing something in the ManageModeration template, and started finding some JS that's not formatted in the way I'm doing it, and I'm a bit anal when it comes to this... Even though most of my writing standards are due to the ability to compress data even further, and it's not the case in inline JS, but I like having it done consistently thoughout the project. Is it okay with you if I commit my changes...?

Re: user ID, never looked into this... I'll do it as soon as I'm done.
6432
Features / Re: New revs
« on February 15th, 2012, 12:48 PM »
rev 1341
(3 files, 9kb)

* Tweaked auto-suggest to show item lists inline instead of one per line. Added some padding to their right to ensure the Delete button's target is clear. (suggest.js)

* Translation. (ManageMedia.english.php, ManageSettings.french.php)

:edit: If you happen to look through my code and wonder about something (which I doubt, ah, ah.) Although undocumented, jQuery does support setting .html() to an array of jQuery elements, or whatever. It just tests whether it's a string, and if not, it does empty() and then append().
6433
Features / Re: Selectbox
« on February 14th, 2012, 11:56 PM »
Exactly the thing. There aren't THAT many opportunities to run sb(), so why waste time checking all other select boxes, I'd rather we get multiple user reports of select boxes that should be refreshed and aren't ;)
6434
Features / Re: New revs
« on February 14th, 2012, 11:47 PM »
rev 1339
(12 files -1, 17kb)

* Rewrote, once again, a large portion of the auto-suggest component. It's a bit tighter, cleaner, accepts shorter parameters (especially in the aListItems area...), and basically, it works, unlike the previous version. (ManageBans.template.php, ManageBoards.template.php, ManageMembergroups.template.php, ManageNews.template.php, Media.template.php, PersonalMessage.template.php, pm.js, suggest.js, Worg/index.css)

* Because I'm weak and I listen to outside suggestions, I used the opportunity to restyle the auto-suggest to look like the select box dropdowns. I sure could have hoped for a smaller CSS code block though... (Worg/index.css)

* Media area's Search by Member and Allowed/Denied Read/Write lists of album users now use the auto-suggest component. The Search feature is totally untested. Any volunteers? (Aeva-Gallery2.php)

* Reworked Media search page layout a tiny bit.  Fixed subtabs but, honestly... These should go, shouldn't they?! Or at least use the proper contextmenu styling... @todo! (Media.template.php)

- Removed FindMember component (the ancestor to the auto-suggest). Finally got around to updating the last area that made use of it -- the media album creation page. (index.php, FindMember.php, Load.php, Aeva-Gallery2.php)

Please everyone test the areas where I made the most prominent changes! Media search, media album per-member permissions... I worked for 5-6 hours on this and am too upset to finish testing.
6435
Features / Re: Selectbox
« on February 14th, 2012, 11:25 PM »
There's no 'better' way than doing .sb() in the method chain after loading the value.
And yes, it 'looks ugly', but the alternatives were:
- adding a timer to determine whether the select box had changed (slow, resource intensive, silly)
- overloading the various jQuery functions that change attributes and stuff, to determine whether it belongs to a select box and thus trigger a timeout to redraw. Very slow, slightly resource intensive, complicated.

Please don't touch sbox.js itself, as you feared it's very, very prone to accidents :P (I broke it dozens of times, and I'm the one who wrote it!)