Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
6406
Features / Re: Don't know if I shared it publicly or not
« on February 17th, 2012, 12:33 PM »
- AeMe changelog should go, it's no longer relevant anyway, only for AeMe itself, and even then this'll eventually go too...
- SMF changelog should obviously go. I'm not even sure why it's remained in the SVN after all this time... :P Well, it has its uses, I guess, when I'm searching for a rare text entry and I'm not sure of the spelling... If it shows up in the SMF changelog, then I know I wasn't mistaken and I can keep looking elsewhere...
- Changelog/readme conversion code is what should stay, IMO, but I don't know what for... :P
- At the very least, it should stay in the attic.
6407
Features / Re: Privacy options
« on February 17th, 2012, 10:09 AM »
Well, I'll try working on this today... -_-

I've decided that I'll try and put the approved test into query_see_topic.
If there's a permission involved in the original query, then I'll add an additional approved test. Is that all right with you?
6408
Features / Re: Privacy options
« on February 17th, 2012, 12:06 AM »
Nobody uses this feature on noisen actually. Neither does anyone here. I'm just... Convinced it's a great feature.
But I'd like it to be as simple as possible. Plus I need to add contact list support so there's always gonna be a performance issue.
Shit.
6409
Features / Re: Privacy options
« on February 16th, 2012, 11:25 PM »
I'm starting to wonder if I shouldn't just give up on topic privacy... :(
6410
Features / Re: Privacy options
« on February 16th, 2012, 10:50 PM »
Quote from Arantor on February 16th, 2012, 10:42 PM
Yes, t.approved (and m.approved, ma.approved and all the other aliases that get used on the tables in those queries) are 'protected' but they're protected in a funky way, i.e. based on owner and a permission. I'd argue that you need to leave that component alone, as well as adding the see_topic component to said queries.
I noticed one of these 'funky' variations, and I'm unsure what of think of them... :-/
e.g. if I'm putting the condition at the same level as the is_approved, which is probably what 'should' be, then why not simply have the approved test inside the query_see_topic...? I really can't think of a reason not to, right now. If someone has the right to modify/delete/whatever a topic because of a permission, then surely they should be allowed to view it if it's not technically a topic they should be able to read... It's a moderator's job. No?
Quote
Therein lies the problem: can, or should, a topic whose privacy is not explicitly 'everyone' be able to have unapproved posts?
I have no idea... I'd tend to say yes, otherwise it gets complicated.
Quote
Any queries we've added to the code should adhere to t.approved where it's currently been used, I can't think of a single query we might have added where it wasn't respected, with the exception of anything added in the admin panel where the rules are different anyway.
There are only a few queries about topics in the admin anyway.
Quote
I'd also argue you pretty much do have to go by what's there and not necessarily by what's in the Noisen patch because there are going to be differences now that weren't in the original SMF code, which does mean looking through approved - there are, unfortunately, quite a few of those.
Noisen patch = still 440KB to implement. Of these, many, many KB are about the query_see_topic code... I'm a bit wary of removing the patch code without checking the implementation... :^^;:

BTW, if no one comments on the logo topic any longer... Does that mean I get to choose our final logo? :whistle:
6411
Features / Re: Privacy options
« on February 16th, 2012, 10:33 PM »
Bump.

Also... I'm currently trying to determine what's best for implementing {query_see_topic}.

I'm thinking of a relatively different way, compared to what I did with Noisen.
Instead of looking for {db_prefix}topics and adding {query_see_topic} to these queries, I could instead look for any queries that have a "t.approved" test in them... (or just 'approved', just need to make sure it's for a topic)
Because these queries are seen as "protected", I should be able to replace these tests with query_see_topic. And of course, I'll be moving the t.approved test to the query_see_topic string... Which totally makes sense.

Only issue is, I'm not *sure* all of our added queries correctly follow t.approved and such... What do you think? Is this the right approach? Or should I just follow the query list from my Noisen patch, considering that it's been 100% proven as working?
6412
The Pub / Re: Logo Madness
« on February 16th, 2012, 07:22 PM »
In red or green?
And with this font?
I didn't post any logos when I first sent that post, eh. I only edited it a couple of days later...

Posted: February 15th, 2012, 11:59 PM

Added an amusing one with Bebas Neue (the default font in Worg's header, although it's not loaded through a webfont so you'll have to install it on your PC to see it), and an alternative version of the white logo I made yesterday. I went through more tutorials and this is the results of my research. Although it's definitely starting to look like the Nike logo, now that I'm looking at it... :lol:
Posted: February 16th, 2012, 11:06 AM

Added another with a larger Bebas Neue + simplified shape using the recent color set + rounded corners except on the Wedge text corner.

:edit: And another variation... Having fun :)
Posted: February 16th, 2012, 01:27 PM

......Bump, then?
6413
Features / Re: New revs
« on February 16th, 2012, 07:10 PM »
rev 1353
(5 files, 3kb)

* Tweaked Subscription pages, for better layout mostly, as well as a miserable hack to avoid things like "Duration: 1 Years". Really should use our own numeric formatting function, but I can't bother to redo the text strings. (ManagePaid.php, ManagePaid.template.php, ManagePaid.french.php, sections.css)

* Indenazi. (GenericMenu.template.php)
6414
Features / Re: New revs
« on February 16th, 2012, 06:22 PM »
Another quiet day on the forums... Eh?

rev 1352
(18 files, 11kb)

- Got rid of all #admincenter declarations. Use #admin instead, and #admin #main if you want to target the main content area. Also, indenazi here and there. (TEMPLATES: Admin, ManageMembergroups/Members/News/Paid/Permissions/ScheduledTasks/Search/Smileys, Packages, Register, Reports, Themes, SKINS: admin.css, admin.rtl.css, index.ie6.css, Worg/index.ie6.css)

* Doing a westr::safe, to be on the... safe side. (ManageSmileys.template.php)

* Translation. (ManageSettings.french.php)
6415
Features / Re: Thought system
« on February 16th, 2012, 03:49 PM »
Nope... It's obviously something I'll add later on. But it's not my priority, honestly. I want to give it a chance to get known... :P (Obviously, at the very least it'll be enabled by default...)
6416
Features / Re: New revs
« on February 16th, 2012, 11:16 AM »
rev 1348
(10 files, 3kb)

+ Adding database tables for contact lists. That's all there is to it now... It's mostly there to discuss the required fields etc. (install.sql)

* Renamed some remaining 'buddies' to 'contacts', as well as the French equivalent 'amis'. Other translation tweaks. (index.language.php, ManagePermissions.french.php, ManageSettings.french.php, PersonalMessage.french.php, Profile.language.php, Reports.french.php, Who.french.php)
6417
Features / Re: Privacy options
« on February 16th, 2012, 10:55 AM »
Okay, I'll stick with 'contacts' then ;)

Admins are always going to be able to view custom groups, aren't they...? Would probably be the case for contact lists as well... Well, now that I'm thinking about it, it might be a good idea to hide these even from the admin if they're marked as private. I mean it's not like people can break a website this way...

Hmm, speaking of renaming...
"Send topic". This always bothered me. Not because I would never use that feature (I still wouldn't), but because it doesn't seem natural to me, in the age of Facebrood crap.
Why not rename it to "Share"...? This way, we could 'hook' other items into it -- share by e-mail/Facedoom/Twatter/Redditboughtthetshirt...
Heck, the French translation already says "Partager" (Share.)

PS: before anyone says so... I doubt very much that people would confuse it with the "Split topic" feature. :lol:
6418
Features / Re: Privacy options
« on February 16th, 2012, 12:23 AM »
One of my issues with contact lists is due to the privacy of current thoughts at wedge.org.
It'd be way easier for me to set privacy to id_group=friends group, like I did on the test site. But then new thoughts can't be posted to that group only because it's not implemented in the UI. And doing it... Well, maybe users would start getting confused between membergroups and contacts when time comes to choose a target privacy... thus, headache.
Additionally, I'm starting to think that I'll need extra columns for privacy... Just having a privacy flag won't cut it. I need id_group and id_contact_list fields, or something. Hm...
6419
The Pub / Re: Logo Madness
« on February 15th, 2012, 11:41 PM »
No Pete, you didn't miss anything, I simply edited my post over time to add more stuff... nwl4 has been there since day one along with the first three though ;)

Okay, a couple more samples based on feedback.... I still like the green text the best. (Trying with a different font though.)
I think the 8_ logo looks great, as busy as ever though... But with the text outside of it, it works nicely. Perhaps I should try with the 6_ font and the 8_ logo. Not sure about the best font color.
6420
Features / Re: New revs - Public comments
« on February 15th, 2012, 11:06 PM »
Are you planning to watch all 7 seasons of Buffy for the foreseeable future...? :^^;:

Really, don't bother testing. I don't think there are any important places where I missed it.