Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
6376
Features / Re: Board descriptions
« on February 20th, 2012, 05:58 PM »
The less, the better.
I'm starting to feel that way after converting the Wine skin to be a child of Weaving... On the one hand, with the tools I wrote for this, it was actually doable and I did it in a couple of hours, which wouldn't be possible without said tools. On the other hand -- SMF/Wedge's amount of CSS is so huge, it's just impossible to deal with it and not end up with a single bug... I don't know how future Wedge themers will do to deal with that! (I guess they'll just create new themes... :lol:)
I'm starting to feel that way after converting the Wine skin to be a child of Weaving... On the one hand, with the tools I wrote for this, it was actually doable and I did it in a couple of hours, which wouldn't be possible without said tools. On the other hand -- SMF/Wedge's amount of CSS is so huge, it's just impossible to deal with it and not end up with a single bug... I don't know how future Wedge themers will do to deal with that! (I guess they'll just create new themes... :lol:)
6377
Features / Re: Privacy options
« on February 20th, 2012, 05:56 PM »Yes, but how often do you use post moderation?
How often are there board (or global) moderators who can approve posts?
How often are these things viewed outside of boards?
Yes, I also tend to overthink things but for something like this, there is a part of me that feels I have to because it can have all sorts of nasty consequences.
6378
Features / Re: New revs
« on February 20th, 2012, 05:55 PM »
rev 1371
(2 files, 1kb)
* Cached CSS should give at least some breathing space to the copyright lines, they're supposed to be readable... (Subs-Cache.php)
! Fixed some minor glitches in auto-suggest object when suggestion list is empty and CSS adds some styling around a list, however empty it may be. (suggest.js)
(2 files, 1kb)
* Cached CSS should give at least some breathing space to the copyright lines, they're supposed to be readable... (Subs-Cache.php)
! Fixed some minor glitches in auto-suggest object when suggestion list is empty and CSS adds some styling around a list, however empty it may be. (suggest.js)
6379
Features / Re: New revs
« on February 20th, 2012, 05:38 PM »
rev 1370
(10 files -2, 9kb)
* Converted Wine to a child skin of Weaving. Oh my, was harder than I hoped... Also tweaked the search box color in Wine, and fixed a few issues in both Weaving and Wine, such as user boxes being incorrectly positioned. (index.css, index.member.css, Wine/*)
! Changed thought list buttons to use absolute positioning instead of floating. This ensures that thought cells no longer get resized on the fly. (index.member.css)
(10 files -2, 9kb)
* Converted Wine to a child skin of Weaving. Oh my, was harder than I hoped... Also tweaked the search box color in Wine, and fixed a few issues in both Weaving and Wine, such as user boxes being incorrectly positioned. (index.css, index.member.css, Wine/*)
! Changed thought list buttons to use absolute positioning instead of floating. This ensures that thought cells no longer get resized on the fly. (index.member.css)
6380
Features / Re: New revs
« on February 20th, 2012, 05:35 PM »
rev 1369
(4 files, 3kb)
! Sidebar positioning flag was incorrectly retrieved from the skin file by Wedge. (Subs-Cache.php)
! Forgot to commit a file for rev 1368's transparency fix. (Subs-Media.php)
* Made WeCSS's reset keyword a bit more productive by allowing it on selectors within a nested tree. (Class-CSS.php)
* Don't display the prev/next link container if it's empty to begin with. (Display.template.php)
(4 files, 3kb)
! Sidebar positioning flag was incorrectly retrieved from the skin file by Wedge. (Subs-Cache.php)
! Forgot to commit a file for rev 1368's transparency fix. (Subs-Media.php)
* Made WeCSS's reset keyword a bit more productive by allowing it on selectors within a nested tree. (Class-CSS.php)
* Don't display the prev/next link container if it's empty to begin with. (Display.template.php)
6381
Features / Re: New revs
« on February 20th, 2012, 02:55 PM »
rev 1368
(2 files, 2kb)
* WeCSS will now simply remove unsupported properties from old IE versions, because we can't expect them to add support for them in the future, so it's a waste of bandwidth... (Subs-Cache.php)
! Wedge wasn't correctly setting up attachment transparency, as I forgot to specify the path and filename. Oops. (Load.php)
:edit: A PHP+GD2 limitation is that due to lack of support for animated GIFs, these will always be treated as opaque. It's unfortunate, because Pete's avatar gets drop shadows around it. :(
(2 files, 2kb)
* WeCSS will now simply remove unsupported properties from old IE versions, because we can't expect them to add support for them in the future, so it's a waste of bandwidth... (Subs-Cache.php)
! Wedge wasn't correctly setting up attachment transparency, as I forgot to specify the path and filename. Oops. (Load.php)
:edit: A PHP+GD2 limitation is that due to lack of support for animated GIFs, these will always be treated as opaque. It's unfortunate, because Pete's avatar gets drop shadows around it. :(
6382
Features / Re: Privacy options
« on February 20th, 2012, 11:56 AM »
I don't know. If I don't get started it'll never get done.
And, really, Noisen.com has been running fine for 4 years with these privacy settings. I could simply get them straight from Noisen, but I just wanted to be 'cleaner' and move t.approved to query_see_topic... It's really the only difference. I don't think it'll hurt in any way.
You already know that, Pete, but sometimes you tend to overthink it ;)
Posted: February 20th, 2012, 07:23 AM
And, really, Noisen.com has been running fine for 4 years with these privacy settings. I could simply get them straight from Noisen, but I just wanted to be 'cleaner' and move t.approved to query_see_topic... It's really the only difference. I don't think it'll hurt in any way.
You already know that, Pete, but sometimes you tend to overthink it ;)
6383
Features / Re: New revs
« on February 20th, 2012, 11:49 AM »
rev 1367
(4 files, 3kb)
* Moved thought list-related styles back to members-only CSS. I'm not sure I remember why I canceled that in the first place... (index.css, index.member.css, Wine/index.css, Wine/index.member.css)
* Thought buttons should no longer get in the way of those who will recognize themselves ;p (index.member.css, Wine/index.member.css)
* Started doing some CSS resets. Eventually, Wine will be an inherited skin again. It's already the case on my local install. (Wine/index.css)
(4 files, 3kb)
* Moved thought list-related styles back to members-only CSS. I'm not sure I remember why I canceled that in the first place... (index.css, index.member.css, Wine/index.css, Wine/index.member.css)
* Thought buttons should no longer get in the way of those who will recognize themselves ;p (index.member.css, Wine/index.member.css)
* Started doing some CSS resets. Eventually, Wine will be an inherited skin again. It's already the case on my local install. (Wine/index.css)
6384
Features / Re: Privacy options
« on February 20th, 2012, 12:27 AM »
I mean, give up on board moderators, especially in SSI, and simply focus on replacing t.approved=1 with {query_see_topic} everywhere it shows up..? That would seem like the 'safe' solution, at this point...
6385
Features / Re: New revs
« on February 20th, 2012, 12:23 AM »
rev 1366
(1 file, 1kb)
! Was a little too nice with Firefox and Safari... Firefox 12 still requires a prefix for box-sizing rules, and Safari did it until v5.0 (and iOS 4.3), which sort of warrants a de facto prefix for now. (Subs-Cache.php)
(1 file, 1kb)
! Was a little too nice with Firefox and Safari... Firefox 12 still requires a prefix for box-sizing rules, and Safari did it until v5.0 (and iOS 4.3), which sort of warrants a de facto prefix for now. (Subs-Cache.php)
6386
Features / Re: New revs - Public comments
« on February 19th, 2012, 11:50 PM »
I'd rather have feedback on the new 'reset' keyword you know :niark:
(Woohoo I'm so happy it's finally in... Now it's become much easier to make child skins, because you can simply inherit everything, and if you have a single element like a header that you'd like to redo entirely, you can just reset it and not have to worry about Wedge making further changes to the parent skin... :))
(Woohoo I'm so happy it's finally in... Now it's become much easier to make child skins, because you can simply inherit everything, and if you have a single element like a header that you'd like to redo entirely, you can just reset it and not have to worry about Wedge making further changes to the parent skin... :))
6387
Features / Re: New revs
« on February 19th, 2012, 07:51 PM »
rev 1365
(3 files, 6kb)
+ Added a new keyword for WeCSS. 'reset' will take the current select and remove it from earlier styles. It's different from '@remove' and 'unextends', and should be very helpful for inherited skins. This was a complicated implementation, too, one which could possibly be rewritten in a cleaner way if I parsed this before even building the CSS tree... I don't know what's best. Opinions?[1] (Class-CSS.php)
+ Added an unset_recursive function to quickly delete CSS selectors and their children. (Class-CSS.php)
* Made CSS tree parsing about 5 to 10% faster. (Class-CSS.php)
! Tahoma is not always installed on Linux. (index.css, Wine/index.css)
(3 files, 6kb)
+ Added a new keyword for WeCSS. 'reset' will take the current select and remove it from earlier styles. It's different from '@remove' and 'unextends', and should be very helpful for inherited skins. This was a complicated implementation, too, one which could possibly be rewritten in a cleaner way if I parsed this before even building the CSS tree... I don't know what's best. Opinions?[1] (Class-CSS.php)
+ Added an unset_recursive function to quickly delete CSS selectors and their children. (Class-CSS.php)
* Made CSS tree parsing about 5 to 10% faster. (Class-CSS.php)
! Tahoma is not always installed on Linux. (index.css, Wine/index.css)
| 1. | Seriously, this is a feature I wanted to have from day one! Took me a whole day to get it right... |
6389
Features / Re: Privacy options
« on February 19th, 2012, 04:10 PM »
Maybe we could cache in the member table a list of boards they can moderate? Serialized in data...
6390
Features / Re: Privacy options
« on February 19th, 2012, 01:44 PM »approve_posts is a board level permission, not a global one and in SSI, it isn't loaded. Nor is it loaded for search, recent, unread or indeed anywhere that doesn't explicitly contain topic= or board= in the URL string, so it will always return false, with the exception of true for administrators due to the hard-wiring of always-return-true-for-group-1-users.
I'd suggest:
- doing {query_see_topic} anywhere in the WHERE when no particular params are given,
- doing {query_see_topic} instead of t.approved = {int:is_approved} anywhere t.approved shows up in a query.
Does SSI need to support post moderation? That's a good question. My gut instinct says that for the purpose for which post moderation is normally applied and where SSI is used, it's actually not necessary to worry about and that it would actually likely confuse users rather than reassure them.
I do know, though, that global moderators (group ID 3 or something?) probably don't get the benefits of viewing unapproved posts... That should be changed, too...?
Oh, I'm so rusty when it comes to permissions. Heck, I was more knowledgeable about them back when I did my first query_see_topic implementation...