Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
6256
Archived fixes / Re: SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 2nd, 2012, 06:27 PM »
And I suppose it's not possible to move the hook further down, preferably below the caching code...?
6257
Bug reports / Re: SMF bug 4953 (PS adds 'cellTextIsHtml' to JPGs causing them to fail checks)
« on March 2nd, 2012, 06:25 PM »
I mean I don't really care in the sense that I'd rather not fix it, i.e. consider it as harmful if there's any reason to be suspicious at all.

I'm not a security specialist, though. But I don't think AeMe was ever found to have a security hole...?
6258
Archived fixes / Re: Fixed SMF bugs
« on March 2nd, 2012, 06:24 PM »
Quote from Arantor on March 2nd, 2012, 06:07 PM
Quote
It's not full size here, it's at 640x480... Which is precisely the setting I'd like to modify. Having to use the media gallery when you just want to post a quick attachment isn't so cool.
Nope. http://wedge.org/pub/plugins/7122/a-project-i-started-a-while-back/ disagrees with you: the original image was larger than 640 wide, so it was rescaled to cap at 640px, but there's no thumbnail for it - that image shown under the post is 640x501, and downloading it also gives you a 640x501 image.
But the thumbnail settings in Wedge.org are 1280x1024. Where does the 640 value come from, then..?
Quote
Well, I know that Weaving reports 3 missing images on the page for me, which fouls it up.
That's because I haven't committed them, as I said :P
You can download them off the demo site if you want. They're there, you just need to upload them to the folders they belong to. I know, it's a hassle, but I have yet to update the site with the new tentative logos ;)
Quote
I have no issue with the htaccess pushing 404s to index.php, but they must not be logged in writeLog(), because that pushes it into the online log, which is where the referrer is tracked as far as checkSession('post', 'admin') is concerned (which is what's causing the problem)
I posted a bug fix while tracking this error, something I'd long wanted to do, but I'm not sure how we can do both -- logging 404's and not logging them for checkSession use.
6259
Features / Re: New revs
« on March 2nd, 2012, 06:20 PM »
rev 1420
(4 files, 2kb)

! Wedge's 404 error handling should now also give you the proper URL where the error occurred, instead of specifying twice the file that wasn't found. Also addedd css and js extensions to the list of files to look out for. (Errors.php, QueryString.php)

! repair_settings.php was broken, due to wesql not being instanced. (repair_settings.php)

- wesql instantiation doesn't have access to query_see_topic, no need to declare it. (Class-DB.php)
6260
Archived fixes / Re: Fixed SMF bugs
« on March 2nd, 2012, 06:02 PM »
Quote from Arantor on March 2nd, 2012, 01:48 PM
They are - to a point. If the image size is smaller than the thumbnail size, it will display the image unresized. Now, if no thumbnail size is set, it will just show the image full size... (that's what's happening here)
It's not full size here, it's at 640x480... Which is precisely the setting I'd like to modify. Having to use the media gallery when you just want to post a quick attachment isn't so cool.
Quote
Quote
Generally speaking, SMF never asked an admin to set a value of -1 to disable something or whatever -- always zero.
Makes sense, I guess...
Definitely, but we'll need to check every entry, just to be sure...
Quote
Lemme guess, there's a broken image somewhere on the page?
I don't think so?
Quote
(I've noticed this before: where even 404s are pushed to Wedge for handling, it screws up the referer, 404s need to not be logged in writeLog())
Well, they need to be if you want the admin to be able to fix the 404 in the first place...?
6261
Bug reports / Re: SMF bug 4953 (PS adds 'cellTextIsHtml' to JPGs causing them to fail checks)
« on March 2nd, 2012, 06:00 PM »
Would like to see what spuds' fix on this was.

Well, I don't care much about this bug actually... :^^;:
6262
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 05:59 PM »
Oh, it's safe to say that since most of those we thought undermined SMF's community (most notably vblamer) left to other failures, we're fine with the SMF management these days. It's been quite some time since I've been in a flame war with SMF really... Over a year I'd say?
6263
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 04:41 PM »
Don't forget to follow our changelogs, we often report SMF bugs there too. (When we're merciful, we specify 'SMF bug' so that SMF devs can easily find them in the logs :P)

I'm definitely curious to know where the SMF dev team currently stands with regards to Wedge, though :)
6264
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 03:10 PM »
emanuele, aren't you one of the current SMF developers? ;)
(It would seem that they're all lurking here, I reckon... Possibly even more now with all of the SMF bug topics :P)

Re: poll options, I never bothered much about them, but I'd just like to point out that whenever I edit some options (e.g. remove one and replace another), the result will usually be mixed up. Not the number of votes for each item, but the order in which they're shown.
6265
Archived fixes / Re: Fixed SMF bugs
« on March 2nd, 2012, 01:45 PM »
Quote from Arantor on March 2nd, 2012, 10:38 AM
Well, setting a max is good because it prevents the textboxes being huge (otherwise they're long enough to easily fit a 32 bit int), and I just figured 400 was a sane size for a *thumbnail*.
Err, just help me here... I thought thumbnails were what Wedge would show below posts -- i.e. what is capped to 640x480 on Wedge.org right now. I thought there was nothing else..?
Wedge caps normal image size to 1280x1024 but it never works, they're always capped in 640x480. Does it mean I did it the other way around? That there's a setting I didn't find in the admin area, where I can set them to 1280x1024 and then a thumbnail size of 400x400 which, in this case, is perfectly allowable...?
Quote
Quote
Speaking of which, how about setting 'int' to have a 'min' of 0 by default? You've already set it to 0 pretty much everywhere, really...
I actually didn't want to set a blanket default but it's probably for the best.
It would be, I think.
Maybe it's a bad idea, but if you search for array('int', -- it will always return values that shouldn't be < 0. Well, didn't look through all of them, but it looks like it. Generally speaking, SMF never asked an admin to set a value of -1 to disable something or whatever -- always zero.
Posted: March 2nd, 2012, 01:41 PM

Oh, a possible bug...?
Manage Attachments > Prune > Prune avatars for members who haven't logged in over X days
Enter a number, press the button.

"Unable to verify referring url. Please go back and try again."

Always says that...
Posted: March 2nd, 2012, 01:44 PM

Actually says the rest on other options, too.
6266
Features: Forward thinking / Re: Removing deprecated code
« on March 1st, 2012, 11:12 PM »
Like what? Apart from namespaces, can't think of anything...
6267
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on March 1st, 2012, 10:59 PM »
If you need it, just ask for it... :^^;: Or do it yourself, I think you have admin access..?

So... I'm not sure about the best solution for this. I'd just rather keep it simple.
6268
Features: Forward thinking / Re: Removing deprecated code
« on March 1st, 2012, 10:58 PM »
So, they're adding mixins (like WeCSS but for objects :P), and JavaScript-style short arrays? That's not a lot, but it's stuff that I can see people using. Too bad I can use $arr = [0,1] right now in PHP 5.2 :P
6269
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on March 1st, 2012, 10:16 PM »
If people want to limit the number of images in a signature, a size limit isn't gonna cut it -- after all they can use shortlinks. They'd rather see a limitation in the number of tags, then... Or better, a limitation in the number of links, images and media items. Why not... Then again, there are also people who like ensuring their signatures are, at the same time, as short and compact as possible, and as informative as they want them to be -- i.e. a list of links inside small icons, like your own sig.
6270
Features / Re: New revs
« on March 1st, 2012, 10:10 PM »
rev 1416
(5 files, 3kb)

! MySQL doesn't need a client with version 5.1 (as evidenced by Wedge.org), only the server needs to be at least 5.1. Setting the minimum client version to 4.1. Or should it be 5.0? (install.php)

! Pretty URLs wouldn't accept the same URL on two different topics, even though the system no longer cares about their unique quality. (install.sql)

! Attachment loading code was failing calls to transparency tests. (Display.php)

! Me like big thumbnail. Me want big thumbnail. Me sad that thumbnail not big with rewrite. Me want big thumbnail. (ManageAttachments.php)

* GD2 likes to throw exceptions from time to time. Or maybe it's the filesystem, I don't know. Anyway -- making one of these functions a bit more conservative. (Subs-Media.php)