Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
6241
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 3rd, 2012, 06:15 PM »
"Let's add 10.000 options to see if it crashes the server... And then I'll complain that it's a bug!"
Technically, I doubt anyone would read a poll with a hundred options, let alone answer it...
Technically, I doubt anyone would read a poll with a hundred options, let alone answer it...
6242
Archived fixes / Re: SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 3rd, 2012, 03:56 PM »
The decision is in your hands. :)
6243
Features / Re: New revs
« on March 3rd, 2012, 02:49 PM »
rev 1422
(2 files, 2kb)
! WeCSS: @replace wasn't implemented cleaned up after execution. (Class-CSS.php)
* WeCSS: because indentation is removed when building the tree, don't waste time searching for opening spaces. (Class-CSS.php)
+ WeCSS: added support for single-line resets. Previously, you had to add a dummy rule below the selector if you just wanted to forget a selector's earlier styling. (Class-CSS.php)
* Logic nazi. (Subs-Post.php)
(2 files, 2kb)
! WeCSS: @replace wasn't implemented cleaned up after execution. (Class-CSS.php)
* WeCSS: because indentation is removed when building the tree, don't waste time searching for opening spaces. (Class-CSS.php)
+ WeCSS: added support for single-line resets. Previously, you had to add a dummy rule below the selector if you just wanted to forget a selector's earlier styling. (Class-CSS.php)
* Logic nazi. (Subs-Post.php)
6244
Archived fixes / Re: SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 3rd, 2012, 02:17 PM »
How about we cache dynamic entries as {cache:id} and fill in the ids at runtime?
6245
Archived fixes / Re: Fixed SMF bugs
« on March 3rd, 2012, 01:26 PM »It's not even as simple as that potentially. Remember that you get regional codes too, en_GB vs en_US for example.Quote Browser detection is not great, because it returns a shortcode (fr, en) instead of the full name
@Farjo> Pete alone is working on these SMF bugs. Just don't want to steal his thunder ;)
6246
Archived fixes / Re: Fixed SMF bugs
« on March 3rd, 2012, 12:20 PM »
While I'm at it.
I'm currently adding language detection to the installer.
Here's the current logic implemented in SMF: take the first language in the list. If it's English and there are more languages available, take the next one. It takes sense because SMF only ships with English. Wedge has French available in the SVN, so it will always default to French because it assumes you want French.
So, possible solutions:
- implement browser detection and if it doesn't match an entry, fall back to SMF's solution
- just use SMF's solution and make sure not to ship French in the final release
What do you like best?
Browser detection is not great, because it returns a shortcode (fr, en) instead of the full name. I don't see myself maintaining a list of shortcuts against full names somewhere in the code... :^^;: And going through the complete list of index.*.php files, opening them and scanning for lang_dictionary or lang_locale... Not great either!
I'm currently adding language detection to the installer.
Here's the current logic implemented in SMF: take the first language in the list. If it's English and there are more languages available, take the next one. It takes sense because SMF only ships with English. Wedge has French available in the SVN, so it will always default to French because it assumes you want French.
So, possible solutions:
- implement browser detection and if it doesn't match an entry, fall back to SMF's solution
- just use SMF's solution and make sure not to ship French in the final release
What do you like best?
Browser detection is not great, because it returns a shortcode (fr, en) instead of the full name. I don't see myself maintaining a list of shortcuts against full names somewhere in the code... :^^;: And going through the complete list of index.*.php files, opening them and scanning for lang_dictionary or lang_locale... Not great either!
6247
Archived fixes / Re: SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 3rd, 2012, 12:16 PM »
Level 2+ isn't recommended by SMF anyway. I understand the logic of having multiple caching levels, but it's not clear what exactly is cached and isn't.
I suppose it'd be good to time the time taken by the admin menu from build time to display time. Just to see how much of a percentage of performance it takes on the page.
I suppose it'd be good to time the time taken by the admin menu from build time to display time. Just to see how much of a percentage of performance it takes on the page.
6248
Archived fixes / Re: Fixed SMF bugs
« on March 3rd, 2012, 12:13 PM »What setting, exactly, are you changing?
Maximum uploaded image width (0 = disabled)
And same for height (the option below it.)
Set them to 1280x1024. Then I set the thumbnail size to 640x480 in Attachment Settings. They did get resized, but the original upload isn't kept.
Oh, I get it... The option is for REJECTING an upload if it's too wide/tall, not for resizing it. Which doesn't make sense. Especially compared with AeMe's comprehensive way of handling these. Heck... Another good incentive for getting rid of attachments, eh :P
Still, it automatically resizes the pics to 640x480 even with no thumbnail settings in...
But yet it displays the standard content, indicating to me it isn't triggering. But all you should have to do is add a define of WEDGE_NO_LOG there.
Technically, these errors should be shown in a template-free template. Just a text message...
6249
Archived fixes / Re: SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 3rd, 2012, 10:54 AM »
Is this for the main menu or admin menu (or both?)
If it's admin, then I agree, caching can be disabled to simplify everything...
If it's main menu, no need to bother either, because it's short enough.
If it's non-main and non-admin (profile...), then it gets interesting. I guess.
If it's admin, then I agree, caching can be disabled to simplify everything...
If it's main menu, no need to bother either, because it's short enough.
If it's non-main and non-admin (profile...), then it gets interesting. I guess.
6250
Bug reports / Re: SMF bug 4953 (PS adds 'cellTextIsHtml' to JPGs causing them to fail checks)
« on March 3rd, 2012, 10:49 AM »
I don't think there's a getimagesize protection. Couldn't find any.
Found this, thought, it's funny, in Subs-Post:
list ($attachmentOptions['width'], $attachmentOptions['height']) = empty($size) ? array(null, null, null) : $size;
Just because $size returns three entries doesn't mean a fallback should have three as well... :P
Found this, thought, it's funny, in Subs-Post:
list ($attachmentOptions['width'], $attachmentOptions['height']) = empty($size) ? array(null, null, null) : $size;
Just because $size returns three entries doesn't mean a fallback should have three as well... :P
6251
Archived fixes / Re: Fixed SMF bugs
« on March 3rd, 2012, 10:46 AM »Maximum uploaded image size.Quote But the thumbnail settings in Wedge.org are 1280x1024. Where does the 640 value come from, then..?
And it doesn't work.
Heck. It's still resized to 640x480 max. So I don't see the point of one or the other.
:edit: Trying again, this time with thumbnails disabled.
:edit: Still doesn't work... This time, the thumbnail size data is emptied (not set to 0, just emptied.)
Still, I just have a question... Why the hell does this option show up in an admin area that has *nothing* to do with attachments...?!
It should be moved!
Logic says that if a software author can't find an option in their own software, it's because it's out of place.
How do we know to log it? If we know to log it, we know to define WEDGE_NO_LOG so that it won't be logged in the online log.
6252
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 3rd, 2012, 10:16 AM »
It would break other things like layout before becoming another bug nest ;)
6253
Bug reports / Re: SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 11:08 PM »
Because they made 1500 logos for their members to choose from? :P
6254
Archived fixes / Re: Fixed SMF bugs
« on March 2nd, 2012, 10:45 PM »
Just look at the New revs topic ;)
6255
Features / Re: New revs
« on March 2nd, 2012, 07:01 PM »
rev 1421
(7 files -3, 2kb)
* Alphabetical table reordering for wedge_sessions. (install.sql)
- Removed a CSS file link that's never going to work anyway. (readme_update.html)
! Various CSS fixes for Weaving and Wine (and inherited skins), mainly for IE 6/7/10. Not exactly finished, though. (index.ie6.css, index.ie7.css, index.ie10.css, Wine/index.css...)
(7 files -3, 2kb)
* Alphabetical table reordering for wedge_sessions. (install.sql)
- Removed a CSS file link that's never going to work anyway. (readme_update.html)
! Various CSS fixes for Weaving and Wine (and inherited skins), mainly for IE 6/7/10. Not exactly finished, though. (index.ie6.css, index.ie7.css, index.ie10.css, Wine/index.css...)