Wedge

Holy cow. I think your Member Options rewrite is buggy.
I just realized that the bug I was complaining about in Quick Reply was probably triggered by the fact that I'd just changed the default value for newest PMs... It seems that it reset *all* of the items to "No"!

As for Googlebot, then the problem would be fixed, right? I'll try to disable the thing.
However, we still need to get rid of the no_board errors. There are still tons of them. Just got 4 pages worth of pages from a bad bot called ZoomInfo (nextgensearchbot or something). In just a few minutes... And I think it'll plague the error log for a while.

Bump for this... As said before, $context['open_mod_reports'] isn't always set. I'm going to commit some of my changes, and this includes a test for emptiness for this, but please fix it another way if you can ;) (and if you can make it faster, obviously... Not that an empty() test is anywhere slow.)

Which I read on Noisen.com, oddly enough :P
Confirmed here:
http://www.bbc.co.uk/news/entertainment-arts-17456505

I find her... Fugly, at best. She looks like a high-end hooker. Like she went through surgery...

Okay. Good then ;)
I thought you'd think the color palette is the same as the French flag ;) which isn't totally false actually. But not conscious.

Does that 'interesting' mean you'll look into it, or you're not feeling competent and would like me to keep investigating?
Just so I know what to work on right now... ;)

Oh, there's also the 'admin' folder creation thingy... Should we do it soon enough? The question would instead be: do you have any outstanding, uncommitted, admin-related files in your install? (I have none, myself. But it's likely you do.)
If yes, you might want to do the split yourself.

rev 1491
(5 files, 3kb)

* Replaced $txt['reply_noun'] (even though this was added to the SMF codebase as per one of my bug reports ;)), because it's only used in one area, and replaced it with a $txt['reply_number'] entry that should be easier to customize (I'm still having Japanese in mind... but other languages might benefit from this.) (Display.template.php, index.language.php)

* Harmonized a bit more the PM template with topic posts. User box should no longer overflow inside the PM body, and some optimizations are also imported. (PersonalMessage.template.php)

* Because of the table to div switch, the birthday cake is no longer properly aligned with the age. And sure enough, had to wait until it was my birthday to notice that... So I just moved the cake below the age. Wait, wait... It's not a cake... It's a WEDGE of cake! (Profile.template.php)

So, I've never been familiar with the 'trim' (trim_wspace in the database) parameter of bbcodes.

The Noisen codebase automatically trims whitespace before and after quotes, because I hate it when people don't insert any whitespace and we end up with quotes touching the rest of the text, so I trimmed everything out and added extra margins to compensate.

Now, with Wedge I didn't add this code because I'm trying to stay away from 'hacks'... After discussing with Pete, it seemed like the obvious answer was to change the trim_wspace value of quote tags from 'none' to 'outside' (meaning, 'trim any whitespace outside the tag').
So, I did that... And it still didn't work. Which brings us to 2 bugs.

1/

I managed to find out that whitespace was just ignored, because Aeva Embedding is active, which adds noae tags around quotes right when they're being processed. So it will see another tag around it, and will consider there are no extra spaces, which is wrong. Possible fixes:

a) account for  being possibly there in the regex. This is what I'm doing for now. It seems to be working just fine, but I'm a bit worried it might make the regex slower. So, I added a ^ right before the noae test, so that it only does once, and ignores it if it fails. This should now make the regex actually faster than in SMF... Much faster, even, because it looks like the SMF code is actually looking for the entire rest of the string...?! Heck, this can't be possible, because that would be an awful bug. I just realized I'm not that well versed into BBC parsing these days. Used to be... But I forgot most of it.

b) Right when adding the noae tags, do the trimming at this instant. Because we know that a quote has to be trimmed, we can do that. However, if an admin decides that they don't want trimming, it'll still occur even if disabled in the BBC DB table... Hmm.

2/

Okay, I checked and double-checked, and can't seem to find the code that will trim outside spaces BEFORE the quote... There are two such tests, but it seems they both account for whitespace AFTER the tag... WTF?! If that's the case, then isn't it a bug, too...?

---

Also, I figured that it would also make sense to apply outside trimming to other 'special' block tags like code, and possibly media. What do you reckon[1]?

1.	I love this word. It's close to the French for "recognize", meaning that for years I misunderstood it... I think the first time I realized my mistake was when watching a Harry Potter movie with French subtitles and being surprised at the translation for the word.

I thought Pete's code generated animated Gifs..?