Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
5881
Development blog / Re: Aftermath of the Great Deployment
« on March 22nd, 2012, 04:44 PM »
Yes. We were so happy when we finished implementing that one :)
I love it that Wedge is so full of goodies that people won't immediately notice, but make it superior to any other software package when it comes to attention to detail.
(Of course, the price to pay is the infamous development delays...)
Oh, BTW, r1501 does seem to fix anchor positioning on blogs!
I love it that Wedge is so full of goodies that people won't immediately notice, but make it superior to any other software package when it comes to attention to detail.
(Of course, the price to pay is the infamous development delays...)
Oh, BTW, r1501 does seem to fix anchor positioning on blogs!
5882
Features / Re: New revs
« on March 22nd, 2012, 04:40 PM »
rev 1501
(6 files, 3kb)
! Attempting to fix some of the recently discovered auto-saving draft bugs. Drafts should no longer be saved if the message is empty, and the auto-save flag is reset as soon as Wedge is done with it, instead of after the saving operation is completed successfully. (post.js)
! Here's my pretty lame attempt at fixing the anchor position bug in blog posts. I simply added an $excluding_first boolean that is applied to $counter in each post. I'm... pretty sure it's the reason for the issue, although I'd like to get confirmation. (Display.php)
- Removed some $context['page_info'] declarations. These were only useful for wap2 mode or anything that doesn't support JavaScript. Hey, welcome to the 21st century, right?! (Display.php, MessageIndex.php, PersonalMessage.php, Unread.php, UnreadReplies.php)
(6 files, 3kb)
! Attempting to fix some of the recently discovered auto-saving draft bugs. Drafts should no longer be saved if the message is empty, and the auto-save flag is reset as soon as Wedge is done with it, instead of after the saving operation is completed successfully. (post.js)
! Here's my pretty lame attempt at fixing the anchor position bug in blog posts. I simply added an $excluding_first boolean that is applied to $counter in each post. I'm... pretty sure it's the reason for the issue, although I'd like to get confirmation. (Display.php)
- Removed some $context['page_info'] declarations. These were only useful for wap2 mode or anything that doesn't support JavaScript. Hey, welcome to the 21st century, right?! (Display.php, MessageIndex.php, PersonalMessage.php, Unread.php, UnreadReplies.php)
5883
The Pub / Re: Improvement to drafts (and posting, actually) I need to do
« on March 22nd, 2012, 04:32 PM »
Okay, I've made a few changes to the draft code... Hopefully it will help, if only a bit.
- needsUpdate is set to false right after it's tested against. This is to ensure that drafts don't get saved multiple times if for some reason the function is executed again before the server has answered. (e.g. server is temporarily down...?)
- if 'message' is empty, return without doing anything. I don't think there's any good reason to save an empty draft. Really.
Will commit soon. Pete, this is your code, so feel free to revert at any time without explanations. I'm not even sure I'm doing it correctly :P
- needsUpdate is set to false right after it's tested against. This is to ensure that drafts don't get saved multiple times if for some reason the function is executed again before the server has answered. (e.g. server is temporarily down...?)
- if 'message' is empty, return without doing anything. I don't think there's any good reason to save an empty draft. Really.
Will commit soon. Pete, this is your code, so feel free to revert at any time without explanations. I'm not even sure I'm doing it correctly :P
5884
Development blog / Re: Aftermath of the Great Deployment
« on March 22nd, 2012, 04:07 PM »
Yes, I know what you were referring to, but come to think of it, that post from billy2 about the iPad was probably in reply to you, not me ;)
(Heck, yeah it's definitely so much more usable on a touch screen..!)
I'm sure I disabled it on the SMF version because, well, it sucked :P
(Heck, yeah it's definitely so much more usable on a touch screen..!)
I'm sure I disabled it on the SMF version because, well, it sucked :P
5885
Features / Re: New revs
« on March 22nd, 2012, 04:01 PM »
rev 1500 (yay!)
(7 files, 3kb)
! Fixed Ajax rebuilding of thought list after submitting a new one. Now it should properly in iOS. (script.js)
* Added 4px to .cat's top margin. Don't worry about me, it will pass. (index.css)
* Media queries were being a bit too conservative with 1000px. 900px is still an okay width. (sections.css)
* IE's glow filter looks awful. Replaced it with shadow filters in Wine. Also fixed header background (again?)... (Wine/index.ie*.css)
(7 files, 3kb)
! Fixed Ajax rebuilding of thought list after submitting a new one. Now it should properly in iOS. (script.js)
* Added 4px to .cat's top margin. Don't worry about me, it will pass. (index.css)
* Media queries were being a bit too conservative with 1000px. 900px is still an okay width. (sections.css)
* IE's glow filter looks awful. Replaced it with shadow filters in Wine. Also fixed header background (again?)... (Wine/index.ie*.css)
5886
Development blog / Re: Aftermath of the Great Deployment
« on March 22nd, 2012, 03:39 PM »
Was in the demo, but here...? I'm not sure.
Heck, it's enabled by default in Wedge (from install.sql), I have no idea why it was disabled... Perhaps I disabled it in the SMF-based Wedge.org...?
BTW, the links are hidden when there's not enough width on your device to accomodate for three titles at the same time.
Since I have an Opera sidebar (list of tabs) that takes a lot of space, I never see the list. Maybe I should rework that, because it's really a bit too strict.
Oh, and the setting really wasn't set in the admin area... So it's not related to that.
Heck, it's enabled by default in Wedge (from install.sql), I have no idea why it was disabled... Perhaps I disabled it in the SMF-based Wedge.org...?
Posted: March 22nd, 2012, 03:35 PM
BTW, the links are hidden when there's not enough width on your device to accomodate for three titles at the same time.
Since I have an Opera sidebar (list of tabs) that takes a lot of space, I never see the list. Maybe I should rework that, because it's really a bit too strict.
Oh, and the setting really wasn't set in the admin area... So it's not related to that.
5887
Features / Re: New revs
« on March 22nd, 2012, 03:31 PM »
rev 1499
(3 files, 2kb)
* Added a post_shortcuts block to the Post template, which holds the list of keyboard shortcuts, and moved the post_buttons block before the options block, allowing for it to be properly aligned, since it's right-floated. (Post.php, Post.template.php)
* The main menu's admin menu should point to the Plugins page, rather than the (soon to be gone) Packages page. (Subs.php)
(3 files, 2kb)
* Added a post_shortcuts block to the Post template, which holds the list of keyboard shortcuts, and moved the post_buttons block before the options block, allowing for it to be properly aligned, since it's right-floated. (Post.php, Post.template.php)
* The main menu's admin menu should point to the Plugins page, rather than the (soon to be gone) Packages page. (Subs.php)
5888
Development blog / Re: Aftermath of the Great Deployment
« on March 22nd, 2012, 03:09 PM »Also, I'm slightly surprised no-one's said anything about the page-index navigation having 'prev/next' arrows by the pages. I actually thought that was more of a usability improvement than a lot of things we did >_>
Oh, and I didn't notice that enablePreviousNext was disabled here... Re-enabled it. I'm sure someone will suddenly notice how cool that rewritten feature is :)
5889
Archived fixes / Re: Preparsing adds url bbc where it shouldn't
« on March 22nd, 2012, 02:38 PM »
It may be due to a change in Wedge.org, then. The only change I can think of is the one to trim whitespace around quotes (which I stumbled upon yesterday while trying to remember how Noisen did it without fucking with noae tags...):
Code: [Select]
But it doesn't look like it's doing anything special... Really couldn't find anything else in the entire codebase related to url tags.
// !!! Purifying quotes (change noae?)
$message = preg_replace('~(?:<br />|\s)*(?:\)?\[(/?)quote(.*?)\](?:\)?(?:<br />| |\s)*~is', '[$1quote$2]', $message);
$message = preg_replace('~(?:<br />|\s)*(\[url=[^]]*?)?\[img( align=center)?]([^\[]+?)\[/img](\[/url])?(<br />| |\s)*~is', '$1[img$2]$3[/img]$4', $message);But it doesn't look like it's doing anything special... Really couldn't find anything else in the entire codebase related to url tags.
5890
The Pub / Re: Improvement to drafts (and posting, actually) I need to do
« on March 22nd, 2012, 02:30 PM »
Yep, but there's no point in using it, we need to fix that...
- Make sure that drafts don't get saved if the same text is already in the database,
- Ensure they really don't get saved if no activity is found...
- Ensure they don't get saved *if the post is empty* (even if there's activity like keydown, Wedge still saves an empty draft for EVERY topic I'm simply reading with my iPod...!)
- Make sure that iOS generally won't screw up with drafts.
- Ensure all drafts are removed for a specific post once it's sent.
Looking at my latest drafts:
- this is found as a draft, completely the same post. Not even a partial one... Same for the Werner Herzog post.
- the current post is updated in real time, with no extra drafts being created for it, so that one is okay.
- an empty draft for a New Revs post (I never post there from my iPod), but no empty drafts for my other recent Opera posts.
- that empty draft says, "This draft is a reply to a topic that is currently locked by a moderator. Editing this draft will attempt to create a new topic." --> yeah, but I'm the admin... I can post it there if I want! Does the feature at least check against that...?
- about 1350 drafts are the same post -- a Logo Madness draft that is just a quote of another post, possibly a tab I opened somewhere with a plan to post a reply, and then 12 hours later I found the tab and just closed it. It saved a new copy of the draft every single time... :-/
- Make sure that drafts don't get saved if the same text is already in the database,
- Ensure they really don't get saved if no activity is found...
- Ensure they don't get saved *if the post is empty* (even if there's activity like keydown, Wedge still saves an empty draft for EVERY topic I'm simply reading with my iPod...!)
- Make sure that iOS generally won't screw up with drafts.
- Ensure all drafts are removed for a specific post once it's sent.
Looking at my latest drafts:
- this is found as a draft, completely the same post. Not even a partial one... Same for the Werner Herzog post.
- the current post is updated in real time, with no extra drafts being created for it, so that one is okay.
- an empty draft for a New Revs post (I never post there from my iPod), but no empty drafts for my other recent Opera posts.
- that empty draft says, "This draft is a reply to a topic that is currently locked by a moderator. Editing this draft will attempt to create a new topic." --> yeah, but I'm the admin... I can post it there if I want! Does the feature at least check against that...?
- about 1350 drafts are the same post -- a Logo Madness draft that is just a quote of another post, possibly a tab I opened somewhere with a plan to post a reply, and then 12 hours later I found the tab and just closed it. It saved a new copy of the draft every single time... :-/
5891
The Pub / Re: Improvement to drafts (and posting, actually) I need to do
« on March 22nd, 2012, 02:18 PM »
Checked my drafts. I have 1389 drafts since March 16. No typo.
5892
The Pub / Re: Improvement to drafts (and posting, actually) I need to do
« on March 22nd, 2012, 02:17 PM »
Tried again. Opened box. Waited. Saved itself. Meh.
So there really is an issue in iOS.
So there really is an issue in iOS.
5893
The Pub / Re: Improvement to drafts (and posting, actually) I need to do
« on March 22nd, 2012, 02:15 PM »
all I can say is that it happened again right now. On this post. Except the message was there already when I opened it.
5894
The Pub / Re: Improvement to drafts (and posting, actually) I need to do
« on March 22nd, 2012, 01:02 PM »
Possible bug...? If yes, it's minor.
Yesterday, I tapped Quick Reply (it's collapsed by default) to answer a post.
Right after it opened the (empty) QR box, the first draft was saved.
This could mean two bugs: drafts are still saved on empty contents, and the draft timer is started even if the QR box is closed.
Yesterday, I tapped Quick Reply (it's collapsed by default) to answer a post.
Right after it opened the (empty) QR box, the first draft was saved.
This could mean two bugs: drafts are still saved on empty contents, and the draft timer is started even if the QR box is closed.
5895
Archived fixes / Re: IE8: menu broken (with fix)
« on March 22nd, 2012, 12:56 PM »
Holy crap... Thank you, Microsoft........ -_-
What do I do now.
And yes, playing with display styles usually fixes this kind of stuff.
However, there's often a reason for deciding to use this or that style. Too many times, I've fixed something to break it somewhere else. (This is why I was so adamant to implement @remove from: because instead of replacing a rule with another, we can now simply ignore it... Simple example: try cancelling hasLayout on older IEs after it was triggered... Good luck!)
A few days ago I was wondering why I wasn't using the gradient filter on the main menu for IE... Oh, well: it works when you first open it... But if you switch to another menu entry, it'll display a transparent background instead. Fun... Maybe it's only in IE9 in compatibility mode... But I won't tempt the devil.
So, what can I say... Thorsten, can you confirm that not only your fix works, but that it doesn't break anything else...?
What do I do now.
And yes, playing with display styles usually fixes this kind of stuff.
However, there's often a reason for deciding to use this or that style. Too many times, I've fixed something to break it somewhere else. (This is why I was so adamant to implement @remove from: because instead of replacing a rule with another, we can now simply ignore it... Simple example: try cancelling hasLayout on older IEs after it was triggered... Good luck!)
A few days ago I was wondering why I wasn't using the gradient filter on the main menu for IE... Oh, well: it works when you first open it... But if you switch to another menu entry, it'll display a transparent background instead. Fun... Maybe it's only in IE9 in compatibility mode... But I won't tempt the devil.
So, what can I say... Thorsten, can you confirm that not only your fix works, but that it doesn't break anything else...?