Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
5836
Features / Re: New revs
« on March 24th, 2012, 07:36 AM »
rev 1505
(5 files +1, 6kb)

! Fixed Split Topics selector's Ajax code, which simply failed to work with the page index function being moved to the index template. (SplitTopics.php, SplitTopics.template.php, Xml.template.php)

! Fixed error in create_button(). (Subs.php)

+ Added a robots.txt with an exclusion rule for ?msg= links, which are aliases to topic pages that I'm sure Google can do without. Plus, it saves you the 404 error on that file. (other/robots.txt)

* Latest homepage tweaks. (Home.template.php)
5837
Archived fixes / Re: Smart Tag Closer
« on March 23rd, 2012, 09:51 PM »
It isn't creating anything.

Here's the logic behind the smart tag closer: if you press shift+enter, which is a conscious choice, you're telling Wedge you want to create a new line where all open tags are closed.
So it'll go through the post, see the open "b", close it, and reopen it after that.
It's exactly as desired...
It doesn't work 'only' for quotes, it works for any kind of tag. It's just *most* useful for quotes ;)
5838
Archived fixes / Re: IE8: menu broken (with fix)
« on March 23rd, 2012, 07:51 PM »
test
5839
Archived fixes / Re: IE8: menu broken (with fix)
« on March 23rd, 2012, 07:38 PM »
Yes, would be a good idea :P
5840
Archived fixes / Re: IE8: menu broken (with fix)
« on March 23rd, 2012, 06:54 PM »
Are you on xp?
5841
Archived fixes / Re: IE8: menu broken (with fix)
« on March 23rd, 2012, 06:41 PM »
Quote from Farjo on March 23rd, 2012, 06:38 PM
This PC has IE8 and all the dropdown options drop down below "Home". Does that make sense?
I can't test.
Are you implying that before today (i.e. before the fix), it worked better than now..?
5842
Features / Re:
« on March 23rd, 2012, 05:16 PM »
Quote from Arantor on March 23rd, 2012, 04:50 PM
Quote
Make sure to check Post.php out when you have some time to look into rev 1503
I will do that. I really don't remember it adding slashes.
No, you didn't. That's the point. The draft code doesn't do it, when I think it should turn quotes to their entity equivalent (quot). As for the addcslashes() call, it was added by SMF, not by you. We just never noticed the bug because we don't often have double quotes in topic titles, and the error only shows up when replying.
Quote
That's sort of how I implemented it. The drafts don't need to have the same level of protection that normal posts do, just enough to prevent XSS injections.
But they'll still show double quotes in the subject... Unless you already protected them at auto-save time?
Quote
Quote
Oh, and another bug: if a topic is moved (not deleted!) while writing a draft, the draft only offers to create a new topic.
That's a bug. It should still pick up on the topic, even if it's in a different board. Missing board, on the other hand, is known to cause problems at the present time.
Will you think of fixing this, too?
5843
Archived fixes / Re: Undefined index, Subs.php
« on March 23rd, 2012, 05:12 PM »
Thanks! Was an error of mine...
create_button() is bound to disappear at some point anyway. It's an old, barely used function.
5844
Off-topic / Re: Y U NO WAP2?
« on March 23rd, 2012, 04:08 PM »
Quote from JBlaze on March 23rd, 2012, 04:05 PM
Ah, cool beans. Haven't been around here lately so I must have missed it.
I ripped it apart a few weeks ago already. And welcome back then ;)
Quote
BTW, loving the new theme :)
Thanks!
I keep thinking that it's ugly as hell, but then again, 99% of all designs I see outside of mine, I find to be even uglier :P
The only thing I'm pretty happy with, right now, is the Display template.
5845
Off-topic / Re: Y U NO WAP2?
« on March 23rd, 2012, 04:03 PM »
Profile > Change skin > Wireless

Of course it's no longer in Wap2. But if your browser is HTML capable, it should like this better, it's optimized for very narrow resolutions.

Which reminds me that I still haven't implemented my mobile detector... Hmm.
5846
Features / Re: New revs
« on March 23rd, 2012, 04:00 PM »
rev 1504
(8 files, 2kb)

* If the admin_login template is shown (to confirm your password before you access an admin page), Wedge will now use a 'login' id in the html tag, rather than the original page's action id. (index.template.php)

+ ...Which allows me to finally vertically align that dreaded login box. Yay. (sections.css)

! Arhh. Even Firefox doesn't like a 49% width on two-columns! (index.firefox.css)

! Modify Topic Settings was set at an incorrect index in the contextual tabs. (ManagePosts.php)

* Minor tweak to media area styling. (media.css)

* Minor language/translation tweaks. (Admin.french.php, Help.language.php)
5847
Features / Re:
« on March 23rd, 2012, 03:53 PM »
Quote from Arantor on March 23rd, 2012, 02:35 PM
I don't recall SMF adding slashes there...
Make sure to check Post.php out when you have some time to look into rev 1503 ;)
SMF does it in two passes: htmlspecialchars, then addcslashes.
Wedge retains the addcslashes. I also forgot to mention that in the situation where you're editing a draft, it will then reset the subject (protection-free?) after the addcslashes (now str_replace). It's at Post.php:1024 if you're interested. It also does an un_htmlspecialchars on the message body... The code block also has a //!! in it, so I suspect you stopped working on it in the middle.

Oh, and another bug: if a topic is moved (not deleted!) while writing a draft, the draft only offers to create a new topic.
5848
Features / Re: New revs
« on March 23rd, 2012, 03:07 PM »
rev 1503
(14 files +1, 7kb)

! Plugins would never load the non-default language strings. Hey, I think it's the first time I touch plugin-related code at all! :P (Load.php)

+ Added an aeva_showStars() function whose purpose is to simply show an img tag of stars for a corresponding rating between 0 and 5. Half points are taken into account, which wasn't the case before (especially not with a rating of 0.5/5 which would generate a 404 error!) (Aeva-Foxy.php, Aeva-Gallery2.php, Subs-Media.php, Media.template.php, images/aeva/star05.gif)

! If a subject had double quotes in it, replying would show a backslash instead of the first quote, and remove the rest of the subject. (Post.php)

! If $options['view_newest_first'] is set, show the page index's "New" post indicator at the beginning of the list, instead of the end. (index.template.php)

* The Flash language string was a bit confusing. (Admin.language.php)

! Fixed more translations. (Help.french.php)

! Fixed media comment layout. (Media.template.php)

! Fixed the rating select box disappearing after rating a media item. (script.js)

! Fixed overlapping main menu icons in the 'genuine' IE8 (thanks TE). Just to make it clear: this problem doesn't show up in IE9 + IE8 compatibility view, so a big thank you to Microsoft for making our lives a misery. (index.ie8.css)

! Fixed some colors when showing drop-shadow-type zooms with Zoomedia. (media.css, zoom.css)
5849
Archived fixes / Re: Bug with color & font selectboxes
« on March 23rd, 2012, 02:47 PM »
Quote from Arantor on March 23rd, 2012, 02:35 PM
Rated.
Thanks! Bug fixed.
5850
Features / Re: Badges and the displaying thereof
« on March 23rd, 2012, 02:32 PM »
Personally, right now I'd be happy just with a setting to disable all textual membergroups and only show one badge per person... :^^;:
How can I say that?

Perhaps my number one issue with forums, and the more time passes the worse it gets, is that they're BUSY. They look busy, and they are. They show plenty of buttons and icons everywhere. It's always like the authors want their new features to be visible, but then they forget to hide their older, lesser used features. vBulletin is the prime example of that, I'd say... Every time I'm on a VB forum, I keep telling myself that, no, it's okay, I DON'T need a PhD to navigate through the board... But it certainly feels so!