Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Nao
571
Features / Re: New revs
« on September 12th, 2014, 01:41 AM »
[Commit revision c7c0b6f]
Author: Nao
Date: Fri, 12 Sep 2014 01:41:16 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Board age tests (in board lists) were done incorrectly (difference between current unadjusted time, and last post's adjusted time). I told you, these timestamp adjustments just don't make sense... Well, okay, in that case it was my board icon rewrite that was a bit messed up. Had a lot to rewrite, at the time... (Subs-BoardIndex.php)
572
Features / Re: Plugin revs
« on September 12th, 2014, 01:24 AM »
[Commit revision e5364fb]
Author: Nao (Signed-off)
Date: Fri, 12 Sep 2014 01:24:36 +0200
Stats: 7 files changed; +8 (insertions), -29 (deletions)

  • Rewrote Recent Items to use the time tag instead of these convoluted timestamp manipulations... (recent_items/*)
573
Archived fixes / Re: Wedge.org broken in IE11
« on September 12th, 2014, 01:20 AM »
It'd require updating both some PHP and the htaccess, so no it's not easy to achieve if you don't know the codebase too well... ;)

(I always find it ironic that E.T., which was historically the *very* first forum to ever perm-ban me, ended up running software I wrote! :^^;:)
574
Features / Re: New revs
« on September 12th, 2014, 12:42 AM »
[Commit revision 7b016f4]
Author: Nao
Date: Sat, 30 Aug 2014 23:57:07 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • The main script file was broken when compressing it with JSMin, because of the "+ ++unique" thingy. (sbox.js)
  • Interestingly, adding these 4 brackets actually reduced the file size by 2 bytes...

[Commit revision c04b446]
Author: Nao
Date: Mon, 08 Sep 2014 21:14:54 +0200
Stats: 1 file changed; +2 (insertions), -1 (deletion)

  • PHP has a set_charset function, let's use it... Seems to be a bit faster and safer. (Load.php)

[Commit revision b867b56]
Author: Nao
Date: Tue, 09 Sep 2014 13:55:23 +0200
Stats: 2 files changed; +2 (insertions), -35 (deletions)

  • I can't think of any other software that puts so much care into rebuilding the current URL, and then proceed to not using it in some areas. (Subs-Auth.php, Login.template.php)

[Commit revision 0caffa4]
Author: Nao
Date: Tue, 09 Sep 2014 14:01:49 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • We have the PROTOCOL constant, too, so let's use that... (Class-System.php)

[Commit revision caec3b3]
Author: Nao
Date: Fri, 12 Sep 2014 00:42:05 +0200
Stats: 2 files changed; +7 (insertions), -6 (deletions)

  • Message edited time was applying the user timezone twice, resulting in odd things like "edited 10 hours ago" instead on a message posted 5 or 6 hours ago... (Display.php)
  • Added a parameter to time_tag to disable timezone transformations. This isn't used in Wedge, and probably won't be used in the main codebase (doing timezone transforms isn't too expensive, but I'd rather do them only as needed), but here it is, it should be more flexible now. (Subs.php)
575
Features / Re: Language revs
« on September 11th, 2014, 09:31 PM »
[Commit revision cbe621e]
Author: Nao (Signed-off)
Date: Thu, 11 Sep 2014 21:30:45 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • This might be one of the most obviously bad French translations I've ever seen in SMF... And it took me years to realize that. (Profile.french.php)

[Commit revision d5a5239]
Author: Nao
Date: Thu, 11 Sep 2014 21:31:19 +0200
Stats: 1 file changed; +6 (insertions), -0 (deletion)

576
Archived fixes / Re: Wedge.org broken in IE11
« on September 10th, 2014, 11:33 PM »
Apparently they say this can be fixed by changing the extension to gz.css instead of css.gz... Dunno. Can anyone test this, if you know how to change it..? I really don't want to install a pirate copy of Windows 8 and update ie11 on it just for that... (Because yes, I have no plans to upgrade from my legit Windows 7! And Microsoft doesn't offer an iso of win 8 for ie testing... Color me surprised...)

Alternatively, I could simply disable gzipping on IE11 (including on platforms where it isn't buggy, e.g. Win7), just tell me what you prefer guys...
577
Features / Re: Let's discuss privacy openly!
« on August 30th, 2014, 10:30 AM »
Bump for @Pandos or anyone else in the know..!
578
Archived fixes / Re: Post Time
« on August 27th, 2014, 01:27 AM »
Good... But I just realized I failed to commit something else, and it probably wasn't any useful, so I'm still interested in knowing whether or not it works for Americans and Asians.
579
Archived fixes / Re: Post Time
« on August 26th, 2014, 01:17 AM »
Can anyone check whether post time & edited time work for you in topic pages..? (e.g. here!)

This is only for people who aren't on my timezone, i.e. Paris / Brussels / etc. For further reference, I edited the message above at 01:13 AM on August 26 (for me), which is also server time. You can see the 'base' time for you by hovering the post time & modified time -- it'll show you a tooltip with the time for you, I think.
580
Archived fixes / Re: Wedge.org broken in IE11
« on August 26th, 2014, 01:12 AM »
Yeah, but Wedge does gzipping the 'proper' way...
Safari used to choke on that, too. They eventually fixed it. Wedge works around these old versions by simply disabling gzipping on old Safari's.
However, having to disable on Windows 8.1 + IE 11 is pretty weird..!
581
Features / Re: New revs
« on August 26th, 2014, 12:48 AM »
[Commit revision 7f70b39]
Author: Nao
Date: Tue, 26 Aug 2014 00:48:17 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Homepage topic lists were applying user timezones twice -- once at SSI time, once at templating time. User-specific times were already set up in SSI, and didn't need to be recalculated. (Home.template.php)
  • I'm not too happy that the 'timestamp' value isn't consistent when it comes to user timezones. I guess it's a remnant of iterative SMF development...
582
Archived fixes / Re: Post Time
« on August 25th, 2014, 08:49 PM »
Broken locally too.

:edit: Fixed...
583
Archived fixes / Re: Wedge.org broken in IE11
« on August 25th, 2014, 08:48 PM »
MS bug then?
585
Features / Re: New revs
« on August 25th, 2014, 08:09 PM »
[Commit revision e33bf38]
Author: Nao
Date: Mon, 25 Aug 2014 20:09:01 +0200
Stats: 2 files changed; +4 (insertions), -6 (deletions)

  • Fixed error when showing custom fields in profiles. (Profile.template.php)
  • Spacinazi... (Profile.php)