This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
5687
Features / Re: New revs - Public comments
« on March 30th, 2012, 01:09 PM »Doing it off groups is an inference, it's also not possible to infer 'friends' from that either, assuming you wanted to do that,
is it possible to infer 'just me' or 'everyone' without guessing or coming up with some magic state to refer to these.
Much better would simply be to define a value in the boards table to indicate that board's default privacy, which avoids any risk or inference being wrong, and it's almost certainly faster too.
Posted: March 30th, 2012, 01:08 PM
(I love it how Wedge auto-fixed the mismatched tags when I changed them in quick edit. That one is mine, too, IIRC :P)
5688
Archived fixes / Re: Time offset (auto detect)
« on March 30th, 2012, 01:05 PM »
Okay. :P
(Oh and tell me about complexity. I can barely even read time when giving by an analog clock...)
(Oh and tell me about complexity. I can barely even read time when giving by an analog clock...)
5689
Features / Re: Badges and the displaying thereof
« on March 30th, 2012, 01:04 PM »We've managed to talk about several very very different things.
On the one hand, is user-created groups. A lot of that is UI fluff. I'd argue that the badges for these should never be shown (mind you I don't see that you'd ever have badges for them in the first place, eh)
Perhaps it could be done, but I suspect through a plugin maybe. By default it really would be opening the door to abuse. e.g. I'll just create 30 groups with a badge and put myself into them :P
(Hmm, would be interesting to ensure that groups you create, you CANNOT join. Any access permissions given to it for your items are automatically given to you anyway, as you're the author...)
On the other hand is groups based on other criteria that isn't assigned and isn't posts, e.g. likes. Or number of topics created. Or number of attachments posts. Or total time logged in. Or karma if we still had it. This is where it becomes painfully obvious that there are problems in the post count group setup, in terms of extensibility, usability and reliability. As I've alluded to, it's possible to make people admins *by accident* by screwing up the post count groups.
Eh, what am I talking about... No one would use that anyway. :P
Which means, then, perhaps we want to rethink how post count groups are actually managed, and not make them groups in the current conventional sense.
Perhaps what could be done, though, is to instigate a "minimum post count" setting that would be quite global to the forum. Anywhere you can set up a membergroup, you could also set up a minimum post count check that is done after the membergroup check. That setting could be kept either in a new field in most tables, or simply in a new table with a content_type field or something.
But, quite honestly, I think that id_post_group is... relatively well known now, and perhaps it would put off admins if we removed the system entirely. Like, it might give some users access to areas they previously didn't know about...
5690
Features / Re: New revs - Public comments
« on March 30th, 2012, 12:50 PM »
How come it would be wrong to use the board access table to emulate this anyway...?
If you don't want to show it to guests, remove -1 from the list... If you want to restrict it from access to group 4, add 4 to the deny list... It seems to me that it is a more efficient way of dealing with it than mine.
The only thing that's missing is an "easy UI", e.g. when creating a board, it should offer to have either a simple or complex membergroup list, and in simple mode it should have models -- "Only my groups", for instance, would only give access to user groups that you own, i.e. no guests and regular members and non-personal/non-hidden groups...
If you don't want to show it to guests, remove -1 from the list... If you want to restrict it from access to group 4, add 4 to the deny list... It seems to me that it is a more efficient way of dealing with it than mine.
The only thing that's missing is an "easy UI", e.g. when creating a board, it should offer to have either a simple or complex membergroup list, and in simple mode it should have models -- "Only my groups", for instance, would only give access to user groups that you own, i.e. no guests and regular members and non-personal/non-hidden groups...
5691
Archived fixes / Re: Time offset (auto detect)
« on March 30th, 2012, 12:46 PM »
Hmm... Meaning that their functions are broken? :P
Or just plain hard to use...! If someone like Arantor can't get them to work immediately!
Or just plain hard to use...! If someone like Arantor can't get them to work immediately!
5692
Features / Re: Badges and the displaying thereof
« on March 30th, 2012, 12:46 PM »
"On top"? You mean, additional groups?
And my post doesn't cover what to do when the group is Additional or Primary, though... Ah ah.
And my post doesn't cover what to do when the group is Additional or Primary, though... Ah ah.
5693
Bug reports / Re: SMF bug 3702 (emptying file cache when changing cache settings)
« on March 30th, 2012, 12:44 PM »
I have... no clue about that ;)
Probably, though! :p
Probably, though! :p
5694
Archived fixes / Re: Time offset (auto detect)
« on March 30th, 2012, 12:34 PM »
If it's not 'wrong' in the SMF codebase, maybe you could look into it and see where you started deviating from their code..?
5695
Features / Re: New revs - Public comments
« on March 30th, 2012, 12:27 PM »
Are you talking about that bit?
Code: [Select]
If yes -- it's probably something I added from noisen. It uses the (older) topic privacy format for boards. And yes, it's not 'inaccurate' per se because it's mainly of use in case topic privacy is set to inherit the board privacy setting. Other than that... Well, yes it can go, it's only a UI thing at this point.
Hey, I think you rewrote the board privacy feature in Load.php... That bit with switch ($board_info['privacy'])... It gives you away because I never use switch() in my code :P
The only feature that board privacy has, that isn't in your implementation, is friends. But because it's a pretty basic thing to implement in the user-group mindset, it can go easily. It just won't be 'available' to users right now...
I think I'll you play with removing the code because, basically, I'm getting short on time today.
// !!! Are we still meant to be using this now we have query_see_topic ? It's going to be inaccurate!If yes -- it's probably something I added from noisen. It uses the (older) topic privacy format for boards. And yes, it's not 'inaccurate' per se because it's mainly of use in case topic privacy is set to inherit the board privacy setting. Other than that... Well, yes it can go, it's only a UI thing at this point.
Posted: March 30th, 2012, 12:18 PM
Hey, I think you rewrote the board privacy feature in Load.php... That bit with switch ($board_info['privacy'])... It gives you away because I never use switch() in my code :P
The only feature that board privacy has, that isn't in your implementation, is friends. But because it's a pretty basic thing to implement in the user-group mindset, it can go easily. It just won't be 'available' to users right now...
I think I'll you play with removing the code because, basically, I'm getting short on time today.
5696
Features / Re: New revs
« on March 30th, 2012, 11:39 AM »
rev 1525
(6 files, 5kb)
! Fixed (actually removed and simplified) a malformed rtrim call in pretty_generate_url() that would systematically return an empty string for board URLs. (Subs-PrettyUrls.php)
! Fixed Wedge breaking the entire forum (by redirecting it internally to an empty board) if said pretty_generate_url() returned an empty string, for instance by entering only dashes as the board name. Or something like that. Now it will correctly name it 'b123' where 123 is the board ID. You can always change the URL later... (Subs-Boards.php)
* Shortened posting icons code below board lists. (Boards.template.php, sections.css, index.rtl.css)
* Homepage blurb update. (As a reminder, that file won't be in Wedge, only a shortened version inspired by it. I'm only taking advantage of the SVN server here :P) (Home.template.php)
(6 files, 5kb)
! Fixed (actually removed and simplified) a malformed rtrim call in pretty_generate_url() that would systematically return an empty string for board URLs. (Subs-PrettyUrls.php)
! Fixed Wedge breaking the entire forum (by redirecting it internally to an empty board) if said pretty_generate_url() returned an empty string, for instance by entering only dashes as the board name. Or something like that. Now it will correctly name it 'b123' where 123 is the board ID. You can always change the URL later... (Subs-Boards.php)
* Shortened posting icons code below board lists. (Boards.template.php, sections.css, index.rtl.css)
* Homepage blurb update. (As a reminder, that file won't be in Wedge, only a shortened version inspired by it. I'm only taking advantage of the SVN server here :P) (Home.template.php)
5697
Features / Re: Badges and the displaying thereof
« on March 30th, 2012, 11:31 AM »
I don't know, I think that user-owned groups (for starters) will only get to modify a few of the settings -- basically, the first half of the settings in the membergroup edit page. They will also be able to edit their permissions, I guess, for their own user-created boards. It gets complicated, I know, but it makes sense as well to give users freedom... Otherwise there's no point in implementing blogs or anything. Because that's really what all other forums (except for Noisen but it's pretty much proto-Wedge anyway :P) do WRONG IMHO: they consider that blogs are only to be created by forum admins, or they provide blogs to their users but they're extremely limited, e.g. they can only have one blog, public viewing, etc... I haven't looked much into other forum+blog solutions, but they all seemed to be that limited.
Could you give your opinion on that post, btw..?
http://wedge.org/pub/feats/7108/badges-and-the-displaying-thereof/msg276657/#msg276657
Could you give your opinion on that post, btw..?
http://wedge.org/pub/feats/7108/badges-and-the-displaying-thereof/msg276657/#msg276657
5698
The Pub / Re : Bloc Madness
« on March 30th, 2012, 11:26 AM »
Okay thanks, that's the way I was thinking it worked. (Only a tad more complicated because of the post ranks... :lol:)
5699
Features / Re: New revs - Public comments
« on March 30th, 2012, 11:25 AM »
Nope, no such id_board index, at least in install.sql and in my database...
I understand your issue with aliases eheh. I'd just recommend renaming the code, although obviously it will do exactly the same, but it tickles me ;)
Also. Working on the board creation bug. (Having new boards breaking the *entire* forum until I fix them in phpmyadmin isn't exactly cool...)
The bug is two-fold: member groups and pretty URLs.
I fixed the PURL bug a few minutes ago -- it was a sad, a very sad typo (a forgotten backslash) which broke the URL generation code for boards, and worst of all -- that particular piece of code wasn't even needed...
So I'm working on member groups and, wow. It seems that there's a minor difficulty.
Wedge, like SMF, initializes the member_groups field to '-1,0' by default.
Then SMF will do this:
Code: [Select]
Only, Wedge no longer has this. Because it uses a new table with the same data (for access), it directly fills in the data in the table, and ignores the member_groups field in the boards table, which may or may not break the board access system. Actually, I don't know... But if it isn't used anymore, maybe this field should be removed entirely...?
I understand your issue with aliases eheh. I'd just recommend renaming the code, although obviously it will do exactly the same, but it tickles me ;)
Also. Working on the board creation bug. (Having new boards breaking the *entire* forum until I fix them in phpmyadmin isn't exactly cool...)
The bug is two-fold: member groups and pretty URLs.
I fixed the PURL bug a few minutes ago -- it was a sad, a very sad typo (a forgotten backslash) which broke the URL generation code for boards, and worst of all -- that particular piece of code wasn't even needed...
So I'm working on member groups and, wow. It seems that there's a minor difficulty.
Wedge, like SMF, initializes the member_groups field to '-1,0' by default.
Then SMF will do this:
// Who's allowed to access this board.
if (isset($boardOptions['access_groups']))
{
$boardUpdates[] = 'member_groups = {string:member_groups}';
$boardUpdateParameters['member_groups'] = implode(',', $boardOptions['access_groups']);
}Only, Wedge no longer has this. Because it uses a new table with the same data (for access), it directly fills in the data in the table, and ignores the member_groups field in the boards table, which may or may not break the board access system. Actually, I don't know... But if it isn't used anymore, maybe this field should be removed entirely...?
5700
Features / Re: Badges and the displaying thereof
« on March 30th, 2012, 10:22 AM »
Yeah, post-count groups *are* perverted in some way, I myself am known for spamming some boards when I was close to getting into a 'good' post group, and even becoming silent when I was close to getting out of it :P