Wedge

rev 1560
(3 files, 2kb)

! Fixed attach_downloaded being parsed with the actual string rather than the $txt index. Maybe I should allow for a string to be sent directly, though...? It's just an extra isset()... (Display.template.php)

! Fixed autolinking triggering itself a bit too happily in non-quick-edit mode... Should I reuse the exact same code as in parse_bbc()? (Aeva-Embed.php)

! Applied SMF 2.1 fix 8d54b5b by Spuds for cleanXml (PCRE v8.3 no longer accepting range D800-DFFF in regexes.) I never look into their fixes but when it comes to regex I must have a radar of sorts... (Subs.php)

rev 1559
(4 files, 2kb)

* Forgot to hit F5 and refresh my list of updated files... Hmm. Another classic of mine. All of these files are related to the number_context() changes. (Subs.php, Boards.template.php, Display.template.php, MessageIndex.template.php)

rev 1557
(26 files, 38kb) (huge commit... Hopefully everything still works. I'll keep an eye on the error log...)

* Moved more index language strings to satellite files. More to come later but I think the bulk is done. Original size was 33.6KB, current size if 27.3KB... Not bad, because this makes it more enticing for translators to start a 'basic' translation of Wedge by doing just the index file. Note that most debug strings are now a single long string (a tad slower to manage but should save time for non-admins.) (Class-DB.php, MoveTopic.php, Register.php, Report.php, SendTopic.php, Subs-Post.php, Subs-Template.php, SSI.php, LANGUAGES: Errors, index, Login, ManageTopics, Post, Profile)

* Rewrote loadLanguage to load an array of language files, rather than an exploded string of filenames, effectively harmonizing it with loadSource etc. (Admin.php, ManageErrors.php, ManagePermissions.php, Report.php, Subs-Post.php)

! Fixed loadLanguage not properly caching some files when some are loaded in batches. (Load.php)

! Fixed buffer hooks not executing. (Thanks live627!) (Subs-Template.php)

* Number of downloads/views per attachment is now a context number. (Display.template.php, index.language.php)

* Clean-up à la Nao. (SplitTopics.template.php)

I think itll be good dont worry :P

Hey yeah, it's not a problem :) I did my share of CRLF commits too...!For now it's okay, even though I moved SendTopic strings there.Yep, and sometimes it's annoying to find some generic strings that are found across different files used in multiple strings...

BTW, you didn't tell me whether you thought it'd be best to rewrite number_context to use an array directly?
Oh and we could for instance put a string instead of an array, and that would mean 'no special treatment' (i.e. always '_n'), meaning that instead of doing sprintf() on strings, we could directly call number_context even if we don't have special treatment for them in French or English -- because it doesn't mean other languages won't need it...

Also -- I looked into loadLanguage and it has an oddity.
loadLanguage('index+Errors') would be an acceptable call. It will explode the string and deal with both language files.
However:
- it could benefit from being turned into an array parameter, like loadSource etc...
- currently, $already_loaded stores the entire string in its cache. Meaning that if we did loadLanguage('index') and then someone did loadLanguage('index+Errors'), the index file would be loaded a second time. It can be fixed by moving the caching operations to within the foreach, and using a continue; instead of a return $lang, but I don't know if it's acceptable to you...?Certainly. I know that Wedge's skins are currently not set up for RTL use at all... It may work. Then again it may not.Which is what was done after I requested to have $txt['reply'] disambiguated because it was used both as a verb and as a noun... :)It's not always going to be possible though, e.g. 'reply' is too short for that. :)Even THAT..?! Hmm...
I'm not convinced that performance-wise, it's a good idea to put into the DB whatever you're simply going to retrieve later without any sorting work... I mean, SMF/Wedge has the settings table to load entirely, but even that is cached to file, as you kindly reminded me a few days ago... :lol:

Something else... MoveTopic.php does, in a few occasions, load the default language for a file, just to retrieve a string in particular, and then reverts to the user's preference.
However, it 'simply' reloads the file without a second thought about the static cache.
I think it should reload by doing loadLanguage('File', '', false, true) (i.e. $force_reload = true and $fatal = false), don't you agree?

:edit: Forget what I said -- since it stores the latest language loaded in the static cache, then it will automatically continue loading the file. :)

BTW-- index.english.php went from 32KB to 27KB in size... And I'm not even finished!
An incredible amount of data really shouldn't have been in there in the first place ;)

Okay...

- I would also encourage getting rid of guest counting in the stats -- *except* in the Who's online / Info center areas where you can easily sort between guests and online members, and determine that 90% of the 'guests' are actually bots, etc... This kind of thing is interesting, but recording numbers on the long run is pointless because you can't know whether you got a bot swarm or simply an actual surge in interest.

- I think that even if we don't start a session for guests, we should still record whatever page they're on and store it somewhere for the next 15 minutes (by IP.) I really like being able to know what a guest is doing... Not only that, but some people are adamant on knowing it, for security purposes. I'd suggest maybe only showing this data to admins, and showing it in a way that's different from the Who's online section -- for instance, we could store the query string and $_SERVER and show that in a subsection of the Who's online page, or something... Because bots will often try to reach URLs that you never considered, it's nice to be able to spot the oddities in there.

- So, getting rid of PHPSESSID for guests, I'm good with that. I'm sure it'll be beneficial for everyone. We will of course need to ensure that the login and registration links lead us to a proper cookie being set, *or* or a SID param in the URL.

- @Star: you're wrong about awstats and such. But even if you weren't -- it's no reason to get into a fight with Pete. Here you are, waiting for the release of a free software package that will frankly make all others look bad, and you're pretty much insulting half of its authors.

- @Pete: don't bother, again... You don't owe anyone anything (even me, eh.) If you want to ban people (temp or perm), feel free to do it. I'd rather have a forum where people you ban people who piss you off, than a forum where you aren't at all. :P

(BTW, your ManageTopics files were in Windows CRLF format. I tend to double-check for new files so I caught it and fixed it. Try and have your notepad app generate LF files by default :))
(Also, maybe it should be renamed to Topics.language.php?)

Oh and thanks Aaron. Pete is all the more commendable for this because by definition his native language doesn't require any work :P
I'm still lazy enough that I only deal with stuff that makes Wedge better in French. Just like Spip (my fave French CMS which I used back in 2003) had excellent French support.

Let's be clear. The thought system is not 100% finished. It still has a few bugs (try to post a new thought from the sidebar, then try to 'Modify' it immediately without reloading the page... It won't show you the current thought, even though there's one.)
I just don't think it's a huge priority right now. Priorities should basically be whatever will be hard to modify *after* we go live...

For instance, the work I'm doing now on the language files... It's something that's going to be annoying to translators if it's done *after* the first public release.