Wedge

Yeah, basically, if you happened to quit Wedge, I'd be completely screwed because then I'd have to take over your plugin code which I have little knowledge of, restore the calendar code myself, and end up removing Bad Behavior because I'd be totally lost when it comes to updating its rules... And on and on and on... :^^;:

Hmm yeah...

Was testing the attachment handler after rewriting post.js to save another 60+ bytes off it...[1]

Fatal error: Call to undefined function checkGD() in Sources\Subs-Graphics.php on line 203
Call Stack
#   Time   Memory   Function   Location
1   0.0006   827208   {main}( )   ..\index.php:0
2   0.0440   7867680   Post2( )   ..\index.php:198
3   0.0827   14061376   createAttachment( )   ..\Post2.php:683
4   0.0881   14258216   reencodeImage( )   ..\Subs-Post.php:1699

There's a checkGD2() function defined in install.php but that's all. Is this is GD-only function...? If yes, we should use function_exists() on it first...

1.

I should say that I simply turned its methods into private ones, so basically you can't call them from outside (except for checkActive because it's actually used outside), I know it's not something I should do without thinking because one might want to add a prototype for a Wedge object later and they won't be able to access its private variables -- but still, I don't want to put the extra load on everyone when we have no idea whether people will actually want to extend an object... If they do want to, I'll just consider turning the object back into a list of prototypes. Is that okay with you?

I think it's always been the case - and I occasionally used it to enter entities that I didn't know the Alt code for.. :P

rev 1564
(5 files, 7kb)

! Fixed a last-minute warning message that showed up when not providing a custom.js file. I'd tested for this, but incorrectly it would seem... (Subs-Cache.php)

* Rewrote the topic title changer (in message index) to be entirely contained in topic.js (this saves us the extra JavaScript at the end of the HTML, as well as the onmouseout/onmouseover events.) Somehow, even adding more code resulted in saving 31 more bytes off the gzipped size... Yeah, I'm like that. (MessageIndex.template.php)

* Fixed the dollar fix. SMF bug, somehow: the comment says it's for IE compatibility, when it really happens on all browsers, because $ is a meta-character when used in the replacement string in a .replace() call. The solution is to simply convert it (once) to $$$$ (or just $$$, but it's close to a hack and doesn't save any gzipped space), and not bother with converting it back. Basically: a bug fix is good when it makes sense. This one didn't and I got stumped for months because I kept researching IE bug lists instead of JS regex flavors. (topic.js)

* Translation. (Errors.french.php, ManageTopics.french.php)

Iirc it will be rejected.

Scary attachment pic :P

Board icons -- you mean, replacing the "new posts" icon in the board index, is it...?
I don't know about that. I personally prefer to consider that if a board should have its own icon, it should be offered as an addition to what is already in SMF/Wedge, i.e. new material next to the board title or something.
Noisen has support for board icons but I won't elaborate, as it's quite fucked up... :lol:

[OFF TOPIC STARTS HERE :P] (I don't really have time to start new topics etc...)

Pete, glad to see you back... Although I suddenly got like 50 extra posts to read and I was too busy working on my local install to notice you were back... :^^;:

Speaking of icons -- what do you think of today's rewrites for the action bar? I renamed .moderatorbar to .actionbar (because really, what was the semantic point of showing .modified inside that? I got so much confused by it, I'd actually declared .moderatorbar in index.member.css...!), and moved the action menu there. I changed the global opacity to make it less striking, and I think the result is quite good. More importantly, this (finally) fixes the header bar which was always a bit too crowded with icon + title + reply number + date + actions + action menu + moderation checkbox...
Remaining issues:
- Eats a little more vertical space for guests, or any post that hasn't been modified and that the user has no control over -- i.e. post has no 'last modified' date or Quick Edit button. It's no big deal, and I think FluxBB already has a bar at the bottom and nobody complained about that. IIRC Nightwish also brought a bottom bar to his Eos theme redesign...
- Mobile mode -- should I reset it or leave it as is? I think I'll reset it so that it uses the action bar... The main point is that in order to save space, I moved the Quote and Modify buttons to the action menu in mobile mode, even though these menus are a (tiny bit) harder to navigate in mobile mode than desktop mode.
- The post can feel a bit 'trapped' between the header and action bars... I added some generous extra vertical padding to help. Should be fine.
- I'll have to integrate the Quick Edit button into the action bar -- dunno how best to handle this in terms of usability.

Ah, and before I go... Remember the ugly dollarfix thing in SMF/Wedge? That's in topic.js... Well, I understood what it was all about. It's actually NOT AN IE BUG, contrary to what the comment says. I was misled by this. In fact, when applying a regex replacement in JS, "$" is a meta-character and any proper "$" needs to be escaped to "$$" before it can be used as a replacement string... Which is the reason why every single browser would 'eat' extra dollar signs in posts and subjects. So there was no need to replace to 'dollarfix' and back to '$', just replacing to '$$$$' was enough to fix it. Tested in IE6, Opera and Chrome...

Now, the funny thing is that this is the only place where SMF dealt with that, when in reality there are plenty more places where it potentially tries to inject dollar signs.... Any volunteers to deal with these? :P