Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
5251
Features / Re: Action buttons: positioning
« on May 5th, 2012, 11:22 AM »I agree. It fits in better minimalist, though I like the text color (blueish) of unlike better then the color of Like and Quote & More.Quote from live627 on May 5th, 2012, 05:31 AM Too many borders and lines. I like it more minimalistic like how it is now.Quote You know, I think it might be better if the like button were actually a button in the style of the other buttons
The reason why the buttons don't share the same link color is only due to the fact that I was trying to set an opacity on the icons, and the button text is inside the same stuff so basically they also inherit the opacity, so I had to decrease their brightness to keep them readable. Which OTOH makes them very dark once you hover them... There isn't a "good" solution to fix these, I just like the opacity play too much to get rid of it... :-/
5252
Features / Re: Action buttons: positioning
« on May 5th, 2012, 01:09 AM »
I've done a quick mockup of the Like button repositioning. Is it all right this way?
The 'x likes this' mention is shown in small print, but eventually I think I'll move it to a popup, and replace it with a <span class="note">NUMBER OF LIKES</span> (and class="warn" if you liked it, yourself. Isn't it a good idea? :P)
The 'x likes this' mention is shown in small print, but eventually I think I'll move it to a popup, and replace it with a <span class="note">NUMBER OF LIKES</span> (and class="warn" if you liked it, yourself. Isn't it a good idea? :P)
5253
Features / Re: Action buttons: positioning
« on May 4th, 2012, 08:56 PM »
Logic talked to my brain again.
How about... We move Last Edited to the top next to the posting date, and we use that spot for a left-aligned Like button? Problem is, Like button + list of people who like this is going to overflow very quickly... (perhaps give just the number, and show who likes it in the title hover or with an Ajax click?)
How about... We move Last Edited to the top next to the posting date, and we use that spot for a left-aligned Like button? Problem is, Like button + list of people who like this is going to overflow very quickly... (perhaps give just the number, and show who likes it in the title hover or with an Ajax click?)
5254
Features / Scratching my head on CSS margin collapsing...
« on May 4th, 2012, 06:31 PM »
There's a feature in CSS that you may not know about.
I actually learned about it only very recently, and it suddenly made it clear that many of the "CSS issues" I had were due to my lack of knowledge about that particular feature.
Let's say you have three divs nesting into each other:
.div1________
|
| .div2______
| |
| | .quote___
| | |
.div1 isn't styled at all. Now, consider the idea that .quote is a quote block that has some padding and margin to make the text breathable.
We want any text located between the beginning of .div2 and the beginning of .quote to be separated from .quote by a few pixels.
.quote
margin-top: 8px
All right. Now we want the text before .quote to be readable as well, so we add padding around .div2...
.div2
padding: 8px
border: 1px solid #999
All good. Except that if you don't have any text at the beginning of .div2, then you end up with a 8px padding (from div2) and 8px margin (from quote), making a 16px block of whitespace. It sucks.
I would usually 'fix' that with classes or complex CSS, or even some HTML, but there's another way of doing that.
.div1
border: 1px solid #999
.div2
margin: 8px
Now we have, inside .div2, two adjoining 8px margins from both .div2 and .quote.
The magic of CSS makes it actually reduce itself to the maximum of both margins (here, max(8px, 8px) = 8px).
So, we essentially cancel our quote's top margin and get some proper positioning.
Yay.
So I did exactly that for Wedge's quote blocks. It works perfectly, although I need to figure out how to remove the extra HTML linebreaks that are inserted before a quote.
Now, here's my problem... Which I only noticed this morning.
A quote nested inside another quote.
.quote____
|
| .quote__
| |
The outer quote has some *padding* to make the text inside it actually readable. The inner quote has margins and paddings, too. But because padding and margin aren't mutually exclusive, the inner quote doesn't get the benefits of margin collapsing, and thus a disgracious extra padding shows up.
So... What solution do we have?
- Removing the padding, and replacing it with a margin. The HTML is a bit more complex than what I show above, but it basically works... Somehow. However, we use extra borders and, more importantly, extra backgrounds, that require using paddings and NOT margins if we don't want the inner text to 'stick' to the background's boundaries. The solution would be to use background-origin: margin-box, where the background extends to the margins... Except that there is NO such property in CSS -- it only supports content, padding or border, but doesn't extend to margins at all. Well, if that isn't a useful CSS property eh...?
- We could add an extra div layer inside the .quote, so that we need not apply padding to .quote... In this case, the outer quote has a natural border, which stops any collapsing, then inside it, no padding, then a div with no padding but a margin that is there for text, and finally an inner quote that has a margin, and will 'collapse' against its outer div's margin.
Yeah, you can already see it... It's *extra markup*, just to fix something that should be a natural, or at least be taken into account by a CSS property.
So... Any ideas anyone?
(Another possibility would be to add a br tag at the beginning of the quote html, and then strip br's away from the beginning of the post, and I think we already do that...)
I actually learned about it only very recently, and it suddenly made it clear that many of the "CSS issues" I had were due to my lack of knowledge about that particular feature.
Let's say you have three divs nesting into each other:
.div1________
|
| .div2______
| |
| | .quote___
| | |
.div1 isn't styled at all. Now, consider the idea that .quote is a quote block that has some padding and margin to make the text breathable.
We want any text located between the beginning of .div2 and the beginning of .quote to be separated from .quote by a few pixels.
.quote
margin-top: 8px
All right. Now we want the text before .quote to be readable as well, so we add padding around .div2...
.div2
padding: 8px
border: 1px solid #999
All good. Except that if you don't have any text at the beginning of .div2, then you end up with a 8px padding (from div2) and 8px margin (from quote), making a 16px block of whitespace. It sucks.
I would usually 'fix' that with classes or complex CSS, or even some HTML, but there's another way of doing that.
.div1
border: 1px solid #999
.div2
margin: 8px
Now we have, inside .div2, two adjoining 8px margins from both .div2 and .quote.
The magic of CSS makes it actually reduce itself to the maximum of both margins (here, max(8px, 8px) = 8px).
So, we essentially cancel our quote's top margin and get some proper positioning.
Yay.
So I did exactly that for Wedge's quote blocks. It works perfectly, although I need to figure out how to remove the extra HTML linebreaks that are inserted before a quote.
Now, here's my problem... Which I only noticed this morning.
A quote nested inside another quote.
.quote____
|
| .quote__
| |
The outer quote has some *padding* to make the text inside it actually readable. The inner quote has margins and paddings, too. But because padding and margin aren't mutually exclusive, the inner quote doesn't get the benefits of margin collapsing, and thus a disgracious extra padding shows up.
So... What solution do we have?
- Removing the padding, and replacing it with a margin. The HTML is a bit more complex than what I show above, but it basically works... Somehow. However, we use extra borders and, more importantly, extra backgrounds, that require using paddings and NOT margins if we don't want the inner text to 'stick' to the background's boundaries. The solution would be to use background-origin: margin-box, where the background extends to the margins... Except that there is NO such property in CSS -- it only supports content, padding or border, but doesn't extend to margins at all. Well, if that isn't a useful CSS property eh...?
- We could add an extra div layer inside the .quote, so that we need not apply padding to .quote... In this case, the outer quote has a natural border, which stops any collapsing, then inside it, no padding, then a div with no padding but a margin that is there for text, and finally an inner quote that has a margin, and will 'collapse' against its outer div's margin.
Yeah, you can already see it... It's *extra markup*, just to fix something that should be a natural, or at least be taken into account by a CSS property.
So... Any ideas anyone?
Posted: May 4th, 2012, 04:14 PM
(Another possibility would be to add a br tag at the beginning of the quote html, and then strip br's away from the beginning of the post, and I think we already do that...)
5255
Features / Re: Action buttons: positioning
« on May 4th, 2012, 06:30 PM »Familiarity isn't always a boon, either, I'd honestly rather have things at the end where they would naturally fall in how people read posts and reply to them.
I wasn't too sure because you were confused at first, and thought it was an error on my side, instead of encouraging me to 'keep' that error online ;)
If you're replying without reading first, there's always the reply button at the top of the thread anyway...
If you're editing a post in a topic, you want to see what came up to that point (as presumably you're not editing it with the knowledge of later, but only for is applicable up to that point) but if you hit quote, you're replying to that, and would likely want to take the rest of the thread into account. Always made sense to me.
One of the things that confuse me is, I think, the Like button... I'd probably like for the ability to push it to the Plus button, actually. This is because over the years I've been so used to clicking the first button in the list to reply, it just became a no-brainer... Now I have to be more careful (although it's not too bad since at worst I can simply unlike a post.)
Perhaps we should give users the ability to choose what buttons they want inside and outside the action button... I don't know. It could be something we store in the generic data field.
5256
Features / Action buttons: positioning
« on May 4th, 2012, 04:32 PM »
So... It's been a few days/weeks since I moved the action bar from the top of a post to the bottom.
I haven't got around to dealing with the moderation checkbox and the Quick Edit button, though.
Still, I think it's a good time to determine what's best for a 'default' setup.
(1) TOP
Pros:
- It's what every SMF user is used to...
- Pretty much immediate recognition of the Quote button's position.
Cons:
- It makes it harder (much harder) to make the post header look good, as on smaller widths + longer titles it will breaks these titles, or make them warp on a small width which is even worse...
- Vertical positioning isn't easy. I had to resort to using CSS table emulation, which I'd rather avoid as much as possible...
(2) BOTTOM
Pros:
- It fits nicely into the 'Last edited' box.
- The quick edit button takes space anyway -- might as well use that space...
- Logic says that you're more likely to answer a post after you're done reading it, rather than before you read it (it's not always the case, i.e. very long posts in a two-man discussion, I tend to favor answering first), thus the Quote button would be more useful at the end of the post...
- It just looks better, layout-wise. Just like FluxBB's default layout, it feels a bit more organized. Better thought-out.
Cons:
- Seriously... I can't get the hang of it. It's been days, weeks, and I still have to look twice before I find that damned Quote button!
So... There's only one con that I can think of, but it makes it hard for me to actually commit my changes. Looking for opinions! Will add a poll, too...
PS: a freebie for teatime... How come if you edit a post in the middle of a topic, your Topic Summary has the last posts *before* that post, but if you quote the same post, the Topic Summary has the latest posts in the topic instead..? I understand the idea, I just don't know if it makes sense for the common man...
I haven't got around to dealing with the moderation checkbox and the Quick Edit button, though.
Still, I think it's a good time to determine what's best for a 'default' setup.
(1) TOP
Pros:
- It's what every SMF user is used to...
- Pretty much immediate recognition of the Quote button's position.
Cons:
- It makes it harder (much harder) to make the post header look good, as on smaller widths + longer titles it will breaks these titles, or make them warp on a small width which is even worse...
- Vertical positioning isn't easy. I had to resort to using CSS table emulation, which I'd rather avoid as much as possible...
(2) BOTTOM
Pros:
- It fits nicely into the 'Last edited' box.
- The quick edit button takes space anyway -- might as well use that space...
- Logic says that you're more likely to answer a post after you're done reading it, rather than before you read it (it's not always the case, i.e. very long posts in a two-man discussion, I tend to favor answering first), thus the Quote button would be more useful at the end of the post...
- It just looks better, layout-wise. Just like FluxBB's default layout, it feels a bit more organized. Better thought-out.
Cons:
- Seriously... I can't get the hang of it. It's been days, weeks, and I still have to look twice before I find that damned Quote button!
So... There's only one con that I can think of, but it makes it hard for me to actually commit my changes. Looking for opinions! Will add a poll, too...
PS: a freebie for teatime... How come if you edit a post in the middle of a topic, your Topic Summary has the last posts *before* that post, but if you quote the same post, the Topic Summary has the latest posts in the topic instead..? I understand the idea, I just don't know if it makes sense for the common man...
5257
Features / Re: New revs - Public comments
« on May 3rd, 2012, 08:28 PM »
Quick bug... Admin area > Search for 'post' > First result says "Array" (it's actually the option for signature_minposts). Looks like it's trying to echo an array...Quote from Arantor on May 3rd, 2012, 08:12 PM Yup... We can always restore it later, although I doubt it. Saved 1.5KB off the 10KB filesize.Quote Yeah, it's perfectly true, and that's why I'm not sure about JsModify, but QuoteFast isn't used a lot I'd say, and other Ajax functions are the same... And I don't think that technically 10KB or 15KB isn't going to change the parsing time a lot. (It's not even an extra 5KB because there's the Wedge file header...)
Or perhaps we could add prefixes to the Ajax files? Ajax-QuoteFast, Ajax-JsModify...Quote Let's say that we should try to keep files split up when we determine they're used relatively a lot, or they're very resource-intensive.Quote I suppose so. Especially since it has its own folder anyway... It could be done. And it'd be a good idea to rename 'Aeva-Gallery2' or 'Subs-Aeva' to some self-explained names...Quote Meh. About 200 of them are 'quick tabs' that I just don't have time to read... About 300 are late answers to Wedge.org... Things I promised myself I'll answer (and never will, of course.)
If it's not used for anything other than receiving those results, get rid of it because we don't need it.
As far as multiplying small files goes, it's a tricky one. Certainly for such things it would be faster to have the small files for specific actions rather than big files containing everything (because that all still has to be loaded and parsed even if not run).
Or perhaps we could add prefixes to the Ajax files? Ajax-QuoteFast, Ajax-JsModify...
In hindsight it was one of the things I didn't like about SimpleDesk in the end was putting all the AJAX stuff into a single file, when all the AJAX code was all called for every action even if only part of it was ever used. There is a part of me that would prefer to break things down where there's no commonality to code (if they don't have any shared code, split 'em up) but I can see the argument about fewer files too.
One thing I would say at this juncture is that I would quite like to split Aeva-Gallery up a bit. Loading all that code for every single action=media item (including items, previews, albums, etc.) is heavy.
I've been working with ~50 tabs lately where I've been trying to piece together stuff on Node.js etc. but 700 tabs is insane!
5258
Features / Re: New revs - Public comments
« on May 3rd, 2012, 08:16 PM »Well, for one the menu is not looking good. There is an gap at the right, and the register button is on an new line. Thats what I mean with shrinked, at first, it was just 1 line.
Also, the menu width always depends on how many items are in there. And it depends on whether you're logged in or not, and whether you have access to all options, etc...
I also miss the date and time of the post. I'm not sure if this is an bug, or intended, but I just really miss it.
5259
Features / Re: New revs - Public comments
« on May 3rd, 2012, 08:11 PM »
In Xml.template.php, there's a template_results function... It's apparently an Ajax return function for search results.
However, it's never used in Wedge. It's actually used for remote searches on the SMF official website (Admin.php in SMF2), but never here.
I'm going to remove it, but I'd like to know if there's any reason to keep it in...
Also, I'd like to merge QuoteFast.php (5KB) into Ajax.php, and possibly JsModify.php (12KB) as well. I don't see much of a reason to multiply files that are of such a small size... It's alright for big files like Search.php/Search2.php, but other than that, considering we gave up on the idea of automatic action file discovery...
Quote from Arantor on April 29th, 2012, 02:36 PM Same here. I have the sidebar enabled in Opera, with my list of tabs, because with 736 tabs (as of now...), it's definitely impossible to use the horizontal tab bar for switching between tabs.
Heck, I absolutely hate Google for removing their vertical tabs sidebar, because it was actually usable at the time... It was a bit buggy, but removing it also removed my interest in Chrome entirely. (Heck, now I do my Chrome testing under... Maxthon Webkit, because it's got a more usable tab UI.)Quote Yeah, there's also plenty of other options that are missing some kind of UI... Eh. (Mostly mine :P)Quote (Modified after your post. Seems to work now.)Quote Before we forget -- when we add UI for choosing blog types, it should act as a 'template' like in the custom fields, i.e. it'll automatically set up other things in the page but users will be free to change them... I suppose that's how you envisioned it, too?
However, it's never used in Wedge. It's actually used for remote searches on the SMF official website (Admin.php in SMF2), but never here.
I'm going to remove it, but I'd like to know if there's any reason to keep it in...
Also, I'd like to merge QuoteFast.php (5KB) into Ajax.php, and possibly JsModify.php (12KB) as well. I don't see much of a reason to multiply files that are of such a small size... It's alright for big files like Search.php/Search2.php, but other than that, considering we gave up on the idea of automatic action file discovery...
Posted: May 3rd, 2012, 08:05 PM
I actually have the sidebar at the bottom because I don't have my browser at full size (it would look a bit silly in other sites to run at 1920 wide)
Heck, I absolutely hate Google for removing their vertical tabs sidebar, because it was actually usable at the time... It was a bit buggy, but removing it also removed my interest in Chrome entirely. (Heck, now I do my Chrome testing under... Maxthon Webkit, because it's got a more usable tab UI.)
As far as ordering, there isn't a UI for it, just as there isn't a UI to determine whether a board is a blog or not.
However, in the boards table there is the sort_method and sort_override columns, sort_method defaults to last_post (order by last post in a topic) with the direction being set as naturally descending.
Sorting method can be based on subject (alphabetically), starter, last poster (both by user name IIRC alphabetically), number of replies, number of views, and first post and last post. Blogging, typically, would use first post rather than last post.
5260
Bug reports / Re: Minor bug with drafts and entities
« on May 3rd, 2012, 02:05 PM »
I don't even know if it can... I mean, doesn't WSE actually modify the textarea to transform entities? In which case you don't wanna do it while you're typing...
(Unless we just rewrite it to do it differently.)
(Unless we just rewrite it to do it differently.)
5261
Features / Re: New revs
« on May 3rd, 2012, 12:43 PM »
And yet another big commit...
rev 1578
(23 files +1-1, 10kb)
! First item in action/user menus would never show up. (topic.js)
* Got rid of $txt['on'] and $txt['search_on'], which were both confusing and used incorrectly. Replaced everything with $txt['on_date']. Renamed a few 'time' variables to 'on_time' to reflect the actual contents, need to finish them all. (Admin.php, Display.php, MessageIndex.php, ModerationCenter.php, PersonalMessage.php, Post.php, PostModeration.php, PrintPage.php, Profile-View.php, TEMPLATES: Display, MessageIndex, ModerationCenter, PersonalMessage, Post, PrintPage, Profile, Xml, LANGUAGES: index)
+ Clearly mark one's own PMs with a 'self' class in PM conversation mode. (PersonalMessage.template.php)
* Renamed Printpage template to PrintPage (see Sources). (PrintPage.php, PrintPage.template.php, other/xml/detailed-version.php)
* Spacinazi. (PostModeration.php)
* Some updates and fixes to the mini-menu code (that were already on wedge.org but not in the SVN.) (Display.template.php)
! Forgot to move a language string from index to Login. (Login.english.php)
! Profile drafts were showing the 'on' twice in 'on_date'. (Profile.template.php)
! showDrafts function was called viewDrafts, as opposed to what the file header said (and what convention implied.) (Profile.php, Profile-View.php)
* Moved the post page's dynamic new post template back into the post template, I don't know why, but I did that. Am I in trouble? (Post.template.php, post.js)
rev 1578
(23 files +1-1, 10kb)
! First item in action/user menus would never show up. (topic.js)
* Got rid of $txt['on'] and $txt['search_on'], which were both confusing and used incorrectly. Replaced everything with $txt['on_date']. Renamed a few 'time' variables to 'on_time' to reflect the actual contents, need to finish them all. (Admin.php, Display.php, MessageIndex.php, ModerationCenter.php, PersonalMessage.php, Post.php, PostModeration.php, PrintPage.php, Profile-View.php, TEMPLATES: Display, MessageIndex, ModerationCenter, PersonalMessage, Post, PrintPage, Profile, Xml, LANGUAGES: index)
+ Clearly mark one's own PMs with a 'self' class in PM conversation mode. (PersonalMessage.template.php)
* Renamed Printpage template to PrintPage (see Sources). (PrintPage.php, PrintPage.template.php, other/xml/detailed-version.php)
* Spacinazi. (PostModeration.php)
* Some updates and fixes to the mini-menu code (that were already on wedge.org but not in the SVN.) (Display.template.php)
! Forgot to move a language string from index to Login. (Login.english.php)
! Profile drafts were showing the 'on' twice in 'on_date'. (Profile.template.php)
! showDrafts function was called viewDrafts, as opposed to what the file header said (and what convention implied.) (Profile.php, Profile-View.php)
* Moved the post page's dynamic new post template back into the post template, I don't know why, but I did that. Am I in trouble? (Post.template.php, post.js)
5262
Bug reports / Minor bug with drafts and entities
« on May 3rd, 2012, 10:11 AM »
Was looking into a draft bug (no biggie, presentational issue, I fixed it), and noticed two things in my drafts area.
First of all -- well, I still have recent (yesterday etc) drafts that should have been deleted after I submitted the final post... They're still there. Perhaps it's on my side though -- I have two posts from yesterday, then a post from April 30, then April 27 onwards was due to the earlier bug IIRC.
Secondly, my bug report for the cache key length had this code:
aeva-embed-link-[url=http://www.youtube.com/watch?v=OgCjpA03mOI#ws]B+ Episode 5 - باسم يوسف شو (مع تامر من غمرة) الحلقة ٥[/url]
However, in the draft area, it has this instead:
log_online-updateaeva-embed-link-[url=http://www.youtube.com/watch?v=OgCjpA03mOI#ws]B+ Episode 5 - باسم يوسف شو (مع تامر من غمرة) الحلقة ٥[/url]
I don't know if it's a bug in the draft saving code, or if it's due to my changing the location of weSaveEntities(). (But because it's in editor-func.js, it should be loaded on all topic pages as well...)
It's probably due to drafts not going through weSaveEntities() before saving the post, I guess. Or maybe I'm mistaken...
First of all -- well, I still have recent (yesterday etc) drafts that should have been deleted after I submitted the final post... They're still there. Perhaps it's on my side though -- I have two posts from yesterday, then a post from April 30, then April 27 onwards was due to the earlier bug IIRC.
Secondly, my bug report for the cache key length had this code:
aeva-embed-link-[url=http://www.youtube.com/watch?v=OgCjpA03mOI#ws]B+ Episode 5 - باسم يوسف شو (مع تامر من غمرة) الحلقة ٥[/url]
However, in the draft area, it has this instead:
log_online-updateaeva-embed-link-[url=http://www.youtube.com/watch?v=OgCjpA03mOI#ws]B+ Episode 5 - باسم يوسف شو (مع تامر من غمرة) الحلقة ٥[/url]
I don't know if it's a bug in the draft saving code, or if it's due to my changing the location of weSaveEntities(). (But because it's in editor-func.js, it should be loaded on all topic pages as well...)
It's probably due to drafts not going through weSaveEntities() before saving the post, I guess. Or maybe I'm mistaken...
5263
Off-topic / Re: Bitcointalk.org $11k bounty for new forum software
« on May 3rd, 2012, 09:38 AM »
But you're part of our team :P
5264
Off-topic / Re: Bitcointalk.org $11k bounty for new forum software
« on May 3rd, 2012, 07:19 AM »
Ignore what?
We're not refusing anything. We are just waiting for mor details... Because obviously Wedge isn't exactly what you think it is.
We're not refusing anything. We are just waiting for mor details... Because obviously Wedge isn't exactly what you think it is.
5265
Archived fixes / Re: Logging password errors
« on May 2nd, 2012, 09:33 PM »
Like button should show up in mobile mode now. This was a recent bug I fixed today.
Yeah I know passwords have their own category which is why I'm suggesting that admins could choose types of errors to log -- just like they can choose to disable 404s which have their own cat, it'd be nice to streamline all of this.
Yeah I know passwords have their own category which is why I'm suggesting that admins could choose types of errors to log -- just like they can choose to disable 404s which have their own cat, it'd be nice to streamline all of this.