Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
5116
Features / Re: Rewriting the skin file parser...
« on May 22nd, 2012, 05:47 PM »
It's not working 100% for now, works fine when not using comma-separated lists but I did that on ie6+ie7 and they fail to load correctly... Will test later...
Oh god, I have so many leftover features to finish... Grmpf...
Oh god, I have so many leftover features to finish... Grmpf...
5117
Features / Re: Action buttons: positioning
« on May 22nd, 2012, 04:46 PM »
I split (most of) the cache related discussion to this topic:
http://wedge.org/pub/feats/7420/rewriting-the-skin-file-parser/
(Please note that a few mentions about the action menus are moved there, and a few mentions on file caches are left here -- this is because of posts that mix them up together, obviously.)
http://wedge.org/pub/feats/7420/rewriting-the-skin-file-parser/
(Please note that a few mentions about the action menus are moved there, and a few mentions on file caches are left here -- this is because of posts that mix them up together, obviously.)
5118
Features / Re : Rewriting the skin file parser...
« on May 22nd, 2012, 04:38 PM »
Phew... Finally done rewriting the logic for replace-type skins.
I added a dummy skin with just two files (index.member.css and sections.css), and here's how it was included:
Array
(
[2] => /Themes/default/skins/index.member.css
[3] => /Themes/default/skins/Wutherings/index.member.css
[4] => /Themes/default/skins/Wutherings/sections.css
[5] => /Themes/default/skins/custom.css
[6] => /Themes/default/skins/custom.admin.css
)
The absolute perfect order.
Meaning you can easily manipulate ordering just by removing files in your replace skin or adding empty files, or choosing adequate suffixes.
Meanwhile, I've switched to makinge use of scandir(), and caching the results in a static array, although I'm disappointed by the lack of performance improvements with the caching... (Well, it probably works better on external files like editor.css, so I won't be removing it.)
I added a dummy skin with just two files (index.member.css and sections.css), and here's how it was included:
Array
(
- => /Themes/default/skins/index.css
[2] => /Themes/default/skins/index.member.css
[3] => /Themes/default/skins/Wutherings/index.member.css
[4] => /Themes/default/skins/Wutherings/sections.css
[5] => /Themes/default/skins/custom.css
[6] => /Themes/default/skins/custom.admin.css
)
The absolute perfect order.
Meaning you can easily manipulate ordering just by removing files in your replace skin or adding empty files, or choosing adequate suffixes.
Meanwhile, I've switched to makinge use of scandir(), and caching the results in a static array, although I'm disappointed by the lack of performance improvements with the caching... (Well, it probably works better on external files like editor.css, so I won't be removing it.)
5119
Features / Re : Rewriting the skin file parser...
« on May 22nd, 2012, 12:15 PM »
Hmm... Tried replacing the glob() call with scandir() and opendir(), hoping to get better performance...
Unfortunately, it's not any faster, maybe even a bit slower, although at least the performance is more stable across multiple refreshes.
I'll probably switch to scandir() because at the very least it's supported everywhere...
Unfortunately, it's not any faster, maybe even a bit slower, although at least the performance is more stable across multiple refreshes.
I'll probably switch to scandir() because at the very least it's supported everywhere...
5120
Features / Re: New revs
« on May 22nd, 2012, 11:32 AM »
rev 1591 (forget to tick a box... oops.)
(1 file, 1kb)
! weUrl() was recently broken for cookieless users. (script.js)
(1 file, 1kb)
! weUrl() was recently broken for cookieless users. (script.js)
5121
Features / Re: New revs
« on May 22nd, 2012, 11:31 AM »
rev 1590
(1 file, 1kb)
* Only animate quick-edit subject input box if the subject was empty to begin with, i.e. it wasn't shown to the user. This is something that's only useful in Wireless, and since it's unlikely mobile users can watch full-fledged animations, I'm actually tempted to get rid of that animation altogether. (topic.js)
(1 file, 1kb)
* Only animate quick-edit subject input box if the subject was empty to begin with, i.e. it wasn't shown to the user. This is something that's only useful in Wireless, and since it's unlikely mobile users can watch full-fledged animations, I'm actually tempted to get rid of that animation altogether. (topic.js)
5122
Features / Re : Rewriting the skin file parser...
« on May 21st, 2012, 11:31 PM »
I have this terrible feeling that I'm going to have to add even more lines of code...
I usually make my rewrites shorter than any earlier code. It would be a first ;)
I usually make my rewrites shorter than any earlier code. It would be a first ;)
5123
Features: Posts & Topics / Re: Likes
« on May 21st, 2012, 11:30 PM »
It's just a Like button. It's no biggie I think. It's not like we're showing the entire post :)
Committed in rev 1588.
Committed in rev 1588.
5124
Features / Re: New revs
« on May 21st, 2012, 11:23 PM »
rev 1589
(1 file, 2kb)
! Committed too much... The thought rewrite isn't ready for prime-time yet. (Xml.template.php)
(1 file, 2kb)
! Committed too much... The thought rewrite isn't ready for prime-time yet. (Xml.template.php)
5125
Features / Re: New revs
« on May 21st, 2012, 11:22 PM »
rev 1588
(2 files, 5kb)
* Show the action bar (but hide anything but the Like button) for any ignored posts that received at least one like. Give peace a chance... (Display.template.php)
* Shortened modifytopicdone Ajax. I don't think the id is used anywhere. (Xml.template.php)
! SMF bug: a foreach() ended with a semicolon, meaning it only ran the block that followed on the very last entry in the array... Oops? Worst of all, I think, is that I was unable to find any difference between the buggy and the fixed implementations... Probably not a very important Xml block, eh. (Xml.template.php)
(2 files, 5kb)
* Show the action bar (but hide anything but the Like button) for any ignored posts that received at least one like. Give peace a chance... (Display.template.php)
* Shortened modifytopicdone Ajax. I don't think the id is used anywhere. (Xml.template.php)
! SMF bug: a foreach() ended with a semicolon, meaning it only ran the block that followed on the very last entry in the array... Oops? Worst of all, I think, is that I was unable to find any difference between the buggy and the fixed implementations... Probably not a very important Xml block, eh. (Xml.template.php)
5126
Features: Posts & Topics / Re: Likes
« on May 21st, 2012, 08:39 PM »
But if 10 people liked it and it says so -- wouldn't you be interested in knowing what it says?
We can always hide the Like button if there are no likes though!
We can always hide the Like button if there are no likes though!
5127
Features / Re: Disable animation on mobile devices
« on May 21st, 2012, 08:36 PM »
... Not doing it myself. Priorities, all that :P
5128
Features: Posts & Topics / Re: Likes
« on May 21st, 2012, 08:13 PM »
But what about my use case? Isn't it realistic?
5129
Features / Re: Disable animation on mobile devices
« on May 21st, 2012, 08:10 PM »
Suggesting to add a user setting to disable anims. Could even override it in skin options...
5130
The Pub / Re: One more stupid animation...
« on May 21st, 2012, 08:09 PM »
Since it's committed, feel free to change speeds to get a feeling of how best to handle it...
After all the quick reply is animated too.
After all the quick reply is animated too.