Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
5041
Features / Re: New revs - Public comments
« on May 31st, 2012, 08:10 PM »
I just don't know if:
- it's really gonna help performance (SMF/Wedge's param tester in parse_bbc() basically does all possible permutations of all parameters, while AeMe only tests for the presence of every single param... So in the end I don't think it's better optimized...?)
- it's going to make it 'clearer' in any way. We'd still have to call aeva_showThumbnail() for any media tag...
- it's really gonna help performance (SMF/Wedge's param tester in parse_bbc() basically does all possible permutations of all parameters, while AeMe only tests for the presence of every single param... So in the end I don't think it's better optimized...?)
- it's going to make it 'clearer' in any way. We'd still have to call aeva_showThumbnail() for any media tag...
5042
Features / Re: New revs - Public comments
« on May 31st, 2012, 07:50 PM »
Well... I'm perfectly willing to test again (after all, maybe this was added after 2009 or so), but how do I test for it...?
If anything, having the bbcodes in the database makes it VERY hard for me to do any testing on them... (Heck, it's happened so many times to me, I think we should have implemented this move right before going alpha, not before... :P)
I suppose the params list would be like this, but that's all I got done:
Code: [Select]
Perhaps I need to fix this code tag that doesn't behave perfectly with word-break...
If anything, having the bbcodes in the database makes it VERY hard for me to do any testing on them... (Heck, it's happened so many times to me, I think we should have implemented this move right before going alpha, not before... :P)
I suppose the params list would be like this, but that's all I got done:
a:6:{s:2:"id";a:1:{s:5:"match";s:14:"(\d+(?:,\d+)*)";}s:4:"type";a:2:{s:5:"match";s:82:"(normal|box|av|link|preview|full|album|playlist|(?:media|audio|video|photo)_album)";s:8:"optional";b:1;}s:5:"align";a:2:{s:5:"match";s:24:"(none|right|left|center)";s:8:"optional";b:1;}s:5:"width";a:2:{s:5:"match";s:5:"(\d+)";s:8:"optional";b:1;}s:7:"details";a:2:{s:5:"match";s:97:"(none|all|no_name|(?:name|description|playlists|votes)(?:,(?:name|description|playlists|votes))*)";s:8:"optional";b:1;}s:7:"caption";a:2:{s:6:"quoted";b:1;s:8:"optional";b:1;}}Perhaps I need to fix this code tag that doesn't behave perfectly with word-break...
5043
Features / Re: New revs - Public comments
« on May 31st, 2012, 05:30 PM »
Nope. It's easy to add support for multiple params though. Well not too hard at least.
Dontforget that the quote tag has 5 entries in the list ;) it's not very flexible right now.
Dontforget that the quote tag has 5 entries in the list ;) it's not very flexible right now.
5044
Archived fixes / Re: Optimizing parse_bbc() and Aeva
« on May 31st, 2012, 05:12 PM »
Just fyi -- :hover on iframes and Flash objects is supported on Chrome, Firefox and Opera (at least the versions I tested). It didn't work in IE 9 or IE 10. (I don't really care much about that one...
5045
The Pub / Re: The Cookie Law (in the UK at least)
« on May 31st, 2012, 05:04 PM »For what I want to apologize to you, Nao?
That I have a clear idea of what I will do what?
I've never personally attacked you and I respect what you do.
And that, I think, I can also expect from you ...
Back in late 2010 I think, I offered you to join our private forum to share your ideas about what SMF should be. Then you said you'd only share your ideas once we give you "half ownership of Wedge".
Which was a bit 'expensive' for some text that you already posted on sm.org for free, if I may say...
It even led me to ignore your posts, suggestions and requests on sm.org from that point on.
5046
Features / Re: New revs - Public comments
« on May 31st, 2012, 05:02 PM »
Yep, sure...
But in the case of Aeva for instance, I'm still stuck with a half-baked Aeva-Embed.php+Subs-BBC.php that doesn't seem to know where it wants to go (autolink or not? should I get rid of the code I have no idea what it is doing like aeva_protection? etc.)
But in the case of Aeva for instance, I'm still stuck with a half-baked Aeva-Embed.php+Subs-BBC.php that doesn't seem to know where it wants to go (autolink or not? should I get rid of the code I have no idea what it is doing like aeva_protection? etc.)
5047
Features: Upcoming / Re: Q&A enhancement: multiple answers and multiple languages
« on May 31st, 2012, 04:56 PM »
Button margins could help being fixed, though ;)
5048
Features / Re: New revs - Public comments
« on May 31st, 2012, 04:56 PM »Should probably keep that field. Is it tinyint(3) unsigned not nulll? IIRC, parse_bbc had several strlen calls to determine tag length, and every little bit of savings helps, especially on large, tag-heavy posts, right?Quote @ Of recent memory, this rewrite of Subs-BBC.php is my biggest disappointment... I was really hoping to optimize it a lot, until I realized it really didn't need optimizing that much. What a waste of time! Is that 'len' field really worth it..?0
There's one call to strlen every time it matches a tag. It also adds another call in some situations later (unparsed_contents or whatever...), but in the end it'll only save time on tag-heavy posts as you said -- and even then, not THAT much..
5050
Plugins / Re: Hooking up data loading
« on May 30th, 2012, 07:47 PM »
Apparently pastebin is also used for communication between software pirates... Well, that's what Google says?!
5051
The Pub / Re: The Cookie Law (in the UK at least)
« on May 30th, 2012, 07:44 PM »
I just think that considering how she regarded me (if not both of us) back when we started work on Wedge, even though I was inviting her to share her feelings about our fixes to *her* specific problems with SMF, the least I deserve from feline is an apology...
5052
The Pub / Re: When can I download Wedge? / Where can I download Wedge?
« on May 30th, 2012, 07:42 PM »
If you'd asked back in 2011, I would have said a frank 'yes'.
Wedge has a lot of fallback code to make the transition from IE6 as smooth as possible. It supports plenty of crap.
And it was done in a way that would not hurt performance or features for other browsers (well, as much as I could.)
However, as time goes by -- I find myself testing under IE6 less and less, and *currently* the theme is VERY broken and looks awfully wrong in IE6 (IE7+ work fine except for a few issues that I try to keep up with.)
Quite honestly, because IE6's market share is under 1% in the US and around 3% globally (if we except China which is clearly not a target market for Wedgeward, mostly because of their overwhelming use of IE6), the more I think about it, the more I think I should get rid of IE6 support entirely... (Just keep my hacks for IE7 and IE8. And even some IE9 hacks, because Microsoft is a fun company to play with.)
Wedge has a lot of fallback code to make the transition from IE6 as smooth as possible. It supports plenty of crap.
And it was done in a way that would not hurt performance or features for other browsers (well, as much as I could.)
However, as time goes by -- I find myself testing under IE6 less and less, and *currently* the theme is VERY broken and looks awfully wrong in IE6 (IE7+ work fine except for a few issues that I try to keep up with.)
Quite honestly, because IE6's market share is under 1% in the US and around 3% globally (if we except China which is clearly not a target market for Wedgeward, mostly because of their overwhelming use of IE6), the more I think about it, the more I think I should get rid of IE6 support entirely... (Just keep my hacks for IE7 and IE8. And even some IE9 hacks, because Microsoft is a fun company to play with.)
5053
Archived fixes / Re: Optimizing parse_bbc() and Aeva
« on May 30th, 2012, 07:38 PM »I don't believe it does because of how Flash works.Quote I could always show it on hover... (although I don't think hover works on a Flash item...? Or maybe it works if I put the hover on the container div... Will try that.)
So it's not too hard to implement some nice styling around videos to specify the URL, allow for resizing (if technically possible) and things like that..
Oh, he was very keen to point out that it was faster. But too many people realised the downsides related to the embedding limit and the fact it (still) doesn't filter for signatures.
We both knew that, right? :P
Oh, I'm fine with doing it, I just need to understand how the system currently works, then I can do the rest.
5054
Features / Re: New revs
« on May 30th, 2012, 07:30 PM »
rev 1601
(3 files, 2kb)
+ New WeCSS feature: ifnull($var, something) will output $var if it's defined, or something (which can be a var, a string or nested ifnull calls) if it isn't. That regex was painful to write, as it refused to process my perfectly formed negative lookbehind assertion. Bugger. Now it's using a lookahead preceded by a possessive quantifier, the likes of which I rarely use. So maybe it's even neater. Added a few examples with cat/title font sizes. (Class-CSS.php, index.css)
! Aeva embeds were never pre-processed correctly when quick editing a post. Bad me. (JSModify.php)
@ Note: ifnull() is named after the MySQL function, and is a prototype. Maybe in the future I'll want to do something like if(var1, var1, var2) but it's unlikely.
(3 files, 2kb)
+ New WeCSS feature: ifnull($var, something) will output $var if it's defined, or something (which can be a var, a string or nested ifnull calls) if it isn't. That regex was painful to write, as it refused to process my perfectly formed negative lookbehind assertion. Bugger. Now it's using a lookahead preceded by a possessive quantifier, the likes of which I rarely use. So maybe it's even neater. Added a few examples with cat/title font sizes. (Class-CSS.php, index.css)
! Aeva embeds were never pre-processed correctly when quick editing a post. Bad me. (JSModify.php)
@ Note: ifnull() is named after the MySQL function, and is a prototype. Maybe in the future I'll want to do something like if(var1, var1, var2) but it's unlikely.
5055
Archived fixes / Re: Optimizing parse_bbc() and Aeva
« on May 30th, 2012, 04:36 PM »Well, with something like this, I'd look at the alternatives - namely the youtube bbc or similar. None of those show the title after the video, nor do any of them have a convenient link either.
I'm not bothered with the title (and does this mean you can avoid the lookup aspect?)
But lookups aren't only for titles. They also fetch information such as whether embedding is allowed (for YouTube). This is the kind of information I like having around.
but the link to the video would be useful to have.
I'd note that vbgamer's mod supports about 60 sites these days and he does add new ones reasonably easily.
Well, in terms of features SAVE is limited to doing a preg_replace on the URLs. Of course it also probably makes it a bit faster than Aeva, but it also prevents it from things like disabling embedding after X embeds on a page. (Easy way to crash browsers that don't push their Flash content into a separate process... Heck, it can even crash browsers that do.)
He can't support a noembed tag either... (Can probably be emulated through nobbc, but in any way, it means these links wouldn't even be clickable...)
Or things like 'disable embed in quotes/sentences'.
Basically, it's limited. Not something I'd ever want to do!
What would be ideal is if it becomes possible to provide new auto embed options easily (i.e. as a plugin) and if that's doable we can farm all the smaller ones out to plugins and then create plugins as needed.
Honestly, the extra weight of the url surroundings in the database is small enough not to worry about, and the performance benefit is worth the effort, IMHO.
So, I'm leaving autolinking in for now. But in both parse_bbc() and aeva_onposting (which means we both lose database space AND not benefit from it at all), because I don't want to go through the process of reparsing posts through an importer. (Heck, that would also mean older Wedge.org URLs are broken...)
(Not that it's vital, though.)
One thing to note is that aeva_onposting would best be placed inside preparsecode(), but Post2.php doesn't always call it, as I mentioned in my thoughts.
Right now, my 'fix' was to call it as well from JSModify.php, because that's something that I forgot to import from Aeva 7's xml files -- believe it or not, I actually skipped that bit and this is the reason why quick edit never properly preparsed a video link...