Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
4862
Features / Re: Users Online Today
« on June 15th, 2012, 08:00 PM »
Well, up until today I'd never touched the plugin code anyway... ;)
I made a couple more fixes, but your JS code is complicated...
It's not like I can easily reuse weUrl() (which in addition doesn't support anchors...), and it doesn't support index.php-free URLs like here.
I also moved the code to the sidebar, isn't that what your description mentions...?
And added language files.
I made a couple more fixes, but your JS code is complicated...
It's not like I can easily reuse weUrl() (which in addition doesn't support anchors...), and it doesn't support index.php-free URLs like here.
I also moved the code to the sidebar, isn't that what your description mentions...?
And added language files.
4863
Features / Re: Users Online Today
« on June 15th, 2012, 07:46 PM »Shows for me just fine, error notwithstanding. Mind if I attempt to commit my change?
Now I'll have to compare the changes... :^^;:
4864
The Pub / Re: The Cookie Law (in the UK at least)
« on June 15th, 2012, 03:23 PM »Oh, yes. It's been discussed at SMF that the 'hide online' doesn't hide last online time for users, this is an extension of the same idea.
Well, I suppose we could just hide it entirely, too. It's a bit annoying because sometimes you'll (at least) want to know whether someone is an active member or not, but...
Oh, maybe we could hide the item *only* if the user has been online in the last X months...? i.e. if you're no longer a regular visitor, what do you care that people know you aren't...?
There is still an issue, though, regardless of whether hide online is enabled or not - it's still logged as to what they're doing and it's still shown to admins, so even if 'hide online' is on, it's not hidden from admins. Whether that's a privacy issue is also questionable, of course.
(AFAIK we have only one regular lurker who's hiding his online status here, and it was helpful for my tests earlier today :P)
Now, as to whether or not we should STORE their online status in the database... I think it's asking a bit much not to do it, right..?
4865
Features / Re: Users Online Today
« on June 15th, 2012, 03:18 PM »
Well it's the plugin repo, I'm not going to be thorough all the time I think... :lol:
I'm trying to install the theme selector, but it's not working... I replaced the outdated loadBlock() call with a wetem::add, and still nothing... Uh, dunno if I have time to deal with this right now...
I'm trying to install the theme selector, but it's not working... I replaced the outdated loadBlock() call with a wetem::add, and still nothing... Uh, dunno if I have time to deal with this right now...
4866
Features / Re: Users Online Today
« on June 15th, 2012, 03:11 PM »
Okay...
rev 34
+ Added French version to OnlineToday plugin. (OnlineToday-Admin.french.php, OnlineToday.french.php)
! Fixed em tag. (OnlineToday.php)
Rollin'! :P
rev 34
+ Added French version to OnlineToday plugin. (OnlineToday-Admin.french.php, OnlineToday.french.php)
! Fixed em tag. (OnlineToday.php)
Rollin'! :P
4867
Features / Re: Users Online Today
« on June 15th, 2012, 03:08 PM »
Hmm.... And now it's working.
4868
Features / Re: Users Online Today
« on June 15th, 2012, 03:04 PM »
arantor_weplugins just returns OK with an empty folder... (?)
arantor_plugins asks me for a password, which usually means it doesn't exist.
arantor_plugins asks me for a password, which usually means it doesn't exist.
4869
Features / Re: New revs
« on June 15th, 2012, 02:58 PM »
rev 1619
(9 files, 3kb)
! Replaced a few complex regexes applied to htmlspecialchars, with a simple westr::htmlspecialchars, which as it happens, does exactly the same thing internally... Hopefully this won't break anything (I'm looking at the login form mostly!) (Display.php, Login2.php, ManageAttachments.php, SSI.php)
! Fixed some double backslashes in regexes here and there. Well, they didn't do anything unexpected, but it's cleaner to avoid escaping stuff that doesn't need it. (install.php, Register.php, Subs-Auth.php, Subs-Members.php)
! Search results would break when meeting an entity in the body. Basically, westr::entity_fix shouldn't be called through an eval but a callback instead, ensuring it sends an array. But anyway, I replaced that ugly call with a simple call to westr::entity_clean which does the same... (Search2.php)
(9 files, 3kb)
! Replaced a few complex regexes applied to htmlspecialchars, with a simple westr::htmlspecialchars, which as it happens, does exactly the same thing internally... Hopefully this won't break anything (I'm looking at the login form mostly!) (Display.php, Login2.php, ManageAttachments.php, SSI.php)
! Fixed some double backslashes in regexes here and there. Well, they didn't do anything unexpected, but it's cleaner to avoid escaping stuff that doesn't need it. (install.php, Register.php, Subs-Auth.php, Subs-Members.php)
! Search results would break when meeting an entity in the body. Basically, westr::entity_fix shouldn't be called through an eval but a callback instead, ensuring it sends an array. But anyway, I replaced that ugly call with a simple call to westr::entity_clean which does the same... (Search2.php)
4870
Features / Re: Users Online Today
« on June 15th, 2012, 02:33 PM »
Note to Pete: would be nice if you could update this plugin to use <em> instead of <i> at some point... ;) (It's only in one place really!)
Are there any other plugins that we should/could install here btw...? :P
Are there any other plugins that we should/could install here btw...? :P
4871
Features / Re: New revs
« on June 15th, 2012, 02:17 PM »
rev 1618
(3 files, 3kb)
+ Leave topic prefixes out of the links. Been in use for some time on wedge.org now, without any issues. I'm not convinced it's for the better (a page-wide preg_replace is not always very fast), but I'd rather have this out now, can be improved later. My uncommitted file list is getting too long. (Subs-Template.php)
! Don't show a user's current action in their profile if they're hidden... Admins will still see the action, but in italics to show that the user is hidden. (Profile-View.php)
! Moderators could get some errors in Who's Online when a user was getting an error in the media area. Instead of moving the error messages from the Media to Error language files, which is a long and annoying task, let's just ignore this... All right? Do you still like me? (Who.php)
(3 files, 3kb)
+ Leave topic prefixes out of the links. Been in use for some time on wedge.org now, without any issues. I'm not convinced it's for the better (a page-wide preg_replace is not always very fast), but I'd rather have this out now, can be improved later. My uncommitted file list is getting too long. (Subs-Template.php)
! Don't show a user's current action in their profile if they're hidden... Admins will still see the action, but in italics to show that the user is hidden. (Profile-View.php)
! Moderators could get some errors in Who's Online when a user was getting an error in the media area. Instead of moving the error messages from the Media to Error language files, which is a long and annoying task, let's just ignore this... All right? Do you still like me? (Who.php)
4872
Features / Re: New revs
« on June 15th, 2012, 01:44 PM »
rev 1617
(15 files, 7kb)
! Fixed thought permission to use the security functions to disable itself for muted members, instead of doing it through a hack... (Load.php, Security.php, index.template.php)
* Replaced all remaining italic tags with emphasis tags. I'm trying to keep the i tag to the smiley code, really. (other/ssi_examples.php, Aeva-Gallery2.php, Who.php, Help.language.php, ManageMedia.language.php, Media.language.php, Who.english.php)
+ Added a hackish representation of the $actions array for moderators in the Who's Online page. I'd rather print out the full URL as visited, but it's not possible with the current structure of the log table. Noisen.com has a special field which stores just that -- would it be worth doing the same? (Who.php)
* Who's Online page showed (to admins) hidden members with a 'hidden' class, which was never defined. Since the homepage shows them with a hardcoded em tag, doing the same here instead. (Who.template.php)
* Spellcheck translation was too long in French, making for ugly buttons... Settled for 'Orthographe', which is understandable enough for me. (index.french.php)
(15 files, 7kb)
! Fixed thought permission to use the security functions to disable itself for muted members, instead of doing it through a hack... (Load.php, Security.php, index.template.php)
* Replaced all remaining italic tags with emphasis tags. I'm trying to keep the i tag to the smiley code, really. (other/ssi_examples.php, Aeva-Gallery2.php, Who.php, Help.language.php, ManageMedia.language.php, Media.language.php, Who.english.php)
+ Added a hackish representation of the $actions array for moderators in the Who's Online page. I'd rather print out the full URL as visited, but it's not possible with the current structure of the log table. Noisen.com has a special field which stores just that -- would it be worth doing the same? (Who.php)
* Who's Online page showed (to admins) hidden members with a 'hidden' class, which was never defined. Since the homepage shows them with a hardcoded em tag, doing the same here instead. (Who.template.php)
* Spellcheck translation was too long in French, making for ugly buttons... Settled for 'Orthographe', which is understandable enough for me. (index.french.php)
4873
The Pub / Re: The Cookie Law (in the UK at least)
« on June 15th, 2012, 09:32 AM »
I think so.
However... Bug report?
I had a look at determineAction(), in Who.php, and it never tests for mem.show_online, assuming that if the user isn't shown in the Who's Online list, the action won't be shown either...
*However*, because Wedge also shows their current action in the profile summary, it should test whether the user is online or not, and whether they want their online status to be given away or not.
Is this a SMF or a Wedge bug? From a look at the *code*, it looks like if a user is online, their Online icon is green regardless of their privacy settings, and their current action is indicated. I'm pretty sure that if a user doesn't want to "show up in the online list", they certainly don't want their online status to be given away either...? (Heck, we could even *hide* the icon everywhere it shows up, whether online or offline, for non-admin members...)
Is that something relevant...?
However... Bug report?
I had a look at determineAction(), in Who.php, and it never tests for mem.show_online, assuming that if the user isn't shown in the Who's Online list, the action won't be shown either...
*However*, because Wedge also shows their current action in the profile summary, it should test whether the user is online or not, and whether they want their online status to be given away or not.
Is this a SMF or a Wedge bug? From a look at the *code*, it looks like if a user is online, their Online icon is green regardless of their privacy settings, and their current action is indicated. I'm pretty sure that if a user doesn't want to "show up in the online list", they certainly don't want their online status to be given away either...? (Heck, we could even *hide* the icon everywhere it shows up, whether online or offline, for non-admin members...)
Is that something relevant...?
4874
Features / Re: Post moderation
« on June 15th, 2012, 09:03 AM »
Re: the message just above... (Which I missed originally. It was unread --- there are some topics I keep for later and then they drop out of the 20 latest topics and I completely forget about them...)
I was working on fixing the post_thought permission to work 'as intended' with user warnings (as opposed to the odd hack I committed by mistake), and then found about user moderation (high warning level.) It applies post_unapproved_topics and such to them, which I think is exactly relevant to what you mentioned above.
So, yeah, I was already thinking that associating post moderation to moderation filters, while a notably good concept in your mind, wasn't going to cut it because I wanted to be able to post-moderate a message (i.e. make it unapproved even though it was already approved, for instance as a replacement to deletion, or simply as a way for multiple negative reports to hide it until a moderator decides it's okay and should be protected against reports or something) (yeah I know, it's a feature suggestion and I'm not going to do it... -_-), anyway, I was already thinking that, and now it's even more obvious to me -- post moderation should be *always* enabled on any topic that has at least one unapproved post (i.e. topics should have a 'post_moderation' field set to 1), and technically speaking, everywhere we access multiple topics in a single query (either by looking for a post_moderation setting, or just enabling unapproved post tests by default.)
Discuss. (<-- I feel at school all over again...)
I was working on fixing the post_thought permission to work 'as intended' with user warnings (as opposed to the odd hack I committed by mistake), and then found about user moderation (high warning level.) It applies post_unapproved_topics and such to them, which I think is exactly relevant to what you mentioned above.
So, yeah, I was already thinking that associating post moderation to moderation filters, while a notably good concept in your mind, wasn't going to cut it because I wanted to be able to post-moderate a message (i.e. make it unapproved even though it was already approved, for instance as a replacement to deletion, or simply as a way for multiple negative reports to hide it until a moderator decides it's okay and should be protected against reports or something) (yeah I know, it's a feature suggestion and I'm not going to do it... -_-), anyway, I was already thinking that, and now it's even more obvious to me -- post moderation should be *always* enabled on any topic that has at least one unapproved post (i.e. topics should have a 'post_moderation' field set to 1), and technically speaking, everywhere we access multiple topics in a single query (either by looking for a post_moderation setting, or just enabling unapproved post tests by default.)
Discuss. (<-- I feel at school all over again...)
4875
The Pub / Re: The Cookie Law (in the UK at least)
« on June 15th, 2012, 08:51 AM »
Hmm who's online is not a privacy issue per se as concerned users can hide their online status and thus activity.. No?