Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Nao
4726
The Pub / Re: Only display 'Redirect boards' when there actually are any
« on July 24th, 2012, 08:35 PM »Well, redirect boards normally have a different icon for that reason ;)
Perhaps in hindsight we should alter redirect boards to actually indicate they are redirect boards through the board type column ;)
Heck, thinking about it, we could provide different default boardstate icons per board type... (Although it would then mean extra space in the CSS file... Hmm. Well, we could always have them as actual image files, just like it used to be in SMF and all... But then it means Google PageSpeed will complain about the extra icons not being put into a sprite.)
I haven't got any read/unread boards to do a comparison on here.
If it's commitable, commit it because if we decide we don't like it we can always change it later, the joys of version control :)
4728
Bug reports / Re: Reply post showing as 'New'
« on July 24th, 2012, 08:31 PM »
Then we just don't provide any visual hints for these... Which IMHO is not a huge loss.
4729
Archived fixes / Re: Time offset (auto detect)
« on July 24th, 2012, 08:30 PM »
Not entirely, but very close.
In vB:
- Caracaz is in its own (new?) timezone (-4.5)
- some cities are in the list that aren't in the other (and vice versa), overall the vB version is more targeted towards populated areas
- Indian cities use their 'modern' names (Mumbai instead of Bombay, Kolkata instead of Calcutta... Which sounds odd to me because in France we never 'cared' to follow the renaming)
- it supports Kathmandu (with its very amusing 5.75 offset)
- also adds a Yangon (Rangoon IIRC) timezone
- uses "Beijing" instead of "Taipei" in the 8.0 timezone (dunno about you, but it feels like they tried very hard to please the DRC government...)
- and adds some Russian places that aren't mentioned in phpBB such as Vladivostok and Kamchatka -- yeah, once again it looks like vB tried to please communist governments, eh eh.
Overall I'd say that the phpBB version is outdated since it's missing at least 3 timezones (-4.5, 5.75 and 6.5). It nearly looks like they took the phpBB version and simply updated it over time (maybe the phpBB version I found was from an old install, but it didn't seem like it, it had a modern skin).
Of course, it's not like they *can't* copy the phpBB version, after all we're all in the same world, using the same timezone system...
In vB:
- Caracaz is in its own (new?) timezone (-4.5)
- some cities are in the list that aren't in the other (and vice versa), overall the vB version is more targeted towards populated areas
- Indian cities use their 'modern' names (Mumbai instead of Bombay, Kolkata instead of Calcutta... Which sounds odd to me because in France we never 'cared' to follow the renaming)
- it supports Kathmandu (with its very amusing 5.75 offset)
- also adds a Yangon (Rangoon IIRC) timezone
- uses "Beijing" instead of "Taipei" in the 8.0 timezone (dunno about you, but it feels like they tried very hard to please the DRC government...)
- and adds some Russian places that aren't mentioned in phpBB such as Vladivostok and Kamchatka -- yeah, once again it looks like vB tried to please communist governments, eh eh.
Overall I'd say that the phpBB version is outdated since it's missing at least 3 timezones (-4.5, 5.75 and 6.5). It nearly looks like they took the phpBB version and simply updated it over time (maybe the phpBB version I found was from an old install, but it didn't seem like it, it had a modern skin).
Of course, it's not like they *can't* copy the phpBB version, after all we're all in the same world, using the same timezone system...
4730
The Pub / Re: Only display 'Redirect boards' when there actually are any
« on July 24th, 2012, 08:15 PM »
So, here's what I came up with... It's online here.
- There are no redirect boards, but just so you know, it has an opacity set to .25, which works fine for me. I don't know how best to indicate it's a redirect board, but now at least the icon will have a title saying it is such a board.
- I think there's a nicer balance between on/off states with this icon.
Overall, it's committable material. I'd just like to point out that nothing prevents us from allowing users to set up a 'read' icon state for boards -- and if not there, rely on the default fallback, i.e. opacity: .5 :)
- There are no redirect boards, but just so you know, it has an opacity set to .25, which works fine for me. I don't know how best to indicate it's a redirect board, but now at least the icon will have a title saying it is such a board.
- I think there's a nicer balance between on/off states with this icon.
Overall, it's committable material. I'd just like to point out that nothing prevents us from allowing users to set up a 'read' icon state for boards -- and if not there, rely on the default fallback, i.e. opacity: .5 :)
4731
The Pub / Re: Only display 'Redirect boards' when there actually are any
« on July 24th, 2012, 06:55 PM »
My suggestions...
- Remove the small icons altogether.
- Keep only ONE copy of the (large) board icon, the unread state. (The boardstatus.png file goes from 1.5KB to 624 bytes.)
- If board is read, apply an opacity of 0.5 to that icon, to make it look like it's a dimmed down version of the icon.
- Makes it easy to replace a board icon with a media item thumbnail.
- Don't show a legend (at all). Instead, show a clear 'NEW' or 'REDIRECT' note (using the note class or a child) next to the board name.
- Remove the small icons altogether.
- Keep only ONE copy of the (large) board icon, the unread state. (The boardstatus.png file goes from 1.5KB to 624 bytes.)
- If board is read, apply an opacity of 0.5 to that icon, to make it look like it's a dimmed down version of the icon.
- Makes it easy to replace a board icon with a media item thumbnail.
- Don't show a legend (at all). Instead, show a clear 'NEW' or 'REDIRECT' note (using the note class or a child) next to the board name.
4732
Bug reports / Re: Reply post showing as 'New'
« on July 24th, 2012, 06:48 PM »
- Calculation: how about we store a 'snapshot' of boards in localStorage, and use that to determine whether there are new boards at runtime? (With JavaScript...) That's in reply to Dragooon's post. I'll go back to sleep now...
- new icon: I'll mention that in the other topic.
- new icon: I'll mention that in the other topic.
4733
Archived fixes / Re: Admin search issues
« on July 24th, 2012, 06:44 PM »
I guess there aren't too many places where it breaks. Maybe we could just take the one I mentioned, and rename the option... Would be simpler.
4734
Archived fixes / Re: Time offset (auto detect)
« on July 24th, 2012, 06:43 PM »
Me neither...
Kinda went to other things because we couldn't agree on stuff here, IIRC... I've kept somewhere a copy of the timezones as shown by vBulletin and phpBB, both having their pros and cons. Still dunno what's best.
Kinda went to other things because we couldn't agree on stuff here, IIRC... I've kept somewhere a copy of the timezones as shown by vBulletin and phpBB, both having their pros and cons. Still dunno what's best.
4735
Archived fixes / Re: Logging password errors
« on July 24th, 2012, 06:41 PM »
Perfect, thank you :)
4736
Features / Re: New revs
« on July 24th, 2012, 05:33 PM »
rev 1646
(16 files +2, 53kb -- most of this is the new files)
+ It would appear that I forgot to upload a couple of new files from when I split the splitter... (Split.php, Merge.template.php)
! Hopefully fixed a theme JS function that was incorrectly handling the script URL. (Themes.template.php)
* Harmonized all weUrl() calls to use the new param format. (Load.php, Admin.template.php, index.template.php, Packages.template.php, Themes.template.php, editor-func.js, editor.js, mediadmin.js, player.js, post.js, register.js, stats.js, suggest.js, topic.js, up.js)
(16 files +2, 53kb -- most of this is the new files)
+ It would appear that I forgot to upload a couple of new files from when I split the splitter... (Split.php, Merge.template.php)
! Hopefully fixed a theme JS function that was incorrectly handling the script URL. (Themes.template.php)
* Harmonized all weUrl() calls to use the new param format. (Load.php, Admin.template.php, index.template.php, Packages.template.php, Themes.template.php, editor-func.js, editor.js, mediadmin.js, player.js, post.js, register.js, stats.js, suggest.js, topic.js, up.js)
4737
Features / Re: New revs
« on July 24th, 2012, 12:41 PM »
rev 1645
(9 files, 4kb)
* Simplified weUrl() function by making it always use we_script as the base URL. The param is still optional so it doesn't save any gzipped bytes, but it's still better IMHO. (script.js)
* Replaced Ajax draft call tests with is_ajax instead of xml, allowing for some shorter JS. And getting rid of an annoying line of code. (PersonalMessage.php, Post2.php, editor-func.js)
* More byte saving: some getXMLDocument to $.get, referring to 'window.location' as just 'location'... (script.js, stats.js, suggest.js, topic.js)
! IE9 doesn't support border-radius on elements with a filter. Removed filter from .note classes because the solid border radius looks better than a square gradient. (index.ie9.css)
* French translation. (ManageSettings.french.php)
(9 files, 4kb)
* Simplified weUrl() function by making it always use we_script as the base URL. The param is still optional so it doesn't save any gzipped bytes, but it's still better IMHO. (script.js)
* Replaced Ajax draft call tests with is_ajax instead of xml, allowing for some shorter JS. And getting rid of an annoying line of code. (PersonalMessage.php, Post2.php, editor-func.js)
* More byte saving: some getXMLDocument to $.get, referring to 'window.location' as just 'location'... (script.js, stats.js, suggest.js, topic.js)
! IE9 doesn't support border-radius on elements with a filter. Removed filter from .note classes because the solid border radius looks better than a square gradient. (index.ie9.css)
* French translation. (ManageSettings.french.php)
4738
Features / Re: Github & stuff
« on July 23rd, 2012, 03:33 PM »SmartGit is written in Java, as long as you not using a mixed OS environment (Virtual Machine) as I am, you should be fine, power to you, for me Java just screws round with clipboard synchronisation that Virtual Machine uses,
TortoiseGit is pretty much Windows only, I choose to use something cross platform and not written in Java. Use whatever you're comfortable with. ;)
Posted: July 23rd, 2012, 03:32 PM
You can always use BB for a Git repo ;)
4739
Features / Re: New revs
« on July 20th, 2012, 11:44 PM »
rev 1643
(52 files, 10kb) (more frightening than threatening, as the size implies.)
* Replaced these old "new Image().src" calls with $.get(). (upgrade.php, Load.php, ScheduledTasks.php, Subs-Scheduled.php, Admin.template.php, Themes.template.php)
* Moved blankGif() over to VerificationCode.php, as it was only used there at that point. (Subs.php, VerificationCode.php)
* It suddenly hit me that die() isn't an enticing function name, and I decided to replace them all with exit. Except for hacking attempts, because that's what they deserve. Or because I'm too lazy to change all of these for now. Next time I'll revert all of that to die() calls because it's "shorter", ah ah. Don't mind me. (index.php, install.php, a dozen of useless other/* files, smfinfo.php, upgrade.php, Ajax.php, Class-DB.php, Display.php, Dlattach.php, Errors.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Class-Media.php, Load.php, MessageIndex.php, QueryString.php, ScheduledTasks.php, Search2.php, Security.php, Spellcheck.php, Subs-Captcha.php, Subs-Scheduled.php, Subs-Sound.php, Subscriptions-PayPal.php, Themes.php, Unread.php, UnreadReplies.php, SSI.php, subscriptions.php)
* Some more minor JavaScript optimizations (mostly for size.) (install.php, a few more obscure other/* files, upgrade.php, Load.php, Display.template.php, Register.template.php, avasize.js)
* Spacinazi. Just the one line. (Stats.php, Subs-Media.php)
(52 files, 10kb) (more frightening than threatening, as the size implies.)
* Replaced these old "new Image().src" calls with $.get(). (upgrade.php, Load.php, ScheduledTasks.php, Subs-Scheduled.php, Admin.template.php, Themes.template.php)
* Moved blankGif() over to VerificationCode.php, as it was only used there at that point. (Subs.php, VerificationCode.php)
* It suddenly hit me that die() isn't an enticing function name, and I decided to replace them all with exit. Except for hacking attempts, because that's what they deserve. Or because I'm too lazy to change all of these for now. Next time I'll revert all of that to die() calls because it's "shorter", ah ah. Don't mind me. (index.php, install.php, a dozen of useless other/* files, smfinfo.php, upgrade.php, Ajax.php, Class-DB.php, Display.php, Dlattach.php, Errors.php, Load.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-ModCP.php, Class-Media.php, Load.php, MessageIndex.php, QueryString.php, ScheduledTasks.php, Search2.php, Security.php, Spellcheck.php, Subs-Captcha.php, Subs-Scheduled.php, Subs-Sound.php, Subscriptions-PayPal.php, Themes.php, Unread.php, UnreadReplies.php, SSI.php, subscriptions.php)
* Some more minor JavaScript optimizations (mostly for size.) (install.php, a few more obscure other/* files, upgrade.php, Load.php, Display.template.php, Register.template.php, avasize.js)
* Spacinazi. Just the one line. (Stats.php, Subs-Media.php)
4740
Features / Re: New revs
« on July 20th, 2012, 11:21 PM »
rev 1642
(6 files, 11kb)
! SMF bug: there was some code to preview external avatars as they were entered, but the avatar preview was shown on a different tab, and thus invisible... Also fixed the JS to ensure that the image would load entirely before attempting to get its dimensions. A classic. (Profile.template.php)
* Rewrote keep-alive JS code to only trigger on textareas and WYSIWYG editors. Moved it to editor-func.js because I don't really see a reason to bother when it's a textarea lost in some far away admin area or something. Saves nearly 50 gzipped bytes off the main script. Laugh all you want about my optimizations, but that script is now easily a kilobyte shorter than months ago. (script.js, editor-func.js)
! Fixed reqWin popup auto-height in IE10. Well, at least the old Win7 preview. Not my fault if Microsoft wants to force us to use their crappy Win8. Hopefully it doesn't break other browsers or specific situations. (script.js)
* Simplified get/sendXMLDocument() functions. They should look less cryptic now. Also optimized script for size, as always... (script.js)
! Fixed WYSIWYG editor throwing errors at IE9. Which didn't happen before. Anyway, using feature detection instead of is_ie (even though is_ie8down would fix that.) (editor.js)
- Removed on-the-fly minification of JavaScript through the minify_html hidden variable. It's still available for tab removal, but minification was both slow and buggy. (Subs-Template.php)
* Remove stats.js into a singleton to save over 80 gzipped bytes compared to the latest version. (stats.js)
(6 files, 11kb)
! SMF bug: there was some code to preview external avatars as they were entered, but the avatar preview was shown on a different tab, and thus invisible... Also fixed the JS to ensure that the image would load entirely before attempting to get its dimensions. A classic. (Profile.template.php)
* Rewrote keep-alive JS code to only trigger on textareas and WYSIWYG editors. Moved it to editor-func.js because I don't really see a reason to bother when it's a textarea lost in some far away admin area or something. Saves nearly 50 gzipped bytes off the main script. Laugh all you want about my optimizations, but that script is now easily a kilobyte shorter than months ago. (script.js, editor-func.js)
! Fixed reqWin popup auto-height in IE10. Well, at least the old Win7 preview. Not my fault if Microsoft wants to force us to use their crappy Win8. Hopefully it doesn't break other browsers or specific situations. (script.js)
* Simplified get/sendXMLDocument() functions. They should look less cryptic now. Also optimized script for size, as always... (script.js)
! Fixed WYSIWYG editor throwing errors at IE9. Which didn't happen before. Anyway, using feature detection instead of is_ie (even though is_ie8down would fix that.) (editor.js)
- Removed on-the-fly minification of JavaScript through the minify_html hidden variable. It's still available for tab removal, but minification was both slow and buggy. (Subs-Template.php)
* Remove stats.js into a singleton to save over 80 gzipped bytes compared to the latest version. (stats.js)